[Wikidata-bugs] [Maniphest] [Commented On] T98124: Deserializers should not store serialization in private properties

2015-05-05 Thread thiemowmde 
thiemowmde added a comment.

WIP: https://github.com/wmde/WikibaseInternalSerialization/pull/69


TASK DETAIL
  https://phabricator.wikimedia.org/T98124

REPLY HANDLER ACTIONS
  Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign 
.

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Aklapper, Wikidata-bugs, aude, GWicke



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98124: Deserializers should not store serialization in private properties

2015-06-08 Thread JeroenDeDauw 
JeroenDeDauw added a subscriber: JeroenDeDauw.
JeroenDeDauw added a comment.

I do not agree with the motivations outlined here as outlined in my comment on 
the pull request: https://github.com/wmde/WikibaseInternalSerialization/pull/69


TASK DETAIL
  https://phabricator.wikimedia.org/T98124

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JeroenDeDauw
Cc: JeroenDeDauw, thiemowmde, Aklapper, Wikidata-bugs, aude, GWicke



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98124: Deserializers should not store serialization in private properties

2015-06-08 Thread thiemowmde 
thiemowmde added a comment.

What does "do not agree" mean? How can one not agree with simple facts?

Reason 3: It's confusing because it looks like the serialization is part of the 
state of the deserializer object, but is not. The deserializers can deserialize 
more than one serialization.


TASK DETAIL
  https://phabricator.wikimedia.org/T98124

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: JeroenDeDauw, thiemowmde, Aklapper, Wikidata-bugs, aude, GWicke



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs