[Wikidata-bugs] [Maniphest] [Commented On] T98343: Drop support for numeric ids in EntityDocument::setId

2015-05-07 Thread Bene 
Bene added a comment.

Thanks @thiemowmde for closing this. I forgot that this task was still open.


TASK DETAIL
  https://phabricator.wikimedia.org/T98343

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde, Bene
Cc: thiemowmde, daniel, JeroenDeDauw, Bene, Aklapper, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98343: Drop support for numeric ids in EntityDocument::setId

2015-05-06 Thread JeroenDeDauw 
JeroenDeDauw added a comment.

Thanks for looking into this.

-2 as per https://github.com/wmde/WikibaseDataModel/pull/477


TASK DETAIL
  https://phabricator.wikimedia.org/T98343

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: JeroenDeDauw
Cc: thiemowmde, daniel, JeroenDeDauw, Bene, Aklapper, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T98343: Drop support for numeric ids in EntityDocument::setId

2015-05-06 Thread thiemowmde 
thiemowmde added a subscriber: thiemowmde.
thiemowmde added a comment.

"Code smell"? O_o
"No places"? O_o
A solid -2 as argued in https://github.com/wmde/WikibaseDataModel/pull/477. 
This is a convenience feature, useful especially in tests to make them much 
easier to read. Please close this as invalid.


TASK DETAIL
  https://phabricator.wikimedia.org/T98343

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, daniel, JeroenDeDauw, Bene, Aklapper, Wikidata-bugs, aude



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs