| Addshore updated the task description. (Show Details) |
CHANGES TO TASK DESCRIPTION
**Bug Description**
https://wikidata.beta.wmflabs.org/wiki/Special:EntitiesWithoutLabel
**Impact & priority**
This is mildly annoying for users as the UI suggestions that they should try to do something that will never work (lexemes without labels).
The fact that the exception is uncaught means that it turns up in the production logs which adds to the logspam that deployers have to hunt through when identifying issues.
**Fix Part 1: Fixing the exception bubble up**
The main exception being thrown by SqlEntitiesWithoutTermFinder->normalizeEntityTypes can remain.
But it needs to be caught before bubbling up to the user.
It might make sense to catch it further up and rethrow a more specific exception than InvalidArgumentException to be caught by the SpecialPage.
The SpecialPage can then just return an error saying that the request entity type is not supported by the page.
**Fix Part 2: Fixing the UI...**
SpecialEntitiesWithoutPage only deals with entities without terms
SpecialEntitiesWithoutPageFactory currently passes in all entity types from $wikibaseRepo->getLocalEntityTypes()
It looks like we already have a setting for this, supportedEntityTypesForEntitiesWithoutTermListings, but it is null by default.
We can set this in WMF production to no longer suggest lexeme etc on the special page in the first place
The pages should display a message stating that the entities are not supported**Acceptance Criteria**
[] When an entity without terms is used on the special page the user should be presented with a helpful error message instead of a raw exception
[] WMF production should only list the entities that have terms on the special page in the first place.
https://wikidata.beta.wmflabs.org/wiki/Special:EntitiesWithoutLabel
...
```**Impact & priority**
This is mildly annoying for users as the UI suggestions that they should try to do something that will never work (lexemes without labels).
The fact that the exception is uncaught means that it turns up in the production logs which adds to the logspam that deployers have to hunt through when identifying issues.
**Fix Part 1: Fixing the exception bubble up**
The main exception being thrown by SqlEntitiesWithoutTermFinder->normalizeEntityTypes can remain.
But it needs to be caught before bubbling up to the user.
It might make sense to catch it further up and rethrow a more specific exception than InvalidArgumentException to be caught by the SpecialPage.
The SpecialPage can then just return an error saying that the request entity type is not supported by the page.
**Fix Part 2: Fixing the UI...**
SpecialEntitiesWithoutPage only deals with entities without terms
SpecialEntitiesWithoutPageFactory currently passes in all entity types from $wikibaseRepo->getLocalEntityTypes()
It looks like we already have a setting for this, supportedEntityTypesForEntitiesWithoutTermListings, but it is null by default.
We can set this in WMF production to no longer suggest lexeme etc on the special page in the first place
The pages should display a message stating that the entities are not supported**Acceptance Criteria**
[] When an entity without terms is used on the special page the user should be presented with a helpful error message instead of a raw exception
[] WMF production should only list the entities that have terms on the special page in the first place.
TASK DETAIL
EMAIL PREFERENCES
To: Addshore
Cc: Aklapper, Lydia_Pintscher, daniel, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Luke081515, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair, greg
Cc: Aklapper, Lydia_Pintscher, daniel, Addshore, Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Jonas, Luke081515, Wikidata-bugs, aude, Darkdadaah, Jdforrester-WMF, Mbch331, Jay8g, Krenair, greg
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
