[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-07-02 Thread CommunityTechBot 
CommunityTechBot updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION26570726f6475636520796f757220627567207573696e67206120726563656e742076657273696f6e206f662074686520736f6674776172652c20746f2068652077696b6920636f6e74656e74206c616e67756167652e0a0a5468616e6b20796f752e0a546167730a436865636b557365720ad70a436f6e6e65637465642d4f70656e2d48657269746167652d42617463682d75706c6f61647320285241c42d4b4d425f315f323031372d3032290ad70a54616d696c2d53697465730ad70a47616d6570726573730ad70a48617368746167730ad70a4a4144450ad70a4b6172746f456469746f720ad70a4c616e67756167652d323031382d4170722d4a756e650ad70a4e65772d456469746f722d457870657269656e6365730ad70a4d61696c0ad70a5443422d5465616d0ad70a53756273637269626572730a4465736372697074696f6e20507265766965770a436f6e74656e77a6f6e652073657474696e6720696e20796f75722070726f66696c652c20636c69636b20746f207265636f6e63696c652e[property scope](http://www.wikidata.org/entity/Q53869507) is a new constraint type specifying where a property may be used: in the main snak, in qualifiers, and/or in references. There has been some controversy about the way this constraint is modeled, but from the [project talk page](https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_property_constraints#Change_of_format_for_scope_constraints) there now seems to be general agreement that the constraint parameter for this is the new [property scope](http://www.wikidata.org/entity/P5314) property.

Should be fairly easy to implement: add support for the parameter to `ConstraintParameterParser` (returning an array of `Context::TYPE_*` constants), and then in the new checker simply look at the context’s type.

In the interest of a healthy relationship with the community, I think we should implement this as soon as possible :) however, there will be no deployments on the week of June 18th (SRE offsite), so the next regular deployment where this could happen will be on the evening of June 27th (assuming no train problems). I’ll try to implement this on June 25th and 26th, and hopefully get it merged before the branch cut.

#patch-for-review:
- [x] [minor](https://gerrit.wikimedia.org/r/440879)
- [x] [parameter](https://gerrit.wikimedia.org/r/440880)
- [x] [`ViolationMessage`](https://gerrit.wikimedia.org/r/441029)
- [x] [checker](https://gerrit.wikimedia.org/r/441030)
- [x] refactoring [1](https://gerrit.wikimedia.org/r/441835), [2](https://gerrit.wikimedia.org/r/441847)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: CommunityTechBotCc: Liuxinyu970226, MisterSynergy, Lucas_Werkmeister_WMDE, AndyTan, Gaboe420, Zylc, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 1978Gage2001, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, herron, GoranSMilovanovic, Adik2382, Chicocvenancio, alanajjar, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Tbscho, merbst, LawExplorer, Lea_WMDE, Mattias_Ostmar-WMSE, Lewizho99, JJMC89, Maathavan, Jseddon, Agabi10, Ryuch, Mkdw, RuyP, JEumerus, Jonas, Trizek-WMF, KasiaWMDE, 0x010C, srodlund, Luke081515, grin, Bsadowski1, mys_721tx, Wikidata-bugs, Snowolf, aude, Huji, Gryllida, jayvdb, Tobi_WMDE_SW, Lydia_Pintscher, revi, scfc, He7d3r, Romaine, Mbch331, Jay8g, Glaisher, Krenair, chasemp___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-27 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [checker](https://gerrit.wikimedia.org/r/441030)
- [ - [x] refactoring [1](https://gerrit.wikimedia.org/r/441835), [2](https://gerrit.wikimedia.org/r/441847)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, gerritbot, MisterSynergy, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-26 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [minor](https://gerrit.wikimedia.org/r/440879)
- [ - [x] [parameter](https://gerrit.wikimedia.org/r/440880)
- [ - [x] [`ViolationMessage`](https://gerrit.wikimedia.org/r/441029)...TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, gerritbot, MisterSynergy, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] [refactoringg [1](https://gerrit.wikimedia.org/r/441835), [2](https://gerrit.wikimedia.org/r/44183547)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, gerritbot, MisterSynergy, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [x] [checker](https://gerrit.wikimedia.org/r/441030)
- [ ] [refactoring](https://gerrit.wikimedia.org/r/441835)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: Liuxinyu970226, gerritbot, MisterSynergy, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-22 Thread Jonas 
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] [`ViolationMessage`](https://gerrit.wikimedia.org/r/441029)
- [ - [x] [checker](https://gerrit.wikimedia.org/r/441030)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, JonasCc: Liuxinyu970226, gerritbot, MisterSynergy, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-21 Thread Jonas 
Jonas updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...#patch-for-review:
- [ - [x] [minor](https://gerrit.wikimedia.org/r/440879)...TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, JonasCc: Liuxinyu970226, gerritbot, MisterSynergy, Ghuron, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-19 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] [`ViolationMessage`](https://gerrit.wikimedia.org/r/441029)
- [ ] [checkerker](https://gerrit.wikimedia.org/r/441030)TASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, MisterSynergy, Ghuron, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-19 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...- [ ] [parameter](https://gerrit.wikimedia.org/r/440880)
- [ ] `ViolationMessage`
- [ ] checkerTASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, MisterSynergy, Ghuron, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Edited] T197473: Implement property scope constraint

2018-06-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
CHANGES TO TASK DESCRIPTION...In the interest of a healthy relationship with the community, I think we should implement this as soon as possible :) however, there will be no deployments on the week of June 18th (SRE offsite), so the next regular deployment where this could happen will be on the evening of June 27th (assuming no train problems). I’ll try to implement this on June 25th and 26th, and hopefully get it merged before the branch cut.

#patch-for-review:
- [ ] [minor](https://gerrit.wikimedia.org/r/440879)
- [ ] [parameter](https://gerrit.wikimedia.org/r/440880)
- [ ] checkerTASK DETAILhttps://phabricator.wikimedia.org/T197473EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, MisterSynergy, Ghuron, Lucas_Werkmeister_WMDE, Aklapper, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, merbst, LawExplorer, Lewizho99, Maathavan, Agabi10, Wikidata-bugs, aude, Mbch331___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs