[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-08 Thread daniel 
daniel added a comment.

@aude: if we check the changeop against the latest revision for validation, 
there should be no need to validate the result of the merge. Because of the way 
ChangeOps (the plural version) does validation, we then already do validate 
against what we would get after patching, assuming the patch applies cleanly. 
But really, we should get rid of the patching logic altogether, see T126231: 
Detect edit conflicts in ChangeOp instead of using diff-and-patch in EditEntity 
.


TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: thiemowmde, gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, 
Jonas, StudiesWorld, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-08 Thread daniel 
daniel added a comment.

Suspicion (2) seems to be the problem, especially since our own UI //always// 
hits this edge case when editing the label and description for a given language 
at the same time:

- User 1 is viewing revision B of Q5 in their browser
- User 1 enters a German label and description for Q5. These conflict with the 
German label and description of Q7, but we don't know that yet.
- The UI sends two API requests, once for changing the label 
(https://phabricator.wikimedia.org/E1), and one for changing the description 
(https://phabricator.wikimedia.org/E2). Both edits give B as the base revision.
- When https://phabricator.wikimedia.org/E1 is processed, validation is 
performed against B, no conflict is found because Q5 doesn't have a German 
description in revision B. https://phabricator.wikimedia.org/E1 is applied to 
B, resulting in B'.
- When https://phabricator.wikimedia.org/E2 is processed, validation is 
performed against B, no conflict is found because Q5 doesn't have a German 
label in revision B. https://phabricator.wikimedia.org/E2 is applied to B and 
then patched into B'' via the conflict resolution mechanism, resulting in B''.
- B'' now contains the combination of German label and description that 
conflicts with Q7.

Jan suggested that the simplest way to avoid this is to always use the current 
revision, not the edit's base revision, when validating. The above would then 
change as follows:

- When https://phabricator.wikimedia.org/E2 is processed, validation is 
performed against B', and a conflict is found with Q7, because 
B'+https://phabricator.wikimedia.org/E2 contains the conflicting combination of 
label and description.


TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: thiemowmde, gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, 
Jonas, StudiesWorld, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-02-01 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-02-02.

TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tobi_WMDE_SW
Cc: thiemowmde, gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, 
Jonas, StudiesWorld, Izno, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2016-01-18 Thread Tobi_WMDE_SW 
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-01-19.

TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tobi_WMDE_SW
Cc: gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, 
StudiesWorld, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-22 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: gerritbot, Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, 
StudiesWorld, Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-18 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.

A related issue seems to be going on in 
https://phabricator.wikimedia.org/T121851.


TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, StudiesWorld, 
Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T121395: [Bug] Term constraints not working

2015-12-14 Thread daniel 
daniel added a comment.

*sigh* not, again...

I strongly recommend we implement T74430: Re-implement uniqueness constraint in 
a consistent and efficient way  
instead of trying to fix this based on the terms table.


TASK DETAIL
  https://phabricator.wikimedia.org/T121395

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel
Cc: Bene, Lydia_Pintscher, hoo, aude, Aklapper, daniel, Jonas, StudiesWorld, 
Wikidata-bugs, Mbch331



___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs