[Wikidata-bugs] [Maniphest] [Updated] T222681: WikidataPageBanner uses a blacklist of skin names to decide 'prebodyhtml' support instead of sane feature detection

2019-05-09 Thread Jdlrobson 
Jdlrobson edited projects, added User-Jdlrobson, Readers-Web-Backlog 
(Tracking), patch-welcome; removed Readers-Web-Backlog.
Jdlrobson added a comment.


  Patches welcome. Extension was a GSoc project and right now I'm the only one 
who reviews patches and patches I submit to the repo don't get code reviewed so 
I don't submit them myself (and I prefer to avoid self merging if I can).  I've 
been trying to find a maintainer to mentor/code review for, but sadly nothing 
has come about in that area yet.
  
  The crux of the problem here is skins do not have well defined APIs and the 
best we do have is hard to discover template variables (something I know that 
Krinkle is working towards with introducing mustache and trying to define this 
contract).
  
  WikidataPageBanner by design was defined such that skins would need to make 
themselves compatible if they wanted to. We didn't want to burden skin 
designers unnecessarily with a feature that may not work and/or would need skin 
level support (which is why we have $wgWPBSkinBlacklist configuration option). 
Supporting all the skins we have in the Wikimedia universe is hard, so I wanted 
to share that load.
  
  Per the code:
  
GetSkinTemplateOutputPageBeforeExec
Modifies the template to add the banner html for rendering by the skin. 
Note not
 * all skins render the prebodyhtml template variable so in some skins 
this will have no impact
 * whatsoever.
  
  So up to you. You can add that prebodyhtml and support banners or not. Longer 
term, I'd hope to see some kind of documentation of all the possible values 
that a skin can render and their types (array, html string or text string) as a 
result of some sort of skin API. On hindsight it would have been better to use 
"wikidatapagebanner" as a key rather than use the "prebodyhtml" that already 
existed to prevent overloading it.
  
  e.g.
  
$skin->registerTemplateValue( 'wikidatapagebanner', $value, 'string', 'An 
HTML string providing WikidataPageBanner')
  
  rather than
  
$skin->wikidatapagebanner = $value;
  
  so we can document how these template values are for and how they are used. 
T217158  should get us closer to 
something like that.

TASK DETAIL
  https://phabricator.wikimedia.org/T222681

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: phuedx, Jdlrobson, ashley, Isarra, Bawolff, darthmon_wmde, alaa_wmde, 
Dinadineke, Nandana, Chief_Mike, CycloneIsaac, tabish.shaikh91, Lahi, Gq86, 
GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, 
merbst, LawExplorer, Winter, Framawiki, _jensen, rosalieper, D3r1ck01, Evad37, 
Izno, MGChecker, Feldo, Wong128hk, Luke081515, Unapersona, Wikidata-bugs, aude, 
Dinoguy1000, waldyrious, RandomDSdevel, Lydia_Pintscher, TheDJ, Mbch331, Jay8g, 
Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T222681: WikidataPageBanner uses a blacklist of skin names to decide 'prebodyhtml' support instead of sane feature detection

2019-05-09 Thread phuedx 
phuedx added subscribers: Jdlrobson, phuedx.
phuedx added a project: Readers-Web-Backlog.
phuedx added a comment.


  Ping @Jdlrobson (the extension's author IIRC).

TASK DETAIL
  https://phabricator.wikimedia.org/T222681

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: phuedx
Cc: phuedx, Jdlrobson, ashley, Isarra, Bawolff, darthmon_wmde, alaa_wmde, 
Nandana, Chief_Mike, CycloneIsaac, Lahi, Gq86, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Winter, Framawiki, _jensen, rosalieper, 
Evad37, Izno, MGChecker, Feldo, Wong128hk, Luke081515, Unapersona, 
Wikidata-bugs, aude, Dinoguy1000, waldyrious, RandomDSdevel, Lydia_Pintscher, 
Mbch331, Jay8g, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs