[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Jdlrobson]

Jdlrobson edited projects, added MediaWiki-extensions-CentralAuth, 
Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.
Jdlrobson added a comment.


  This is not a MobileFrontend issue TBH.
  
  On wikidata.org (wmf-config/InitialiseSettings.php) $wgMobileUrlTemplate is 
set to m.%h1.%h2
  
$url = MobileContext::singleton()->getMobileUrl(
wfAppendQuery(

"//www.wikidata.org/wiki/Special:CentralAutoLogin/start",
[]
)
);
```gives  "//m.wikidata.org/wiki/Special:CentralAutoLogin/start" 

The only way I seem to be able to get `https://www.m.wikidata.org/...%22`  
is if I pass in 
"https://m.www.wikidata.org/wiki/Special:CentralAutoLogin/start; which is 
garbage in.

Although that works fine if I call that function with other projects, I'm 
going to get bad results. For example on English Wikipedia $wgMobileUrlTemplate 
is set to '%h0.m.%h1.%h2'. so if you call getMobileUrl on a wiki with a 
different host you are going to have a bad time.

The issue should be resolved in CentralNotice  (I'm not sure who maintains 
that) however I'm not quite sure how this will work.

The hook in MobileFrontend `GetMobileUrl` could be used or alternatively 
CentralNotice could make use of Varnish/redirects to determine what these links 
should be.

Note:
I remember vaguely working on a similar bug several years ago with help 
from the security team that introduced the hook GetMobileUrl.  We use to have a 
GetMobileUrl hook somewhere in our codebase, [[ 
https://codesearch.wmflabs.org/search/?q=GetMobileUrl=nope== | 
but that seems to have disappeared ]] so that might provide further clues on 
how this broke.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ovasileva, Jdlrobson
Cc: darthmon_wmde, Jdlrobson, aude, Krinkle, WDoranWMF, Anomie, Stryn, 
Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, 
Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, CptViraj, DannyS712, 
wildly_boy, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, QZanden, 
LawExplorer, Winter, JJMC89, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wong128hk, Wikidata-bugs, Snowolf, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Anomie]

Anomie edited projects, added MobileFrontend, Readers-Web-Backlog; removed Core 
Platform Team, MediaWiki-extensions-CentralAuth.
Anomie added a comment.


  This has nothing directly to do with CentralAuth. The logic that mangles URLs 
for mobile domains belongs to #MobileFrontend 
, specifically it's in 
`MobileContext::getMobileUrl()` and its downstream methods.
  
anomie@mwmaint1002:~$ mwscript shell.php --wiki=enwiki
Psy Shell v0.9.12 (PHP 7.2.26-1+0~20191218.33+debian9~1.gbpb5a340+wmf1 — 
cli) by Justin Hileman
>>> $wiki = WikiMap::getWiki( 'wikidatawiki' );
=> WikiReference {#5960}
>>> $url = $wiki->getFullUrl( 'Special:CentralAutoLogin/start' );
=> "//www.wikidata.org/wiki/Special:CentralAutoLogin/start"
>>> MobileContext::singleton()->getMobileUrl( $url )
=> "//www.m.wikidata.org/wiki/Special:CentralAutoLogin/start"
  
  Digging a little deeper, it seems to assume that every URL being mangled can 
use the local value for `$wgMobileUrlTemplate` rather than determining the 
mangling based on the //target// domain.
  
  Poking to #readers-web-backlog 
 as the owner of 
#mobilefrontend .

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Anomie
Cc: WDoranWMF, Anomie, Stryn, Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, 
csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, 
darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, mojoaxel, GoranSMilovanovic, 
QZanden, LawExplorer, Winter, JJMC89, _jensen, rosalieper, Agabi10, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Rxy, holger.knust, EvanProdromou, wildly_boy, 
Pchelolo, Wong128hk, Snowolf, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[WDoranWMF]

WDoranWMF added subscribers: Anomie, WDoranWMF.
WDoranWMF added a project: Core Platform Team.
WDoranWMF added a comment.


  @Anomie could you review this and give an opinion on who would be best/which 
team to request input from?

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WDoranWMF
Cc: WDoranWMF, Anomie, Stryn, Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, 
csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, 
darthmon_wmde, holger.knust, EvanProdromou, DannyS712, wildly_boy, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Pchelolo, Wong128hk, Wikidata-bugs, Snowolf, 
aude, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Addshore]

Addshore added a project: MediaWiki-Authentication-and-authorization.
Addshore added a comment.


  Also going to tag #mediawiki-authentication-and-authorization 

 as it could be related and likely to catch some more eyes.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Reedy, Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, 
Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, DannyS712, 
wildly_boy, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, Agabi10, Wong128hk, Wikidata-bugs, Snowolf, aude, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Krinkle]

Krinkle removed a project: Wikimedia-production-error.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Krinkle
Cc: Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, 
WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Addshore, Mbch331, Rxy, Jay8g, Jdforrester-WMF, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Pablo-WMDE]

Pablo-WMDE added a project: Wikidata Mobile.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, 
WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Jdforrester-WMF, Addshore, Mbch331, Rxy, Jay8g, 
Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Lydia_Pintscher]

Lydia_Pintscher merged a task: T196531: Use same login mechanism on desktop and 
mobile.
Lydia_Pintscher added a subscriber: Jonas.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Jonas, Jakob_WMDE, Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, 
WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, 
Wikidata-bugs, Snowolf, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Pablo-WMDE]

Pablo-WMDE added a project: Wikimedia-production-error.
Pablo-WMDE added a comment.


  It is a bit concerning to see this has not been triaged by the maintainers 
after more than 3 weeks.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE-leszek, 
Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, Snowolf, 
aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Lea_WMDE]

Lea_WMDE added a project: Wikidata-Termbox-Hike.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_WMDE
Cc: Legoktm, hoo, csteipp, vvv, Framawiki, Lydia_Pintscher, WMDE-leszek, 
Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wong128hk, Wikidata-bugs, Snowolf, 
aude, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T225814: m.wikidata: login status not detected

[Pablo-WMDE]

Pablo-WMDE added a project: MediaWiki-extensions-CentralAuth.
Pablo-WMDE added a comment.


  Would be great to get word from the #mediawiki-extensions-centralauth 
 
people if they have a suspicion where this problem originates from.

TASK DETAIL
  https://phabricator.wikimedia.org/T225814

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Lydia_Pintscher, WMDE-leszek, Aklapper, Pablo-WMDE, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wong128hk, Wikidata-bugs, Snowolf, aude, Mbch331, Rxy, Jay8g, Legoktm
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs