[Wikidata-bugs] [Maniphest] [Updated] T88434: generate Wikibase.git code coverage on Jenkins

2019-05-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  For reference, over the past two years, 75% of Wikibase commits only touched 
one subdirectory, 14% touched two, 6% touched three, and 4% touched four or 
more (or files in the root directory). That’s excluding merge commits and 
l10n-bot stuff; see P8544  for details.
  
  Some of these will be submodule updates (we have six submodules in 
`view/lib/`), but still, this seems to suggest that the Wikibase extensions 
aren’t as tightly coupled as I thought, and that splitting them into separate 
repositories might actually be an option.

TASK DETAIL
  https://phabricator.wikimedia.org/T88434

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, 
JanZerebecki, Aklapper, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, 
Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T88434: generate Wikibase.git code coverage on Jenkins

2019-05-19 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T88434#4918803 , 
@Legoktm wrote:
  
  > That's one possible option, yes. Or you can adopt the standard layout in 
one repo, but slightly reversed: `includes/lib/`, `includes/repo/`, 
`tests/phpunit/client/`. That's more up to the maintainers of Wikibase to 
figure out, but CI (and a growing number of tools) do assume the standard 
layout.
  
  
  I just came back across this point while looking into T223214: Start 
converting Wikibase extensions to use extension registration 
, because the location of the 
`extension.json` file(s) for Wikibase is influenced by this as well. If we keep 
the current `repo/includes/` etc. pattern, then there’s a clear place for the 
JSON files: `repo/extension.json`. On the other hand, with `includes/repo/`, 
the most natural (to me) placement of the JSON files would place them all in 
the repository root, where they would collide with each other. I guess that 
could be resolved by departing from the standard `extension.json` name and 
having `extension-repo.json` etc., but I’m not sure how ugly that is compared 
to other approaches…

TASK DETAIL
  https://phabricator.wikimedia.org/T88434

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ricordisamoa, Addshore, Legoktm, hashar, 
JanZerebecki, Aklapper, darthmon_wmde, alaa_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, thcipriani, 
Wikidata-bugs, aude, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs