[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-15 Thread darthmon_wmde 
darthmon_wmde closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, darthmon_wmde
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-15 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Reviewed, verified and approved. Thanks for the amazing work!

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, Sarai-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-14 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  https://github.com/wmde/wikit/pull/80

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-14 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  After a comment in the chat I interpret
  
  > structure is [...] not followed
  
  as a deficit in
  
  > the order of the nested pages
  
  instead, and will address that order in a separate patch.

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-13 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  All solved in terms of content and visualization, but I need to bring up the 
structure again (sorry about that). Any reason why we cannot follow the 
spreadsheet here?
  
  F31933750: Screenshot 2020-07-13 at 18.29.10.png 
  F31933755: Screenshot 2020-07-13 
at 18.32.08.png 
  
  (The structure is also not followed in the "Font" section, but in that case 
there's not a logical connection within the nested pages, like here)

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE, Sarai-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T256854: Create visalization for Size/Dimension

2020-07-10 Thread Pablo-WMDE 
Pablo-WMDE added a comment.


  In T256854#6277508 , 
@Sarai-WMDE wrote:
  
  > Viz pimping:
  >
  > 1. Divide the content in two sections/tables with their respective h3s in 
the following order:
  >   1. Static sizes (from `dimension-static-size-0` to 
`dimension-static-size-3200`)
  >   2. Heights and widths
  >
  > (A third section containing paddings will also be included here once those 
tokens are injected)
  >
  > 2. Remove `dimension-font-size` tokens from this page: they are contained 
by the section "Font size" already
  
  There was movement about the token structure, as far as I understand it this 
comment may be covered in https://github.com/wmde/wikit/pull/73 - please take a 
look at the storybook there.

TASK DETAIL
  https://phabricator.wikimedia.org/T256854

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Pablo-WMDE
Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs