[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread Ammarpad 
Ammarpad closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Maintenance_bot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.3; 
2020-08-04); removed MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, ReleaseTaggerBot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread brennen 
brennen removed a parent task: T257971: 1.36.0-wmf.3 deployment blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, brennen
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-operations) [2020-08-06T17:36:14Z] 
 Synchronized 
php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoEntityTermsView.php:
 Backport: [[gerrit:618582|Fix array unpacking as argument list]] (T259745 
) (duration: 01m 07s)

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Stashbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread gerritbot 
gerritbot added a comment.


  Change 618582 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.3] Fix array unpacking 
as argument list
  
  https://gerrit.wikimedia.org/r/618582

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread gerritbot 
gerritbot added a comment.


  Change 618582 had a related patch set uploaded (by Brennen Bearnes; owner: 
Ammarpad):
  [mediawiki/extensions/WikibaseMediaInfo@wmf/1.36.0-wmf.3] Fix array unpacking 
as argument list
  
  https://gerrit.wikimedia.org/r/618582

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, 
Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Ramsey-WMF, Bsandipan, Pablo-WMDE, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread thiemowmde 
thiemowmde added subscribers: Umherirrender, thiemowmde.
thiemowmde added a comment.


  The problematic `...` was added in patch 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/538388
 (T224772 ) by @Umherirrender 10 
months ago. I think I understand why: I believe Phan gets confused by how the 
called `\OOUI\Tag::appendContent()` method is documented. The method accepts 
any number of `string`, `\OOUI\Tag`, or `\OOUI\HtmlSnippet` in whatever 
combination and order, either as an array or as a list of parameters. So the 
documentation would need to say something like 
`string|Tag|HtmlSnippet|(string|Tag|HtmlSnippet)[]`, but talks about a generic 
`array` instead.
  
  Note that while adding the `...` slightly changed the semantics (while an 
array can be empty, a list of parameters can not), this was not a mistake! 
According to the documentation of getLanguagesOrderedByFallbackChain() it can 
never return an empty array, so getCaptionsContent() can never be an empty 
array as well. I believe there is another bug that makes these methods return 
empty arrays. I created T259779: LanguageFallbackChainFactory returns empty 
fallback chain when it shouldn't  to 
keep track of this.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, thiemowmde
Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, 
Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, 
GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, 
El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, Maintenance_bot
Cc: Agusbou2015, Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, 
LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.4; 2020-08-11).

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, ReleaseTaggerBot
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-06 Thread gerritbot 
gerritbot added a comment.


  Change 618643 **merged** by jenkins-bot:
  [mediawiki/extensions/WikibaseMediaInfo@master] Fix array unpacking as 
argument list
  
  https://gerrit.wikimedia.org/r/618643

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad, gerritbot
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Ammarpad 
Ammarpad added a project: WikibaseMediaInfo.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Ammarpad 
Ammarpad claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ammarpad
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Agusbou2015, Catrope, Aklapper, brennen, Alter-paule, Beast1978, CBogen, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, 
Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread gerritbot 
gerritbot added a comment.


  Change 618643 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
  [mediawiki/extensions/WikibaseMediaInfo@master] Fix array unpacking as 
argument list
  
  https://gerrit.wikimedia.org/r/618643

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Agusbou2015, Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, 
Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, 
LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, 
Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, 
Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, 
Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread Catrope 
Catrope added a comment.


  The relevant code is
  
$layout->appendContent(
...$this->getCaptionsContent(
$entity->getLabels(),
$this->getLanguagesOrderedByFallbackChain( 
$entity )
)
);
  
  I think the simplest fix would be to simply remove the spread operator 
(`...`), since `appendContent()` can also be called with an array as the only 
parameter.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Catrope
Cc: Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, 
Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, 
Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, 
Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Lydia_Pintscher, 
Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen 
brennen added a parent task: T257971: 1.36.0-wmf.3 deployment blockers.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, 
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, 
Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen 
brennen triaged this task as "Unbreak Now!" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, 
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, 
Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan, RhinosF1
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed

2020-08-05 Thread brennen 
brennen created this task.
brennen added projects: Wikimedia-production-error, Wikidata-Campsite, Commons, 
OOjs, User-brennen.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  `MediaWiki version:`  **`1.36.0-wmf.3`**
  
  name=message
PHP Fatal Error: Uncaught ArgumentCountError: Too few arguments to function 
OOUI\Tag::appendContent(), 0 passed in 
/srv/mediawiki/php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoEntityTermsView.php
 on line 91 and exactly 1 expected in 
/srv/mediawiki/php-1.36.0-wmf.3/vendor/oojs/oojs-ui/php/Tag.php:216
Stack trace:
#0 
/srv/mediawiki/php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoEntityTermsView.php(91):
 OOUI\Tag->appendContent()
#1 
/srv/mediawiki/php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoView.php(86):
 
Wikibase\MediaInfo\View\MediaInfoEntityTermsView->getHtml(Object(Wikibase\MediaInfo\DataModel\MediaInfo))
#2 
/srv/mediawiki/php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/View/MediaInfoView.php(79):
 
Wikibase\MediaInfo\View\MediaInfoView->getCaptionsHtml(Object(Wikibase\MediaInfo\DataModel\MediaInfo))
#3 
/srv/mediawiki/php-1.36.0-wmf.3/extensions/WikibaseMediaInfo/src/WikibaseMediaInfoHooks.php(528):
 Wikibase\MediaInfo\View\MediaInfoView->getContent(Object(Wikibase\MediaInf
  
  
  
  Impact / Notes
  --
  
  28+ of these and slowly ticking up within the first 15 minutes or so of 
rolling 1.36.0-wmf.3 to group1.

TASK DETAIL
  https://phabricator.wikimedia.org/T259745

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: brennen
Cc: Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, 
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, 
Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Lydia_Pintscher, Jdforrester-WMF, 
Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs