[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
EBernhardson merged a task: T255658: PHP Warning:
{type:error,message:cirrussearch-backend-error,params:[]}
[Called from
Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults in
/srv/mediawiki/php-1.35.0-wmf.37/extensions/WikibaseCirrusSearch/src/EntitySearchElastic.php
at line 318].
EBernhardson added subscribers: LarsWirzenius, dcausse, brennen,
Jdforrester-WMF.
TASK DETAIL
https://phabricator.wikimedia.org/T260276
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: EBernhardson
Cc: Jdforrester-WMF, brennen, dcausse, LarsWirzenius, Krinkle, EBernhardson,
Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana,
Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer,
_jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb,
Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
Krinkle closed this task as "Resolved". Krinkle added a comment. Confirmed gone from Logstash after Aug 26. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, Krinkle Cc: Krinkle, EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.6; 2020-08-25). TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, ReleaseTaggerBot Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, Maintenance_bot Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
gerritbot added a comment. Change 621584 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseCirrusSearch@master] Don't log end user error messages https://gerrit.wikimedia.org/r/621584 TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson, gerritbot Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
EBernhardson moved this task from needs triage to Current work on the Discovery-Search board. EBernhardson edited projects, added Discovery-Search (Current work); removed Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T260276 WORKBOARD https://phabricator.wikimedia.org/project/board/1849/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
EBernhardson claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
gerritbot added a comment. Change 621584 had a related patch set uploaded (by Ebernhardson; owner: Ebernhardson): [mediawiki/extensions/WikibaseCirrusSearch@master] Don't log end user error messages https://gerrit.wikimedia.org/r/621584 TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, Alter-paule, Beast1978, CBogen, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
EBernhardson added a comment. This bit of code includes the comment // FIXME: this is a hack, we need to return Status upstream instead The value that is being logged here was intended for end users, it provides an i18n message to tell the user what went wrong. In this case there was a failure communicating with the backend service. Failure rates are already tracked and alerted on, the log message here is unactionable. Tempted to simply drop the code that logs these. It was trying to make sure it didn't simply ignore the error, but amounts to spamming up logs with messages for the end user. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EBernhardson Cc: EBernhardson, Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260276: cirrussearch-backend-error: Called from Wikibase\Search\Elastic\EntitySearchElastic::getRankedSearchResults
thcipriani added projects: CirrusSearch, Wikidata-Campsite. Restricted Application added a project: Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T260276 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thcipriani Cc: Aklapper, thcipriani, Wilmanbeno, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, jeremyb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
