[Wikidata-bugs] [Maniphest] T267741: Switch test for wikit-class on root html tag to eslint based solution
ItamarWMDE closed this task as "Resolved". ItamarWMDE claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T267741 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ItamarWMDE Cc: Pablo-WMDE, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T267741: Switch test for wikit-class on root html tag to eslint based solution
Pablo-WMDE added a project: User-Pablo-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T267741 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T267741: Switch test for wikit-class on root html tag to eslint based solution
Pablo-WMDE added a comment. Scribbled something here: https://github.com/wmde/wikit/pull/266 TASK DETAIL https://phabricator.wikimedia.org/T267741 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T267741: Switch test for wikit-class on root html tag to eslint based solution
Michael created this task. Michael added a project: Wikidata Design System. Restricted Application added a subscriber: Aklapper. Restricted Application added a project: Wikidata. TASK DESCRIPTION Maintaining the existing test for the presence of the `wikit` class on published components is becoming complicated as those components start to get required properties with no default value. Consider replacing this test by en eslint rule. C.f. https://github.com/vuejs/eslint-plugin-vue/blob/80b8983/lib/rules/static-class-names-order.js See for context: - https://github.com/wmde/wikit/pull/264 - https://github.com/wmde/wikit/pull/260 TASK DETAIL https://phabricator.wikimedia.org/T267741 WORKBOARD https://phabricator.wikimedia.org/project/board/4521/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Aklapper, Michael, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs