[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore moved this task from Legacy Inbox to Backlog on the wdwb-tech board.
Addshore added a comment.


  > Remove the communication and the unused message (and maybe rephrase the 
used message, if we want to). This means effectively no change to users – we’d 
just acknowledge a status quo that has existed for years, and which seems to be 
acceptable (I’m not aware of complaints about it).
  
  Sounds like this would be the right choice

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3532/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore moved this task from Prioritized Tech (prioritised from top to bottom) 
to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, 
maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Ladsgroup]

Ladsgroup added a comment.


  There is a basically exact same situation with 
`wikibase-after-page-delete-queued` as well. I have to check the hook handlers 
to be sure but if you know on top of your head that it's the case or not. Let 
me know.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[gerritbot]

gerritbot added a comment.


  Change 709489 had a related patch set uploaded (by Ladsgroup; author: 
Ladsgroup):
  
  [mediawiki/extensions/Wikibase@master] Drop wikibase-after-page-move-queued 
message
  
  https://gerrit.wikimedia.org/r/709489

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, 
DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, 
alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  In T268135#7252244 , 
@Ladsgroup wrote:
  
  > There is a basically exact same situation with 
`wikibase-after-page-delete-queued` as well. I have to check the hook handlers 
to be sure but if you know on top of your head that it's the case or not. Let 
me know.
  
  Doesn’t ring a bell, please check :)

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, Kent7301, 
alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup added a comment.
Restricted Application added a project: User-Ladsgroup.


  In T268135#7252426 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T268135#7252244 , 
@Ladsgroup wrote:
  >
  >> There is a basically exact same situation with 
`wikibase-after-page-delete-queued` as well. I have to check the hook handlers 
to be sure but if you know on top of your head that it's the case or not. Let 
me know.
  >
  > Doesn’t ring a bell, please check :)
  
  I'll check that separately. The first patch is ready for review.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[gerritbot]

gerritbot added a comment.


  Change 709489 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Drop wikibase-after-page-move-queued 
message
  
  https://gerrit.wikimedia.org/r/709489

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, gerritbot
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Ladsgroup]

Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  let me check the deletion hook.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, ReleaseTaggerBot
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, 
Hazizibinmahdi, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Maintenance_bot]

Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Maintenance_bot
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g, Biggs657, Lalamarie69, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Ladsgroup]

Ladsgroup moved this task from Doing to Test (Verification) on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Ladsgroup added a comment.


  No the delete hook (`ArticleDeleteCompleteHook`) is synchronous as far as I 
can see.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Addshore]

Addshore closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Addshore
Cc: Ladsgroup, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, Aklapper, 
Invadibot, maantietaja, Hazizibinmahdi, Akuckartz, Iflorez, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, 
aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, wdwb-tech-focus, 
Technical-Debt, MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  I noticed while working on T261275 
 that the current code related to 
the “page was moved, {{WBREPONAME}} item was updated” notification message is a 
mess, and I believe it needs to be cleaned up. This is the timeline, as far as 
I can tell:
  
  - June 2013 : First implementation of 
page move handling. Two hook handlers are used on the client. The “update repo” 
hook handler listens for a MediaWiki hook when a page was moved, and tries to 
schedule a job on the repo to update the connected item accordingly. The 
“notice” hook handler listens for a MediaWiki hook when a special page for a 
successful page move is being shown, and adds a notice to the HTML about the 
repo item being updated. The hooks communicate with one another through a 
dynamic property on the `Title` object they both receive: if the “update repo” 
hook handler successfully scheduled the job, it sets the 
`wikibasePushedMoveToRepo` property, and the “notice” hook handler will then 
choose the `wikibase-after-page-move-queued` message: “The item associated with 
this page will be automatically updated.” If the property does not exist on the 
`Title` (e. g. because the “update repo” hook handler encountered an error), 
then the “notice” hook handler will instead choose the 
`wikibase-after-page-move` message: “You should also update the item to 
maintain links.”
  
  - October 2015 : A change in MediaWiki 
core causes the hook used by the “update repo” hook handler to be fired 
asynchronously (initially using `IDatabase::onTransactionIdle`; later, it will 
be turned into a deferred update). I believe this means that the “update repo” 
hook handler will now always run //after// the “notice” hook handler, and 
therefore the “notice” hook handler will never see the dynamic property added 
to the `Title`, and will always choose the `wikibase-after-page-move` message: 
“You should also update the item.”
  
  - June 2017 : The 
`wikibase-after-page-move` message is changed from “You should also update the 
item” to “The move should now be reflected in the item; we ask that you check 
this has occurred.” – closer to the `wikibase-after-page-move-queued` message. 
The change is linked to T158842: Update wording re associated Wikidata item 
following move , and both the change 
and the task mention an “update” or “new functionality”, but I’m not aware of 
any changes in Wikibase that this is reacting to, and suspect it’s a 
misunderstanding: Wikibase has been able to update the associated item since 
2013, and used to have two messages depending on whether this was successful or 
not; this change now changed the “unsuccessful” message into a variant of the 
“successful” one, because in the meantime a MediaWiki core change had caused 
the “successful” message to become unused, and the “unsuccessful” message to be 
shown always.
  
  - June 2020 : The “update repo” hook 
handler is changed, and now sets the dynamic property 
(`wikibasePushedMoveToRepo`) on a newly created `Title` object, not the 
`LinkTarget` it received as input (which may or may not be a `Title`); as a 
result, the “notice” hook handler now has no chance to see this dynamic 
property even if the “update repo” hook handler somehow became synchronous 
again.
  
  I see two ways forward:
  
  1. Fix the communication between the two hook handlers, and then add a solid 
test case to ensure it doesn’t break again. There is a synchronous version of 
the hook used by the “update repo” hook handler, `PageMoveCompleting`, but I’m 
not sure if it’s worth using. I’m also not sure if using that hook (and fixing 
the “June 2020” issue mentioned above) would be enough – and there’s no denying 
that the communication between the two hooks, by setting a random property on a 
MediaWiki core object that both hooks receive as input, was at best hacky even 
when it worked.
  
  2. Remove the communication and the unused message (and maybe rephrase the 
//used// message, if we want to). This means effectively no change to users – 
we’d just acknowledge a status quo that has existed for years, and which seems 
to be acceptable (I’m not aware of complaints about it).
  
  Personally, I lean towards option 2. Showing whether the page move could be 
propagated to the repo or not was a nice feature when it worked, but I don’t 
think it’s an essential feature worth preserving with a lot of effort. (Also, 
even if we can enqueue the job in the repo, there’s no guarantee it doesn’t 
crash, so we can never have a //complete// guarantee that

[Wikidata-bugs] [Maniphest] T268135: Clean up Wikibase page move notification message

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Note: currently, the “update repo” handler is the `UpdateRepoHookHandler` 
class and it listens for the `PageMoveComplete` hook, and the “notice” handler 
is the `MovePageNotice` class and it listens for the `SpecialMovepageAfterMove` 
hook, but I avoided mentioning those names in the timeline because this moved 
around somewhat over time.

TASK DETAIL
  https://phabricator.wikimedia.org/T268135

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, darthmon_wmde, DannyS712, 
Nandana, lucamauri, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, 
Dinoguy1000, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs