[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-19 Thread Lydia_Pintscher 
Lydia_Pintscher closed this task as "Resolved".
Lydia_Pintscher moved this task from Test (Verification) to Done on the 
Wikidata Query Builder (Wikidata Query Builder - sprint 5) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Lydia_Pintscher
Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Michael, Manishsamota, 
Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-15 Thread Ladsgroup 
Ladsgroup moved this task from Doing to Peer Review on the Wikidata Query 
Builder (Wikidata Query Builder - sprint 5) board.
Ladsgroup added a comment.


  https://github.com/wmde/query-builder/pull/102

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Michael, Manishsamota, 
Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-14 Thread Ladsgroup 
Ladsgroup claimed this task.
Ladsgroup moved this task from To Do to Doing on the Wikidata Query Builder 
(Wikidata Query Builder - sprint 5) board.
Restricted Application added a project: User-Ladsgroup.

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Michael, Manishsamota, 
Hazizibinmahdi, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-14 Thread Ladsgroup 
Ladsgroup added a comment.


  Why not? It's Christmas! *insert jingle bells music*

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-14 Thread guergana.tzatchkova 
guergana.tzatchkova added a comment.


  So is this ticket assigned to you @Ladsgroup ? :D

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: guergana.tzatchkova, Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup 
Ladsgroup added a comment.


  Indeed, we should get the list of the ones that are string value type but 
different rdf builder, can work on that a bit later.

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Michael 
Michael added a comment.


  We should only have datatypes in that list that //actually// work with the 
QueryBuilder as it is currently implemented. https://w.wiki/pHB doesn't, so I 
guess we should at least move `commonsMedia` to unsupported, maybe even more 
data types.
  
  Which of the others isn't working either?

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup 
Ladsgroup added a comment.


  That's an interesting observation. The Commons media data type is a string 
value type so if we want to check in json, it works but the rdf output checks 
against a different value (its own prefix, etc.)

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Michael 
Michael added a comment.


  In T269439#6669468 , 
@Ladsgroup wrote:
  
  > I'm not sure if that's the case. `P14` is a commons media datatype which we 
don't support yet and that query is not done correctly.
  >
  > What we do support seems to work (Should not show 
https://www.wikidata.org/wiki/Q84365153) and it doesn't: https://w.wiki/pGY
  
  Ok, so that means we have added to many datatypes as "supported" in 
https://github.com/wmde/query-builder/pull/82 ?

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Ladsgroup 
Ladsgroup added a comment.


  I'm not sure if that's the case. `P14` is a commons media datatype which we 
don't support yet and that query is not done correctly.
  
  What we do support seems to work (Should not show 
https://www.wikidata.org/wiki/Q84365153) and it doesn't: https://w.wiki/pGY

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Michael 
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T269439: Queries "not matching" a value are broken

2020-12-04 Thread Michael 
Michael created this task.
Michael added projects: Wikidata Query Builder (Wikidata Query Builder - sprint 
5), Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Steps to Reproduce:
  
  - `P14` as the property
  - `without` as the relation
  - "NH Route 16.svg" as the value
  
  Then it produces the following SPARQL:
  
SELECT ?item WHERE { ?item (p:P14/ps:P14) ?instance. FILTER(?instance != 
"NH Route 16.svg")}
  
  However, when some sorting is added, then it becomes obvious that the item 
with that value is not actually removed from the result: https://w.wiki/pFe (It 
is the first item in the results.)
  
  **Acceptance criteria:**
  
  [ ] the "without" query does not return results that match the provided
  
  **Notes:**
  
  - This will need some research to figure out what is actually the correct 
query here

TASK DETAIL
  https://phabricator.wikimedia.org/T269439

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5090/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Manishsamota, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs