[Wikidata-bugs] [Maniphest] T272626: Correct inset style of focused filled elements

2021-04-15 Thread Sarai-WMDE 
Sarai-WMDE claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T272626

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272626: Correct inset style of focused filled elements

2021-04-15 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T272626

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272626: Correct inset style of focused filled elements

2021-01-27 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  @SaiSan-WMDE About the outline issues noticed in #358, This is due to the 
face that the global token's offest value is inset 0 0 0 1px when in fact what 
we want is to create the shdow box outline 1px inside the borders. See this 
example on codepen.

TASK DETAIL
  https://phabricator.wikimedia.org/T272626

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272626: Correct inset style of focused filled elements

2021-01-25 Thread ItamarWMDE 
ItamarWMDE added a comment.


  Priority Notes:
  
  - Breaking change
  - Affects implementers of the DS
  - Doesn't really affect end users
  - Doesn't affect developer workflow

TASK DETAIL
  https://phabricator.wikimedia.org/T272626

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Volker_E, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T272626: Correct inset style of focused filled elements

2021-01-21 Thread Sarai-WMDE 
Sarai-WMDE created this task.
Sarai-WMDE added a project: Wikidata Design System.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Current state:
  
  - Primary buttons (& the toggle, by extension) currently display a 2px white 
inset box-shadow, while actually they should display a 1px #36c inset + a 2px 
#fff inset  => `box-shadow-inset-focus-button-primary` should be replaced by 
`box-shadow-inset-focus-inverted` & `box-shadow-inset-focus-progressive` / 
`box-shadow-inset-focus-destructive`.
  
  - Checkboxes currently display a 1px white inset box-shadow, while – like 
primary buttons – they should display a 1px #36c inset + a 2px #fff inset
  
  `box-shadow-inset-focus-button-primary` can be deprecated, while the width of 
`box-shadow-inset-focus-inverted` needs to. The buttons were missing a 1px 
inset that makes their border more prominent on focus

TASK DETAIL
  https://phabricator.wikimedia.org/T272626

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4521/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs