[Wikidata-bugs] [Maniphest] T273178: Results shown even after deleting the condition

[amy_rc]

amy_rc closed this task as "Resolved".
amy_rc added a comment.


  Tested and it works now!! ❇ \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T273178

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, amy_rc
Cc: Ladsgroup, Michael, Aklapper, amy_rc, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273178: Results shown even after deleting the condition

[Ladsgroup]

Ladsgroup claimed this task.
Ladsgroup moved this task from Ready to pick up to Peer Review on the Wikidata 
Query Builder board.
Ladsgroup added a comment.
Restricted Application added a project: User-Ladsgroup.


  https://github.com/wmde/query-builder/pull/189

TASK DETAIL
  https://phabricator.wikimedia.org/T273178

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, Michael, Aklapper, amy_rc, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273178: Results shown even after deleting the condition

[Michael]

Michael moved this task from Ready for story time to Ready to pick up on the 
Wikidata Query Builder board.
Michael added a comment.


  Heh, yes. That is the query that we run in that case:
  
SELECT DISTINCT ?item ?itemLabel WHERE {
  SERVICE wikibase:label { bd:serviceParam wikibase:language 
"[AUTO_LANGUAGE]". }
  {
SELECT DISTINCT ?item WHERE { ?item wikibase:sitelinks _:anyValue. }
LIMIT 5
  }
}
  
  It just returns the expected number of items, no conditions at all. That's 
probably not what we want.
  
  This bug seems simple enough to be worked on straight away, if need be.
  
  **acceptance criteria**
  
  --> We should adjust the `Validator` to take the case of 0 conditions into 
account and to show the "empty Query Builder" info message.

TASK DETAIL
  https://phabricator.wikimedia.org/T273178

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Aklapper, amy_rc, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273178: Results shown even after deleting the condition

[Lydia_Pintscher]

Lydia_Pintscher triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T273178

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, amy_rc, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273178: Results shown even after deleting the condition

[amy_rc]

amy_rc created this task.
amy_rc added projects: Wikidata, Wikidata Query Builder.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Incorrect results are displayed when the last condition is deleted.
  
  **Steps to Reproduce: **
  
  1. A visual query,  `With` "postal code" and `matching` "560094"
  2. Run the query,  the correct results are displayed
  3. Delete the condition
  4. Run the query
  
  **Actual Results:**
  Random items are displayed. 
  F34052914: image.png 
  
  **Expected Results:**
  An info message to be displayed so that editors do not get confused- 
  Example - //"Looks like the Query Builder was empty, please enter a valid 
query first, then try running it again."//

TASK DETAIL
  https://phabricator.wikimedia.org/T273178

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: amy_rc
Cc: Aklapper, amy_rc, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs