[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-24 Thread amy_rc 
amy_rc moved this task from Test (Verification) to Done on the Wikidata Query 
Builder board.
amy_rc closed this task as "Resolved".
amy_rc added a comment.


  Thanks. Tested and it works!! 

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, amy_rc
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-24 Thread Ladsgroup 
Ladsgroup added a comment.


  The new system should be already deployed. Just make sure you cleared the 
cache (ctrl+shift+r)

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-24 Thread amy_rc 
amy_rc added a comment.


  I will wait for the deployment to test it? Is it any other link where i could 
test this?

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, amy_rc
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-24 Thread amy_rc 
amy_rc added a comment.


  In T273184#6853575 , 
@Ladsgroup wrote:
  
  > This took hours and a headache to let me understand what's happening.
  >
  > The fix is: https://github.com/wmde/query-builder/pull/209
  >
  > So, it doesn't happen if you copy-paste the url but it does happen if you 
refresh the page with ctrl+r, at first I thought it might be something in the 
headers and referrer was a candidate. It was the only thing different in 
headers when you make a request by copy-pasting the URL but it doesn't happen 
if you right-click on it and open on the new tab and it does have the referrer 
too so that's not the issue. Comparing how we make the iframe with scholia (and 
reading about iframes in general). I learned that we sandbox our iframe which 
does some security measure. The problem is that sandbox 
 is extremely 
restrictive (which is a good thing in general) and you need to turn on each 
feature one by one. The reason this happens is that when you click on it 
meaning you allow a popups, it carries the sandbox mode to the new tab and it 
breaks wdqs gui (I couldn't figure out exactly how, the number of caught 
exceptions in gui is really astonishing) but when turning on 
`allow-popups-to-escape-sandbox` would fix it. I assume when don't let bad js 
being ran in the iframe nor we link to problematic websites there. So this is 
fine.
  
  

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, amy_rc
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-23 Thread Michael 
Michael added a comment.


  In T273184#6853575 , 
@Ladsgroup wrote:
  
  > This took hours and a headache to let me understand what's happening.
  >
  > The fix is: https://github.com/wmde/query-builder/pull/209
  >
  > So, it doesn't happen if you copy-paste the url but it does happen if you 
refresh the page with ctrl+r, at first I thought it might be something in the 
headers and referrer was a candidate. It was the only thing different in 
headers when you make a request by copy-pasting the URL but it doesn't happen 
if you right-click on it and open on the new tab and it does have the referrer 
too so that's not the issue. Comparing how we make the iframe with scholia (and 
reading about iframes in general). I learned that we sandbox our iframe which 
does some security measure. The problem is that sandbox 
 is extremely 
restrictive (which is a good thing in general) and you need to turn on each 
feature one by one. The reason this happens is that when you click on it 
meaning you allow a popups, it carries the sandbox mode to the new tab and it 
breaks wdqs gui (I couldn't figure out exactly how, the number of caught 
exceptions in gui is really astonishing) but when turning on 
`allow-popups-to-escape-sandbox` would fix it. I assume when don't let bad js 
being ran in the iframe nor we link to problematic websites there. So this is 
fine.
  
  Great work figuring this out and fixing it. Thanks!

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup, Michael
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-23 Thread Ladsgroup 
Ladsgroup moved this task from Ready for story time to Peer Review on the 
Wikidata Query Builder board.
Ladsgroup claimed this task.
Ladsgroup added a comment.
Restricted Application added a project: User-Ladsgroup.


  This took hours and a headache to let me understand what's happening.
  
  The fix is: https://github.com/wmde/query-builder/pull/209
  
  So, it doesn't happen if you copy-paste the url but it does happen if you 
refresh the page with ctrl+r, at first I thought it might be something in the 
headers and referrer was a candidate. It was the only thing different in 
headers when you make a request by copy-pasting the URL but it doesn't happen 
if you right-click on it and open on the new tab and it does have the referrer 
too so that's not the issue. Comparing how we make the iframe with scholia (and 
reading about iframes in general). I learned that we sandbox our iframe which 
does some security measure. The problem is that sandbox 
 is extremely 
restrictive (which is a good thing in general) and you need to turn on each 
feature one by one. The reason this happens is that when you click on it 
meaning you allow a popups, it carries the sandbox mode to the new tab and it 
breaks wdqs gui (I couldn't figure out exactly how, the number of caught 
exceptions in gui is really astonishing) but when turning on 
`allow-popups-to-escape-sandbox` would fix it. I assume when don't let bad js 
being ran in the iframe nor we link to problematic websites there. So this is 
fine.

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Hazizibinmahdi, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-19 Thread amy_rc 
amy_rc added a comment.


  I tried similar scenario on Scholia. link: 
https://scholia.toolforge.org/publisher/Q233358. Here `editSPARQL query link 
`works with left-click
  
  F34113861: scholia.gif 

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: amy_rc
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-17 Thread amy_rc 
amy_rc added a comment.


  yes. It does not work when I `left-click`. But it worked for middle-click, 
right-click, ctrl-left-click

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: amy_rc
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-16 Thread Michael 
Michael added a comment.


  This is an interesting bug. It DOES occur if you left-click that `Edit 
SPARQL` link. It does NOT occur, if you middle-click it, if you ctrl-click it, 
or if you right-click it and select "Open in a new tab". 樂

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-10 Thread Ladsgroup 
Ladsgroup added a comment.


  This is a bug in WDQS GUI and we can't do anything inside query builder to 
fix it. We can fix the problem by changing the wdqs gui code though but that 
opens a huge list of things need fixing (including the look, design, etc.)

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: Ladsgroup, amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-02-08 Thread Lydia_Pintscher 
Lydia_Pintscher triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4990/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T273184: The editSPARQL query link does not generate results in query.wikidata.org

2021-01-28 Thread amy_rc 
amy_rc renamed this task from "The editSPARQL query link does not generate 
results in https://query.wikidata.org/; to "The editSPARQL query link does not 
generate results in query.wikidata.org".

TASK DETAIL
  https://phabricator.wikimedia.org/T273184

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: amy_rc
Cc: amy_rc, Aklapper, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs