[Wikidata-bugs] [Maniphest] T281709: Make PropertyLabelResolverTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE assigned this task to Collins.
Lucas_Werkmeister_WMDE added a comment.


  This was resolved by Use ObjectCacheFactory 
 
(T363770 , T361949 
) as far as I can tell. \o/

TASK DETAIL
  https://phabricator.wikimedia.org/T281709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Collins, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benjafield_WMDE, 
S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281709: Make PropertyLabelResolverTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  > Because the cache type is variable, this won’t be solved by T243233 
.
  
  This is now resolved thanks to T358346 
 – `ObjectCache::getInstance( 
$cacheType )` is now equivalent to 
`$services->getObjectCacheFactory()->getInstance( $cacheType )`.

TASK DETAIL
  https://phabricator.wikimedia.org/T281709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Ullasoff, Danny_Benjafield_WMDE, 
S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281709: Make PropertyLabelResolverTest a proper unit test

[Addshore]

Addshore added a project: wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T281709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T281709: Make PropertyLabelResolverTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T281709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T281709: Make PropertyLabelResolverTest a proper unit test

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase Service Migration.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The `WikibaseClient.PropertyLabelResolver` service wiring uses the 
`ObjectCache::getInstance()` function with a variable `$cacheType`. If no such 
instance is set yet, then `ObjectCache` will try to access MediaWiki globals 
and the default service container to create the instance, so that the unit test 
for that service wiring actually can’t run without MediaWiki being set up.
  
  This is similar but not the same thing as T281708 
 and T281706 
, and won’t be solved by T243233 
. Given that 
`ObejctCache::$instances` is public, maybe we can just set a mock cache in the 
test case setup, so that `getInstance()` will return it without trying to 
create an instance?
  
  The alternative would be some kind of `ObjectCacheFactory` service, I guess.

TASK DETAIL
  https://phabricator.wikimedia.org/T281709

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs