[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-15 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Iflorez, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g, 
Suran38, Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, 
Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, 
Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-15 Thread gerritbot 
gerritbot added a comment.


  Change 719083 **abandoned** by Addshore:
  
  [mediawiki/extensions/WikibaseLexeme@REL1_36] Don\u2019t use 
array_merge_recursive() to merge entity types
  
  Reason:
  
  This was only a maybe, and CI says no, so not going to invest time in this
  
  https://gerrit.wikimedia.org/r/719083

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Suran38, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-15 Thread gerritbot 
gerritbot added a comment.


  Change 719084 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@REL1_36] Use wfArrayPlus2d() 
to merge definitions arrays
  
  https://gerrit.wikimedia.org/r/719084

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Suran38, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-06 Thread gerritbot 
gerritbot added a comment.


  Change 719084 had a related patch set uploaded (by Addshore; author: Lucas 
Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@REL1_36] Use wfArrayPlus2d() 
to merge definitions arrays
  
  https://gerrit.wikimedia.org/r/719084

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Suran38, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-06 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Suran38, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-09-06 Thread gerritbot 
gerritbot added a comment.


  Change 719083 had a related patch set uploaded (by Addshore; author: Lucas 
Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexeme@REL1_36] Don\u2019t use 
array_merge_recursive() to merge entity types
  
  https://gerrit.wikimedia.org/r/719083

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Iflorez, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-31 Thread Addshore 
Addshore closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Addshore
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Iflorez, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-25 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Iflorez, alaa_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g, 
Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-25 Thread gerritbot 
gerritbot added a comment.


  Change 705968 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Don\u2019t use 
array_merge_recursive() to merge entity types
  
  https://gerrit.wikimedia.org/r/705968

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-25 Thread gerritbot 
gerritbot added a comment.


  Change 714336 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Use wfArrayPlus2d() to merge 
definitions arrays
  
  https://gerrit.wikimedia.org/r/714336

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-25 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.21; 2021-08-30).

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-25 Thread gerritbot 
gerritbot added a comment.


  Change 714360 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use wfArrayPlus2d() 
to merge definitions arrays
  
  https://gerrit.wikimedia.org/r/714360

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-23 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  I think I’m done, it doesn’t seem to be used in that many extensions after 
all. (I even checked codesearch for `array_merge_recursive(` in case I missed 
any extensions.)

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-23 Thread gerritbot 
gerritbot added a comment.


  Change 714360 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Use wfArrayPlus2d() 
to merge definitions arrays
  
  https://gerrit.wikimedia.org/r/714360

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-23 Thread gerritbot 
gerritbot added a comment.


  Change 714336 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Use wfArrayPlus2d() to merge 
definitions arrays
  
  https://gerrit.wikimedia.org/r/714336

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-23 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-20 Thread toan 
toan removed dang as the assignee of this task.
toan added a subscriber: dang.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: toan
Cc: dang, Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-08-09 Thread dang 
dang claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dang
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-28 Thread Addshore 
Addshore moved this task from Prioritized Tech (prioritised from top to bottom) 
to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
Addshore edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, jijiki, 
Klaas_Z4us_V, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-28 Thread Addshore 
Addshore set the point value for this task to "5".

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-28 Thread Addshore 
Addshore triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-28 Thread Addshore 
Addshore added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-28 Thread Addshore 
Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-22 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I’ve attached the change I uploaded yesterday to this task, but that’s not 
the only place where we use `array_merge_recursive()` for definitions arrays, 
so if we pick this task up, more work still needs to be done. (Though it 
shouldn’t be too bad either.)

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-22 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Biggs657, Invadibot, Lalamarie69, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, jijiki, Klaas_Z4us_V, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, elukey, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-22 Thread gerritbot 
gerritbot added a comment.


  Change 705968 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseLexeme@master] Don\u2019t use 
array_merge_recursive() to merge entity types
  
  https://gerrit.wikimedia.org/r/705968

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287139: Don’t use array_merge_recursive() to merge Wikibase definitions arrays

2021-07-22 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Sustainability (Incident 
Followup), wdwb-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Several Wikibase extensions use `array_merge_recursive()` to combine multiple 
“definitions” arrays (mappings from entity or data type names to various 
definitions – formatter factory callback, RDF builder factory callback, etc.). 
However, this is dangerous – when more than one input array has a non-array 
value for the same (nested) key, `array_merge_recursive()` will merge the 
values into an array:
  
>>> array_merge_recursive( [ 'a' => 1 ], [ 'a' => 2 ] )
=> [ "a" => [ 1, 2 ] ]
  
  But an array is not a valid value for most definitions, and depending the key 
where this happens, it can bring down the whole site (as it did in T287100 
). We don’t really want a fully 
recursive merge of these arrays – just one level deeper than a standard 
`array_merge()` (the arrays for each type should be added non-recursively).

TASK DETAIL
  https://phabricator.wikimedia.org/T287139

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org