[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter closed this task as "Resolved".
Peter added a comment.


  Cool, lets close this for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: ItamarWMDE, larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, 
karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, 
Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[ItamarWMDE]

ItamarWMDE added a comment.


  @Peter Thank you for your response. I agree, that can probably skip the alert 
for now. However, when we resume working on QueryBuilder, we would be in touch 
in order to set up some kind of way to inform us about degraded JS performance.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, ItamarWMDE
Cc: ItamarWMDE, larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, 
karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, 
Aklapper, Ladsgroup, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Thank you. Taking it with me.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Lydia_Pintscher
Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, 
Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  @Lydia_Pintscher I think the main concern from the beginning would be if the 
JavaScript performance got worse over time and we wanted to add an alert for 
that. Today when I look at the metric (we measure CPU long tasks 
https://developer.mozilla.org/en-US/docs/Web/API/Long_Tasks_API) to see 
JavaScript is blocking the main thread. Looking at the data on that page I 
could only see one CPU long tasks that is 53 ms, and that is much better than 
the rest of our performance, so from my point of view I think we can skip it.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, 
Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  Yes I can. Can you help me understand again what type of alert we are talking 
about?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Lydia_Pintscher
Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, 
Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[larissagaulia]

larissagaulia added a comment.


  Hi @Lydia_Pintscher, could you help us identify someone that could receive 
the alerts? Thanks ;)

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, larissagaulia
Cc: larissagaulia, RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, 
Lucas_Werkmeister_WMDE, Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, 
Astuthiodit_1, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  So it turns out I never added the alert. I can add it now, but who should 
receive it?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Krinkle]

Krinkle removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Krinkle
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Astuthiodit_1, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, Vali.matei, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Fernandobacasegua34, 786, Suran38, 
Biggs657, Lalamarie69, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, 
Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, 
Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  I think this is ok as it is now. I can add a simple alert for the size and 
then if it fires we can sit-down and have look together.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  Sure. If you need a call or chat. Feel free to ping me in IRC.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Ladsgroup
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Suran38, Biggs657, 
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  Cool @Ladsgroup, do you have time so I can walk you through the data we 
collect?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  We have it now \o/ 
https://grafana.wikimedia.org/d/00282/webpagerelay-drilldown?orgId=1=sitespeed_io=desktop=webpagereplay=query_wikidata_org=Main_page=chrome=100=median=https:%2F%2Fsynthetic-tests-result-wikimedia.s3.amazonaws.com

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Ladsgroup
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[gerritbot]

gerritbot added a comment.


  Change 712966 **merged** by jenkins-bot:
  
  [performance/synthetic-monitoring-tests@master] Add test for wikidata Query 
Builder
  
  https://gerrit.wikimedia.org/r/712966

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, gerritbot
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  Cool, I just added a comment to the your push @Ladsgroup !

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  I want to start with something simple and slowly migrate to something more 
complex. Specially since basically every interaction's bottleneck is API 
response time (e.g. for lookup for property ID, loading the WDQS results, etc.) 
and not the app itself. Other reason is that the main part of the interaction 
time is just loading the app, the rest are pretty quick.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Ladsgroup
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  @Ladsgroup I'm thinking maybe a user journey is better to measure instead of 
a cold hit? Then we can measure every part of it? Let me explain, I think like 
this:
  
  1. You add user timings that is meaningful to you (like either the full JS 
execution or parts of it if that could help you in the future).
  2. We add user user journey to the synthetic tests: I can do that if you help 
me with a good journey. That could be like going to the start URL, adding a 
property(/value and run the query. That way we will automatically collect the 
user timings but also devtools timeline data for JS where the time is spent. If 
we do that for one URL/user journey that is good because then we have a history 
of data so if you do change later on, we have something that we can compare 
with.
  
  Does that sounds ok @Ladsgroup ?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: RhinosF1, dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, 
Michael, Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  Thanks. I started it, the problem is that the URL is not up so we can't merge 
the patches, I hope I did them correctly at least. Does that look correct to 
you?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, Ladsgroup
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[gerritbot]

gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, gerritbot
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Biggs657, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Jony, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[gerritbot]

gerritbot added a comment.


  Change 712966 had a related patch set uploaded (by Ladsgroup; author: Amir 
Sarabadani):
  
  [performance/synthetic-monitoring-tests@master] Add query builder
  
  https://gerrit.wikimedia.org/r/712966

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, gerritbot
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Peter]

Peter added a comment.


  I'll start with this later this week. One thing you can start with is this:
  
  > We don't have ongoing measurement of javascript performance so it might get 
worse without us noticing.
  
  You can use the User Timing API 
 for that, 
that would be super helpful if that is added before its used by real users. If 
you use the API those metrics are automatically picked up by our synthetic 
measurement tools if we point them to the query builder. If you feel like it 
you can create your own synthetic test, you can checkout searchWvuiObama.js in 
https://github.com/wikimedia/performance-synthetic-monitoring-tests/tree/master/tests/desktop
 how that can be done (I can also help you).
  
  You can also have a look how the team implemented user timings for the Wvui 
search.
  
  You can also beacon those metrics back to your server from real users, that 
is good so we can pickup if there are some users that struggle with the 
performance. Could those tag along with the other metrics you are measuring or 
are those backend only in your graphs?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[dpifke]

dpifke moved this task from Inbox to Doing: Goal-oriented on the 
Performance-Team board.
dpifke assigned this task to Peter.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

WORKBOARD
  https://phabricator.wikimedia.org/project/board/1212/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Peter, dpifke
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  You can ;-)
  As Amir said, we'd like to deploy the tool as soon as possible.

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup added a comment.


  The plan is basically to deploy it really soon. I can't talk on behalf of 
WMDE on the final day but it's basically as soon as possible (specially since 
the security readiness review is done)

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[dpifke]

dpifke added a comment.


  Do you have a timeline when you were hoping to launch this?

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: dpifke
Cc: dpifke, conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup, Invadibot, maantietaja, 
Akuckartz, Nandana, Jony, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
Vali.matei, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T287769: Performance review of Query Builder

[Ladsgroup]

Ladsgroup created this task.
Ladsgroup added projects: Performance-Team, Wikidata Query Builder, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  
  
  Description
  ---
  
  //(Please provide the context of the performance review, and describe how the 
feature or service works at a high level technically and from a user point of 
view, or link to documentation describing that.)//
  
  Query builder is basically a WYSIWYG for Wikidata Query Service 
 and SPARQL querying. It's a frontend-only 
application being served as static files from miscweb 
.
  
  - It is using Vuejs 2 and TypeScript + WMDE's design system (wikit 
). It uses Vite and Rollup for bundling.
  - It lives fully outside of MediaWiki and appservers and will be accessible 
in https://query.wikidata.org/querybuilder
  - It doesn't have a language selector yet (blocked on WMF building of a 
language selector in Vue) but you can access other languages through `uselang` 
parameter. e.g. https://query-builder-test.toolforge.org/?uselang=es
  - More info on user-side of things: 
https://www.wikidata.org/wiki/Wikidata:Query_Builder
  - It is based on ES6 and not being compiled down to ES5 (i.e. we don't 
support IE11).
  
  Preview environment
  ---
  
  //(Insert one or more links to where the feature can be tested, e.g. on Beta 
Cluster.)//
  
  It's in https://query-builder-test.toolforge.org/ If you need ssh access to 
that toolforge tool, let me know but it's just static files.
  
  Which code to review
  
  
  //(Provide links to all proposed changes and/or repositories. It should also 
describe changes which have not yet been merged or deployed but are planned 
prior to deployment. E.g. production Puppet, wmf config, or in-flight features 
expected to complete prior to launch date, etc.).//
  
  - Main code: 
https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query-builder/
  - Deploy repository holding the final static assets: 
https://gerrit.wikimedia.org/r/plugins/gitiles/wikidata/query-builder/deploy
  - Puppet patch deploying it to miscweb: 
https://gerrit.wikimedia.org/r/c/operations/puppet/+/700317/3
  - The CI job that builds the deploy repo patches: 
https://gerrit.wikimedia.org/r/c/integration/config/+/708398
  
  Performance assessment
  --
  
  Please initiate the performance assessment by answering the below:
  
  - What work has been done to ensure the best possible performance of the 
feature?
- We made sure to use lowest possible number of dependencies to avoid 
bloating the final payload and supply chain attacks. Both production and dev 
dependencies. The current package lock file is 14K lines, compared to for 
example MobileFrontend extension with package lock file of 22K lines
- We investigated to find performance issues and fixed those. For example 
https://gerrit.wikimedia.org/r/c/wikidata/query-builder/+/708762 reducing size 
of css by factor of ten.
- The current payload is extremely small considering its functionalities 
and features (date selection, complex relations between conditions, different 
data types, selectors of items, etc.)
- Since it's fully outside of MediaWiki, it can't cause disruptions or 
become a DDoS vector.
- API queries being made on behalf of this app to Wikidata (to search for 
example) are debounced and throttled.
- We built several monitoring tools to make sure it's working properly 
https://grafana.wikimedia.org/d/RA1j2T0Mk/wikidata-query-builder?orgId=1
  - What are likely to be the weak areas (e.g. bottlenecks) of the code in 
terms of performance?
- We don't have ongoing measurement of javascript performance so it might 
get worse without us noticing.
- It depends on wikit (wmde's design system) and if it starts to get 
bloated, query builder will follow but wikit is in our control so we can work 
on it if any issue arises.
  - Are there potential optimisations that haven't been performed yet?
- Not that I know of, we could maybe squeeze a bit more out of its 
dependencies and make sure we compile to ES6 to avoid extra code but that would 
be it.
  - Please list which performance measurements are in place for the feature 
and/or what you've measured ad-hoc so far. If you are unsure what to measure, 
ask the Performance Team for advice: performance-t...@wikimedia.org 
.
  
  Payload:
  F34570499: image.png 
  
  JS flame chart of loading the page (partial):
  F34570503: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T287769

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ladsgroup
Cc: conny-kawohl_WMDE, karapayneWMDE, Lucas_Werkmeister_WMDE, Michael, 
Lydia_Pintscher, Krinkle, Aklapper, Ladsgroup,