[Wikidata-bugs] [Maniphest] T295356: Entity usage for mw.wikibase.entity:getSitelink()

2022-02-06 Thread William_Cheselden 
William_Cheselden added a comment.


  any update on the issue?

TASK DETAIL
  https://phabricator.wikimedia.org/T295356

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: William_Cheselden
Cc: William_Cheselden, iamrunner, Lydia_Pintscher, putnik, 
Lucas_Werkmeister_WMDE, Ghuron, Aklapper, Invadibot, maantietaja, Akuckartz, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295356: Entity usage for mw.wikibase.entity:getSitelink()

2022-01-21 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  Note: This came up in the last office hour again.

TASK DETAIL
  https://phabricator.wikimedia.org/T295356

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, putnik, Lucas_Werkmeister_WMDE, Ghuron, Aklapper, 
Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295356: Entity usage for mw.wikibase.entity:getSitelink()

2021-11-14 Thread Lydia_Pintscher 
Lydia_Pintscher added a project: Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T295356

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: putnik, Lucas_Werkmeister_WMDE, Ghuron, Aklapper, Invadibot, maantietaja, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295356: Entity usage for mw.wikibase.entity:getSitelink()

2021-11-09 Thread Ghuron 
Ghuron added a comment.


  Apparently implementation of //wikibase.getSitelink()// in 
//client/includes/DataAccess/Scribunto/mw.wikibase.lua// is utilizing 
//trackUsageForTitleOrSitelink()// in 
//client/includes/DataAccess/Scribunto/WikibaseLanguageIndependentLuaBindings.php//
  Implementation of //methodtable.getSitelink()// in 
//client/includes/DataAccess/Scribunto/mw.wikibase.entity.lua// is much more 
brutal, it just fires //addSiteLinksUsage// on any access to //sitelinks// table
  
  It looks very strange that 2 implementations of //getSitelink()// functions 
that are supposed to work identically based on 2 completely different pieces of 
code. If they are not going to be merged somehow, I believe the easiest way to 
fix this would be to expose //addTitleOrSitelinksUsage()// for lua and use it 
instead of //php.addSiteLinksUsage// Technically //maskEntityTable()// always 
passes both //entityId// and //key// (//globalSiteId// here) to 
//usageFunc()//, it just addSiteLinksUsage happens to ignore second parameter

TASK DETAIL
  https://phabricator.wikimedia.org/T295356

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Ghuron
Cc: putnik, Lucas_Werkmeister_WMDE, Ghuron, Aklapper, Invadibot, maantietaja, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T295356: Entity usage for mw.wikibase.entity:getSitelink()

2021-11-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T295356

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Ghuron, Aklapper, Invadibot, maantietaja, 
Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org