[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2024-06-10 Thread Jeff_G 
Jeff_G added a comment.


  In edit 
https://commons.wikimedia.org/w/index.php?title=File:Queen_Victoria_by_Bassano.jpg&diff=prev&oldid=804669319
 Cessy3 vandalistically added en caption "welcome". In edit 
https://commons.wikimedia.org/w/index.php?title=File:Queen_Victoria_by_Bassano.jpg&diff=prev&oldid=841293383
 Haansn08 removed that caption, but earned abuse filter log entries 
https://commons.wikimedia.org/wiki/Special:AbuseLog/10343284 and 
https://commons.wikimedia.org/wiki/Special:AbuseLog/10343285 in the process 
because "New page wikitext, after the edit ($1) (new_wikitext)" is completely 
wrong (it is not wikitext at all, but a bastardized text representation of the 
change in wikibase-mediainfo) and triggered Commons Abuse Filter 58. Perhaps we 
can exclude changes where "New content model ($1) (new_content_model)" is 
'wikibase-mediainfo' to remove such false positives?

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jeff_G
Cc: matej_suchanek, Jeff_G, Achim55, Daimona, Bugreporter, Base, Aklapper, 
Danny_Benjafield_WMDE, Uata1122, 1AmNobody24, S8321414, Astuthiodit_1, 
karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, FRomeo_WMF, 
Muchiri124, ItamarWMDE, Nintendofan885, Akuckartz, Dringsim, 94rain, Nandana, 
JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, 
GoranSMilovanovic, ihojose, QZanden, KimKelting, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, Butko, JJMC89, Silverfish, _jensen, rosalieper, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Fuzheado, 
Nirmos, Jane023, Wikidata-bugs, matthiasmullie, aude, Daniel_Mietchen, 
Nullzero, Huji, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, 
Raymond, Billinghurst, Jackmcbarn, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2023-04-17 Thread matej_suchanek 
matej_suchanek merged a task: T334808: Edit filter variable contains wrong data 
for structured data edits on Commons.
matej_suchanek added subscribers: Achim55, Jeff_G.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: Jeff_G, Achim55, Daimona, Bugreporter, Base, Aklapper, Jdx, Astuthiodit_1, 
karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, FRomeo_WMF, 
Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, 94rain, Nandana, 
JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, 
GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, Litanwei, 
Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Fuzheado, Nirmos, Jane023, Wikidata-bugs, 
matthiasmullie, aude, Daniel_Mietchen, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2023-04-21 Thread Jeff_G 
Jeff_G added a comment.


  See also the edits logged at 
https://commons.wikimedia.org/w/index.php?title=Special:AbuseLog&wpSearchUser=91.120.252.226
 .

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jeff_G
Cc: Jeff_G, Achim55, Daimona, Bugreporter, Base, Aklapper, Astuthiodit_1, 
karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, FRomeo_WMF, 
Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, 94rain, Nandana, 
JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, 
GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, Litanwei, 
Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Fuzheado, Nirmos, Jane023, Wikidata-bugs, 
matthiasmullie, aude, Daniel_Mietchen, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2023-05-06 Thread matej_suchanek 
matej_suchanek added a comment.


  For the record, I had already created 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/776286, 
which is still waiting for review.
  I don't think it will solve this problem. Looking at T25 
, or doing something like T304238 
 is still much needed.
  
  In T298672#8799137 , 
@Jeff_G wrote:
  
  > See also the edits logged at 
https://commons.wikimedia.org/w/index.php?title=Special:AbuseLog&wpSearchUser=91.120.252.226
 .
  
  These don't look to me like //changes related to structured data//.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek
Cc: matej_suchanek, Jeff_G, Achim55, Daimona, Bugreporter, Base, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, 
FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, 94rain, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, 
GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, Litanwei, 
Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Fuzheado, Nirmos, Jane023, Wikidata-bugs, 
matthiasmullie, aude, Daniel_Mietchen, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2023-06-10 Thread Jeff_G 
Jeff_G added a comment.


  See also the edits logged at 
https://commons.wikimedia.org/w/index.php?title=Special:AbuseLog&wpSearchUser=2605%3ABA00%3A4138%3A445%3A1974%3ACACD%3AE09D%3AA640&offset=&limit=50
 .

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jeff_G
Cc: matej_suchanek, Jeff_G, Achim55, Daimona, Bugreporter, Base, Aklapper, 
Astuthiodit_1, karapayneWMDE, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, 
FRomeo_WMF, Muchiri124, CBogen, ItamarWMDE, Nintendofan885, Akuckartz, 94rain, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, 
GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, Litanwei, 
Salgo60, JJMC89, Silverfish, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, 
Susannaanas, Ixocactus, Wong128hk, Fuzheado, Nirmos, Jane023, Wikidata-bugs, 
matthiasmullie, aude, Daniel_Mietchen, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-06 Thread Jdx 
Jdx created this task.
Jdx added projects: SDC General, AbuseFilter, Commons.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **List of steps to reproduce** (step by step, including full links if 
applicable):
  
  - On Commons please log out
  - Try to undo a structured data related change, e.g. 
https://commons.wikimedia.org/w/index.php?title=File:United_States_Antarctic_Program_website_from_2018_02_22.png&action=edit&undoafter=586130689&undo=614027851
  
  **What happens?**:
  AbuseFilter blocks the action, three rules are triggered at once: 27, 58 and 
84, e.g. 27 , 58 
 and 84 
. Please look 
closely at variables `old_content_model`, `new_content_model`, `old_wikitext`, 
`new_wikitext` (and optionally `edit_diff`, `added_lines`, `removed_lines`) in 
the mentioned log entries. I have no idea what, but something is definitely 
screwed up. I think it started about a month ago.
  
  **What should have happened instead?**:
  AbuseFilter should allow the action.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdx
Cc: Aklapper, Jdx, GFontenelle_WMF, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, 
Nintendofan885, 94rain, JKSTNK, Lahi, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, Daimona, ihojose, Tramullas, Acer, Litanwei, Salgo60, JJMC89, 
Silverfish, Poyekhali, 4nn1l2, Taiwania_Justo, Susannaanas, Ixocactus, 
Wong128hk, Nirmos, Jane023, Wikidata-bugs, Base, matthiasmullie, Nullzero, 
Huji, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Billinghurst, Jackmcbarn, Steinsplitter
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-06 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, maantietaja, Y.ssk, 
FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 94rain, Nandana, 
JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, SandraF_WMF, 
Daimona, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-06 Thread Bugreporter 
Bugreporter added a comment.


  Issues about specific AbuseFilter should be raised at local wiki unless it is 
related to the extension itself, such as a missing or broken feature.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bugreporter
Cc: Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, maantietaja, 
Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 94rain, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, Daimona, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, 
LawExplorer, Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, 
rosalieper, 4nn1l2, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, 
Wong128hk, Nirmos, Jane023, Wikidata-bugs, matthiasmullie, aude, Nullzero, 
Huji, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Billinghurst, Jackmcbarn, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-06 Thread Jdx 
Jdx added a comment.


  @Bugreporter Just look at the log entries – these three rules/filters have 
been triggered because something is screwed up "below", perhaps AbuseFilter 
extension itself. It's not a problem with the rules, they have been working for 
years.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdx
Cc: Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, maantietaja, 
Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 94rain, 
Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, Daimona, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, 
LawExplorer, Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, 
rosalieper, 4nn1l2, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, 
Wong128hk, Nirmos, Jane023, Wikidata-bugs, matthiasmullie, aude, Nullzero, 
Huji, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, 
Billinghurst, Jackmcbarn, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-11 Thread Daimona 
Daimona added a comment.


  The first thing that comes to mind is that whoever is firing the 
EditFilterMergedContent hook is passing SLOT_MAIN instead of the actual slot 
being edited. I'll try to reproduce this locally and see if that's indeed the 
reason.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-11 Thread Daimona 
Daimona added a subtask: T25: Wikibase runs the EditFilterMergedContent 
hook with an extra parameter.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T298672: "Anonymous" users cannot undo changes related to structured data due to AbuseFilter

2022-01-11 Thread Daimona 
Daimona added a comment.


  Based on my local testing, my guess was right. This was caused by r747596 
 -- notice how 
`$slotRole` is not passed to onEditFilterMergedContent. OTOH, it's really not 
that patch's fault, since the parameter is not officially documented in the 
hook documentation, nor is it present in the EditFilterMergedContentHook 
interface (see T25 ).
  
  At this point, I think that the core hook should be changed to pass this 
parameter. Making it mandatory would be a breaking change and we'd better 
replace the hook with a new one, so perhaps we can just add it as an optional 
(but recommended) parameter for now.

TASK DETAIL
  https://phabricator.wikimedia.org/T298672

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Bugreporter, Base, Aklapper, Jdx, Invadibot, GFontenelle_WMF, 
maantietaja, Y.ssk, FRomeo_WMF, Muchiri124, CBogen, Nintendofan885, Akuckartz, 
94rain, Nandana, JKSTNK, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, Anoop, 
SandraF_WMF, GoranSMilovanovic, ihojose, QZanden, Tramullas, Acer, LawExplorer, 
Litanwei, Salgo60, JJMC89, Silverfish, Poyekhali, _jensen, rosalieper, 4nn1l2, 
Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Nirmos, Jane023, 
Wikidata-bugs, matthiasmullie, aude, Nullzero, Huji, El_Grafo, Dinoguy1000, 
Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Billinghurst, Jackmcbarn, 
Steinsplitter, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org