[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2024-03-07 Thread Michael 
Michael moved this task from Backlog to External/3rd Party on the Wikidata 
Change Dispatching & Watchlists board.
Michael added a project: Wikibase (3rd party installations).

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

WORKBOARD
  https://phabricator.wikimedia.org/project/board/7031/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, ItamarWMDE, CtrlZvi, Aklapper, RickiJay-WMDE, 
Danny_Benjafield_WMDE, Isabelladantes1983, roti_WMDE, Themindcoder, Adamm71, 
Jersione, jdfraine, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2024-03-07 Thread Michael 
Michael edited projects, added Wikidata Change Dispatching & Watchlists, 
Wikibase Suite Team; removed [DEPRECATED] wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, ItamarWMDE, CtrlZvi, Aklapper, RickiJay-WMDE, 
Danny_Benjafield_WMDE, Isabelladantes1983, roti_WMDE, Themindcoder, Adamm71, 
Jersione, jdfraine, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, 
karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, 
Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, 
Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Ullasoff
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-07 Thread CtrlZvi 
CtrlZvi added a comment.


  Sure. I have a personal wiki I'm running (currently MW 1.37.1) with some 
custom extensions. One of these extensions is one I'm developing that will 
automatically geocode an address (stored in a property on an item) and store 
the resulting coordinates (into a different property on the same item). This 
(currently) runs as a deferred update triggered by saving the item with a 
change to the address property. The process is triggered by the 
`onWikibaseChangeNotification` hook which adds the deferred update to do the 
geocoding then returns.
  
  I haven't traced the precise execution of all deferred jobs to determine the 
exact order they execute in, but what ends up happening is that before the 
`onRecentChange_save` hook is invoked, both property edits have been saved, 
generating two different revisions, and two different changes (one for each 
revision) both of which are in the `ChangeHolder`.
  
  And then, the first recent change is processed, for the first revision, and 
the change for the second revision has its metadata overwritten to be the first 
revision. This results in the clients not being notified about the change 
caused by the second revision (which, in my case, causes the linked page's 
WikiDataCoord to not get updated).

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: CtrlZvi
Cc: Michael, Ladsgroup, ItamarWMDE, Addshore, CtrlZvi, Aklapper, 
Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-07 Thread Michael 
Michael added subscribers: Ladsgroup, Michael.
Michael added a comment.


  I'm trying to understand the underlying context. This issue is what was 
discussed in the comments on I1d59cbf 
. 
It was my understanding back then that only ever the changes related to the 
given recent changes entry should be in that changeHolder.
  
  Could you elaborate in what situation you noticed the problem? E.g. what wiki 
and which pages and revisions?
  
  Though @Ladsgroup has probably also a good idea about the potential root 
cause of this.

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Ladsgroup, ItamarWMDE, Addshore, CtrlZvi, Aklapper, 
Fernandobacasegua34, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, 
Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-05 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ItamarWMDE, Addshore, CtrlZvi, Aklapper, Fernandobacasegua34, 786, Suran38, 
Biggs657, karapayneWMDE, Invadibot, Lalamarie69, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
Michael, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-05 Thread gerritbot 
gerritbot added a comment.


  Change 768249 had a related patch set uploaded (by CtrlZvi; author: CtrlZvi):
  
  [mediawiki/extensions/Wikibase@master] Filter changes by RecentChange revision
  
  https://gerrit.wikimedia.org/r/768249

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ItamarWMDE, Addshore, CtrlZvi, Aklapper, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T303099: Changes from all revisions have metadata overridden with data from the first change.

2022-03-05 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T303099

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: ItamarWMDE, Addshore, CtrlZvi, Aklapper, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org