[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the 
Wikidata Dev Team (Sprint-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[guergana.tzatchkova]

guergana.tzatchkova updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, guergana.tzatchkova
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Todo/Backlog to Doing on the 
Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Alright!

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[ItamarWMDE]

ItamarWMDE added a comment.


  Approach 1 as listed by you earlier, parse on show.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Does approach 1 refer to storing the data values in the `mismatches` table, 
or storing the original string and only parsing when showing mismatches?

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[ItamarWMDE]

ItamarWMDE added a comment.


  In T321173#8331786 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > I don’t know, can’t the `ResultsController` see all the mismatches at once? 
That’s how the current item and property ID formatting seems to be done 
(`extractEntityIds()` and `getLabels()`).
  
  True, I forgot I wrote that :facepalm: yeah it might be feasible to do it 
similarly
  
  > That also sounds possible, but it would be a major change from how we broke 
down the task so far. Are you thinking of storing the data values directly in 
the `mismatches` table or somewhere else?
  
  I would say yes, as they pertain to each mismatch individually, although 
another solution could be to persist them per property ID, and save ourselves 
the roundtrip to Wikidata, but the cost might not be worth the gain here (as we 
would have to think of invalidation etc.)
  
  Either/or I think both solutions are equally good, so maybe taking the path 
of least resistance and following approach 1 here is the way forward. What do 
you think?

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.
Restricted Application added a project: User-ItamarWMDE.


  In T321173#8331597 , 
@ItamarWMDE wrote:
  
  > Seems pretty feasible to me as well, though I wonder how you will batch 
these as the mismatch will have to be processed one by one, no?
  
  I don’t know, can’t the `ResultsController` see all the mismatches at once? 
That’s how the current item and property ID formatting seems to be done 
(`extractEntityIds()` and `getLabels()`).
  
  > Otherwise, I think persisting the data value is not such a bad idea. We 
could also try and complete the missing data values in a one time migration 
script to run on existing mismatches.
  
  That also sounds possible, but it would be a major change from how we broke 
down the task so far. Are you thinking of storing the data values directly in 
the `mismatches` table or somewhere else?

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[ItamarWMDE]

ItamarWMDE added a comment.


  In T321173#8329735 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > 
  
  
  
  > 1. Before parsing the value, ask the API for the data type of the property 
of the mismatch. (This should be batched, and cached as well.) Only 
parse+format mismatches for properties with data type “time”.
  
  Seems pretty feasible to me as well, though I wonder how you will batch these 
as the mismatch will have to be processed one by one, no? Otherwise, I think 
persisting the data value is not such a bad idea. We could also try and 
complete the missing data values in a one time migration script to run on 
existing mismatches.

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  The issue with only doing this for date values is that we have no idea what 
the value type is when we load the mismatch, we don’t store that information in 
the database… I can think of a few approaches:
  
  1. Before parsing the value, ask the API for the data type of the property of 
the mismatch. (This should be batched, and cached as well.) Only parse+format 
mismatches for properties with data type “time”.
  2. Parse all values. (We send the property ID as part of the parse request, 
so Wikidata can look up the real data type.) When we have the values, we can 
check which of them have the data type “time”, and format only those.
  3. Parse and format all values.
  
  Version 3 might be a nice feature in general, but it would also require some 
UI changes (we couldn’t make the value itself link to the Wikidata statement in 
that case, that link would have to go somewhere else). Version 1 is probably 
the best approach.
  
  No matter which approach we go for: it should also let us solve T321214 
 at the same time (which is also due 
to Mismatch Finder not knowing what the data type is).

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T321173: Mismatch Finder: Parse and format date values when displaying mismatches

[noarave]

noarave renamed this task from "Parse and format date values when displaying 
mismatches" to "Mismatch Finder: Parse and format date values when displaying 
mismatches".

TASK DETAIL
  https://phabricator.wikimedia.org/T321173

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Lydia_Pintscher, Aklapper, Hjfocs, ItamarWMDE, noarave, 
Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
Mattia_Capozzi_WMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org