[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Peer Review to Our work done on the 
Wikidata Dev Team (Sprint-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova, Lucas_Werkmeister_WMDE
Cc: guergana.tzatchkova, Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-17 Thread guergana.tzatchkova 
guergana.tzatchkova added a comment.


  https://github.com/wmde/wikidata-mismatch-finder/pull/475

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: guergana.tzatchkova, Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-17 Thread guergana.tzatchkova 
guergana.tzatchkova added a comment.


  Plan of action:
  
  - in ValidateCSV, make the `statement_guid` not required and validate that if 
`statetament_guid` is not present then `wikidata_value` should also be empty.
  - display none when there is no `statement_guid` and `wikidata_value`

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: guergana.tzatchkova, Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-17 Thread guergana.tzatchkova 
guergana.tzatchkova claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: guergana.tzatchkova, Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-17 Thread guergana.tzatchkova 
guergana.tzatchkova added a comment.


  As indicated by @Sarai-WMDE
  
  > I originally didn't think that using a different style was necessary, but 
it might support recognition: we should use the color #72777d 
(font-color-disabled). I'd hope this would bring enough differentiation (so my 
assumption is that italics are not needed)

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: guergana.tzatchkova
Cc: guergana.tzatchkova, Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323206: Allow statement guid to be empty (optional) and show it as "None" in the UI

2022-11-16 Thread Michael 
Michael created this task.
Michael added projects: Mismatch Finder, Wikidata, Wikidata Dev Team (Sprint-∞).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  If the mismatch has no data for the wikidata value, then it should show as 
"None" in the UI
  
  - Double check with with UX (@Sarai-WMDE) on whether we want the "None" to be 
in italics or some shade of gray or something, to differentiate it from the 
plain string "None"

TASK DETAIL
  https://phabricator.wikimedia.org/T323206

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Aklapper, Sarai-WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org