[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-28 Thread matmarex 
matmarex removed a project: MediaWiki-extensions-DoubleWiki.
matmarex added a comment.


  @Tacsipacsi You're right. I guess I didn't look too closely when I wrote that 
it looks correct.
  
  I don't particularly want to spend time on DoubleWiki here. As you noted, 
it's not an issue in practice, and unlike MobileFrontend or DiscussionTools, no 
one has heard of it so I think folks aren't likely to use it as a bad example 
to copy-paste. I filed a separate bug for it: T323965 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: Tacsipacsi, ppelberg, matmarex, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, VPuffetMichel, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, 
Analytics.mediafiles, Gaboe420, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Legoktm, Khr2003, 
Apameia
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-28 Thread gerritbot 
gerritbot added a comment.


  Change 858618 **merged** by jenkins-bot:
  
  [mediawiki/extensions/DiscussionTools@master] Use 'BeforePageDisplay' instead 
of 'OutputPageBeforeHTML' for once-per-page things
  
  https://gerrit.wikimedia.org/r/858618

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex, gerritbot
Cc: Tacsipacsi, ppelberg, matmarex, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, VPuffetMichel, Biggs657, karapayneWMDE, 
Invadibot, Khr2003, maantietaja, Juan90264, Alter-paule, Apameia, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, Patriccck, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread Tacsipacsi 
Tacsipacsi added a project: MediaWiki-extensions-DoubleWiki.
Tacsipacsi added a comment.


  In T323376#8405720 , 
@matmarex wrote:
  
  > - mediawiki/extensions/DoubleWiki
  >   - Looks correct
  
  Well, not entirely. I don’t know if there are things that work similarly to 
`talkpageheader` but in even-numbered namespaces, but I could (IMO) break it:
  
  1. Since DoubleWiki works with interlanguage links, I had to get MediaWiki 
display interlanguage links in talk namespaces. I could’ve probably written an 
extension that adds them (or install Wikibase), but the easiest solution was 
simply modifying Parser.php to remove the `$nottalk` check from the code 
recognizing interlanguage links. Isn’t likely to happen in production, but it 
fits for testing. 
  2. Created MediaWiki:talkpageheader, calling a template in which I “forgot” 
to wrap the interlanguage link in ``.
  3. Also added a direct interlanguage link to a talk page.
  4. Opened the talk page with `=hu` added to the URL.
  5. Got QuadrupleWiki instead of DoubleWiki: both the talk page header and the 
main content got their Hungarian equivalents – except that sometimes the main 
content also got the Hungarian equivalent of the talk page header, probably due 
to cache pollution.
  
  Until someone comes up with a such way to reproduce this that at least 
doesn’t involve modifying the parser, it’s pretty low-priority, but it’s still 
a bug.

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex, Tacsipacsi
Cc: Tacsipacsi, ppelberg, matmarex, Aklapper, Adamm71, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, 786, VPuffetMichel, Biggs657, karapayneWMDE, 
Invadibot, Khr2003, maantietaja, Juan90264, Alter-paule, Apameia, Beast1978, 
ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, 
CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, Patriccck, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, GoranSMilovanovic, 
Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread matmarex 
matmarex claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, VPuffetMichel, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, 
Analytics.mediafiles, Gaboe420, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread matmarex 
matmarex added a project: Editing-team (FY2021-22 Kanban Board).

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, VPuffetMichel, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, 
Analytics.mediafiles, Gaboe420, Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, mojoaxel, Bsandipan, GoranSMilovanovic, Jayprakash12345, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858621 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/WikidataPageBanner@master] Remove mention of unused 
OutputPageBeforeHTML hook
  
  https://gerrit.wikimedia.org/r/858621

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858620 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/ShortUrl@master] Use 'BeforePageDisplay' instead of 
'OutputPageBeforeHTML' for once-per-page things
  
  https://gerrit.wikimedia.org/r/858620

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858619 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/MobileFrontend@master] Use 'BeforePageDisplay' instead 
of 'OutputPageBeforeHTML' for once-per-page things
  
  https://gerrit.wikimedia.org/r/858619

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, DannyS712, CucyNoiD, Nandana, Analytics.mediafiles, Gaboe420, 
Patriccck, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, mojoaxel, Bsandipan, 
GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Tacsipacsi, Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread gerritbot 
gerritbot added a comment.


  Change 858618 had a related patch set uploaded (by Bartosz Dziewoński; 
author: Bartosz Dziewoński):
  
  [mediawiki/extensions/DiscussionTools@master] Use 'BeforePageDisplay' instead 
of 'OutputPageBeforeHTML' for once-per-page things
  
  https://gerrit.wikimedia.org/r/858618

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: matmarex, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, DannyS712, Nandana, Analytics.mediafiles, Patriccck, 
Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Tacsipacsi, 
Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread matmarex 
matmarex added a comment.


  For starters, I updated 
https://www.mediawiki.org/wiki/Manual:Hooks/OutputPageBeforeHTML with better 
advice: 
https://www.mediawiki.org/w/index.php?title=Manual:Hooks/OutputPageBeforeHTML=5598387=4561707

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, DannyS712, Nandana, Analytics.mediafiles, Patriccck, 
Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Tacsipacsi, 
Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread Maintenance_bot 
Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: matmarex, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, DannyS712, Nandana, Analytics.mediafiles, Patriccck, 
Lahi, Gq86, mojoaxel, GoranSMilovanovic, Jayprakash12345, QZanden, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Tacsipacsi, 
Lydia_Pintscher, Mbch331, Legoktm
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T323376: Fix uses of OutputPageBeforeHTML hook that assume it is only executed once per page view

2022-11-18 Thread matmarex 
matmarex added projects: DiscussionTools, MobileFrontend, 
MediaWiki-extensions-ShortUrl, Wikidata-Page-Banner.
matmarex added a comment.


  The hook is used by:
  
  - mediawiki/extensions/DiscussionTools
- Looks wrong
  - mediawiki/extensions/DoubleWiki
- Looks correct
  - mediawiki/extensions/MobileFrontend
- Looks wrong
  - mediawiki/extensions/ShortUrl
- Looks wrong (but harmless)
  - mediawiki/extensions/TemplateData
- Looks correct
  - mediawiki/extensions/Wikibase
- Looks correct
  - mediawiki/extensions/WikidataPageBanner
- Only mentioned in a code comment (which looks wrong)

TASK DETAIL
  https://phabricator.wikimedia.org/T323376

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matmarex
Cc: matmarex, Aklapper, DannyS712, Analytics.mediafiles, Patriccck, mojoaxel, 
Jayprakash12345, JJMC89, Wikidata-bugs, Tacsipacsi, Lydia_Pintscher, Legoktm, 
Slack_connector_for_Editing_team_triage
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org