[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-20 Thread Jdforrester-WMF 
Jdforrester-WMF added a comment.


  Would it be possible to expedite this fix, please? It's blocking CI (and the 
MediaWiki support for) PHP 8.2 generally.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-20 Thread Jdforrester-WMF 
Jdforrester-WMF added a parent task: T360560: Make PHP 8.2 voting on 
development branch of Wikibase.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-21 Thread gerritbot 
gerritbot added a comment.


  Change 983300 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Replace 
utf8_decode with mb_convert_encoding
  
  https://gerrit.wikimedia.org/r/983300

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-21 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, 
Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, 
Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-21 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.24; 2024-03-26).

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-21 Thread Jdforrester-WMF 
Jdforrester-WMF added a comment.


  Thank you hugely, @thiemowmde!

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdforrester-WMF
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-03-26 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  **Prio Notes:**
  
  | Impact Area | Affected | Notes  
  |
  | --- |  | 

 |
  | production / end users  | ✘| Not until production moves to PHP 8.2, 
which will take quite some time (the next target after mw-on-k8s is 8.1)  |
  | monitoring  | ✘|
  |
  | development efforts | ✔| `utf8_encode()` and `utf8_decode()` 
are confusing; developers on PHP 8.2 have to disable deprecation warnings|
  | onboarding efforts  | ✘|
  |
  | additional stakeholders | ✔| Strongly affected – blocks PHP 8.2 on 
several extensions, including ones by other teams (e.g. GrowthExperiments) |

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Ullasoff, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-03 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team; removed 
[DEPRECATED] wdwb-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Ullasoff
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-04 Thread gerritbot 
gerritbot added a comment.


  Change #1015992 had a related patch set uploaded (by Thiemo Kreuz (WMDE); 
author: Fomafix):
  
  [mediawiki/extensions/Wikibase@master] Replace deprecated utf8_encode
  
  https://gerrit.wikimedia.org/r/1015992

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-04 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org 
Slice); removed Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > I’m pretty sure this use of the functions is pointless (though “correct” in 
that the methods perform their inverse operations). MediaWiki sets 
`mb_internal_encoding( 'UTF-8' );` early in `Setup.php` (since T137509 
), so there is no reason to assume 
that PHP `serialize()` returns Latin 1 that needs to be UTF-8 encoded before 
being passed into `json_encode()` – we’re just putting JSONified mojibake in 
the inner cache.
  
  It turns out that the class has a test 
(`SimpleCacheTestCase::testBinaryData()`, inherited from an upstream library) 
that asserts that binary data can be stored in the cache and retrieved 
correctly; this breaks if the `utf8_encode()` is removed. However, I see no 
reason for us to support this (we only put text into the cache, not binary 
data), so I think we should just skip the test.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread gerritbot 
gerritbot added a comment.


  Change #1017815 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (1/3)
  
  https://gerrit.wikimedia.org/r/1017815

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread gerritbot 
gerritbot added a comment.


  Change #1017816 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (2/3)
  
  https://gerrit.wikimedia.org/r/1017816

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread gerritbot 
gerritbot added a comment.


  Change #1017817 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (3/3)
  
  https://gerrit.wikimedia.org/r/1017817

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-08 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Peer 
Review on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this 
task.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-10 Thread ArthurTaylor 
ArthurTaylor claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-11 Thread gerritbot 
gerritbot added a comment.


  Change #1018958 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Check cached 
data more thoroughly
  
  https://gerrit.wikimedia.org/r/1018958

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, luca.favorido, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-11 Thread gerritbot 
gerritbot added a comment.


  Change #1019060 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Extract 
methods from unserialize()
  
  https://gerrit.wikimedia.org/r/1019060

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, luca.favorido, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-12 Thread gerritbot 
gerritbot added a comment.


  Change #1017815 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (1/3)
  
  https://gerrit.wikimedia.org/r/1017815

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor, gerritbot
Cc: Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, 
Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, 
Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, KimKelting, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-12 Thread ArthurTaylor 
ArthurTaylor removed ArthurTaylor as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-12 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-12 Thread gerritbot 
gerritbot added a comment.


  Change #1019175 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (1/3)
  
  https://gerrit.wikimedia.org/r/1019175

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-16 Thread gerritbot 
gerritbot added a comment.


  Change #1019175 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (1/3)
  
  https://gerrit.wikimedia.org/r/1019175

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-16 Thread gerritbot 
gerritbot added a comment.


  Change #1017816 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (2/3)
  
  https://gerrit.wikimedia.org/r/1017816

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-16 Thread gerritbot 
gerritbot added a comment.


  Change #1020229 had a related patch set uploaded (by Lucas Werkmeister 
(WMDE); author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (2/3)
  
  https://gerrit.wikimedia.org/r/1020229

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-16 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.2; 
2024-04-23); removed MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-17 Thread gerritbot 
gerritbot added a comment.


  Change #1020229 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@REL1_42] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (2/3)
  
  https://gerrit.wikimedia.org/r/1020229

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, 
Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, 
KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread gerritbot 
gerritbot added a comment.


  Change #1017817 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Remove 
double UTF-8 (3/3)
  
  https://gerrit.wikimedia.org/r/1017817

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread gerritbot 
gerritbot added a comment.


  Change #1018958 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Check cached 
data more thoroughly
  
  https://gerrit.wikimedia.org/r/1018958

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread gerritbot 
gerritbot added a comment.


  Change #1019060 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Extract 
methods from unserialize()
  
  https://gerrit.wikimedia.org/r/1019060

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread gerritbot 
gerritbot added a comment.


  Change #1015992 **abandoned** by Jforrester:
  
  [mediawiki/extensions/Wikibase@master] Replace deprecated utf8_encode
  
  Reason:
  
  Removed in other patches, instead.
  
  https://gerrit.wikimedia.org/r/1015992

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.3; 
2024-04-30); removed MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-23 Thread gerritbot 
gerritbot added a comment.


  Change #1023401 had a related patch set uploaded (by Jforrester; author: 
Jforrester):
  
  [integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code
  
  https://gerrit.wikimedia.org/r/1023401

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T324202#9302370 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Given that this cache is (AFAICT) used among other things for the term 
store / formatter cache, where it has a very high absolute hit rate (over a 
million hits per minute 
)
 and a pretty good relative hit rate (ca. 98% 
),
 I don’t think we can afford to just switch out the cache key without having 
some kind of fallback for the old value, unfortunately.
  
  The relative hit rate looks pretty stable over the past week (when step 2/3, 
emitting the new cache format, started to roll out with the train), so I think 
we can call this rollout a success :)
  
  Minor note: I didn’t realize this before, but the multi-step rollout isn’t 
just important in case of train rollback – the cache is intentionally shared 
between repo and client (see 
`TermFallbackCacheFactory::getTermFallbackCache()`), so (if I understand 
correctly) at any time we can have two different train versions reading and 
writing the cache. So it’s extra important that we split this change across 
several trains ^^

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-26 Thread gerritbot 
gerritbot added a comment.


  Change #1023401 **merged** by jenkins-bot:
  
  [integration/config@master] Zuul: Re-apply PHP 8.2 CI to Wikibase-based code
  
  https://gerrit.wikimedia.org/r/1023401

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-26 Thread Stashbot 
Stashbot added a comment.


  Mentioned in SAL (#wikimedia-releng) [2024-04-26T18:18:26Z]  Zuul: 
Re-apply PHP 8.2 CI to Wikibase-based code for T360560 
 T324202 
 T353161 


TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Stashbot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-26 Thread Jdforrester-WMF 
Jdforrester-WMF closed this task as "Resolved".
Jdforrester-WMF assigned this task to Lucas_Werkmeister_WMDE.
Jdforrester-WMF added a comment.


  Thank you!

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Jdforrester-WMF
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, 
LisafBia6531, Astuthiodit_1, malberts, 786, Biggs657, karapayneWMDE, Invadibot, 
maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Dringsim, 
Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-04-26 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: ArthurTaylor, Jdforrester-WMF, WMDE-leszek, thiemowmde, Paladox, Michael, 
ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
Dringsim, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, 
QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2022-12-01 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: PHP 8.2 support, Wikidata, wdwb-tech.

TASK DESCRIPTION
  `utf8_encode()` and `utf8_decode()` are deprecated in PHP 8.2, because their 
names are quite misleading (RFC 
): they convert 
strings from Latin 1 to UTF-8 and vice versa.
  
  Wikibase uses them in `SimpleCacheWithBagOStuff` (since the original revision 
of that class):
  
private function serialize( $value ) {
$serializedValue = serialize( $value );
$dataToStore = utf8_encode( $serializedValue );

$signature = hash_hmac( 'sha256', $dataToStore, $this->secret );
return json_encode( [ $signature, $dataToStore ] );
}

private function unserialize( $string, $default, array $loggingContext 
) {
$result = json_decode( $string );

// ...
$decodedData = utf8_decode( $data );

if ( $decodedData === serialize( false ) ) {
return false;
}

// phpcs:disable Generic.PHP.NoSilencedErrors.Discouraged
$value = @unserialize(
$decodedData,
[
'allowed_classes' => [ \stdClass::class ]
]
);

// ...
return $value;
}
  
  I’m pretty sure this use of the functions is pointless (though “correct” in 
that the methods perform their inverse operations). MediaWiki sets 
`mb_internal_encoding( 'UTF-8' );` early in `Setup.php` (since T137509 
), so there is no reason to assume 
that PHP `serialize()` returns Latin 1 that needs to be UTF-8 encoded before 
being passed into `json_encode()` – we’re just putting JSONified mojibake in 
the inner cache.
  
  name=shell.php
> $c = new HashBagOStuff()
> ( new Wikibase\Lib\SimpleCacheWithBagOStuff( $c, 'prefix', 'secret' ) 
)->set( 'key', 'äöü' )
> $c->get( $c->makeKey( 'prefix', 'key' ) )
= 
"["9b94f92e4cfdcd3a282fc9398acd9a77f6d74d72fe95930c67e3edc44ece2745","s:6:\"\u00c3\u00a4\u00c3\u00b6\u00c3\u00bc\";"]"
> json_decode( $c->get( $c->makeKey( 'prefix', 'key' ) ) )[1] 
= "s:6:"äöü";"
  
  We should remove both method calls. (But we’ll need to tweak the cache key at 
the same time, to ensure that old mojibake serializations don’t get 
deserialized without the `utf8_decode()`.)

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Umherirrender, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-01-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Umherirrender, Aklapper, Lucas_Werkmeister_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, 
Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-11-02 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Note: the practical impact of this issue is that any Wikibase developer on 
PHP 8.2 will need to disable deprecation warnings on their wiki (I use 
`error_reporting( E_ALL & ~E_DEPRECATED ); // T324202`). In Wikidata team 
prioritization terms, I’d say that this affects developers (but it sounds like 
this task isn’t prioritized for us).
  
  ---
  
  > We should remove both method calls. (But we’ll need to tweak the cache key 
at the same time, to ensure that old mojibake serializations don’t get 
deserialized without the utf8_decode().)
  
  Given that this cache is (AFAICT) used among other things for the term store 
/ formatter cache, where it has a very high absolute hit rate (over a million 
hits per minute 
)
 and a pretty good relative hit rate (ca. 98% 
),
 I don’t think we can afford to just switch out the cache key without having 
some kind of fallback for the old value, unfortunately. But instead of changing 
the cache key, I think we can do something clever in 
`SimpleCacheWithBagOStuff::unserialize()`, between the `json_decode()` and the 
`utf8_decode()` – so that both “old-style” and “new-style” entries are stored 
in the underlying cache using the same key, but we detect whether to call 
`utf8_decode()` based on the JSON structure. (Maybe “new-style” values have an 
extra array element in the JSON after the `$signatureToCheck` and `$data`, or 
whatever.) That way we keep the key the same and only hit the underlying cache 
once rather than twice.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
malberts, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-11-03 Thread ItamarWMDE 
ItamarWMDE added a comment.


  Yeah, I think since this change is a bit more global to Wikibase than just 
affecting Wikidata.org, then #wikibase_product_platform_team_wpp 
 
should probably take a look at this.
  
  So far, since wikidata.org production is on PHP v7.4 and the mw-cli tool is 
still on PHP v8.1 (and this is the tool we onboard new developers to use) this 
probably has less of an effect on developers who are not aware of the 
deprecation or how to set the proper error reporting flags to ignore it. But if 
this sufficiently bugs us as a team, there might be a reason to pick it up, so 
long as the impact is constricted.
  
  However, judging from the comments above, this requires a bit more thinking 
as at least some compatibility layer is needed.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-11-03 Thread ItamarWMDE 
ItamarWMDE added a project: Wikibase Product Platform Team WPP.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-15 Thread thiemowmde 
thiemowmde added a comment.


  > though “correct” in that the methods perform their inverse operations […] 
we’re just putting JSONified mojibake in the inner cache.
  
  The `utf8_decode` documentation says "UTF-8 characters which do not exist in 
ISO-8859-1 (that is, code points above U+00FF) are replaced with `?`". This 
operation is not reversible. I can confirm this from personal experience.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T324202#9410163 , 
@thiemowmde wrote:
  
  >> though “correct” in that the methods perform their inverse operations […] 
we’re just putting JSONified mojibake in the inner cache.
  >
  > The `utf8_decode` documentation says "UTF-8 characters which do not exist 
in ISO-8859-1 (that is, code points above U+00FF) are replaced with `?`". This 
operation is not reversible. I can confirm this from personal experience.
  
  But this `utf8_decode()` call is never going to see “UTF-8 characters which 
do not exist in ISO-8859-1”. It only ever sees results from `utf8_encode()`, 
which treats its input as ISO-8859-1, so the output of `utf8_encode()` only 
contains UTF-8 characters which do exist in ISO-8859-1.
  
> $c = new HashBagOStuff()
> $sc = new Wikibase\Lib\SimpleCacheWithBagOStuff( $c, 'prefix', 'secret' )
> $sc->set( 'key', '🤔' ); // U+1F914
> $sc->get( 'key' )
= "🤔"

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-18 Thread thiemowmde 
thiemowmde added a subscriber: WMDE-leszek.
thiemowmde added a comment.


  Oh, got it. It's the wrong way around.
  
  The weird code was added in patchset 20 in July 2018, apparently by 
@WMDE-leszek: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/441203/19..20/lib/includes/SimpleCacheWithBagOStuff.php.
 The commit message was edited in the same patchset. It mentions 3 sources, but 
I can't find `utf8_…` mentioned on these pages.
  
  I tried to read the discussion, but it's not very helpful. Unfortunately I 
wasn't involved back then. There is also no Phabricator task linked.
  
  What's done in the code directly after the weird `utf8_encode` is a 
`hash_hmac` call. Could it be that this is not able to work with UTF-8 strings, 
but expects something else?
  
  What is `SimpleCacheWithBagOStuff` even used for? What does the extra hashing 
do?
  
  My suggestion is to not touch this class, but mark it as deprecated and 
replace all usages with something reliable from core.
  
  An alternative is to change the serialization format and add a 3rd array 
element with a version number `2`. Cache entries without this number are still 
passed through the old deserialization.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: thiemowmde
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-19 Thread gerritbot 
gerritbot added a comment.


  Change 983300 had a related patch set uploaded (by Ollie Shotton; author: 
Paladox):
  
  [mediawiki/extensions/Wikibase@master] SimpleCacheWithBagOStuff: Replace 
utf8_decode with mb_convert_encoding
  
  https://gerrit.wikimedia.org/r/983300

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, 
karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-19 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-20 Thread WMDE-leszek 
WMDE-leszek added a comment.


  As I was explicitly called out, a few answers, plus an opinion at the end.
  
  > The weird code was added in patchset 20 in July 2018, apparently by 
@WMDE-leszek: 
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/441203/19..20/lib/includes/SimpleCacheWithBagOStuff.php.
 The commit message was edited in the same patchset. It mentions 3 sources, but 
I can't find `utf8_…` mentioned on these pages.
  >
  > I tried to read the discussion, but it's not very helpful. Unfortunately I 
wasn't involved back then. There is also no Phabricator task linked.
  >
  > What's done in the code directly after the weird `utf8_encode` is a 
`hash_hmac` call. Could it be that this is not able to work with UTF-8 strings, 
but expects something else?
  
  Looking at the change history I can recall I pair-programmed parts of this 
change with Aleksey. I didn't remember the exact reason for adding utf8_encode 
and _decode. But thankfully there are tests which help to understand it.
  Test in question is seemingly 
`Wikibase\Lib\Tests\SimpleCacheTestCase::testBinaryData`
  Role of `utf8_encode` is apparently not about dealing with UTF-8 strings, but 
to ensure that `$dataToStore` in `return json_encode( [ $signature, 
$dataToStore ] );` (`Wikibase\Lib\SimpleCacheWithBagOStuff::serialize`) is 
UTF-8 encoded. As per PHP documentation in case it was not, json_encode would 
return false, leading to incorrect value being stored in cache.
  
  It might be, which maybe Lucas implies, that given the current usage of this 
cache class (I recall it was introduced to cache labels and descriptions of 
items, those could be maybe assumed to be always UTF-8-encoded) this situation 
might be impossible in practice. Whether this warrants removal of the encoding 
in the cache class, I am not sure.
  
  > What is `SimpleCacheWithBagOStuff` even used for?
  
  It is a PSR-16-compliant implementation `CacheInterface` implementation 
wrapping Mediawiki's "BagOStuff", as per consquence of Decision to "Use PSR-16 
PHP Cache Interface in Wikibase" 

 (instead of binding to Mediawiki's less univeral interfaces or other 
abstractions)
  Originally, `SimpleCacheWithBagOStuff` was introduced to use cache instead of 
secondary SQL table for efficient fetching of item label and description data 
to be used when displaying "references" to an item 
.
 It could be it has been also adopted for other use cases.
  
  > My suggestion is to not touch this class, but mark it as deprecated and 
replace all usages with something reliable from core.
  
  I note that the latter part of the suggestion goes against the quoted above 
decision to use more common cache abstraction.
  
  Finally, I'd like to address the above remarks of possibly introducing some 
fallback cache key generation algorithm to not change keys while changing the 
logic in the cache class. I'd think it would be sensible to provide some data, 
if it was actually intended to introduce some "smart" logic to keep cache keys 
unchanged. Without understanding the suggested impact it does seem like 
unnecessary complexity to me. I'd naively think if such a detail like changing 
the cache key generation algorithm (I guess equaling temporary dropping of 
cache) can take Wikidata down, we might have bigger problems than what is being 
discussed here. I admit I don't remember details of rollout of the cache 
approach (instead of the secondary SQL table) but I don't recall any 
spectacular outages on the way.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2023-12-21 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T324202#9419893 , 
@WMDE-leszek wrote:
  
  > Finally, I'd like to address the above remarks of possibly introducing some 
fallback cache key generation algorithm to not change keys while changing the 
logic in the cache class. I'd think it would be sensible to provide some data, 
if it was actually intended to introduce some "smart" logic to keep cache keys 
unchanged. Without understanding the suggested impact it does seem like 
unnecessary complexity to me.
  
  I already provided some data in T324202#9302370 
. A cache hit rate between 
98% and 99% means that, if we remove the cache, the database will be hit with 
somewhere between 50× and 100× as many queries of this type as before. I don’t 
know how this query compares to other queries that hit the database (does it 
currently occupy 0.1% of the execution time? 1%? 10%? no idea), but it seems to 
run often enough to occasionally show up in the slow queries log 

 (searching for `wbt_term_in_lang`, a table name that I expect to appear in the 
database query underlying this cache) – the few instances where this query was 
above the threshold to get logged (5 seconds) already sum to 47.4 s in the past 
hour.
  
  > I'd naively think if such a detail like changing the cache key generation 
algorithm (I guess equaling temporary dropping of cache) can take Wikidata 
down, we might have bigger problems than what is being discussed here. I admit 
I don't remember details of rollout of the cache approach (instead of the 
secondary SQL table) but I don't recall any spectacular outages on the way.
  
  I don’t understand this argument. The cache was considered necessary when we 
introduced it (T242871 ), and while 
the site wasn’t down before then, the cache improved performance substantially 
(e.g. median parse time for Wikibase items halved, from ~200 ms to ~100 ms, 
T242871#6625282 ). More 
generally speaking – how can we build a well-performing website when the very 
mechanisms that make it perform well can be criticized purely on the grounds 
that, if those mechanisms were removed, the website would no longer perform 
well?
  
  It’s possible the site won’t go down if we just change the cache key, but I’d 
rather avoid the massive load spike if we can.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase

2024-01-03 Thread WMDE-leszek 
WMDE-leszek added a comment.


  Very bad choice of words in the argumentation, my apologies. What I attempted 
to mean is that I'd encourage to compare both the cost of adding some 
additional logic to some low level code (and for how long? for a day or 
long-term?) as well as the "operational" impact of changing cache keys and its 
duration. (massive load spike and lasting how long) I am not saying it is not 
sensible thing to add, neither meant, of course, to say performance 
optimizations should only be restricted to cases when they would prevent 
complete outage. I attempted to call for more empirical approach to discussing 
benefits and tradeoffs of potential optimization.
  
  All that referring to the situation that the cache keys were actually 
supposed to change due to removal of utf8 encoding/decoding which I am not sure 
is actually wanted and necessary for the task at hand.

TASK DETAIL
  https://phabricator.wikimedia.org/T324202

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
malberts, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, TK-999, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org