[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Arian_Bozorg]

Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg moved this task from Product Verification to Our work done on the 
Wikidata Dev Team (Sprint-∞) board.
Arian_Bozorg added a comment.


  Looks good to me :)
  
  Thanks so much @jhsoby

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jhsoby, Arian_Bozorg
Cc: Arian_Bozorg, Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, 
Aklapper, jhsoby, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Looks better to me now:
  F36935191: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jhsoby, Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Product 
Verification on the Wikidata Dev Team (Sprint-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be deployed with this week’s train.

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jhsoby, Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Sprint-∞).
Lucas_Werkmeister_WMDE set the point value for this task to "1".
Lucas_Werkmeister_WMDE assigned this task to jhsoby.

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jhsoby, Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[ReleaseTaggerBot]

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[gerritbot]

gerritbot added a comment.


  Change 902850 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseLexeme@master] Remove text-transform: 
capitalize;
  
  https://gerrit.wikimedia.org/r/902850

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  Okay, +2ed :) thanks all!

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[gerritbot]

gerritbot added a comment.


  Change 902850 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Jon Harald Søby):
  
  [mediawiki/extensions/WikibaseLexeme@master] Remove text-transform: 
capitalize;
  
  https://gerrit.wikimedia.org/r/902850

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lydia_Pintscher]

Lydia_Pintscher added a comment.


  +1

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Sarai-WMDE]

Sarai-WMDE added a comment.


  That sounds like a reasonable explanation, but we definitely make sure that:
  
  > The capitalization or non-capitalization of strings like this must be left 
up to the translators.
  
  As mentioned in the task description. So, LGTM.

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added subscribers: Sarai-WMDE, Lydia_Pintscher.
Lucas_Werkmeister_WMDE added a comment.


  I tried to figure out where this CSS rule came from, but didn’t find much in 
T165567  or T160053 
; my suspicion is that the design 
screenshots, e.g. in T160053#3344681 
, happened to use 
initial-uppercase labels for the buttons, and that Aleksey added the 
`text-transform: capitalize` to match this, but that it wasn’t really a 
conscious decision at any point.
  
  Maybe @Lydia_Pintscher or @Sarai-WMDE can make a quick decision here? 
(Technically, the patch looks fine and should be ready to +2 at any time.)

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Sarai-WMDE, Lucas_Werkmeister_WMDE, Aklapper, jhsoby, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, 
Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, 
CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T333141: Button to add a new sense should not be capitalized via CSS

[Maintenance_bot]

Maintenance_bot added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T333141

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Lucas_Werkmeister_WMDE, Aklapper, jhsoby, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org