[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-22 Thread Edtadros 
Edtadros updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros
Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, 
Patafisik_WMF, Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-22 Thread Edtadros 
Edtadros removed Edtadros as the assignee of this task.
Edtadros closed this task as "Resolved".
Edtadros added a comment.


  Test Result - Beta
  --
  
  **Status:** ✅ PASS
  **Environment:** frwiki
  **OS:** macOS Ventura
  **Browser:** Chrome, Safari
  **Device:** MBP
  **Emulated Device:**NA
  
  **Test Artifact(s):**
  
  QA Steps
  
  
  ✅ AC1:  Wikidatapagebanner should not be shrunken
  F37029154: Screenshot 2023-05-22 at 9.21.46 AM.png 

  
  F37029155: Screenshot 2023-05-22 at 9.20.22 AM.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros
Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, 
Patafisik_WMF, Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread Jdlrobson 
Jdlrobson reassigned this task from Jdlrobson to Edtadros.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, Jdlrobson
Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, 
Patafisik_WMF, Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread Jdlrobson 
Jdlrobson moved this task from Ready for Signoff to QA in Production on the 
Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Jdlrobson added a comment.


  Great. We should verify this in production later tomorrow: 
https://en.wikivoyage.org/wiki/France

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6488/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, 
Patafisik_WMF, Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread Edtadros 
Edtadros reassigned this task from Edtadros to Jdlrobson.
Edtadros moved this task from QA to Ready for Signoff on the 
Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 3) board.
Edtadros added a comment.


  Test Result - Beta
  --
  
  **Status:** ✅ PASS
  **Environment:** beta
  **OS:** macOS Ventura
  **Browser:** Chrome, Safari
  **Device:** MBP
  **Emulated Device:**NA
  
  **Test Artifact(s):**
  
  QA Steps
  
  
  ✅ AC1:  Wikidatapagebanner should not be shrunken
  F37001639: Screenshot 2023-05-16 at 9.33.10 AM.png 

  
  F37001640: Screenshot 2023-05-16 at 9.33.04 AM.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T336264

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6488/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson, Edtadros
Cc: Edtadros, Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, 
Patafisik_WMF, Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-16 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, ReleaseTaggerBot
Cc: Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, 
Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-15 Thread Jdlrobson 
Jdlrobson added a project: Unplanned-Sprint-Work.
Jdlrobson set the point value for this task to "0".
Jdlrobson added a comment.


  Edward could you take a look at this on the beta cluster? 
https://en.wikivoyage.beta.wmflabs.org/wiki/Bannerda Thanks in advance!

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, Jdlrobson
Cc: Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, 
Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-15 Thread Jdlrobson 
Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2022-23 Q4 
Sprint 3); removed Readers-Web-Backlog (Web Team FY2022-23 Q4 Sprint 4).
Jdlrobson assigned this task to Edtadros.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Edtadros, Jdlrobson
Cc: Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, 
Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Jdlrobson, TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, 
Selby, Winter, Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread gerritbot 
gerritbot added a comment.


  Change 919232 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikidataPageBanner@master] Fix Safari bug with 
responsive image sizing
  
  https://gerrit.wikimedia.org/r/919232

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread gerritbot 
gerritbot added a comment.


  Change 919222 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikidataPageBanner@master] Fix indent overrides made on 
#contentSub
  
  https://gerrit.wikimedia.org/r/919222

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread Jdlrobson 
Jdlrobson added a comment.


  In T336264#8846382 , 
@TheDJ wrote:
  
  > hmm. there is something strange going on with mw-content-subtitle, other 
than it seemingly being an incomplete migration... For instance MW core styles 
it as a class, but it is actually an ID...
  
  Yep looks like I added the wrong selector and forgot to cleanup after myself 
:) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/919241

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread TheDJ 
TheDJ updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread TheDJ 
TheDJ added a comment.


  hmm. there is something strange going on with mw-content-subtitle, other than 
it seemingly being an incomplete migration... For instance MW core styles it as 
a class, but it is actually an ID...

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread Jdlrobson 
Jdlrobson moved this task from Incoming to QA on the Readers-Web-Backlog (Web 
Team FY2022-23 Q4 Sprint 4) board.
Jdlrobson added a comment.


  Fixes can hopefully be verified soonish on 
https://en.wikivoyage.beta.wmflabs.org/wiki/Bannerda

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6509/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Jdlrobson, TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, 
Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, 
Selby, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, 
joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, 
Winter, Lewizho99, Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, 
Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread gerritbot 
gerritbot added a comment.


  Change 919232 had a related patch set uploaded (by TheDJ; author: TheDJ):
  
  [mediawiki/extensions/WikidataPageBanner@master] Fix Safari bug with 
responsive image sizing
  
  https://gerrit.wikimedia.org/r/919232

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, 
Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, Selby, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, 
Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Aklapper, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, 
Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Patafisik_WMF, Selby, 
Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Winter, Lewizho99, 
Maathavan, Iniquity, Agabi10, Neuronton, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread gerritbot 
gerritbot added a comment.


  Change 919222 had a related patch set uploaded (by TheDJ; author: TheDJ):
  
  [mediawiki/extensions/WikidataPageBanner@master] Fix indent overrides made on 
#contentSub
  
  https://gerrit.wikimedia.org/r/919222

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-11 Thread TheDJ 
TheDJ added a comment.


  Part of this seems related to T316830: [M] Gadgets should have a reliable way 
to add content to the subtitle  
I60eb3c7d7f169be2f826d7dc3948de5203e5f303 which deprecated #contentSub and 
#contentSub2 in favor of #mw-content-subtitle. The follow up for that 
transition seems to not have taken place.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-10 Thread TheDJ 
TheDJ added a comment.


  https://en.wikivoyage.org/wiki/User:TheDJ/common.css fixes most issues
  
  1. is because mw-indicators are now inside a parent in vector-2022. This 
probably should just be overridden in each Wikivoyage site that uses page 
banners
  2. this seems mostly because of the zebra wrapping of contentsub, which makes 
the specificity of MediaWiki:Vector.css not enough (Also, that page should be 
copied to 2022).
  3. It seems that the font-size does increase the likelihood of triggering 
this SOOO much that if you restore the font-size, you almost never seem to 
trigger the bug again
  
  I also cleaned up the indenting of the page banner, which seems unnecessary 
and is a side effect of its usage of the subtitle. This should be moved into 
PageBanner extension perhaps, or maybe the page banner should not be using the 
page-subtitle to begin with. We might have cleaner entry points for adding this 
content now ? 

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-10 Thread TheDJ 
TheDJ added a comment.


  2. It seems that voyage actually has a override to font-size: 100%, but due 
to increased specificity of the the vector-2022 styling rule for 84%, it is no 
longer applying
  3. This might not be 'just' the font-size triggering. It seems that multiple 
things that influence the eventual effective size of the element actually do. 
The best way to fix this, seems to be to have the container of the image set 
"height: auto", but not set height: auto on the img itself. That means the 
container height can just adapt to the image height, without the height of the 
image being 'wrong' overriding the logic.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread Jdlrobson 
Jdlrobson moved this task from Incoming to Web Team FY2022-23 Q4 Sprint 4 on 
the Readers-Web-Backlog board.
Jdlrobson edited projects, added Readers-Web-Backlog (Web Team FY2022-23 Q4 
Sprint 4); removed Readers-Web-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

WORKBOARD
  https://phabricator.wikimedia.org/project/board/67/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread Jdlrobson 
Jdlrobson triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread Jdlrobson 
Jdlrobson added a project: Readers-Web-Backlog.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Nishu02, Patafisik_WMF, Selby, Winter, 
Iniquity, Agabi10, Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread TheDJ 
TheDJ updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Patafisik_WMF, Selby, Iniquity, Agabi10, 
Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread TheDJ 
TheDJ updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Patafisik_WMF, Selby, Iniquity, Agabi10, 
Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T336264: WikidataPagebanner shrunk due to Desktop improvements

2023-05-09 Thread TheDJ 
TheDJ created this task.
TheDJ added projects: Desktop Improvements (Vector 2022), Wikidata-Page-Banner.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Original report: 
https://en.wikivoyage.org/wiki/Wikivoyage:Travellers%27_pub#Shrunk_banners
  
  **Steps to replicate the issue** (include links if applicable):
  
  - https://en.wikivoyage.org/wiki/France
  
  **What happens?**:
  
  Bug 1, for all users: There is a lot of space before the banner.
  
  Bug 2, for all users: The items in de ToC are pretty small and hard to read
  
  Bug 3, for Safari users. The banner seems to be only 20% of the required 
height
  
  All of this has to do with modifications that desktop improvements has made.
  
  **Causes**
  
  Bug 1: The `vector-body-before-content` is a display:block and therefore 
pushes the banner down.
  
  Bug 2: The font-size of contentSub  is overridden from 100% to 84%.
  
  Bug 3: The font-size change somehow seems to trigger a subpixel sizing bug in 
Safari. The width of the image is set to 100% and height to auto, yet with the 
font size change, it seems it rounds the image dimensions up to a fraction of a 
pixel. This causes the image to be larger than its container (this should not 
be possible, it's clearly a safari bug). Because the image is bigger than the 
container,  it then triggers portrait detection 
,
 which in turn sets a margin-top, that causes half the picture to become way to 
small vertically.

TASK DETAIL
  https://phabricator.wikimedia.org/T336264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: TheDJ
Cc: TheDJ, Aklapper, JCW555, hnijhuis, Patafisik_WMF, Selby, Iniquity, Agabi10, 
Wikidata-bugs, Lydia_Pintscher
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org