[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-18 Thread Michael
Michael closed this task as "Resolved".
Michael added a comment.


  Content transferred to 
https://wikitech.wikimedia.org/wiki/WMDE/Wikidata/Reports/2023/2023-09-18_Ramifications_of_IP_masking_on_Wikidata_related_extensions
  Further discussion of the results should probably happen in the parent story, 
not in this subtask here.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: ItamarWMDE, Lydia_Pintscher, Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, 
Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-13 Thread ItamarWMDE
ItamarWMDE added a comment.


  For Mismatch Finder, we used Wikitech for any documentation that relates to 
Wikmedia specific infrastructure: 
https://wikitech.wikimedia.org/wiki/Tool:Wikidata_Mismatch_Finder
  
  We also have a Wikdata page there that I have slowly started to restructure 
and add to: https://wikitech.wikimedia.org/wiki/WMDE/Wikidata
  
  So I would prefer for Wikitech to be our team's one-stop shop, if we go for 
onwiki documentation.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, ItamarWMDE
Cc: ItamarWMDE, Lydia_Pintscher, Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, 
Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-13 Thread Michael
Michael added a comment.


  To me, Phabricator feels more searchable and keeping things in their context 
than Google Docs, but a Wiki sounds like not a bad idea. We should be using 
wikis more anyway. Now I'm wondering which wiki would be best? Probably either 
www.wikimedia.org  or wikitech 
. I will ponder it some more and find a 
suitable place.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: ItamarWMDE, Lydia_Pintscher, Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, 
Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-13 Thread ItamarWMDE
ItamarWMDE added a comment.


  While it is good to have all the history here on the ticket, and the results 
in the ticket description, phabricator is not an ideal place for future 
discoverability and I would prefer if you summarized the entire investigation 
in one place that is easily searchable (for example on wiki or in a google 
doc), for posterity.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, ItamarWMDE
Cc: ItamarWMDE, Lydia_Pintscher, Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, 
Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-07 Thread Lydia_Pintscher
Lydia_Pintscher moved this task from Product Verification to Tech Verification 
on the Wikidata Dev Team (Sprint-∞) board.
Lydia_Pintscher added a comment.


  Thank you! Looking good. Moving this to tech verification.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lydia_Pintscher
Cc: Lydia_Pintscher, Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-09-04 Thread Bugreporter
Bugreporter added a comment.


  > the jquery.Ui LinkItem widget is only shown to registered users and not 
Anonymous IPs. However, it _is_ currently shown to temporary users.
  
  See: T140661: enable add links widget for anonymous users 


TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Bugreporter
Cc: Bugreporter, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-28 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  In T343799#9110430 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Regarding Wikibase edits not auto-creating temporary accounts: In MediaWiki 
core, this seems to happen in `EditPage::maybeActivateTempUserCreate()` and 
`EditPage::createTempUser()`; I imagine we’ll need similar code in either 
`MediaWikiEditEntity` or `WikiPageEntityStore`, not sure which.
  
  I’m now leaning towards `WikiPageEntityStore`, so that it also applies to 
`ItemMergeInteractor`.
  
  See also T336187: Create temp user on non-edit actions 
 for some useful guidance.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-22 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Regarding Wikibase edits not auto-creating temporary accounts: In MediaWiki 
core, this seems to happen in `EditPage::maybeActivateTempUserCreate()` and 
`EditPage::createTempUser()`; I imagine we’ll need similar code in either 
`MediaWikiEditEntity` or `WikiPageEntityStore`, not sure which. Also, as seen 
in T343799#9077216 , 
`$wgAutoCreateTempUser` supports different `actions`, with `edit` currently 
being the only known action; I think we should check with the MediaWiki core 
developers whether Wikibase should also use this `edit` action (interpreting it 
as a very generic term) or use one or more different, Wikibase-specific actions 
(“wikibase-edit”? or even one per API module / special page?).

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael added a comment.


  As far as I can see, this should cover all the cases I found in a first pass. 
I think there are about 2 hours left in the timebox for some more in-depth 
investigation, if needed, or for a nicer write-up of the findings, if that is 
desired.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael added a comment.


  Looking at `\User::getId` did not result in any places in Wikibase+ that 
would have different behavior based on logged-in status.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-10 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  (ca. 4.5 hours done so far)

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  TODO NEXT:
  
  - look at the client entry and the UpdateRepoJob.php entry for 
https://codesearch.wmcloud.org/things/?q=-%3EisRegistered%5C%28%5C%29=.*%5C.php==Extension%3AEntitySchema%2CExtension%3AWikibase%2CExtension%3AWikibaseLexeme%2CExtension%3AWikibaseQualityConstraints
  - for completeness sake look at `isNamed` and `isTemp`, both in js and php
  - look at `$user-getId() != 0`
  - look at client from the other side, include what is mentioned in 
T343800#9077730 

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  On the js side of things, there seems to be both `mw.config.get( 
'wgUserIsTemp' )` and `mw.user.isTemp()`.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  Special:MergeLexemes and the non-js fallback of Special:NewLexeme use 
`User:isRegistered()` for showing the anon user warning. The Vue-based 
Special:NewLexme page gets that information for the same purpose via js: 
`mw.user.isAnon()`.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  EntitySchema seems to be the only Extension of ours that uses \User::isAnon():
  
https://codesearch.wmcloud.org/things/?q=-%3EisAnon%5C%28%5C%29=.*%5C.php==Extension%3AEntitySchema%2CExtension%3AWikibase%2CExtension%3AWikibaseLexeme%2CExtension%3AWikibaseQualityConstraints
  It is used to show the anon edit warning.
  
  There are two more ways to edit EntitySchema: `undo` and `restore`. Neither 
of those has the anon edit warning, and both trigger the IP Address to be 
recorded, without an anonymous user being created.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-09 Thread Michael
Michael added a comment.


  NewItem, NewProperty, NewLexeme, NewEntitySchema, all of them do NOT show the 
"anon-user-warning" to temporary users.
  
  The code that used to check for this is currently `\User::isRegistered()` (or 
`\User::isAnon()`, which is just the negated result of the former).
  
  Since 1.39, Mediawiki also has the methods `\User::isNamed()` and 
`\User::isTemp()`, which might be suitable for what we maybe want to do.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael added a comment.


  Neither creating an EntitySchema via Special:NewEntitySchema, nor edits to 
the schema text (`action=edit`) triggered the creation of a temporary user.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael added a comment.


  Creating a new Item did also NOT result in a temporary user being created.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael added a comment.


  First observation:
  
  Using a local config based on a related core change 

 looking as follows:
  
  name=LocalSettings.php
$wgAutoCreateTempUser = [
'enabled' => true,
'actions' => [
0 => 'edit',
],
'genPattern' => '*Unregistered $1*',
'matchPattern' => '*$1',
'serialProvider' => [ 'type' => 'local' ],
'serialMapping' => [ 'type' => 'plain-numeric' ],
];
  
  
  
  1. Editing a Statement on an Item through the UI while not logged-in did 
**NOT** create a new temporary user and instead recorded the IP address.
  2. Editing an ordinary Wikipage however, **did** create a temporary user.
  3. Using that temporary user, it was then possible to make an edit to a 
Statement via the UI that shows in the history with the temporary user instead 
of the IP.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael added a comment.


  One way to approach this is via endpoints. That includes on the repo side:
  
  - Wikibase Action-API endpoints, such as wbeditentity
- question to answer: how much is this generalized? How much is this 
endpoint-specific
  - Special pages, such as Special:NewItem
- what message is shown, should it be shown differently?
  - The JS UI anon editor warning
  - how/where exactly is semi-protection of pages handled?
  - What does this mean for Lexeme?
  - What does this mean for WikibaseQualityConstraints?
  - What does this mean for EntitySchema?
  - ...
  
  Another approach is to look at the code, find what methods/patterns are used 
to distinguish between logged-in and anon users, and then look all the places 
where these are used.
  
  Also relevant, but potentially out of scope:
  
  - How is the new Termbox handling anon users?
  - How is the REST API handling anon users?

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael claimed this task.
Michael moved this task from Todo/Backlog to Doing on the Wikidata Dev Team 
(Sprint-∞) board.
Restricted Application added a project: User-Michael.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6017/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org


[Wikidata-bugs] [Maniphest] T343799: [8 hr] Investigate places where Wikibase distinguishes between anonymous and registered users

2023-08-08 Thread Michael
Michael created this task.
Michael added projects: wmde-wikidata-tech, Wikidata, Wikidata Dev Team 
(Sprint-∞).
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  See parent task for details.

TASK DETAIL
  https://phabricator.wikimedia.org/T343799

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org