[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think it’s just due to the number of forms. E.g. eraso 
 and tentetu 
, two Basque verbs, have fewer 
forms and show constraint violations normally. (eraso is currently affected by 
T344362 , but that’s unrelated.)

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, mrephabricator, Nikki, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[Lydia_Pintscher]

Lydia_Pintscher added a project: Wikidata Dev Team.
Lydia_Pintscher added a comment.


  Is this only happening on Basque Lexemes? That doesn't seem to make sense to 
me based on what Lucas wrote. Or am I missing something? Is the problem just 
that Basque Lexemes tend to be more complete and larger and therefor run into 
the issue?

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, mrephabricator, Nikki, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[Lucas_Werkmeister_WMDE]

Lucas_Werkmeister_WMDE added a comment.


  I think there’s some weird interaction between `$.when` and jQuery deferreds 
going on in `gadget.js`’s `_fullCheckAllIds` / 
`_aggregateMultipleWbcheckconstraintsResponses`. When there’s only one API 
request (≤50 entities on the page), the `arguments` to the aggregate function 
look like:
  
{
"0": { "wbcheckconstraints": {...}, "success": 1 } },
"1": { "readyState": 4, "getResponseHeader": ... },
}
  
  where the first argument is apparently an API response (JSON-decoded) and the 
second argument is some kind of additional response data, which happens to get 
ignored due to how the method is implemented. But when there’s more than one 
API request, it instead looks like:
  
{
"0": [ { "wbcheckconstraints": {...}, "success": 1 } }, { "readyState": 4, 
"getResponseHeader": ... } ],
"1": [ { "wbcheckconstraints": {...}, "success": 1 } }, { "readyState": 4, 
"getResponseHeader": ... } ],
}
  
  where we suddenly have an array of these responseData/responseMeta pairs. But 
the method expects each argument to be one response data, so in this case it 
doesn’t find any constraint violations (neither argument has a 
`wbcheckconstraints` member).
  
  Also, it’s kind of evil that `_fullCheckAllIds()` makes all the constraint 
check requests in parallel in the first place. I think we should rewrite this 
to do the requests sequentially (chain the promises after one another) and then 
check that this also resolves the buggy merging.

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, mrephabricator, Nikki, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, Esc3300, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[mrephabricator]

mrephabricator added a comment.


  It seems like you are exactly write about the 50 entity check limit being 
related to this issue - this lexeme is just shy of 50 entities total with 6 
senses and 38 forms, and still shows constraint violations. 
https://www.wikidata.org/wiki/Lexeme:L1092922
  
  F37668405: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: mrephabricator
Cc: mrephabricator, Nikki, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, Esc3300, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[mrephabricator]

mrephabricator added a comment.


  For what it is worth, I have definitely noticed there is a limit in lexeme 
size of some kind where constraint violations no longer appear. I typically do 
not expect them to appear on Hindustani or Punjabi verbs. On the first sense of 
a lexeme adding a gloss quote usually results in a constraint violation, but if 
I add one now to this lexeme with over 50 senses no constraint violation is 
applied (the lexeme is https://www.wikidata.org/wiki/Lexeme:L33485 but see the 
screenshot since I do not want to actually leave this statement unreferenced.)
  
  F37668396: image.png 
  
  (To be honest, it did not occur to me to report this because if these 
violations did keep coming up it would significantly slow down the load time of 
the page.)

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: mrephabricator
Cc: mrephabricator, Nikki, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, Esc3300, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T345177: Constraint warnings not being shown on many Basque lexemes

[Nikki]

Nikki created this task.
Nikki added projects: Wikidata, Wikibase-Quality-Constraints, Wikidata 
Lexicographical data.

TASK DESCRIPTION
  This query 

 lists lexemes with lexeme-level pronunciation audio 
 statements. These should all 
trigger a constraint violation, because the property has a constraint saying 
that it's only allowed on items and forms.
  
  The warnings are not being shown on the majority of the Basque lexemes, e.g.
  
  - https://www.wikidata.org/wiki/Lexeme:L71868
  - https://www.wikidata.org/wiki/Lexeme:L50898
  - https://www.wikidata.org/wiki/Lexeme:L72576
  
  They are being shown on lexemes in other languages:
  
  - https://www.wikidata.org/wiki/Lexeme:L1694 (has no forms or senses)
  - https://www.wikidata.org/wiki/Lexeme:L1091443 (has forms but no senses)
  - https://www.wikidata.org/wiki/Lexeme:L366675 (has senses but no forms)
  - https://www.wikidata.org/wiki/Lexeme:L1135573 (has forms and senses)
  - https://www.wikidata.org/wiki/Lexeme:L134777 (has identifiers)
  - https://www.wikidata.org/wiki/Lexeme:L1094423 (does not have identifiers)
  
  There's one Basque lexeme where it does work:
  
  - https://www.wikidata.org/wiki/Lexeme:L222139 (has no forms or senses)
  
  The constraint is being triggered even when it's not shown:
  
  - It's shown on Special:ConstraintReport, e.g. 
https://www.wikidata.org/wiki/Special:ConstraintReport/L71868
  - It's included in the wbcheckconstraints response when loading the lexeme
  
  The only common factor I can see is that the lexemes where it doesn't work 
all have a lot of forms. It seems there are multiple wbcheckconstraints 
requests when there are more than 50 entities to check (since it can only do 50 
at a time) - perhaps the second one is overwriting the first?

TASK DETAIL
  https://phabricator.wikimedia.org/T345177

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, Mahir256, QZanden, Esc3300, 
LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org