[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-02 Thread Arian_Bozorg 
Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata 
Dev Team (Wikidata.org Slice) board.
Arian_Bozorg claimed this task.
Arian_Bozorg added a comment.


  Looks good to me, thanks so much :)

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, 
Lucas_Werkmeister_WMDE, Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, 
Astuthiodit_1, AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, 
Izno, freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread Nikki 
Nikki added a comment.


  Yep, now it's invisible again - T277559 


TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Product 
Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be deployed in ca. 30 minutes.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread gerritbot 
gerritbot added a comment.


  Change 970729 **merged** by Lucas Werkmeister (WMDE):
  
  [wikidata/query/gui-deploy@production] Merging from 
38178de4420b7a0fef5887167eb1e0c448e073d5
  
  https://gerrit.wikimedia.org/r/970729

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread gerritbot 
gerritbot added a comment.


  Change 970729 had a related patch set uploaded (by WDQSGuiBuilder; author: 
WDQSGuiBuilder):
  
  [wikidata/query/gui-deploy@production] Merging from 
38178de4420b7a0fef5887167eb1e0c448e073d5
  
  https://gerrit.wikimedia.org/r/970729

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g, Isabelladantes1983, Themindcoder, 
Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, 
Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, 
Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-11-01 Thread gerritbot 
gerritbot added a comment.


  Change 970420 **merged** by jenkins-bot:
  
  [wikidata/query/gui@master] Fix two colors
  
  https://gerrit.wikimedia.org/r/970420

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice).
Lucas_Werkmeister_WMDE added a comment.


  (Pulling into the ~~sprint~~ board since most of the work was done already 
[I’m counting Sarai’s comment as most of the work, me putting the patch 
together based on that didn’t take long])

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T350153#9295915 , 
@Sarai-WMDE wrote:
  
  > I just found that to be correct and that we need to do two changes:
  
  Thanks! Yeah, the old variable name was kind of confusing in retrospect, if I 
understand correctly. Uploaded a change with `-subtle`, which looks good to me 
in local testing.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Isabelladantes1983, 
Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 
AWesterinen, 786, Biggs657, karapayneWMDE, bwang, Invadibot, Mooeena, 
maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, 
Dringsim, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Namenlos314, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, 
Flycatchr, Salgo60, Lewizho99, Zppix, Maathavan, _jensen, rosalieper, 
Neuronton, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread gerritbot 
gerritbot added a comment.


  Change 970420 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [wikidata/query/gui@master] Fix two colors
  
  https://gerrit.wikimedia.org/r/970420

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE attached a referenced file: F41417000: Screen Shot 
2023-10-31 at 15.54.42.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE attached a referenced file: F41417008: Screen Shot 
2023-10-31 at 15.55.23.png.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  As Lucas mentioned, this is an unwanted consequence of the process of 
replacing legacy styling variables. My assumption was that, while the name of 
the variables was similar, their values weren't the same.
  
  I just found that to be correct and that we need to do two changes:
  
  1. In line 469 
,
 the right token to use would be `@background-color-progressive-subtle` 
(instead of @background-color-progressive). This will fix the contrast issue 
that now affects selected cells.
  
  2. The same goes for line 584 
.
 This will return the splitter to its original color.
  
  Human error is very likely and understandable in these comprehensive 
replacement processes. Sorry for the oversight! Wishing we could rely on visual 
regression testing.

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Nikki 
Nikki added a comment.


  Shouldn't the acceptance criteria be that text and links in selected table 
cells have enough contrast?

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Nikki
Cc: Nikki, Michael, AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, 
Aklapper, Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, 
AWesterinen, karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, 
Akuckartz, Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, 
Mahir256, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, 
Salgo60, Zppix, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, 
freephile, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, 
Manybubbles, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Less urgent (doesn’t affect readability, just aesthetics), but might as well 
discuss it here too: I’m pretty sure the “splitter” between the Query Helper 
and the SPARQL code editor didn’t use to be this saturated either.
  F41416994: Screen Shot 2023-10-31 at 15.48.23.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, Aklapper, 
Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, AWesterinen, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, 
Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, Salgo60, Zppix, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread AdrianoRutz 
AdrianoRutz added a comment.


  Eventually a good help: 
https://www.whocanuse.com/?bg=753399&fg=ff&fs=16&fw=

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: AdrianoRutz
Cc: AdrianoRutz, Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, Aklapper, 
Moebeus, DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, AWesterinen, 
karapayneWMDE, bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, 
Dringsim, Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, 
QZanden, EBjune, Orienteerix, merbst, LawExplorer, Flycatchr, Salgo60, Zppix, 
_jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, 
Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  (The color was changed yesterday in styles: Replace WikimediaUI Base with 
Codex Design Tokens 
, and the table 
cell highlight was evidently a part that I didn’t test. I’ll defer to the 
designers to decide what the color should be instead.)

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, AWesterinen, karapayneWMDE, 
bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, Dringsim, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
Orienteerix, merbst, LawExplorer, Flycatchr, Salgo60, Zppix, _jensen, 
rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T350153: Selected table cells in Wikidata Query UI are almost unreadable

2023-10-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata Query UI, 
Accessibility.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Problem:**
  Selected cells in the table result view now have a way too saturated 
background color that makes the contents almost unreadable.
  
  Reported by @Moebeus on Telegram.
  
  **Example:**
  
  - Run a Wikidata query with tabular results, example 

  - Click a table cell to select it
  
  **Screenshots/mockups:**
  Non-hyperlink content has poor color contrast:
  F41416941: Screen Shot 2023-10-31 at 15.34.51.png 

  Hyperlink content is entirely unreadable, it’s the exact same color:
  F41416943: Screen Shot 2023-10-31 at 15.34.53.png 

  (Hovering over it changes it to barely readable:)
  F41416947: Screen Shot 2023-10-31 at 15.35.55.png 

  
  **BDD**
  GIVEN 
  AND 
  WHEN
  AND
  THEN
  AND
  
  **Acceptance criteria:**
  
  - The color is restored to a lighter version.
  
  **Open questions:**

TASK DETAIL
  https://phabricator.wikimedia.org/T350153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Sarai-WMDE, Volker_E, Lucas_Werkmeister_WMDE, Aklapper, Moebeus, 
DTorsani-WMF, Danny_Benjafield_WMDE, Astuthiodit_1, AWesterinen, karapayneWMDE, 
bwang, Invadibot, Mooeena, maantietaja, ItamarWMDE, Akuckartz, Dringsim, 
Nandana, Namenlos314, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, 
Orienteerix, merbst, LawExplorer, Flycatchr, Salgo60, Zppix, _jensen, 
rosalieper, Scott_WUaS, Jonas, Xmlizer, Izno, freephile, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Dinoguy1000, Manybubbles, Lydia_Pintscher, Mbch331, 
Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org