[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-04-02 Thread Arian_Bozorg 
Arian_Bozorg closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Arian_Bozorg
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, 
Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-31 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  All looking good! Thanks for the changes

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-22 Thread noarave 
noarave moved this task from Product Verification to Peer Review on the 
Wikidata Dev Team (Quality Tools "Sprint") board.
noarave added a comment.


  https://github.com/wmde/wikidata-mismatch-finder/pull/839

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-19 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-19 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Thanks for the changes! There's only one low priority fix to make in relation 
to this task. It introduced a bug in the MSMF Store that was already identified 
during code revie: there's a default outline applied via the `.button` class. 
We should include `outline: @outline-base--focus;` in the `&:focus` 
pseudo-class to remove it.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-19 Thread noarave 
noarave added a comment.


  Adding this here as we've noted the issue first on this task. 
  Explanations and a possible workaround for the icon/text misalignment issue 
on codex buttons:
  https://github.com/wmde/wikidata-mismatch-finder/pull/837

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-04 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2024-01-04 Thread Sarai-WMDE 
Sarai-WMDE added a comment.


  Hey Noa! Thanks so much for rising this and confirming the following: there's 
an extra font style needed, UI text M. We should create and apply it to the 
components that don't have internal font modifiers (e.g. Dialog) to prevent 
them from inheriting the body M style and breaking like in your screenshots. 
  I'll add this point to the "Considerations" section in the task description 
and update the Figma specs accordingly. I'll also add a quick view below for 
simplicity. Thanks again!
  
  | Font style | Use case example | Specifications |
  | UI text M  | F41650341: Screenshot 2024-01-04 at 10.21.00.png 
 Text within components such as 
buttons | F41650358: Screenshot 2024-01-04 at 10.34.46.png 
  |

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-12-22 Thread noarave 
noarave added a comment.


  For a reason still unclear to me, the font family token of the body mixin 
(body-M) is breaking text alignment on several places (mostly buttons and links)
  
  example 1 
  F41619408: image.png 
  
  example 2
  F41619410: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-12-15 Thread noarave 
noarave added a comment.


  https://github.com/wmde/wikidata-mismatch-finder/pull/792

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-12-05 Thread noarave 
noarave moved this task from Backlog to Doing on the Wikidata Dev Team (Quality 
Tools "Sprint") board.
noarave claimed this task.
Restricted Application added a project: User-Noarave.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6750/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-12-05 Thread noarave 
noarave set the point value for this task to "3".

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-12-05 Thread noarave 
noarave moved this task from Unified QT Backlog to Quality Tools "Sprint" on 
the Wikidata Dev Team board.
noarave edited projects, added Wikidata Dev Team (Quality Tools "Sprint"); 
removed Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-30 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-30 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-30 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-29 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-29 Thread Sarai-WMDE 
Sarai-WMDE moved this task from UX Backlog to [QT] Tech Backlog on the Wikidata 
Dev Team board.
Sarai-WMDE added a project: wmde-wikidata-tech.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-29 Thread Sarai-WMDE 
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T352304: [WtC-M2] Replace WiKit tokens used in MSMF's Sass files

2023-11-29 Thread Sarai-WMDE 
Sarai-WMDE renamed this task from "[WtC-M2] Replace WiKit tokens used in MSMF 
Sass files" to "[WtC-M2] Replace WiKit tokens used in MSMF's Sass files".
Sarai-WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T352304

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sarai-WMDE
Cc: Aklapper, Sarai-WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org