[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-05-23 Thread kostajh 
kostajh removed a parent task: T359043: Enable temp account creation in 
DevelopmentSettings.php.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, kostajh
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, 
maantietaja, ItamarWMDE, Akuckartz, Dringsim, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen, 
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-05 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-05 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-05 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE closed this task as "Resolved".
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done 
on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  Seems to be working: 
https://github.com/wikimedia/mediawiki-extensions-Wikibase/actions/runs/8155752858

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-05 Thread gerritbot 
gerritbot added a comment.


  Change 1008456 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Test temporary accounts (IP Masking) 
in secondary CI
  
  https://gerrit.wikimedia.org/r/1008456

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-05 Thread gerritbot 
gerritbot added a comment.


  Change 1008455 

 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@master] Fix tests when IP Masking is enabled
  
  https://gerrit.wikimedia.org/r/1008455

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread ArthurTaylor 
ArthurTaylor removed ArthurTaylor as the assignee of this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor
Cc: ArthurTaylor, Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread ArthurTaylor 
ArthurTaylor claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ArthurTaylor
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this 
task.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread gerritbot 
gerritbot added a comment.


  Change 1008455 

 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas 
Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Fix tests when IP Masking is enabled
  
  https://gerrit.wikimedia.org/r/1008455

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread gerritbot 
gerritbot added a comment.


  Change 1008456 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@master] Test temporary accounts (IP Masking) 
in secondary CI
  
  https://gerrit.wikimedia.org/r/1008456

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T353961#9595926 , 
@kostajh wrote:
  
  > Thanks. I added T359043  as a 
parent task, assuming that this task is also about fixing the CI errors when 
AutoCreateTempUser is enabled. The three errors I see (log 
):
  
  Those are the same three I saw, yes.
  
  In T353961#9595936 , 
@Daimona wrote:
  
  > Ideally, I think addDBDataOnce should be treated as a "seeding" method. You 
use it to define the initial state of the database for the test class, **and 
the database is brought back to that state after every test.**
  
  (Emphasis added.) Heh, I was about to write something similar ^^ but 
unfortunately, I assume some tests rely on having outer transaction scope, so 
we probably can’t implement this with a transaction in 
`MediaWikiIntegrationTestCase`. It would probably be possible by copying the 
affected tables around, but that might be prohibitively slow :(

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Daimona 
Daimona added a comment.


  In T353961#9595560 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > Which is a bit of a shame, because @Daimona removed a bunch of inter-table 
dependencies like this when introducing ChangedTablesTracker 
 (it used to be 
something like “if `slot_roles` is cleared then also clear `ip_changes`”, 
yuck), and now we’d be reintroducing something similar again and go behind 
`ChangedTablesTracker`’s back, so to speak :/ but I can’t really think of a 
better solution. Any thoughts?
  
  Yeah, it's not ideal :( Unfortunately, while the `addDBDataOnce` idea was 
noble and it definitely helped a lot making the suites faster, I believe its 
implementation wasn't planned very carefully. For once, the method might have 
been made static. That does mean not being able to access non-static properties 
in it, but it would've allowed us to run it as part of the `beforeClass` hook. 
This was already clear 

 when addDBDataOnce was being introduced, but nobody noticed that making the 
method non-static actually made that harder. Then there's the problem of 
leaving the database in a consistent state. Any "once before class" method 
needs to be paired with an "once after class" counterpart; this wasn't done for 
addDBDataOnce. Everyone just relied on `tablesUsed` to truncate tables 
(assuming you wouldn't forget about it altogether), and the combination of 
addDBDataOnce + tablesUsed was also never considered carefully enough. All in 
all, `$dbDataOnceTables` is itself a hack; one that comes directly from the 
flaws of the previous `addDBDataOnce` implementation.
  
  Sadly, all I had for you is the rant above and not an actual solution :/ 
Ideally, I think addDBDataOnce should be treated as a "seeding" method. You use 
it to define the initial state of the database for the test class, and the 
database is brought back to that state after every test. I'm just not sure how 
to do that, particularly considering the performance requirements. It would be 
a larger change. As long as it's just one test that needs the behaviour to 
change, can we maybe try fixing it in place? I know it's not ideal, but I worry 
that changing the code in MWIntegrationTestCase may introduce more edge cases 
and unwanted effects that people may rely on. What about adding something like 
the following to your addDBDataOnce method?
  
$dbw->insert( 'user_autocreate_serial', /* random row */ );
$dbw->truncateTable( 'user_autocreate_serial' );
  
  This should add the table to `$dbDataOnceTables` and hopefully fix your 
issue. It's ugly, I know... But I'd rather not change this in core unless 
absolutely necessary...

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Daimona
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread kostajh 
kostajh added a comment.


  In T353961#9595656 , 
@Lucas_Werkmeister_WMDE wrote:
  
  >> The tests mostly work in secondary CI, and I think I managed to fix all of 
them
  >
  > Update: With this commit 

 (incorporating the fixes in Wikibase and the above patch to MediaWiki core), 
all the secondary CI runs are indeed green 

 \o/ which would also be useful for T359043 
, I assume.
  
  Thanks. I added T359043  as a 
parent task, assuming that this task is also about fixing the CI errors when 
AutoCreateTempUser is enabled. The three errors I see (log 
):
  
13:15:46 8) 
Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostModifySiteLink
13:15:46 CannotCreateActorException: Cannot create an actor for an IP user 
when temporary accounts are enabled
13:15:46 
13:15:46 /workspace/src/includes/user/ActorStore.php:639
13:15:46 /workspace/src/includes/user/ActorStore.php:416
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:875
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:760
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:626
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:477
13:15:46 /workspace/src/includes/libs/rdbms/database/Database.php:2300
13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:672
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:485
13:15:46 /workspace/src/includes/Storage/PageUpdater.php:1375
13:15:46 /workspace/src/includes/Storage/PageUpdater.php:923
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:416
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:275
13:15:46 
/workspace/src/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:84
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEntityStore.php:53
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/EditEntity/MediaWikiEditEntity.php:610
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php:77
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Specials/SpecialWikibaseRepoPage.php:193
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Specials/SpecialModifyEntity.php:224
13:15:46 
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:120
13:15:46 
/workspace/src/tests/phpunit/includes/specials/SpecialPageExecutor.php:50
13:15:46 
/workspace/src/tests/phpunit/includes/specials/SpecialPageTestBase.php:75
13:15:46 
/workspace/src/extensions/Wikibase/repo/tests/phpunit/includes/Specials/SpecialSetSiteLinkTest.php:266
13:15:46 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:106
Logs generated by test

Show Details
13:15:46 
13:15:46 9) 
Wikibase\Repo\Tests\Specials\SpecialSetSiteLinkTest::testExecutePostRemoveSiteLink
13:15:46 CannotCreateActorException: Cannot create an actor for an IP user 
when temporary accounts are enabled
13:15:46 
13:15:46 /workspace/src/includes/user/ActorStore.php:639
13:15:46 /workspace/src/includes/user/ActorStore.php:416
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:875
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:760
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:626
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:477
13:15:46 /workspace/src/includes/libs/rdbms/database/Database.php:2300
13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:119
13:15:46 /workspace/src/includes/libs/rdbms/database/DBConnRef.php:672
13:15:46 /workspace/src/includes/Revision/RevisionStore.php:485
13:15:46 /workspace/src/includes/Storage/PageUpdater.php:1375
13:15:46 /workspace/src/includes/Storage/PageUpdater.php:923
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:416
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php:275
13:15:46 
/workspace/src/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php:84
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEntityStore.php:53
13:15:46 
/workspace/src/extensions/Wikibase/repo/includes/EditEntity/MediaWikiEditEntity.php:610
13:15:46

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread kostajh 
kostajh added a parent task: T359043: Enable temp account creation in 
DevelopmentSettings.php.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, kostajh
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  > The tests mostly work in secondary CI, and I think I managed to fix all of 
them
  
  Update: With this commit 

 (incorporating the fixes in Wikibase and the above patch to MediaWiki core), 
all the secondary CI runs are indeed green 

 \o/ which would also be useful for T359043 
, I assume.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  In T353961#9595560 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > but I can’t really think of a better solution.
  
  To elaborate a bit: we could probably work around this in Wikibase (the 
easiest would be to move `createItems()` and `addBadgeMatcher()` from 
`addDBDataOnce()` to `setUp()`; we could also try to make `createItems()` use a 
temp user if temp users are enabled, to make sure that the 
`user_autocreate_serial` is also registered as used in `$dbDataOnceTables`, but 
that’d be a bit more annoying to implement), but IMHO that would just leave the 
door open for another test to run into the same problem. I’d prefer to fix it 
in core instead, for all tests with similar patterns.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a subscriber: Daimona.
Lucas_Werkmeister_WMDE added a comment.


  The tests mostly work in secondary CI, and I think I managed to fix all of 
them, but one of the fixes is in core. `SpecialSetSiteLinkTest` has two tests 
that end up creating temporary users, and it also has a `addDBDataOnce()` 
method that makes some test edits, which involves creating (non-temporary) test 
users. This means that the `user` table ends up in `$dbDataOnceTables`, and is 
not cleared between tests, whereas `user_autocreate_serial` is cleared between 
tests; as a result, the second test tries to create a temporary user with the 
same name as the first test, and fails because the user already exists in the 
non-cleared `user` table. Suggested fix:
  
diff --git a/tests/phpunit/MediaWikiIntegrationTestCase.php 
b/tests/phpunit/MediaWikiIntegrationTestCase.php
index 4448f3ebc8..71b15fca92 100644
--- a/tests/phpunit/MediaWikiIntegrationTestCase.php
+++ b/tests/phpunit/MediaWikiIntegrationTestCase.php
@@ -689,6 +689,15 @@ private function maybeSetupDB(): void {
$this->addDBDataOnce();
static::$dbDataOnceTables = 
ChangedTablesTracker::getTables( $this->db->getDomainID() );
ChangedTablesTracker::stopTracking();
+   if (
+   in_array( 'user', static::$dbDataOnceTables, 
true )
+   && !in_array( 'user_autocreate_serial', 
static::$dbDataOnceTables, true )
+   ) {
+   // if the user table will not be cleared 
between tests,
+   // also preserve the temp user counter between 
tests,
+   // otherwise later tests will try to recreate 
temp users that already exist and fail
+   static::$dbDataOnceTables[] = 
'user_autocreate_serial';
+   }
}
 
ChangedTablesTracker::startTracking();
  
  Which is a bit of a shame, because @Daimona removed a bunch of inter-table 
dependencies like this when introducing ChangedTablesTracker 
 (it used to be 
something like “if `slot_roles` is cleared then also clear `ip_changes`”, 
yuck), and now we’d be reintroducing something similar again and go behind 
`ChangedTablesTracker`’s back, so to speak :/ but I can’t really think of a 
better solution. Any thoughts?

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Daimona, kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread kostajh 
kostajh added a comment.


  In T353961#9595415 , 
@Lucas_Werkmeister_WMDE wrote:
  
  > In T353961#9532074 , 
@kostajh wrote:
  >
  >> T355879: Create jobs that run PHPUnit, Selenium, and API testing tests 
with temp account feature flag enabled 
 is also relevant, and would handle 
running CI tests for Wikibase with temp accounts enabled in WMF infrastructure.
  >
  > Yeah, that sounds like a good thing to have for browser and API tests 
(which we currently don’t run in secondary CI, as mentioned in the task 
description). But apart from that, I think it’s still a good idea to test IP 
masking in secondary CI too; we already have five secondary CI jobs, so I think 
we can just change some of them to enable IP masking (rather than add more 
jobs).
  
  Sounds good.
  
  > I’ll try out whether the tests even work or not.
  
  Just as a heads up, I think we are leaning towards enabling temp account 
creation by default in CI rather than having a second set of jobs (T359043: 
Enable temp account creation in DevelopmentSettings.php 
).

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, kostajh
Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-03-04 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE edited projects, added Wikidata Dev Team (Wikidata.org 
Slice); removed Wikidata Dev Team.
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE added a comment.


  In T353961#9532074 , 
@kostajh wrote:
  
  > T355879: Create jobs that run PHPUnit, Selenium, and API testing tests with 
temp account feature flag enabled  
is also relevant, and would handle running CI tests for Wikibase with temp 
accounts enabled in WMF infrastructure.
  
  Yeah, that sounds like a good thing to have for browser and API tests (which 
we currently don’t run in secondary CI, as mentioned in the task description). 
But apart from that, I think it’s still a good idea to test IP masking in 
secondary CI too; we already have five secondary CI jobs, so I think we can 
just change some of them to enable IP masking (rather than add more jobs).
  
  I’ll try out whether the tests even work or not.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-02-11 Thread kostajh 
kostajh added a comment.


  T355879: Create job that runs PHPUnit unit and integration tests with temp 
account feature flag is enabled  is 
also relevant, and would handle running CI tests for Wikibase with temp 
accounts enabled in WMF infrastructure.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: kostajh
Cc: kostajh, Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, 
JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-02-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Incoming to [DOT] By Project on the 
wmde-wikidata-tech board.
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

WORKBOARD
  https://phabricator.wikimedia.org/project/board/5864/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2024-02-09 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  See also T355880: Decide long term strategy for temp account default 
.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, Michael, Danny_Benjafield_WMDE, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2023-12-22 Thread Michael 
Michael added a subtask: T353957: Wikibase secondary CI  is broken and email 
sending is broken again (Dec 2023).

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T353961: Consider creating a Wikibase Secondary CI job with temporary accounts enabled

2023-12-22 Thread Michael 
Michael created this task.
Michael added projects: Temporary accounts, wmde-wikidata-tech, Wikidata.

TASK DESCRIPTION
  Once Wikibase CI is working again (T353957 
), it might make sense to have a job 
there that has temporary accounts enabled.
  
  That might be even more effective if we also could manage to get browser and 
API tests to run there.

TASK DETAIL
  https://phabricator.wikimedia.org/T353961

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org