[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-15 Thread Arian_Bozorg 
Arian_Bozorg created this task.
Arian_Bozorg added projects: Wikidata Dev Team, Temporary accounts, Wikidata.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  **Problem:**
  When a user edits an Item or Property through Wikidata Bridge we need to 
check if we are leaking their IP in case they are not logged in and IP masking 
is enabled on the repo.
  
  If we are leaking the editor's IP and temporary accounts are enabled on the 
repo, we must not leak it and add entry with their temporary account name 
instead to the edit history of the Item
  
  **BDD**
  GIVEN a Wikipedia article
  AND a user who isn't logged in 
  AND Temporary Accounts are enabled
  WHEN editing on Wikidata Bridge
  THEN an entry with their temporary account name is added to the edit history 
of the Item
  
  **Acceptance criteria:**
  
  [ ] IP is not leaked for users editing on Wikidata Bridge and IP masking is 
enabled on the repo

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6016/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-15 Thread Arian_Bozorg 
Arian_Bozorg added a project: Wikidata-Bridge.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Lectrician1, maantietaja, ItamarWMDE, Akuckartz, 
Michael, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-16 Thread karapayneWMDE 
karapayneWMDE edited projects, added Wikidata Integration in Wikimedia 
projects; removed Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: karapayneWMDE
Cc: Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Lectrician1, maantietaja, ItamarWMDE, Akuckartz, 
Michael, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-16 Thread Michael 
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Lectrician1, maantietaja, ItamarWMDE, Akuckartz, 
Michael, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-16 Thread Michael 
Michael added a comment.


  I //think// in this direction there is no issue. If temporary accounts are 
enabled on Wikidata, then that means a new temporary account will be created on 
edit, and that's that. Whether that API-call comes the Wikidata UI, a Wikipedia 
wiki or the command line with curl, doesn't make a difference. (We still may 
wish to do some UX adjustments, but that is not what this task is about.)
  
  If on the Wikipedia-wiki (client wiki) Temporary Accounts are enabled, but 
not yet on Wikidata, and an edit is with the Wikidata bridge, what is the 
desired/acceptable behavior? Though, on the other hand, this would be expected 
to be a temporary state, and we should consider how many resources we want to 
invest into it.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Lectrician1, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-23 Thread Arian_Bozorg 
Arian_Bozorg added a comment.


  Thanks so much Michael, in response to your question
  
  > If on the Wikipedia-wiki (client wiki) Temporary Accounts are enabled, but 
not yet on Wikidata, and an edit is with the Wikidata bridge, what is the 
desired/acceptable behavior?
  
  As the edit will be coming from Wikidata, we will keep the warning on 
Wikidata Bridge. See: T353807#9427709 


TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Michael, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, Lectrician1, maantietaja, ItamarWMDE, Akuckartz, 
Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, 
LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, 
aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-29 Thread Arian_Bozorg 
Arian_Bozorg added a project: Wikidata Dev Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Michael, Aklapper, Arian_Bozorg, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, kostajh, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, 
_jensen, rosalieper, Scott_WUaS, Aschroet, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-31 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I just tried it out and this seems to be covered by the change for T354730 
: 
https://wikidata.beta.wmflabs.org/w/index.php?title=Q11&diff=prev&oldid=136

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, Arian_Bozorg, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355074: Check if client Wikidata Bridge leaks IP on the repo of the edited Item

2024-01-31 Thread Arian_Bozorg 
Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg claimed this task.

TASK DETAIL
  https://phabricator.wikimedia.org/T355074

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, Arian_Bozorg, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, 
QZanden, KimKelting, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, 
Aschroet, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org