[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-02-01 Thread Arian_Bozorg 
Arian_Bozorg closed this task as "Resolved".
Arian_Bozorg moved this task from Product Verification to Done on the Wikidata 
Dev Team (Wikidata.org Slice) board.
Arian_Bozorg claimed this task.
Arian_Bozorg added a comment.


  Looks good to me! Thanks so much :)

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Arian_Bozorg
Cc: Arian_Bozorg, Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, 
Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, 
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, _jensen, 
rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-02-01 Thread Sjoerddebruin 
Sjoerddebruin added a comment.


  Can confirm this is fixed, the loading delay is okayish.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sjoerddebruin
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-25 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Ready for Peer Review to Product 
Verification on the Wikidata Dev Team (Wikidata.org Slice) board.
Lucas_Werkmeister_WMDE added a comment.


  Should be fixed next week.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6751/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-24 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.16; 2024-01-30).

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ReleaseTaggerBot
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-24 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, 
ItamarWMDE, Akuckartz, Eihel, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, Esc3300, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331, Isabelladantes1983, Themindcoder, Adamm71, 
Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, 
Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, 
Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-24 Thread gerritbot 
gerritbot added a comment.


  Change 992467 **merged** by jenkins-bot:
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Make suggestions API 
requests sequentially
  
  https://gerrit.wikimedia.org/r/992467

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Eihel, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Neuronton, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-24 Thread Tacsipacsi 
Tacsipacsi added a comment.


  > (which would also be more in line with the API etiquette 
).
  
  While the etiquette doesn’t state this (nor the contrary), I think we should 
be strict about the request limit only in non-interactive scenarios – yes, many 
concurrent requests put strain on the API, but on the other hand sequential 
requests worsen the user experience.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Tacsipacsi
Cc: Tacsipacsi, Pigsonthewing, Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, 
Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, 
Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, 
Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, 
Akuckartz, Hook696, Eihel, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, KimKelting, Esc3300, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Agabi10, Neuronton, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Probably, yeah. And the reason that non-initial load (e.g. clicking elsewhere 
and then in the input again) doesn’t have the issue is that we cache the API 
responses, so once the network timing is eliminated, the (cached) results are 
put together in the right order again.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread Sjoerddebruin 
Sjoerddebruin added a comment.


  Thank you for investigating, that might explain why 
https://www.wikidata.org/wiki/Property:P39 showed wrongly ordered qualifiers on 
initial load as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Sjoerddebruin
Cc: Sjoerddebruin, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata Dev Team (Wikidata.org Slice).
Lucas_Werkmeister_WMDE added a comment.


  Putting this up for review directly because I confirmed by hypothesis about 
the problem was correct by implementing a fix for what I thought the problem 
was, so I might as well put that up directly.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, 
Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Eihel, Kent7301, 
joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, 
abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread gerritbot 
gerritbot added a comment.


  Change 992467 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
author: Lucas Werkmeister (WMDE)):
  
  [mediawiki/extensions/WikibaseQualityConstraints@master] Make suggestions API 
requests sequentially
  
  https://gerrit.wikimedia.org/r/992467

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
_jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T355697: WikibaseQualityConstraints suggestions feature can show suggestions out-of-order

2024-01-23 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE created this task.
Lucas_Werkmeister_WMDE added projects: Wikidata, Wikibase-Quality-Constraints, 
wmde-wikidata-tech.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  As a Wikidata editor I want to see the suggestions on the sex or gender 
property  in the order in which the 
community defined them, in order to see the most common values first.
  
  **Problem:**
  `P21` currently has more than 50 suggested values in its one-of constraint, 
which means that WikibaseQualityConstraints’ `suggestions` module 
(`modules/suggestions/EntitySelectorHookHandlerFactory.js`) has to make more 
than one API request to get all the labels and descriptions for the values. 
Currently, it makes those requests in parallel, then appends the results to the 
suggestions in whichever order the API requests resolve; since the second 
request has fewer items in it, it often resolves first and those last few items 
are therefore shown at the top of the suggestion list. We should fix this to 
make sure the list is in the right order, either by making sure the 
parallelized results are concatenated order, or by not parallelizing the 
requests at all (which would also be more in line with the API etiquette 
).
  
  **Example/Screenshots/mockups:**
  F41710922: image.png 
  
  **BDD**
  GIVEN I am on an item page
  WHEN I add a new “sex or gender” statement
  THEN the suggestions are in the right order
  
  **Acceptance criteria:**
  
  - WikibaseQualityConstraints doesn’t reorder the results.

TASK DETAIL
  https://phabricator.wikimedia.org/T355697

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Eihel, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, Esc3300, LawExplorer, 
_jensen, rosalieper, Agabi10, Scott_WUaS, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org