[Wikidata-bugs] [Maniphest] T365835: Please remove use of BeforePageDisplayMobile hook

[ItamarWMDE]

ItamarWMDE added a comment.


  **Prio Notes:**
  
  | Impact Area | Affected |
  | --- |  |
  | production / end users  | no   |
  | monitoring  | no   |
  | development efforts | yes  |
  | onboarding efforts  | no   |
  | additional stakeholders | yes  |
  |

TASK DETAIL
  https://phabricator.wikimedia.org/T365835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ItamarWMDE
Cc: ItamarWMDE, Aklapper, Jdlrobson, Danny_Benjafield_WMDE, S8321414, 
Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Dringsim, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T365835: Please remove use of BeforePageDisplayMobile hook

[Jdlrobson]

Jdlrobson triaged this task as "High" priority.
Jdlrobson added a comment.


  This is the last remaining instance in production. I am aiming to hard 
deprecate this by end of June - could this be prioritized with that timeline in 
mind? Thanks in advance!

TASK DETAIL
  https://phabricator.wikimedia.org/T365835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Aklapper, Jdlrobson, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T365835: Please remove use of BeforePageDisplayMobile hook

[Lydia_Pintscher]

Lydia_Pintscher added projects: wmde-wikidata-tech, Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T365835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Aklapper, Jdlrobson, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, 
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Dringsim, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Nastoshka, 
Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T365835: Please remove use of BeforePageDisplayMobile hook

[Jdlrobson]

Jdlrobson created this task.
Jdlrobson added projects: MediaWiki-extensions-WikibaseClient, Technical-Debt.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  The BeforePageDisplayMobile will be deprecated in 1.43 (T350200 
).
  
  A usage was detected in the Wikibase codebase here:
  
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/31782c68e53239618eb59b2f4574fc93d1d6b87e/extension-repo.json#969
  Please update it to use the BeforePageDisplay hook. Thanks in advance!
  
  The preferred way to do this is to use the BeforePageDisplay hook as follows:
  
$isMobileView = ExtensionRegistry::getInstance()->isLoaded( 
'MobileFrontend' ) &&
$services->getService( 'MobileFrontend.Context' 
)->shouldDisplayMobileView();
if ( $isMobileView ) {
  ..
}

TASK DETAIL
  https://phabricator.wikimedia.org/T365835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jdlrobson
Cc: Aklapper, Jdlrobson, ItamarWMDE, Akuckartz, darthmon_wmde, lucamauri, Izno, 
Nastoshka, Wikidata-bugs, Dinoguy1000, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org