[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-04-07 Thread gerritbot 
gerritbot added a comment.


  Change 677343 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@REL1_35] Permit restoring redirects to discard 
entity data
  
  https://gerrit.wikimedia.org/r/677343

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-04-06 Thread gerritbot 
gerritbot added a comment.


  Change 677343 had a related patch set uploaded (by WMDE-leszek; author: Lucas 
Werkmeister (WMDE)):
  
  [mediawiki/extensions/Wikibase@REL1_35] Permit restoring redirects to discard 
entity data
  
  https://gerrit.wikimedia.org/r/677343

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-03-30 Thread gerritbot 
gerritbot added a comment.


  Change 673278 **merged** by jenkins-bot:
  
  [mediawiki/extensions/Wikibase@REL1_35] Handle error when mixing redirects in 
undo
  
  https://gerrit.wikimedia.org/r/673278

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, 
Hook696, Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, 
Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-03-18 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Iflorez, darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, 
Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-03-18 Thread gerritbot 
gerritbot added a comment.


  Change 673278 had a related patch set uploaded (by Tobias Andersson; owner: 
Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@REL1_35] Handle error when mixing redirects in 
undo
  
  https://gerrit.wikimedia.org/r/673278

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, 
lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-02-12 Thread matej_suchanek 
matej_suchanek removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, matej_suchanek
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, 
Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-02-01 Thread Addshore 
Addshore closed this task as "Resolved".
Addshore moved this task from Test (Verification) to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Addshore added a comment.


  Restoring looks good 
https://test.wikidata.org/w/index.php?title=Q214077=537150=537149
  Trying to undo looks good as well 
https://test.wikidata.org/w/index.php?title=Q214077=edit=537147=537149
  F34083028: image.png 

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Addshore
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-18 Thread gerritbot 
gerritbot added a comment.


  Change 656136 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Permit restoring redirects to discard 
entity data
  
  https://gerrit.wikimedia.org/r/656136

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-18 Thread gerritbot 
gerritbot added a comment.


  Change 655726 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Handle error when mixing redirects in 
undo
  
  https://gerrit.wikimedia.org/r/655726

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-14 Thread gerritbot 
gerritbot added a comment.


  Change 656136 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Permit restoring redirects to discard 
entity data
  
  https://gerrit.wikimedia.org/r/656136

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-14 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  No, I don’t think so.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-13 Thread Lydia_Pintscher 
Lydia_Pintscher added a comment.


  I'd lean towards turning it into a redirect again. Or does anything speak 
against that?

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Lydia_Pintscher
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-13 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a subscriber: Lydia_Pintscher.
Lucas_Werkmeister_WMDE added a comment.


  In T97146#6722568 , 
@Jakob_WMDE wrote:
  
  > … when an undo is requested, first check whether the current revision has 
the same redirect status as the revision to be undone …
  
  There is also another situation that currently throws the same 
PatcherException. When undoing an edit that changed a redirect back into an 
ordinary entity, but that edit is also not the latest edit (i.e. there were 
more ordinary edits later), then the current revision has the same redirect 
status as the revision to be undone, but the undo still crashes. In other 
words, when the history looks like this:
  
  - … older revisions
  - revision A: entity is redirect
  - revision B: entity is no longer redirect
  - revision C: regular edit (e.g. add label)
  
  Undoing revisions B and C together works, but undoing revision B alone 
crashes.
  
  @Lydia_Pintscher what should happen in that case? Should we turn the entity 
back into a redirect, ignoring the other edits that were made since then 
(revision C)? Or should we report an edit conflict?

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lydia_Pintscher, Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, 
Krinkle, thiemowmde, gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, 
Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a comment.


  Change 655725 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Migrate EditEntityActionTest test 
cases to yield syntax
  
  https://gerrit.wikimedia.org/r/655725

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a comment.


  Change 655724 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Remove stray / tags from 
EditEntityAction
  
  https://gerrit.wikimedia.org/r/655724

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a comment.


  Change 655726 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Handle error when mixing redirects in 
undo
  
  https://gerrit.wikimedia.org/r/655726

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a comment.


  Change 655725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Migrate EditEntityActionTest test 
cases to yield syntax
  
  https://gerrit.wikimedia.org/r/655725

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread gerritbot 
gerritbot added a comment.


  Change 655724 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Remove stray / tags from 
EditEntityAction
  
  https://gerrit.wikimedia.org/r/655724

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-12 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread Jakob_WMDE 
Jakob_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread Jakob_WMDE 
Jakob_WMDE added a comment.


  From the task inspection:
  On this line 
https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/937beeddb3a8053b91595f7771cbc07322439b48/repo/includes/Actions/EditEntityAction.php#272
 as mentioned in the task description, when an undo is requested, first check 
whether the current revision has the same redirect status as the revision to be 
undone. If not, undo should fail, i.e. show an error via 
`$this->getOutput()->addHTML` and `$this->getOutput()->addWikiMsg` with an 
error message that still needs to be defined.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jakob_WMDE
Cc: Jakob_WMDE, Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, 
gerritbot, hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread WMDE-leszek 
WMDE-leszek edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, Iflorez, 
darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, 
Wikidata-bugs, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread WMDE-leszek 
WMDE-leszek set the point value for this task to "8".

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread WMDE-leszek 
WMDE-leszek updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread noarave 
noarave updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2021-01-05 Thread noarave 
noarave updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2020-12-15 Thread Addshore 
Addshore added a comment.


  Prio Notes:
  
  - Started off voted as 5,5,5,15. 15) Has been around for a while, would only 
cause marginally less logs. 5s) Michael) On the one hand it's less important 
than (a ticket restoring functionality), but still pretty important as its a 
prod error causing log spam. Shouldnt diddle too long. Lucas) Does keep 
happening to different deployers and IMs. 
  - We put it at 5, then slowly moved it up

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, 
hoo, Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T97146: [Bug] Fatal Wikibase PatcherException from EntityContent.php when undoing edits

2020-12-07 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a project: Wikidata-Campsite.
Lucas_Werkmeister_WMDE added a comment.


  This still happens, we just had a spike of 18 of them within two minutes 
around 2020-12-06T23:53Z.

TASK DETAIL
  https://phabricator.wikimedia.org/T97146

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, brennen, Krinkle, thiemowmde, gerritbot, hoo, 
Sjoerddebruin, JanZerebecki, daniel, aude, Aklapper, Akuckartz, darthmon_wmde, 
Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs