[Wikidata-tech] Adding configuration to WikibaseLib
Hey, It has long since been clear it is harmful to add configuration into WikibaseLib. It is a library, not an application, and its users might well want to use it with different config. This means that no additional entries should be added to WikibaseLib.default.php, and that commits that do should not be merged. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 -- ___ Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
Re: [Wikidata-tech] Adding configuration to WikibaseLib
Am 30.01.2014 17:15, schrieb Jeroen De Dauw: > Hey, > > It has long since been clear it is harmful to add configuration into > WikibaseLib. It is a library, not an application, and its users might well > want > to use it with different config. > > This means that no additional entries should be added to > WikibaseLib.default.php, and that commits that do should not be merged. I see your point (library code should not access Settings objects, but use explicit parameters), but this will make it difficult to manage settings shared by repo and client in a single place. Having these in one place makes sure they are consistent, which is especially important when running both repo and client on the same wiki. Do you have a suggestion how to solve this? We have had different saettigns for the same thing in repo and client before, I would like to avoid this in the future. -- daniel -- Daniel Kinzler Senior Software Developer Wikimedia Deutschland Gesellschaft zur Förderung Freien Wissens e.V. ___ Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
Re: [Wikidata-tech] Adding configuration to WikibaseLib
Hey, Having these in one place makes sure they > are consistent, which is especially important when running both repo and > client > on the same wiki. > This highlights a concrete issue with putting it in lib. It makes sure they are consistent, which might work if you have a client and repo running on the same wiki, where the client is connected to the repo. If however the client is connected to another repo, one needs to be able to use different settings. Do you have a suggestion how to solve this? We have had different saettigns > for > the same thing in repo and client before, I would like to avoid this in > the future. > It would indeed be nice to have a convenient way to configure client and repo in the same way for certain settings. I can think of some approaches we could take, though they all seem to much effort to be worthwhile to tackle a nice-to-have. I'd be happy to review any proposal on how we could do that. Tip: you probably should not use Lib at all for this. I trust that in the meanwhile we will not continue to throw architectural principles under the buss for local convenience. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. ~=[,,_,,]:3 -- ___ Wikidata-tech mailing list Wikidata-tech@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
