Re: [Wikidata-tech] Wikibase CI is broken because auf Scribunto issue

2016-02-26 Thread Katie Filbert 
problem now is
http://git.wikimedia.org/commitdiff/integration%2Fjenkins.git/d7bdc8f1a77eec58832bad3684b6c01e6720a639

We have reverted that change for now, so things can get unstuck. The
scribunto tests still need to be fixed so they don't depend on
configuration like this, and then we *do* want to use luasandbox again on
Jenkins.

Cheers,
Katie

On Fri, Feb 26, 2016 at 1:24 PM, Marius Hoch 
wrote:

> I'll look into it once I'm in my train (5 minutes or so).
>
> Cheers,
>
> Marius
> On Feb 26, 2016 13:15, "Daniel Kinzler" 
> wrote:
>
>> Some Jenkins jobs now fail for all changes to Wikibase. E.g.
>>  and
>> . Errors I see:
>>
>> 11:28:52 PHP Strict standards:  Declaration of
>> Capiunto\Test\BasicRowTest::testLua() should be compatible with
>> Scribunto_LuaEngineTestBase::testLua($key, $testName, $expected) in
>>
>> /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Capiunto/tests/phpunit/output/BasicRowTest.php
>> on line 51
>>
>> 11:39:14 1) LuaSandbox:
>>
>> Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
>> 11:39:14 Failed asserting that LuaSandboxFunction Object () is an
>> instance of
>> class "Scribunto_LuaStandaloneInterpreterFunction".
>>
>> I guess some change to Scribunto broke compatibility...
>>
>> --
>> Daniel Kinzler
>> Senior Software Developer
>>
>> Wikimedia Deutschland
>> Gesellschaft zur Förderung Freien Wissens e.V.
>>
>
> ___
> Wikidata-tech mailing list
> Wikidata-tech@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
>
>


-- 
Katie Filbert
Wikidata Developer

Wikimedia Germany e.V. | Tempelhofer Ufer 23-24, 10963 Berlin
Phone (030) 219 158 26-0

http://wikimedia.de

Wikimedia Germany - Society for the Promotion of free knowledge eV Entered
in the register of Amtsgericht Berlin-Charlottenburg under the number 23
855 as recognized as charitable by the Inland Revenue for corporations I
Berlin, tax number 27/681/51985.
___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Re: [Wikidata-tech] Wikibase CI is broken because auf Scribunto issue

2016-02-26 Thread Marius Hoch 
I'll look into it once I'm in my train (5 minutes or so).

Cheers,

Marius
On Feb 26, 2016 13:15, "Daniel Kinzler"  wrote:

> Some Jenkins jobs now fail for all changes to Wikibase. E.g.
>  and
> . Errors I see:
>
> 11:28:52 PHP Strict standards:  Declaration of
> Capiunto\Test\BasicRowTest::testLua() should be compatible with
> Scribunto_LuaEngineTestBase::testLua($key, $testName, $expected) in
>
> /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Capiunto/tests/phpunit/output/BasicRowTest.php
> on line 51
>
> 11:39:14 1) LuaSandbox:
>
> Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
> 11:39:14 Failed asserting that LuaSandboxFunction Object () is an instance
> of
> class "Scribunto_LuaStandaloneInterpreterFunction".
>
> I guess some change to Scribunto broke compatibility...
>
> --
> Daniel Kinzler
> Senior Software Developer
>
> Wikimedia Deutschland
> Gesellschaft zur Förderung Freien Wissens e.V.
>
___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

Re: [Wikidata-tech] Wikibase CI is broken because auf Scribunto issue

2016-02-26 Thread Katie Filbert 
On Fri, Feb 26, 2016 at 1:15 PM, Daniel Kinzler  wrote:

> Some Jenkins jobs now fail for all changes to Wikibase. E.g.
>  and
> . Errors I see:
>
> 11:28:52 PHP Strict standards:  Declaration of
> Capiunto\Test\BasicRowTest::testLua() should be compatible with
> Scribunto_LuaEngineTestBase::testLua($key, $testName, $expected) in
>
> /mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Capiunto/tests/phpunit/output/BasicRowTest.php
> on line 51
>
> 11:39:14 1) LuaSandbox:
>
> Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
> 11:39:14 Failed asserting that LuaSandboxFunction Object () is an instance
> of
> class "Scribunto_LuaStandaloneInterpreterFunction".
>
> I guess some change to Scribunto broke compatibility...
>

now these tests failures are blocking merge of my patches that update data
model version for the quality extensions :(

I will try to take a look, though probably easier and more obvious to
Marius how to fix...

Cheers,
Katie



>
> --
> Daniel Kinzler
> Senior Software Developer
>
> Wikimedia Deutschland
> Gesellschaft zur Förderung Freien Wissens e.V.
>
> ___
> Wikidata-tech mailing list
> Wikidata-tech@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikidata-tech
>



-- 
Katie Filbert
Wikidata Developer

Wikimedia Germany e.V. | Tempelhofer Ufer 23-24, 10963 Berlin
Phone (030) 219 158 26-0

http://wikimedia.de

Wikimedia Germany - Society for the Promotion of free knowledge eV Entered
in the register of Amtsgericht Berlin-Charlottenburg under the number 23
855 as recognized as charitable by the Inland Revenue for corporations I
Berlin, tax number 27/681/51985.
___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech

[Wikidata-tech] Wikibase CI is broken because auf Scribunto issue

2016-02-26 Thread Daniel Kinzler 
Some Jenkins jobs now fail for all changes to Wikibase. E.g.
 and
. Errors I see:

11:28:52 PHP Strict standards:  Declaration of
Capiunto\Test\BasicRowTest::testLua() should be compatible with
Scribunto_LuaEngineTestBase::testLua($key, $testName, $expected) in
/mnt/jenkins-workspace/workspace/mwext-testextension-php55-composer/src/extensions/Capiunto/tests/phpunit/output/BasicRowTest.php
on line 51

11:39:14 1) LuaSandbox:
Wikibase\Client\Tests\DataAccess\Scribunto\Scribunto_LuaWikibaseEntityLibraryTest::testRegister
11:39:14 Failed asserting that LuaSandboxFunction Object () is an instance of
class "Scribunto_LuaStandaloneInterpreterFunction".

I guess some change to Scribunto broke compatibility...

-- 
Daniel Kinzler
Senior Software Developer

Wikimedia Deutschland
Gesellschaft zur Förderung Freien Wissens e.V.

___
Wikidata-tech mailing list
Wikidata-tech@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-tech