[MediaWiki-CodeReview] [MediaWiki r87176]: New comment added
User MaxSem posted a comment on MediaWiki.r87176. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87176#c16453 Commit summary: Add --include-files option to dumpBackup.php to include the uploaded files in the XML stream. Uses new backend features from r85911. Comment: RELEASE-NOTES? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87178]: Revision status changed
User Catrope changed the status of MediaWiki.r87178. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87178#c0 Commit summary: Followup r85884 Fixup the APIs strange way of doing table aliases on a join Only used in very few places ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87179]: Revision status changed
User Catrope changed the status of MediaWiki.r87179. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87179#c0 Commit summary: $db is already defined, don't use $this-getDB() again ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87180]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r87180. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r87180. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87180#c16454 Commit summary: * (bug 28225) Allow hiding of user groups in list=allusers Yay, a LEFT OUTER JOIN Comment: pre + $exclude = array( 'ug1.ug_group = ' . $db-addQuotes( $params['excludegroup'][0] ) ); /pre Can't you use code'ug1.ug_group' = $params['excludegroup'][0]/code here? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87181]: Revision status changed
User Catrope changed the status of MediaWiki.r87181. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87181#c0 Commit summary: Feedbacks isn't English ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87180]: New comment added
User Reedy posted a comment on MediaWiki.r87180. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87180#c16456 Commit summary: * (bug 28225) Allow hiding of user groups in list=allusers Yay, a LEFT OUTER JOIN Comment: Yup, was an artifact from when I was poking at it using != etc. Will clean it up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r72707]: New comment added
User Werdna posted a comment on MediaWiki.r72707. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/72707#c16457 Commit summary: More or less rewrote Special:NewMessages. Only user-visible change is that it is now paged. Comment: Unfortunately, it needs a schema change on LiquidThreads' biggest table, ttuser_message_state/tt. I'm probably not willing to apply the schema change myself, I should have snuck it in with the 1.17 schema changes but I forgot about it (it's not an obvious schema change). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86273]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r86273. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r86273. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86273#c16458 Commit summary: Follow-up r85929: update MediaWiki::articleFromTitle() calls in extensions (and a few edgecases which were missed in core) Comment: I'm guessing it's r85929 at fault really... pre -rakkaus/#mediawiki-i18n- (8 lines skipped) [01-May-2011 12:21:13] PHP Strict Standards: Only variables should be passed by reference in /www/w/includes/api/ApiPurge.php on line 71 -rakkaus/#mediawiki-i18n- (55 lines skipped) [01-May-2011 12:21:43] PHP Strict Standards: Only variables should be passed by reference in /www/w/includes/api/ApiPurge.php on line 71 -rakkaus/#mediawiki-i18n- (72 lines skipped) [01-May-2011 12:22:11] PHP Strict Standards: Only variables should be passed by reference in /www/w/includes/api/ApiPurge.php on line 71 -rakkaus/#mediawiki-i18n- (19 lines skipped) [01-May-2011 12:22:42] PHP Strict Standards: Only variables should be passed by reference in /www/w/includes/api/ApiPurge.php on line 71 -rakkaus/#mediawiki-i18n- (10 lines skipped) [01-May-2011 12:22:50] PHP Strict Standards: Only variables should be passed by reference in /www/w/includes/api/ApiPurge.php on line 71 /pre pre !DOCTYPE HTML PUBLIC \-//W3C//DTD HTML 4.01 Transitional//EN\\nhtml\nhead\n\ttitleMediaWiki API/title\n/head\nbody\npre\nspan style=\color:blue;\?xml version=\1.0\?/span\nspan style=\color:blue;\api servedby=\v22011026445052.yourvserver.net\/span\n span style=\color:blue;\error code=\internal_api_error_MWException\ info=\Exception Caught: Invalid marker: UNIQ23b0557e38403615-languages--QINU\ xml:space=\preserve\ //span\nspan style=\color:blue;\/api/span\n/pre\n/body\n/html\n!-- Served in 0.487 secs. -- /pre While to purge http://translatewiki.net/w/i.php?title=Project:About/fi and some others Seems some pages are fine, some aren't. Not really sure on the correlation between them ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86961]: New comment added
User Krinkle posted a comment on MediaWiki.r86961. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86961#c16460 Commit summary: cross-browser fun Comment: Where did you test ? What did you test ? In the development version of MediaWiki (eg. what we're working on in SVN) $ and $j are exactly the same, if they're then not something is wrong in your script. However the version currently live on Wikimedia (before 1.17) didn't have $, so it's very likely it didn't work there, however without testing on the SVN version you should't be making modifications based on what is live on Wikimedia (one day this won't be an issue, but right now it is) Can you test again (if not already) on a clean install of svn-trunk-phase3 (ie. a simple local LAMP/XAMP webserver) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86961]: Revision status changed
User Krinkle changed the status of MediaWiki.r86961. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86961#c0 Commit summary: cross-browser fun ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87189]: Revision status changed
User Reedy changed the status of MediaWiki.r87189. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87189#c0 Commit summary: Added blog per request on meta ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87188]: Revision status changed
User Reedy changed the status of MediaWiki.r87188. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87188#c0 Commit summary: Removed incorrect svn:executable propery ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87187]: Revision status changed
User Reedy changed the status of MediaWiki.r87187. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87187#c0 Commit summary: svn:eol-style native (and svn:mime-type where needed) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r42585]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r42585. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/42585#c0 Commit summary: added new hook, UserRights::showEditUserGroupsForm from Wikia codebase ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r36161]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r36161. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/36161#c0 Commit summary: Two new hooks to EditPage.php, EditPage::AfterEdit:Form and EditPage:BeforeDisplayingTextbox ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r36804]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r36804. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/36804#c0 Commit summary: Two new hooks and one new global function from Wikia codebase ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r38040]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r38040. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/38040#c0 Commit summary: new hook, ConfirmEmailComplete ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r38068]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r38068. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/38068#c0 Commit summary: SpecialMovepageBeforeMove hook from Wikia codebase - allows extensions, such as spamRegex, to interfere with page moving ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87190]: New comment added
User Krinkle posted a comment on MediaWiki.r87190. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87190#c16461 Commit summary: LiquidThreads backend rewrite: Progress commit on LiquidThreadsFormatter, its friend LiquidThreadsFormatterContext and their subclasses. A LiquidThreadsFormatter takes a LiquidThreadsObject and turns it into HTML for display. Its main entry point, getHTML(), takes a LiquidThreadsFormatterContext, which contains contextual information such as language, user, nesting level and what not. There is currently no formatter for the LiquidThreadsTopic object. Also includes a few data model changes (notably, added a field for the timestamp attributed to a post in the signature) Comment: pre -- Signature + lpv_signature TINYBLOB NOT NULL, + + -- Attributed date/time + lpv_post_time varbinary(14) not null, + lpv_signature TINYBLOB NOT NULL ) /*$wgDBTableOptions*/; /pre There's two lpv_signature columns now ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86927]: New comment added
User MaxSem posted a comment on MediaWiki.r86927.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86927#c16463
Commit summary:
adding language support to #time parser function, per bug 28655
Comment:
Try saving a page with ttnowiki{{#time:j F| +1
days}}/nowiki/tt. You'll get the following meltdown:
pre
Notice: Undefined offset: 89 in D:\Projects\MediaWiki\languages\Language.php on
line 608
Internal error
Non-string key given
Backtrace:
#0 D:\Projects\MediaWiki\includes\GlobalFunctions.php(694):
MessageCache-get(NULL, true, Object(Language))
#1 D:\Projects\MediaWiki\includes\GlobalFunctions.php(818): wfMsgGetKey(NULL,
true, Object(Language), false)
#2 D:\Projects\MediaWiki\languages\Language.php(596): wfMsgExt(NULL, Array)
#3 D:\Projects\MediaWiki\languages\Language.php(608):
Language-getMessageFromDB(NULL)
#4 D:\Projects\MediaWiki\languages\Language.php(898):
Language-getMonthName('90')
#5
D:\Projects\MediaWiki\extensions\ParserFunctions\ParserFunctions_body.php(513):
Language-sprintfDate('j F', '273790901804271...')
#6 [internal function]: ExtParserFunctions::time(Object(Parser), 'j F',
'+1 ...')
#7 D:\Projects\MediaWiki\includes\parser\Parser.php(3192):
call_user_func_array('ExtParserFuncti...', Array)
#8 D:\Projects\MediaWiki\includes\parser\Preprocessor_DOM.php(986):
Parser-braceSubstitution(Array, Object(PPFrame_DOM))
#9 D:\Projects\MediaWiki\includes\parser\Parser.php(2991):
PPFrame_DOM-expand(Object(PPNode_DOM), 0)
#10 D:\Projects\MediaWiki\includes\parser\Parser.php(1153):
Parser-replaceVariables('big'''MediaWi...')
#11 D:\Projects\MediaWiki\includes\parser\Parser.php(315):
Parser-internalParse('big'''MediaWi...')
#12 D:\Projects\MediaWiki\includes\Article.php(4272):
Parser-parse('big'''MediaWi...', Object(Title), Object(ParserOptions), true,
true, 5567)
#13 D:\Projects\MediaWiki\includes\Article.php(4249):
Article-getOutputFromWikitext('big'''MediaWi...', true,
Object(ParserOptions))
#14 D:\Projects\MediaWiki\includes\Article.php(1542):
Article-outputWikiText('big'''MediaWi...', true, Object(ParserOptions))
#15 D:\Projects\MediaWiki\includes\Article.php(4525): Article-doViewParse()
#16 D:\Projects\MediaWiki\includes\PoolCounter.php(163):
PoolWorkArticleView-doWork()
#17 D:\Projects\MediaWiki\includes\Article.php(1065): PoolCounterWork-execute()
#18 D:\Projects\MediaWiki\includes\Wiki.php(486): Article-view()
#19 D:\Projects\MediaWiki\includes\Wiki.php(104):
MediaWiki-performAction(Object(Article))
#20 D:\Projects\MediaWiki\index.php(145):
MediaWiki-performRequestForTitle(Object(Article))
#21 {main}
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87130]: Revision status changed
User Krinkle changed the status of MediaWiki.r87130. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87130#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-04-29 19:42:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87174]: Revision status changed
User Krinkle changed the status of MediaWiki.r87174. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87174#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-04-30 20:45:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87191]: Revision status changed
User Krinkle changed the status of MediaWiki.r87191. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87191#c0 Commit summary: Add message 'form-legend-settings' to krinkle-domain ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87193]: Revision status changed
User Krinkle changed the status of MediaWiki.r87193. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87193#c0 Commit summary: allwikiselect (alws) forms are now used in all krinkletools that iterate all wikis. Form-label wasn't central yet (either in local domain or hardcoded). Removing from local domains, adding to krinke domain ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87194]: Revision status changed
User Krinkle changed the status of MediaWiki.r87194. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87194#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-01 16:36:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Announcing the Open Source Sweble Wikitext Parser v1.0
Hi everyone, We are happy to announce the general availability of the first public release of the Sweble Wikitext parser, available from http://sweble.org. The Sweble Wikitext parser * can parse all complex Wikitext, incl. tables and templates * produces a real abstract syntax tree (AST); a DOM will follow soon * is open source made available under the Apache Software License 2.0 * is written in Java utilizing only permissively licensed libraries You can find all relevant information and code at http://sweble.org – this also includes demos, in particular the CrystalBall demo, which lets you query a Wikipedia snapshot using XQuery. The Sweble Wikitext parser intends to be a complete parser for Wikitext. That said, plenty of work remains to be done. At this stage, we are hoping for your help. You can help us by * playing with the CrystalBall demo and pointing out to us wiki pages that look particularly bad or faulty * simply using the parser in your projects and telling us what works and what doesn’t (bug reports) * getting involved in the open source project by contributing code, documentation, and good humor If you have questions, please don’t hesitate to use the sweble.org facilities or send email to i...@sweble.org. Cheers Hannes ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87183]: Revision status changed
User Catrope changed the status of MediaWiki.r87183. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87183#c0 Commit summary: Remove unneeded manual quoting from r87180 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87196]: Revision status changed
User Reedy changed the status of MediaWiki.r87196. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87196#c0 Commit summary: * (bug 28143) SiteMatrix API module should allow filtering by wiki status (closed, private, fishbowl, etc.) Add filtering by type (special/language) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87198]: New comment added
User Reedy posted a comment on MediaWiki.r87198. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87198#c16466 Commit summary: * (bug 28143) SiteMatrix API module should allow filtering by wiki status (closed, private, fishbowl, etc.) Add filtering by type (special/language) Try r87916 again Comment: Some artefacts left which have been used/fixed in r87199 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Announcing the Open Source Sweble Wikitext Parser v1.0
- Original Message - From: Hannes Dohrn hannes.do...@informatik.uni-erlangen.de Hi everyone, We are happy to announce the general availability of the first public release of the Sweble Wikitext parser, available from http://sweble.org. The Sweble Wikitext parser * can parse all complex Wikitext, incl. tables and templates * produces a real abstract syntax tree (AST); a DOM will follow soon * is open source made available under the Apache Software License 2.0 * is written in Java utilizing only permissively licensed libraries You should identify whether you mean MediaWikitext, or some other dialect -- MediaWiki Is Not The Only Wiki... and you should post to wikitext-l as well. The real parser maniacs hang out over there, even though traffic is low. Cheers, -- jra ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Announcing the Open Source Sweble Wikitext Parser v1.0
You should identify whether you mean MediaWikitext, or some other dialect -- MediaWiki Is Not The Only Wiki... and you should post to wikitext-l as well. The real parser maniacs hang out over there, even though traffic is low. It is MediaWiki's Wikitext; elsewhere it is usually called wiki markup. Cheers, Dirk -- Website: http://dirkriehle.com - Twitter: @dirkriehle Ph (DE): +49-157-8153-4150 - Ph (US): +1-650-450-8550 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Announcing the Open Source Sweble Wikitext Parser v1.0
- Original Message - From: Dirk Riehle d...@riehle.org You should identify whether you mean MediaWikitext, or some other dialect -- MediaWiki Is Not The Only Wiki... and you should post to wikitext-l as well. The real parser maniacs hang out over there, even though traffic is low. It is MediaWiki's Wikitext; elsewhere it is usually called wiki markup. Improperly and incompletely, perhaps, yes. I'm a MW partisan, and think it's better than nearly all its competitors, for nearly all uses... but even I try not to be *that* partisan. Cheers, -- jra ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r66200]: New comment added
User Hashar posted a comment on MediaWiki.r66200.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66200#c16467
Commit summary:
(bug 23426) The {{REVISIONMONTH}} variable is now zero-padded and added new
variable {{REVISIONMONTH1}} when unpadded version is needed.
Comment:
I personally don't care. I was just raising the possible inconstancy enlighten
by r81414 tests:
[x] Currentday is un padded
[x] Currentdaytwo is zero padded
[x] Localday is un padded
[x] Localdaytwo is zero padded
[x] Currentmonth is zero padded
[x] Currentmonthone is un padded
[x] Localmonth is zero padded
[x] Localmonthone is un padded
[x] Revisionday is un padded
[x] Revisiondaytwo is zero padded
[x] Revisionmonth is zero padded
[x] Revisionmonthone is un padded
It should be revisionmonttwo to be consistant with our other uses.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Announcing the Open Source Sweble Wikitext Parser v1.0
You should identify whether you mean MediaWikitext, or some other dialect -- MediaWiki Is Not The Only Wiki... and you should post to wikitext-l as well. The real parser maniacs hang out over there, even though traffic is low. It is MediaWiki's Wikitext; elsewhere it is usually called wiki markup. Improperly and incompletely, perhaps, yes. I'm a MW partisan, and think it's better than nearly all its competitors, for nearly all uses... but even I try not to be *that* partisan. Hmm, never viewed it that way. IMO, MediaWiki (developers) invented a wiki markup language and called it Wikitext; other engines just call it wiki markup or what not. For me, Wikitext always was the particular markup of MediaWiki, much like php or C++ are particular language names. Is there any other engine that calls it's markup Wikitext? I'd be surprised. Even for WikiCreole wikicreole.org we used wiki markup. Cheers, Dirk -- Website: http://dirkriehle.com - Twitter: @dirkriehle Ph (DE): +49-157-8153-4150 - Ph (US): +1-650-450-8550 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r75402]: New comment added
User Krinkle posted a comment on MediaWiki.r75402. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75402#c16468 Commit summary: Followup for r75314 (bug 23923) -- regression fix for prefix of '0' being ignored since r75314 Don't forget that the string '0' evaluates to false in boolean context! Comment: preDon't forget that the string '0' evaluates to false in boolean context!/pre It does ? I thought 0 would only return as false (as a string) when used with span class=plainlinks[http://php.net/manual/en/function.empty.php empty()]/span : http://codepad.org/BdLgET8S ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87173]: New comment added
User Fomafix posted a comment on MediaWiki.r87173.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87173#c16470
Commit summary:
Bug 27047: Nicer design for pre elements in Vector
Comment:
Of course Firefox supports codeword-wrap: break-word/code. But codepre {
white-space: pre-wrap; }/code is the right CSS3 syntax to wrap lines. With
codepre { white-space: pre-wrap; word-wrap: break-word; }/code very long
words get also wrapped. To support all browsers you should use
pre
pre {
word-wrap: break-word; /* IE 5.5-7 */
white-space: -moz-pre-wrap; /* Firefox 1.0-2.0 */
white-space: pre-wrap; /* current browsers */
}
/pre
But wrapping codepre/code generally is bad for source code and ASCII art.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87173]: New comment added
User DieBuche posted a comment on MediaWiki.r87173. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87173#c16471 Commit summary: Bug 27047: Nicer design for pre elements in Vector Comment: There obviously are downsides, but imo their weighted up by the pros. A typical MW installation is neither an ASCII art collection nor a code repo. A quickly pasted long URL can easily break the whole layout, and before we used this fix at commons the village pump's layout was broken more often than not. break-word was purposefully since i breaks very long urls as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87208]: Revision status changed
User DieBuche changed the status of MediaWiki.r87208. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87208#c0 Commit summary: (bug 27916) Don't prefix wgServer in mw.util.wikiGetlink The check is not needed, if wgArticlePath is undefined there's probably a much bigger issue. The wgServer doesn't need to be prefixed to the link (if someone really needs it (ie. external tools using the script and somehow defining wgServer in mw.config) they can surely prefix wgServer themselfs. In most if not all cases this is used to create anchor tags, which are interprated by browsers relatively to the current window location and in some browsers it even auto-prefixes the current environment when setting the href/src attribute. I did a grep search for wikiGetlink in /trunk (including ./extensions), there was one usage that assumed the wgServer prefix. Turned out that was actually a workaround untill this bug was fixed. I remove that workaround ( in mw.util.isMainPage). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87171]: Revision status changed
User DieBuche changed the status of MediaWiki.r87171. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87171#c0 Commit summary: (bug 28076) Thumbnail height limited to 360 pixels on Special:Listfiles ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87207]: Revision status changed
User Reedy changed the status of MediaWiki.r87207. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87207#c0 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Leaderboard extension?
Hello together, I would like to have a look at the code behind http://help.wikia.com/wiki/Help:Achievements#Leaderboard but could not find it and would appreciate any hints. Thanks! Daniel -- http://www.google.com/profiles/daniel.mietchen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Leaderboard extension?
On 01-05-11 22:21 Daniel Mietchen daniel.mietc...@googlemail.com wrote: I would like to have a look at the code behind http://help.wikia.com/wiki/Help:Achievements#Leaderboard but could not find it and would appreciate any hints. GPL licensed at https://svn.wikia-code.com/wikia/trunk/extensions/wikia/AchievementsII/ Siebrand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Leaderboard extension?
Thank you, Siebrand! Daniel On Sun, May 1, 2011 at 10:46 PM, Siebrand Mazeland s.mazel...@xs4all.nl wrote: On 01-05-11 22:21 Daniel Mietchen daniel.mietc...@googlemail.com wrote: I would like to have a look at the code behind http://help.wikia.com/wiki/Help:Achievements#Leaderboard but could not find it and would appreciate any hints. GPL licensed at https://svn.wikia-code.com/wikia/trunk/extensions/wikia/AchievementsII/ Siebrand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- http://www.google.com/profiles/daniel.mietchen ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r87145]: New comment added
User ^demon posted a comment on MediaWiki.r87145. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87145#c16472 Commit summary: (bug 28752) XCache doesn't work in CLI mode Comment: Shouldn't parser tests run with all caching disabled anyway? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86179]: Revision status changed
User ^demon changed the status of MediaWiki.r86179. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86179#c0 Commit summary: Overdue changes to `flaggedrevs` table: * Removed unused ft_text and fr_comment fields * Changed the PK to just rev_id (with an index on old PK fields) * Added fr_rev_timestamp field with indexes * Added a script to populate fr_rev_timestamp ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87215]: New comment added
User Reedy posted a comment on MediaWiki.r87215. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87215#c16473 Commit summary: (bug 28343) Kill unused contextlines/contextchars Comment: Ahhh preferences. Possibly the only thing more nasty than globals ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86179]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r86179. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86179#c16474 Commit summary: Overdue changes to `flaggedrevs` table: * Removed unused ft_text and fr_comment fields * Changed the PK to just rev_id (with an index on old PK fields) * Added fr_rev_timestamp field with indexes * Added a script to populate fr_rev_timestamp Comment: Code changes still needed to make use of this. That will come soon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87131]: Revision status changed
User Krinkle changed the status of MediaWiki.r87131. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87131#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-04-29 19:47:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87175]: Revision status changed
User Krinkle changed the status of MediaWiki.r87175. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87175#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-04-30 20:50:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87213]: Revision status changed
User Krinkle changed the status of MediaWiki.r87213. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87213#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-05-01 20:01:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87190]: New comment added
User Werdna posted a comment on MediaWiki.r87190. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87190#c16475 Commit summary: LiquidThreads backend rewrite: Progress commit on LiquidThreadsFormatter, its friend LiquidThreadsFormatterContext and their subclasses. A LiquidThreadsFormatter takes a LiquidThreadsObject and turns it into HTML for display. Its main entry point, getHTML(), takes a LiquidThreadsFormatterContext, which contains contextual information such as language, user, nesting level and what not. There is currently no formatter for the LiquidThreadsTopic object. Also includes a few data model changes (notably, added a field for the timestamp attributed to a post in the signature) Comment: Thanks for pointing that out. It's been fixed in r87230. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83965]: New comment added
User GreenReaper posted a comment on MediaWiki.r83965. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83965#c16476 Commit summary: Fix overestimation of max-width when using perrow mode. Also use const variables to make this more readable. Fixes bug 27577 Follow up to r77411 Comment: The maxwidth calculation seems off. I had to change it to get it to this for the specified number of columns to be used: $maxwidth = $this-mPerRow * ( $this-mWidths + self::THUMB_PADDING + self::GB_PADDING + self::GB_BORDERS + 1) + 1; Example: http://en.wikifur.com/wiki/Wikifur_gallery_%28Film/media,_logos,games,misc.%29 (running on 1.17) - try reducing max-width by even one pixel in Firebug on Firefox 4 and we get one less column. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r72475]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r72475. Old Status: ok New Status: fixme User Tim Starling also posted a comment on MediaWiki.r72475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72475#c16477 Commit summary: Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to be done for the normal UI. PHPUnit tests are updated and should cover most code paths that can be called from the API. ApiUpload: * Added statuskey parameter; this is the key that is returned by an async upload * Refactored warnings transformation into its own function * filename is no longer required on all uploads UploadFromUrlJob: * Moved upload results to its own entry in $_SESSION, instead of using the one from upload * Fix storing in session by calling wfSetupSession and session_write_close where needed Tests: * Set $wgUser in ApiSetup, so that individual tests don't have to do this for themselves * Added tests to cover most code paths from the API * Fixed UploadFromUrlTestSuite so that its tests are included in a regular phpunit invocation (something strange with the AutoLoader; not sure what) Other files: * Allow passing session id to wfSetupSession * Explicitly close the session before doing jobs, so that jobs can't manipulate the current session Comment: Moving the session_write_close() up completely broke ChronologyProtector and so caused bug 27891. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
