[MediaWiki-CodeReview] [MediaWiki r78943]: Revision status changed
User Krinkle changed the status of MediaWiki.r78943. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78943#c0 Commit summary: Really fix bug 26131: just putting the site+user link at the bottom of the head isn't good enough if the client-side loader is gonna add dynamically populated style tags below it later, so we need those dynamic style tags to go before the site+user link but after the skin link. Make OutputPage insert a meta tag between these two, marking the spot for the client side load which inserts dynamic style tags above this meta tag rather than at the end of the head ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80504]: New comment added
User Krinkle posted a comment on MediaWiki.r80504. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80504#c17192 Commit summary: Add jquery.form.js, from http://jquery.malsup.com/form/#download Comment: Was this fixed ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80504]: New comment added
User Krinkle posted a comment on MediaWiki.r80504. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80504#c17193 Commit summary: Add jquery.form.js, from http://jquery.malsup.com/form/#download Comment: Yep, in r80506. I've associated the follow-up now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80504]: Revision status changed
User Krinkle changed the status of MediaWiki.r80504. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80504#c0 Commit summary: Add jquery.form.js, from http://jquery.malsup.com/form/#download ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83496]: Revision status changed
User Krinkle changed the status of MediaWiki.r83496. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83496#c0 Commit summary: * Increased the size of the tipsy callout, removed the shadow and made the background of tips white to try and improve the visibility of tips. * Added ui-button-green, ui-button-blue, ui-button-red classes to the Vector jquery ui theme ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85179]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r85179. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r85179. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85179#c17194 Commit summary: Followup r80398: fix overspecific css rules which broke Comment: What broke exactly ? Looks alright otherwise, marking OK. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85616]: New comment added
User Krinkle posted a comment on MediaWiki.r85616.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85616#c17195
Commit summary:
For bug 27488: move the startup script, jquery+mediawiki and the
mw.config.set() call for configuration variables back to the head . Let
modules control whether they're loaded in the head ('top') or at the bottom
of the body ('bottom') through the position parameter/property
Also rearranges the loading order a little bit such that only=messages comes
before only=scripts, and config comes before everything except startup and
jquery+mediawiki
Comment:
Could you look at the TODO you added here ? How urgent / accurate is it towards
the current HEAD ?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86106]: Revision status changed
User Krinkle changed the status of MediaWiki.r86106. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86106#c0 Commit summary: Updating jQuery from 1.4.2-1.4.4, for better data-* support. 1.4.4 contains the patch from r74326 in core ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86050]: Revision status changed
User Krinkle changed the status of MediaWiki.r86050. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86050#c0 Commit summary: Followup to r86047: Declare dependency to JUI button more cleanly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added
User DieBuche posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c17196 Commit summary: Comment: I'd say it's resolved. (At least I know nothing that's still broken) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85179]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85179. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85179#c17197 Commit summary: Followup r80398: fix overspecific css rules which broke Comment: td changed to div or something, so the rules didn't match anymore after my some previous change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added
User Nikerabbit posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c17198 Commit summary: Comment: +1, no errors from twn. I'd expect that Wikipedia finds some but it's impossible to say without testing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Nikerabbit posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17199 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: pre+ 'descriptionmsg' = Dublin Core RDF-metadata/pre Really? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87711]: Revision status changed
User Catrope changed the status of MediaWiki.r87711. Old Status: resolved New Status: reverted Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87711#c0 Commit summary: (bug 28840) Commit patch by bawolff that encodes dots in ResourceLoader module names as exclamation marks in the generated URLs, so as to avoid triggering the recently added IE security measure and causing a blank 403 response. This broke RL in various ways for IE users. This is by no means intended to be permanent, but it's the best way to unbreak RL for IE users while we work out how to fix this properly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85179]: New comment added
User Krinkle posted a comment on MediaWiki.r85179. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85179#c17200 Commit summary: Followup r80398: fix overspecific css rules which broke Comment: Thanks! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88883]: New comment added
User Krinkle posted a comment on MediaWiki.r3. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/3#c17201 Commit summary: (bug 28840) URLs with dots break because of IE6 security check * Replace the overly paranoid regex with a function that simulates IE6's behavior * Remove the UA check in isPathInfoBad(), was causing more problems than it was worth * Revert r87711, going back to using dots for dots in ResourceLoader URLs, instead of exclamation marks * Append * to ResourceLoader URLs. * is an illegal character in extensions, and putting it at the end of the URL ensures that both IE6 and our detection function will deem the URL to have no extension (unless something like .html? appears in the query string, but in that case we're screwed no matter what) Comment: blockquoteem... (unless something like .html? appears in the query string, but in that case we're screwed no matter what) .../em/blockquote Does that mean that a module named mw.foo.html must not exist ? I'm not sure what url variations are possible, but are there potential situations in which a question mark could end up after a module name in a load.php requests ? I dont think so, but just repeating here in case someone else thinks differently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Reedy posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17202 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: Suggest something better? :P ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88879]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r88879. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r88879. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88879#c17203 Commit summary: Adding user info for myself Comment: Please set your [[Subversion/auto-props]] and then fix them for this file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88867]: Revision status changed
User Reedy changed the status of MediaWiki.r88867. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88867#c0 Commit summary: Another fix for r85031 - an instance of 'DeleteBatch' was missed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88846]: Revision status changed
User Reedy changed the status of MediaWiki.r88846. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88846#c0 Commit summary: Surprise! my entire ~/.subversion reverted to some default set and I've had no auto-props on this machine. Wha? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88885]: New comment added
User Reedy posted a comment on MediaWiki.r5. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/5#c17204 Commit summary: Remove reset button from Special:Undelete. It does more harm than good Comment: Is the 'undeletereset' message used anywhere else? As if not, it needs removing from messages.inc ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Nikerabbit posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17205 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: That is the message *key*? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User MZMcBride posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17206 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: I suggest [[Manual:$wgExtensionCredits#Example|RTFM]]. ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] XKCD: Extended Mind
http://ryanelmquist.com/cgi-bin/xkcdwiki Leo On Wednesday, May 25, 2011 at 10:59 PM, Peter Gervai wrote: On Wed, May 25, 2011 at 17:16, Domas Mituzas midom.li...@gmail.com Thanks for clearing that up. Nice work. g ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] XKCD: Extended Mind
On Thu, May 26, 2011 at 17:38, Leo Koppelkamm diebu...@gmail.com wrote: http://ryanelmquist.com/cgi-bin/xkcdwiki Nice way to see that first sentences eventually lead to a general quantity or property which links to [[property (phylosophy)]] which links to Philosophy itself. So far I didn't see a way which wasn't following 'property'. g ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r79272]: Revision status changed
User Hashar changed the status of MediaWiki.r79272. Old Status: old New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79272#c0 Commit summary: -Destroy the DB automatically when initting the DB -Add $force option to wfSetVar -More work on getting SQLite to work ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Bryan posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17207 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: PreformAction? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Reedy posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17208 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: [[Manual:Hooks/MediaWikiPerformAction]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Bryan posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17209 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: PreformAction != PerformAction ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: New comment added
User Reedy posted a comment on MediaWiki.r88875. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88875#c17210 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf Comment: It's right on the hook side :P ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80318]: New comment added
User Bryan posted a comment on MediaWiki.r80318. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80318#c17211 Commit summary: Show file properties on the image page. Needs a UI designer to make it look nice. Added imagepage-copyright-information, imagepage-wiki-author, imagepage-author and imagepage-license messages Comment: Going to mark this whole branch as deferred. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r72475]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r72475. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r72475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72475#c17212 Commit summary: Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to be done for the normal UI. PHPUnit tests are updated and should cover most code paths that can be called from the API. ApiUpload: * Added statuskey parameter; this is the key that is returned by an async upload * Refactored warnings transformation into its own function * filename is no longer required on all uploads UploadFromUrlJob: * Moved upload results to its own entry in $_SESSION, instead of using the one from upload * Fix storing in session by calling wfSetupSession and session_write_close where needed Tests: * Set $wgUser in ApiSetup, so that individual tests don't have to do this for themselves * Added tests to cover most code paths from the API * Fixed UploadFromUrlTestSuite so that its tests are included in a regular phpunit invocation (something strange with the AutoLoader; not sure what) Other files: * Allow passing session id to wfSetupSession * Explicitly close the session before doing jobs, so that jobs can't manipulate the current session Comment: Fixed in r88904. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r77067]: Revision status changed
User Reedy changed the status of MediaWiki.r77067. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77067#c0 Commit summary: *(bug 25920) Moved forward ref to a back ref to really get v6 regex to compile on older PCRE versions. Works around PCRE 8 nested named ref bug that killed r76928. * Added another simple v6 assertion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78570]: Revision status changed
User Reedy changed the status of MediaWiki.r78570. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78570#c0 Commit summary: Moved constant values from initialiseFromUser() to class definition ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78570]: Revision status changed
User Reedy changed the status of MediaWiki.r78570. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78570#c0 Commit summary: Moved constant values from initialiseFromUser() to class definition ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88772]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r88772. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r88772. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88772#c17213 Commit summary: Workaround for duplicate key errors Comment: It used to work. Marking as fixme since this needs investigation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80844]: Revision status changed
User Reedy changed the status of MediaWiki.r80844. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80844#c0 Commit summary: Follow-up to r63650: refactor duplicated code in SiteMatrix's lazy list initialization ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81114]: Revision status changed
User Reedy changed the status of MediaWiki.r81114. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81114#c0 Commit summary: $wgConfirmAccountContact declared twice ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81272]: Revision status changed
User Reedy changed the status of MediaWiki.r81272. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81272#c0 Commit summary: fix Bug#26274: Database layer should allow arrays for ORDER BY, GROUP BY ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82016]: Revision status changed
User Reedy changed the status of MediaWiki.r82016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82016#c0 Commit summary: Follow-up r81971: Can't use $this-setWarning() in static context, so append the error to the imageinfo array instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82567]: Revision status changed
User Reedy changed the status of MediaWiki.r82567. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82567#c0 Commit summary: Removed some usages of $wgTitle ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88729]: New comment added
User Platonides posted a comment on MediaWiki.r88729. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88729#c17214 Commit summary: Introduced Maintenance::getDB() and corresponding setDB() to control externally what database object should be used by maintenance script. Currently used by updater to avoid DatabaseSqliteTest from running stuff like Populate* on the live database instead of the one used for testing. Comment: Are you sure this is needed? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83444]: Revision status changed
User Reedy changed the status of MediaWiki.r83444. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83444#c0 Commit summary: Add commiters from March 2nd, 2011 Tim's mail: Pywikipediabot only: * Lewis Cawte (lcawte) Extensions only: * Andrew Fitzgerald (swiftlytilting): MediawikiPlayer, CustomSidebar * Ben Romberg (brezelben): Intopedia * Raylton Sousa: BookManger Extensions and core: * Thomas Gries (tgries): OpenID, email notification ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88892]: Revision status changed
User IAlex changed the status of MediaWiki.r88892. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88892#c0 Commit summary: Swap descriptionmsg to description ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84290]: Revision status changed
User Reedy changed the status of MediaWiki.r84290. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84290#c0 Commit summary: Kill 1.16 compat classes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88869]: Revision status changed
User IAlex changed the status of MediaWiki.r88869. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88869#c0 Commit summary: Remove spurious code from DublinCore.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88864]: Revision status changed
User IAlex changed the status of MediaWiki.r88864. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88864#c0 Commit summary: Changed display of images and other files to also show the name of the file, not just display its thumbnail - seems like a better general solution, especially for the 'gallery' format, but also in other cases ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88875]: Revision status changed
User IAlex changed the status of MediaWiki.r88875. Old Status: new New Status: deferred Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88875#c0 Commit summary: Kill code from CreativeCommonsRdf_body.php that should've been removed in r88873 Add URL, add one description Fix class name of CreativeCommonsRdf ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88297]: Revision status changed
User Reedy changed the status of MediaWiki.r88297. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88297#c0 Commit summary: 1.17wmf1: Copy cldr extension from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86212]: Revision status changed
User Bryan changed the status of MediaWiki.r86212. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86212#c0 Commit summary: (Follow-up r86169) Needed supress warnings around iconv Also make it try to detect if a jpeg file comment has textual data, or is random binary stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85184]: Revision status changed
User Reedy changed the status of MediaWiki.r85184. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85184#c0 Commit summary: Santhosh Thottingal (santhosh): Webfonts extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88910]: Revision status changed
User Krinkle changed the status of MediaWiki.r88910. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88910#c0 Commit summary: fixing error resetting ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added, and revision status changed
User Bryan changed the status of MediaWiki.r81536. Old Status: fixme New Status: new User Bryan also posted a comment on MediaWiki.r81536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81536#c17215 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: The issue was actually a misleading comment, fixed in r88911. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88870]: Revision status changed
User Bryan changed the status of MediaWiki.r88870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88870#c0 Commit summary: Reverting r82307 (bug 27465) as initial step to recommitting a cleaner fix. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88912]: Revision status changed
User Reedy changed the status of MediaWiki.r88912. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88912#c0 Commit summary: Importing Lingo extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81577]: Revision status changed
User Hashar changed the status of MediaWiki.r81577. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81577#c0 Commit summary: Kill off Linker::getExternalLinkAttributes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81528]: Revision status changed
User Hashar changed the status of MediaWiki.r81528. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81528#c0 Commit summary: Use wfMessage() instead of wfMsgGetKey() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82501]: Revision status changed
User Hashar changed the status of MediaWiki.r82501. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82501#c0 Commit summary: Fix ArticleTablesTest after r81528. It needs to set both $wgLanguageCode and $wgContLang. Added setUp() and teardown() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82500]: Revision status changed
User Hashar changed the status of MediaWiki.r82500. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82500#c0 Commit summary: Break the self-reference between parser and preprocessor, so they can be counting collected. Saved a couple of Mb in the destructive make (126.25Mb - 124.25Mb). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84498]: Revision status changed
User Hashar changed the status of MediaWiki.r84498. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84498#c0 Commit summary: Follow-up r84475: fixing the warning is easy enough... :D Also some random tweaks to Database.php documentation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88513]: New comment added
User Catrope posted a comment on MediaWiki.r88513. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88513#c17216 Commit summary: Adding mw.util.wikiScript + small fix in mediawiki.action.watch.ajax.js * Moving wiki* functions together in mediawiki.util.js * Adding Adding mw.util.wikiScript (like wfScript() in GlobalFunctions.php) * Adding test suite for it * Example to use it in mediawiki.action.watch.ajax.js * (bug 29071) mediawiki.action.watch.ajax.js doesn't use uselang Comment: uselang does actually work elsewhere, because it's handled at a lower level shared by index.php and api.php . This is an undocumented feature that shouldn't be relied upon, though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86004]: Revision status changed
User Hashar changed the status of MediaWiki.r86004. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86004#c0 Commit summary: Add a couple of broken tests showing why having the table closing tags in the same line is not a good idea. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85616]: New comment added
User Catrope posted a comment on MediaWiki.r85616.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85616#c17217
Commit summary:
For bug 27488: move the startup script, jquery+mediawiki and the
mw.config.set() call for configuration variables back to the head . Let
modules control whether they're loaded in the head ('top') or at the bottom
of the body ('bottom') through the position parameter/property
Also rearranges the loading order a little bit such that only=messages comes
before only=scripts, and config comes before everything except startup and
jquery+mediawiki
Comment:
It's not urgent. Ugly, but low priority.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88911]: Revision status changed
User IAlex changed the status of MediaWiki.r88911. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88911#c0 Commit summary: Follow-up r81536: Fix misleading comment in Status and add a comment to LocalFileRestoreBatch::cleanupFailedBatch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87364]: Revision status changed
User Hashar changed the status of MediaWiki.r87364. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87364#c0 Commit summary: Follow up r87210 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87229]: Revision status changed
User Hashar changed the status of MediaWiki.r87229. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87229#c0 Commit summary: Follow up r87210 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87210]: Revision status changed
User Hashar changed the status of MediaWiki.r87210. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87210#c0 Commit summary: Fix the old XmlTest.php test bug in the dateMenu() when the wiki is configured for a languange other than English Other tests were running before and messing with the Language objects. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88883]: New comment added
User Catrope posted a comment on MediaWiki.r3. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/3#c17218 Commit summary: (bug 28840) URLs with dots break because of IE6 security check * Replace the overly paranoid regex with a function that simulates IE6's behavior * Remove the UA check in isPathInfoBad(), was causing more problems than it was worth * Revert r87711, going back to using dots for dots in ResourceLoader URLs, instead of exclamation marks * Append * to ResourceLoader URLs. * is an illegal character in extensions, and putting it at the end of the URL ensures that both IE6 and our detection function will deem the URL to have no extension (unless something like .html? appears in the query string, but in that case we're screwed no matter what) Comment: No, a question mark can't end up in the middle of an RL query string, except if a question mark appears in a module name. But we could (and probably should) just disallow that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86789]: Revision status changed
User Hashar changed the status of MediaWiki.r86789. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86789#c0 Commit summary: follow up r86752 with some content for the result of “Gallery with wikitext inside caption” ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88176]: Revision status changed
User Hashar changed the status of MediaWiki.r88176. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88176#c0 Commit summary: Revert r87635, r87637, r87639, r87643 (MW_MIN_PHP_VERSION etc.): breaks HipHop support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88843]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r88843. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r88843. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88843#c17219 Commit summary: * (bug 29140) FirePHP debugging assist extension FirePHP is an extension to Firebug, an awesome debugging extension to Firefox. It allows pulling debug log data in from your PHP script via HTTP headers, which then get displayed in Firebug's console along with errors, warnings, and AJAX hits from the web page. Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take this; note that a few lines of output won't make it to FirePHP as they are output either before we've done all plugin initialization, or after we've flushed output and can no longer add HTTP headers. BSD-licensed FirePHPCore library from firephp-libs commit aff25803a3ff460b2797: https://github.com/cadorn/firephp-libs/blob/aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php There's not a lot of fancy integration; everything's just output as a 'log' line. You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get direct access to FirePHP's fancier features in test code. Comment: The addition of wfRunHooks() to wfDebug breaks parserTests and maintenance scripts for me. I have EditUser extension in LocalSettings.php, which require_onces GlobalSettings.php precisely in case it is loaded from a maintenance script (seems redundant, though). A different extension triggered the autoloader. The autoloader calls wfDebug (if that function exists, which after GlobalSettings inclusion, it does). wfDebug calls wfRunHooks which is not declared yet. We can (and should) fix EditUser, but how many other LocalSettings may have such hidden assumption? (and this was a pain to debug) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88898]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r88898. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r88898. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88898#c17220 Commit summary: Merged MediaWiki::performRequestForTitle() and MediaWiki::handleSpecialCases() into MediaWiki::performRequest(): * this allows to perform tests in the correct order, i.e. first BadTitle check and then userCanRead() * the Article object is now returned by the function instead of passed back in pass-by-reference parameter * Removed the return false; when MediaWiki detects a redirect, was causing an useless full execution Comment: [26-May-2011 19:23:14] PHP Notice: Undefined variable: new_article in /www/w/includes/Wiki.php on line 192 [26-May-2011 19:23:14] /wiki/Translating:Languages: Exception: Shouldn't happen: MediaWiki::initializeArticle() returned neither an object nor a URL ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87500]: Revision status changed
User Hashar changed the status of MediaWiki.r87500. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87500#c0 Commit summary: Simplify a bit: $wgOut-addWikiText( wfMsg( ... ) ) - $wgOut-addWikiMsg( ... ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87569]: Revision status changed
User Hashar changed the status of MediaWiki.r87569. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87569#c0 Commit summary: Remove install-utils.inc marked for 1.19 removal ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87618]: Revision status changed
User Hashar changed the status of MediaWiki.r87618. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87618#c0 Commit summary: Follow-up r87569: update one comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88927]: New comment added
User Jack Phoenix posted a comment on MediaWiki.r88927.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88927#c17221
Commit summary:
bugfix: injected illegal tags
Comment:
pre
+ $doc = @DOMDocument::loadHTML( $text );
/pre
[[Manual:Coding conventions#Error handling|Don't use @, use
wfSuppressWarnings() and wfRestoreWarnings() instead.]]
pre
+ $body = $xpath - query( '/html/body' );
+
+ $text = '';
+ foreach ( $body - item( 0 ) - childNodes as $child ) {
+ $text .= $doc - saveXML( $child );
+ }
/pre
This is ''too'' spacey, and should be written like this instead:
pre
$body = $xpath-query( '/html/body' );
$text = '';
foreach ( $body-item( 0 )-childNodes as $child ) {
$text .= $doc-saveXML( $child );
}
/pre
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82801]: Revision status changed
User Reedy changed the status of MediaWiki.r82801. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82801#c0 Commit summary: SyntaxHighlight_GeSHi: collapse language list by default to look less scary ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84247]: Revision status changed
User Reedy changed the status of MediaWiki.r84247. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84247#c0 Commit summary: ParserFirstCallInit hook has a parameter, so use it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85016]: Revision status changed
User Reedy changed the status of MediaWiki.r85016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85016#c0 Commit summary: Space missing in mesasge. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85759]: Revision status changed
User Reedy changed the status of MediaWiki.r85759. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85759#c0 Commit summary: dl() - wfDl() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85787]: Revision status changed
User Reedy changed the status of MediaWiki.r85787. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85787#c0 Commit summary: Kill duplicate categoryfinder.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86249]: Revision status changed
User Reedy changed the status of MediaWiki.r86249. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86249#c0 Commit summary: API for getting gadget categories ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86318]: Revision status changed
User Reedy changed the status of MediaWiki.r86318. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86318#c0 Commit summary: Use MWNamespace::getContentNamespaces() instead of $wgContentNamespaces in case of misconfiguration of the latter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86408]: Revision status changed
User Reedy changed the status of MediaWiki.r86408. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86408#c0 Commit summary: API: Clarify help text for cmstartsortkey and cmendsortkey parameters ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86341]: Revision status changed
User Reedy changed the status of MediaWiki.r86341. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86341#c0 Commit summary: Finally add my userinfo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87063]: Revision status changed
User Reedy changed the status of MediaWiki.r87063. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87063#c0 Commit summary: Fixed postinst user account creation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87003]: Revision status changed
User Reedy changed the status of MediaWiki.r87003. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87003#c0 Commit summary: RELEASE-NOTES TLC: * break lines at or before 80 characters. * punctuation for every entry. * all caps for API and SVG. * move an entry to language updates. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87560]: Revision status changed
User Reedy changed the status of MediaWiki.r87560. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87560#c0 Commit summary: File syntax is: propertywhitespacevalues; fixing the parsing to pull the entire value ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88299]: Revision status changed
User Reedy changed the status of MediaWiki.r88299. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88299#c0 Commit summary: 1.17wmf1: Move cldr extension to the right place ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88303]: Revision status changed
User Reedy changed the status of MediaWiki.r88303. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88303#c0 Commit summary: 1.17wmf1: Port Language::isValidBuiltInCode() from trunk for CLDR's benefit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88282]: Revision status changed
User Reedy changed the status of MediaWiki.r88282. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88282#c0 Commit summary: db - dbw ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88261]: Revision status changed
User Reedy changed the status of MediaWiki.r88261. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88261#c0 Commit summary: Removed usage of error suppression operator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88457]: Revision status changed
User Reedy changed the status of MediaWiki.r88457. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88457#c0 Commit summary: GoogleNewsSitemap: coding style tweaks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88770]: Revision status changed
User Reedy changed the status of MediaWiki.r88770. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88770#c0 Commit summary: * (bug 27097) SVGEdit loading caching fix Disable caching when fetching source SVG file directly, so we don't accidentally show the previous version after an edit/reload/edit cycle. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88935]: Revision status changed
User Reedy changed the status of MediaWiki.r88935. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88935#c0 Commit summary: Fix typo ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88913]: Revision status changed
User Reedy changed the status of MediaWiki.r88913. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88913#c0 Commit summary: Importing Lingo extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88843]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r88843.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88843#c17223
Commit summary:
* (bug 29140) FirePHP debugging assist extension
FirePHP is an extension to Firebug, an awesome debugging extension to Firefox.
It allows pulling debug log data in from your PHP script via HTTP headers,
which then get displayed in Firebug's console along with errors, warnings, and
AJAX hits from the web page.
Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take
this; note that a few lines of output won't make it to FirePHP as they are
output either before we've done all plugin initialization, or after we've
flushed output and can no longer add HTTP headers.
BSD-licensed FirePHPCore library from firephp-libs commit aff25803a3ff460b2797:
https://github.com/cadorn/firephp-libs/blob/aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php
There's not a lot of fancy integration; everything's just output as a 'log'
line.
You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get
direct access to FirePHP's fancier features in test code.
Comment:
Such an extension would certainly break under HipHop, or probably under
Wikimedia configurations or... well anything that assumes that MediaWiki is
MediaWiki. ;)
I don't even see why it would try to load GlobalFunctions itself -- it doesn't
seem to call any functions at load time (nor should it, as that would be a
GROSS violation of MediaWiki's operating assumptions)!
It looks like it was added for this bit:
pre
if(!file_exists($dir . substr($wgVersion, 0, 4) . '/EditUser_body.php')) {
wfDebug(Your MediaWiki version \$wgVersion\ is not supported by the
EditUser extension);
return;
}
/pre
which no longer is present.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88843]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r88843. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88843#c17224 Commit summary: * (bug 29140) FirePHP debugging assist extension FirePHP is an extension to Firebug, an awesome debugging extension to Firefox. It allows pulling debug log data in from your PHP script via HTTP headers, which then get displayed in Firebug's console along with errors, warnings, and AJAX hits from the web page. Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take this; note that a few lines of output won't make it to FirePHP as they are output either before we've done all plugin initialization, or after we've flushed output and can no longer add HTTP headers. BSD-licensed FirePHPCore library from firephp-libs commit aff25803a3ff460b2797: https://github.com/cadorn/firephp-libs/blob/aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php There's not a lot of fancy integration; everything's just output as a 'log' line. You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get direct access to FirePHP's fancier features in test code. Comment: Removed the require_once on trunk in r88943. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88843]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r88843. Old Status: fixme New Status: new User Brion VIBBER also posted a comment on MediaWiki.r88843. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88843#c17225 Commit summary: * (bug 29140) FirePHP debugging assist extension FirePHP is an extension to Firebug, an awesome debugging extension to Firefox. It allows pulling debug log data in from your PHP script via HTTP headers, which then get displayed in Firebug's console along with errors, warnings, and AJAX hits from the web page. Added 'Debug' hook which gets called from wfDebug() and wfDebugLog() to take this; note that a few lines of output won't make it to FirePHP as they are output either before we've done all plugin initialization, or after we've flushed output and can no longer add HTTP headers. BSD-licensed FirePHPCore library from firephp-libs commit aff25803a3ff460b2797: https://github.com/cadorn/firephp-libs/blob/aff25803a3ff460b2797/packages/core/lib/FirePHPCore/FirePHP.class.php There's not a lot of fancy integration; everything's just output as a 'log' line. You can use $wgFirePHP global (or call FirePHP::getInstance() yourself) to get direct access to FirePHP's fancier features in test code. Comment: Removing fixme -- the bug was in another extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88946]: New comment added
User MarkAHershberger posted a comment on MediaWiki.r88946. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88946#c17226 Commit summary: Fix Bug #28829 - “Failure to subscribe to mediawiki-announce is not reported to the user” Wasn't able to test an actual subscription failure, so I faked it. Error message showed. Tried double-subscribing an address and only got an emailed “privacy alert” from mailman. Doing a double-subscription manually didn't get any web-based error. Comment: This needs to be forward-ported. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
