[MediaWiki-CodeReview] [MediaWiki r89598]: Revision status changed
User "MaxSem" changed the status of MediaWiki.r89598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89598#c0 Commit summary: ; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User "Tim Starling" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17709 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP < 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP < 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: In most places where you might want to use this new variant of wfDie(), you can throw an exception instead. Exceptions already have the infrastructure for formatting error messages in various ways depending on the entry point. If there's some problem with that infrastructure, then it should be fixed rather than duplicated. The old uses of wfDie() are just a shortcut for "echo $msg;die(-1);", they reflect Brion's disgust at PHP when he found out that die($msg) doesn't do that. See r12660. I removed most instances from the core in r14631 in favour of exceptions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89622]: Revision status changed
User "^demon" changed the status of MediaWiki.r89622. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89622#c0 Commit summary: added forgotten patches subdir path to one sql patch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89563]: Revision status changed
User "^demon" changed the status of MediaWiki.r89563. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89563#c0 Commit summary: Two fixes for older MediaWiki versions * SpecialViewUserLang: $this->getSkin to $wgUser->getSkin (fixed by Roan in r89557) * selecting a different namespace for random pages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89357]: Revision status changed
User "^demon" changed the status of MediaWiki.r89357. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89357#c0 Commit summary: 1.17wmf1: Commit live hack to disable join CTAs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89445]: Revision status changed
User "^demon" changed the status of MediaWiki.r89445. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89445#c0 Commit summary: 1.17wmf1: Revert live hack in r89357 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89571]: Revision status changed
User "^demon" changed the status of MediaWiki.r89571. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89571#c0 Commit summary: 1.17wmf1: MFT r89570 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added
User "^demon" posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17708 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP < 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP < 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: I had already noticed this, I just hadn't worked on a fix for it yet. To be honest, I don't really like this approach at all. wfDie() means very different things, depending on the context. * Dying in maintenance scripts - New maintenance scripts can just use error() with the second parameter. Older ones should be updated to subclass Maintenance anyway. * Catastrophic errors like PHP version too low, API disabled, or missing LocalSettings. * Some old junk in Exception.php Since wfDie() isn't used outside of core '''anywhere''', I'd suggest we just remove it entirely or at least severely limit the use-cases. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: New comment added, and revision status changed
User "Tim Starling" changed the status of MediaWiki.r85918. Old Status: new New Status: fixme User "Tim Starling" also posted a comment on MediaWiki.r85918. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c17707 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP < 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP < 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. Comment: Appears to break HipHop support. Please do not define multiple functions with the same name, even if they are in different files. There are lots of other ways to do this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added
User "Wikinaut" posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17706 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: in short and better formatted: * in DatabaseInstaller::createExtensionTables() * $updater->doUpdates( array( 'extensions' ) ); // code is not reached ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85021]: New comment added, and revision status changed
User "Wikinaut" changed the status of MediaWiki.r85021. Old Status: resolved New Status: fixme User "Wikinaut" also posted a comment on MediaWiki.r85021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85021#c17705 Commit summary: (bug 28237) Installer doesn't create extension tables Comment: I double-checked a fresh installation with extension (OpenID or LiquidThreads) and found, that 206 // Now run updates to create tables for old extensions 207 $updater->doUpdates( array( 'extensions' ) ); in DatabaseInstaller::createExtensionTables() (which I tested, and yes, it was called) is *not* executed. Please forgive if I am wrong, but currently my analysis shows that the extension schema updates during *installation* appears to be not working currently (upgrades do work). See also bug28983 . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89166]: New comment added, and revision status changed
User "Tim Starling" changed the status of MediaWiki.r89166. Old Status: fixme New Status: new User "Tim Starling" also posted a comment on MediaWiki.r89166. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89166#c17704 Commit summary: HipHop improvements: * Added the ability to compile extensions. The build process is bootstrapped by running MediaWiki in interpreted mode. Extension setup file inclusions are slightly modified in a way that makes them register themselves for compilation. Then the same LocalSettings.php uses the compiled extension setup file when the compiled binary runs. * Tested with Cite and ParserFunctions. The code which lets you have an extensions directory in a place other than $IP/../extensions is untested. * Simplified WebStart.php slightly by using a custom $_SERVER variable to mark compiled mode. It will break if you don't use the supplied server.conf, but that will break a lot of things so don't do that. * Fixed the core web entry points to include WebStart.php in compiled mode instead of interpreted. * Made the build directory configurable. This is mostly so that I can grep the source tree without seeing loads of generated C++. * In server.conf, added a rewrite rule allowing a /wiki/$1 article path. * Removed server.conf log file location "/dev/stdout", breaks when you switch user * Disable static content cache, breaks horribly when you set SourceRoot to a directory containing 7GB of files. * Rewrote the run-server script in PHP, mostly to support the configurable build directory feature. * Added an option to the run-server script to allow running in interpreted (hphpi) mode. Comment: Marking new then. The getExtensionsDirectory() thing was fixed in r89387. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89617]: New comment added
User "Gurch" posted a comment on MediaWiki.r89617. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89617#c17703 Commit summary: * (bug 28695) If there are no results for an abuse filter log, can you put "No matching items in log" or something similar, as we do for usual logs Think this is right, not verified Comment: - 'abusefilter-edit-builder-funcs-specialratio' => 'Special characters / total characters (specialratio)', + 'abusefilter-edit-builder-funcs-specabuialratio' => 'Special characters / total characters (specialratio)', was that intentional? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80785]: Revision status changed
User "Krinkle" changed the status of MediaWiki.r80785. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80785#c0 Commit summary: Port the remaining Skin.php skins standard(classic), Cologneblue and Nostalgia * Converted Nostalgia's use of inline table alignment to CSS * common_rtl.css is not in use now Refs bug 26649 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89606]: Revision status changed
User "Krinkle" changed the status of MediaWiki.r89606. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89606#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-06 20:43:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85022]: New comment added, and revision status changed
User "Krinkle" changed the status of MediaWiki.r85022. Old Status: new New Status: resolved User "Krinkle" also posted a comment on MediaWiki.r85022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85022#c17702 Commit summary: (bug 19942) remove deprecated HTML attributes (cellpadding, align, valign) from TablePager. Comment: In r89618 I've reverted the change in this commit that was unrelated to the commit summary and made the TablePager element centered. Whether this was an improvement is a bigger decision. See also this one http://i.imgur.com/Q0wCF.png where the Sign-offs and Follow-up revision tables are centered, wheareas that was not originally the case. If you think the styles themself should change, please create an enhancement bug. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89601]: Revision status changed
User "Krinkle" changed the status of MediaWiki.r89601. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89601#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-06 20:39:00 39:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89551]: Revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89551. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89551#c0 Commit summary: Followup r89515, swapped messages around so css => css and js => javascript ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89595]: Revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89595. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89595#c0 Commit summary: Revert r89537 till we decide a sane way to have it on/off as API bools suck ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89615]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89615. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r89615. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89615#c17701 Commit summary: (bug 25124) Resource loader should respect $wgStyleDirectory * Yay, one down, one resourceloader 1.0 blocker to go Comment: Looks ok, doesn't seem to break anything. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
Ashar Voultoiz wrote: > On 06/06/11 00:56, K. Peachey wrote: > >>> Since it skips cache, can not we disable that stub highlighter once for all? >> Logged in users don't get cached versions of the page... > > I am well aware of that. The root cause being the various options > available to users, my proposal is merely to get ride of one of the > options :-) I think you would find opposition from wikipedians when you tried to ditch the stub threshold option. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89371]: New comment added
User "^demon" posted a comment on MediaWiki.r89371. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89371#c17700 Commit summary: Various OpenID cleanups (did them as I went) * Drop 1.15 and below Preference hooks * Drop some unused functions * Fix $wgAvailableRights * Move SQL stuff to patches/, use shorthand for /*_*/ and fix /*i*/ * Just used echo instead of wfOut() in LoadExtensionSchemaUpdates. Yeah it's ugly, but I don't feel like fixing the 1.16/1.17 discrepency here yet Comment: Those hooks don't even exist in 1.16 or above, so removing them won't affect anything. All preferences are done by a single hook now, which I kept. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89585]: New comment added, and revision status changed
User "Platonides" changed the status of MediaWiki.r89585. Old Status: new New Status: ok User "Platonides" also posted a comment on MediaWiki.r89585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89585#c17699 Commit summary: Fix for bug 29274 - Message class ignores $wgForceUIMsgAsContentMsg Also added tests, which pass Comment: Confirmed fixed. I improved it a bit in r89612. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89371]: New comment added, and revision status changed
User "Wikinaut" changed the status of MediaWiki.r89371. Old Status: deferred New Status: fixme User "Wikinaut" also posted a comment on MediaWiki.r89371. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89371#c17698 Commit summary: Various OpenID cleanups (did them as I went) * Drop 1.15 and below Preference hooks * Drop some unused functions * Fix $wgAvailableRights * Move SQL stuff to patches/, use shorthand for /*_*/ and fix /*i*/ * Just used echo instead of wfOut() in LoadExtensionSchemaUpdates. Yeah it's ugly, but I don't feel like fixing the 1.16/1.17 discrepency here yet Comment: It is not fully clear (to me) and not fully tested whether the "dropping 1.15 and below Preference hooks" breaks anything in the OpenID specific user preferences saving/restoring. I need to check this, marked as "fixme" until then. All other patches are ok. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89596]: Revision status changed
User "^demon" changed the status of MediaWiki.r89596. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89596#c0 Commit summary: Fixup error messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89588]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r89588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89588#c17697 Commit summary: * (bug 29287) Path searching input need a suggest list Adding API module to do code paths like a given prefix Comment: I don't think that has anything to do with the messages about 'tags' and 'comments'. Those are entries in the table describing files that have been copied; they should be recorded differently but our code doesn't know how to do so, which is a known bug. (Should add to Bugzilla if it's not in there.) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89610]: New comment added
User "Krinkle" posted a comment on MediaWiki.r89610. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89610#c17696 Commit summary: Fix bug that brakes the 'jquery.tabIndex > firstTabIndex' test in IE8/IE9. Some values default to a "unknown" string. Comment: I meant "jquery.client.profile" instead of "jquery.tabIndex > firstTabIndex" ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79778]: New comment added
User "Hashar" posted a comment on MediaWiki.r79778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79778#c17695 Commit summary: Comment in code says - truncate to 250 bytes, then add ellipse. but we don't add the ellipse, so change it to add the ellipse. The comment and code should be the same, and since we have the room might as well add the ellipse. This normally wouldn't affect much, since users with JS on will be prevented from adding that long a summary on the client side Comment: Great! I have added the follow up manually. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79778]: New comment added, and revision status changed
User "Bawolff" changed the status of MediaWiki.r79778. Old Status: fixme New Status: new User "Bawolff" also posted a comment on MediaWiki.r79778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79778#c17694 Commit summary: Comment in code says - truncate to 250 bytes, then add ellipse. but we don't add the ellipse, so change it to add the ellipse. The comment and code should be the same, and since we have the room might as well add the ellipse. This normally wouldn't affect much, since users with JS on will be prevented from adding that long a summary on the client side Comment: I changed truncate to work with any ellipse length in r84660. resetting to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89600]: Revision status changed
User "Krinkle" changed the status of MediaWiki.r89600. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89600#c0 Commit summary: test thead / tfooter contains th elements Implemented by r85922. Cover r85943. TEST PLAN: $ php parserTests.php --regex 'Table have th inside t' This is MediaWiki version 1.19alpha (r89594). Reading tests from "tests/parser/parserTests.txt"... Running test Table have th inside tfoot... PASSED Running test Table have th inside thead... PASSED Reading tests from "tests/parser/extraParserTests.txt"... Reading tests from "../mwexts/LabeledSectionTransclusion/lstParserTests.txt"... Passed 2 of 2 tests (100%)... ALL TESTS PASSED! $ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85029]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85029. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85029#c0 Commit summary: Fix class name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85180]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85180. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85180#c0 Commit summary: Removed archive(), deprecated and not used ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85181]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85181. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85181#c0 Commit summary: Removed deprecated Image class per documentation; no use in core or extensions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85943]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r85943. Old Status: fixme New Status: ok User "Hashar" also posted a comment on MediaWiki.r85943. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85943#c17693 Commit summary: Followup to r85922: Output th instead of td for tfoot Comment: committed tests with r89600 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85941]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85941. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85941#c0 Commit summary: Followup to r85922: Fix STRICT error, rmv redundant whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85943]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85943. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85943#c0 Commit summary: Followup to r85922: Output th instead of td for tfoot ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89311]: New comment added
User "Catrope" posted a comment on MediaWiki.r89311. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89311#c17692 Commit summary: Make user right selection in installer actually work, thanks Krinkle for spotting this Comment: + $groupRights .= "\$wgGroupPermissions['$group']['$right'] = " . + wfBoolToStr( $perm ) . "\n"; This is missing a trailing semicolon. Reported by Trilarion on IRC. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85985]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85985. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85985#c0 Commit summary: Followup to r85922: Adapt to MW-coding style ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85991]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85991. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85991#c0 Commit summary: Readd support for headings inside tables, broken in r85922 and reported on its CodeReview. Added testcase for it. It changes again Parser24. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86010]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86010. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86010#c0 Commit summary: Another evil test to join r86004 (didn't produce malformed output in the pre-r85922 parser) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86013]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86013. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86013#c0 Commit summary: Move and to its own line (unless it's an empty cell) Fixes the other r86004 test case and r86010 one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86039]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86039. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86039#c0 Commit summary: Fixing line-break issues with r85922 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86144]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86144. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86144#c0 Commit summary: r85922: Fixing another table bordercase ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85922]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r85922. Old Status: new New Status: resolved User "Hashar" also posted a comment on MediaWiki.r85922. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85922#c17691 Commit summary: Comment: Assuming this is resolved. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86746]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86746. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86746#c0 Commit summary: Move the Interwiki class to includes/interwiki/ to make way for a more flexible Interwiki system. Do this first since svn doesn't support editing and moving a file in the same commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86767]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86767#c0 Commit summary: Documentation and type hinting. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89263]: Revision status changed
User "Reedy" changed the status of MediaWiki.r89263. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89263#c0 Commit summary: * suggestion for ExtensionUpdater that would handle DB install/update of extension from DatabaseUpdater * could also generate default code for LocalSettingsGenerator * revert if silly :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86791]: Revision status changed
User "Hashar" changed the status of MediaWiki.r86791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86791#c0 Commit summary: Fix code accidentally committed in r86735 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89588]: New comment added
User "Reedy" posted a comment on MediaWiki.r89588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89588#c17690 Commit summary: * (bug 29287) Path searching input need a suggest list Adding API module to do code paths like a given prefix Comment: /trunk/extensions/CodeReview/api/ApiQueryCodePaths.php (from /trunk/extensions/CodeReview/api/ApiQueryCodeTags.php:89577) (added) (diff) What do you think? ;P ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87997]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r87997. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87997#c17689 Commit summary: * (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this Adding X-Content-Type-Options: nosniff header in WebStart.php so that it's *always* set, even for alternate entry points and when $wgOut gets disabled or overridden. Note that this of course doesn't apply to uploaded images and such loaded directly -- the usual caveats still apply. Have not tested to confirm that this actually protects against sniffing errors -- please test on IE8 and IE9. Comment: As a regression test, I suppose would need: # some sample dangerous files (as would get sent out via wfStreamFile through img_auth.php) and raw page contents (as via ?action=raw) # selenium...? or qunit...? -based tests that use a live wiki to upload the files/add the pages, then load them back, and confirm that an exploit code does *not* run with access to the local session # ... uhhh... maybe some way to disable all our other checks so those things can actually get turned on in the first place ;) A confirm-that-this-thing-works-in-general test could probably be done in the qunit tests, but could need a .php file or something to serve out the data. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89537]: Revision status changed
User "Reedy" changed the status of MediaWiki.r89537.
Old Status: fixme
New Status: reverted
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89537#c0
Commit summary:
* (bug 26597) Allow toggling of persistent cookies ("remember me") in API
action=login
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89589]: Revision status changed
User "Hashar" changed the status of MediaWiki.r89589. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89589#c0 Commit summary: * (bug 29287) Path searching input need a suggest list Adding index on (cp_repo_id, cp_path) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89537]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89537.
Old Status: new
New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r89537.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89537#c17688
Commit summary:
* (bug 26597) Allow toggling of persistent cookies ("remember me") in API
action=login
Comment:
Error:
ApiUploadTest::testLogin
MWException: Internal error in ApiBase::getParameterFromSettings: Boolean param
lgrememberme's default is set to '1'
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/GlobalFunctions.php:1060
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiBase.php:1205
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiBase.php:735
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiBase.php:530
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiMain.php:565
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiMain.php:663
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/includes/api/ApiMain.php:340
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/includes/api/ApiTestCase.php:41
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/includes/api/ApiUploadTest.php:41
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiTestCase.php:60
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/home/ci/cruisecontrol-bin-2.8.3/projects/mw/source/tests/phpunit/phpunit.php:60
ApiQueryTest
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89590]: New comment added
User "^demon" posted a comment on MediaWiki.r89590. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89590#c17687 Commit summary: Comment: Please remember to always add a commit summary :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89573]: Revision status changed
User "^demon" changed the status of MediaWiki.r89573. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89573#c0 Commit summary: add userinfo file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85104]: Revision status changed
User "Hashar" changed the status of MediaWiki.r85104. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85104#c0 Commit summary: * (bug 27893) Edit-on-doubleclick now applies only on view and purge actions; no longer triggers unexpectedly on delete, history etc. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87997]: New comment added
User "Hashar" posted a comment on MediaWiki.r87997. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87997#c17686 Commit summary: * (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this Adding X-Content-Type-Options: nosniff header in WebStart.php so that it's *always* set, even for alternate entry points and when $wgOut gets disabled or overridden. Note that this of course doesn't apply to uploaded images and such loaded directly -- the usual caveats still apply. Have not tested to confirm that this actually protects against sniffing errors -- please test on IE8 and IE9. Comment: Please? :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89588]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r89588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89588#c17685 Commit summary: * (bug 29287) Path searching input need a suggest list Adding API module to do code paths like a given prefix Comment: + $this->dieUsage( 'You don\'t have permission to view code tags', 'permissiondenied' ); + array( 'code' => 'permissiondenied', 'info' => 'You don\'t have permission to view code comments' ), Messages copied from other classes? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87997]: New comment added
User "Hashar" posted a comment on MediaWiki.r87997. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87997#c17684 Commit summary: * (bug 15461) Make IE8 turn off content sniffing. Everbody else should ignore this Adding X-Content-Type-Options: nosniff header in WebStart.php so that it's *always* set, even for alternate entry points and when $wgOut gets disabled or overridden. Note that this of course doesn't apply to uploaded images and such loaded directly -- the usual caveats still apply. Have not tested to confirm that this actually protects against sniffing errors -- please test on IE8 and IE9. Comment: Brion, can you possibly provide a test plan. I might have IE8 on one of my computer but I do not know how to test your patch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83418]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r83418. Old Status: ok New Status: new User "Hashar" also posted a comment on MediaWiki.r83418. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83418#c17683 Commit summary: r82867 converted $wgCaches into a class instance. Update the parsertests. This faking is needed to avoid Table 'unittest_objectcache' doesn't exist errors when using temporary tables. Comment: wrongly marked ok. Still need review. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83418]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83418. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83418#c0 Commit summary: r82867 converted $wgCaches into a class instance. Update the parsertests. This faking is needed to avoid Table 'unittest_objectcache' doesn't exist errors when using temporary tables. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83136]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83136. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83136#c0 Commit summary: More renames and splits for objectcache reorganisation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83617]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83617. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83617#c0 Commit summary: * Add a $count argument to wfIncrStats(), to allow it to increase the count by more than one at a time. * Added stats to job insert and pop. * Formalised live patch for UDP stats aggregation, adding $wgAggregateStatsID. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83634]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83634. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83634#c0 Commit summary: Rewrite the caching code in nextJobDB.php so that jobs-loop.sh has a chance of being able to exit from the "high-priority" loop. The current syndrome is that when the cache expires, a small number of high-priority jobs are added. These jobs are quickly cleared, but the job runners do not continue on to other things, because the cache keeps returning the same small list of wikis for 5 minutes. After 5 minutes, there are a few more jobs in the high-priority list, so the cycle continues. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83636]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83636. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83636#c0 Commit summary: Some bug fixes for r83634. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83640]: Revision status changed
User "Hashar" changed the status of MediaWiki.r83640. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83640#c0 Commit summary: Add --maxtime parameter to allow job runners to be limited by time instead of job count. This makes more sense when --procs is used. Using it on Wikimedia will reduce the effect of laggy slaves. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89300]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r89300. Old Status: new New Status: ok User "Hashar" also posted a comment on MediaWiki.r89300. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89300#c17682 Commit summary: Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete Comment: Great! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89300]: New comment added
User "Brion VIBBER" posted a comment on MediaWiki.r89300. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89300#c17681 Commit summary: Add some doc comments on Cookie::validateCookieDomain() and Http::isValidUri(), which both have some failing test cases and are incomplete Comment: Just run the Http test cases, you'll see them! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89347]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89347. Old Status: ok New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r89347. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89347#c17680 Commit summary: Fix for r89263: this to $this Comment: Reverted for now in r89586 along with parent r89263. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89297]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89297. Old Status: ok New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r89297. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89297#c17679 Commit summary: Not silly, but parser error (r89263)... fixing PHP Parse error: syntax error, unexpected T_STRING, expecting T_VARIABLE in ExtensionUpdater.php on line 7 Comment: Reverted for now in r89586 along with parent r89263. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86490]: New comment added
User "Krinkle" posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c17678 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cabal reverts :P * Tab is added to p-namespaces, not into the dropdown menu in p-cactions * Clicking again on the tab hides the overview. Comment: Nevermind about the max-width, if there are more than x items it's not redundant (which in most cases there will be). Nice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86490]: New comment added
User "Krinkle" posted a comment on MediaWiki.r86490. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c17677 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cabal reverts :P * Tab is added to p-namespaces, not into the dropdown menu in p-cactions * Clicking again on the tab hides the overview. Comment: + .css( 'max-width', Math.floor( Math.sqrt( $tr.size() ) ) * 30 ) This doesn't make sense to me. The end-result is an element with inline-styling max-width, and min-width (which may be higher) in the stylesheet. See http://i.imgur.com/QGOTl.png Also there seems to be some inconsistency with the colors (blue is reverted, dark grey is deferred). Can't the same classnames be used that style the table rows ? And a character "r" is added in front of all username.. ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89220]: New comment added, and revision status changed
User "Brion VIBBER" changed the status of MediaWiki.r89220. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r89220. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89220#c17676 Commit summary: Remove Cite singleton. Store it inside each associated parser at $parser->extCite This fixes bug 20748 and bug 15819 without breaking the other tests. Reverts r88971. The conflict with CategoryTree was the old problem of a message being called inside of a parser callback, this time with clearState for which the hook is global. Comment: So... make functions that match the expected prototypes and use them. Marking this as a fixme. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86490]: New comment added, and revision status changed
User "Krinkle" changed the status of MediaWiki.r86490.
Old Status: ok
New Status: fixme
User "Krinkle" also posted a comment on MediaWiki.r86490.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c17675
Commit summary:
Restore r84687 (reverted in r84751). Now with a few extra features:
* Now called 'overview' rather than 'scapmap', to hopefully prevent more
IRC-cabal reverts :P
* Tab is added to p-namespaces, not into the dropdown menu in p-cactions
* Clicking again on the tab hides the overview.
Comment:
mw.util.addPortletLink(
+ portlet,
+ '#',
+ 'Overview',
+ 'ca-scapmap',
+ 'Show a graphical overview of this list.',
+ '1',
+ '' // Nextnode, needs to be defined but we
actually don't care
+ );
lies, nextnode is not requires. Only the first three paramters are
[http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki.util/mediawiki.util.js?view=markup&pathrev=89349#l305
required].
A string is not a valid nextnode value and will either be ignored or cause a
useless jQuery object to be created.
Also '1' is allowed as accesskey, but did you intend it as an actual accesskey
or meant to skip it ?
These strings are hardcoded and not localized, please use mw.msg()
+#overviewmap #overviewpop {
Seems overly specific, unless there are going to be different contexts
#overviewpop is shorter and faster.
+ // WMF doesn't use live/not live ATM
+ // if( /mw\-codereview\-(not|)live/.test(
trc[j] ) )
+ // live = trc[j].substring( 14 );
+ if( trc[j].substring( 0, 21 ) ==
'mw-codereview-status-' ) {
..
+ //if( !totals[live] ) {
+ // totals[live] = 0;
+ //
This kind of code may be fine for an on-wiki gadget, but Wikimedia's
configuration is irrelevant for this extension.
If the status values options are needed, they should be exposed to the frontend
through mw.config.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89566]: New comment added
User "Bawolff" posted a comment on MediaWiki.r89566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89566#c17674 Commit summary: Followup r89564 Strip out the ?feed= functionality, update urls to point at the API! Comment: I think we should, simply because some people might just assume that you can add ?feed=atom to a special page to get a feed, since that works for most places you can get a feed, even for things like history pages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89584]: New comment added
User "MaxSem" posted a comment on MediaWiki.r89584. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89584#c17673 Commit summary: - Added preferences of type "number" - Improved validation - Minor bugfixes Comment: 'checker' => array( 'Gadget', 'isFloatOrInt' ) :You can safely use the PHP 5.2 syntax 'Gadget::isFloatOrInt' since 5.2.3 is a requirement now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89522]: Revision status changed
User "Hashar" changed the status of MediaWiki.r89522. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89522#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-05 19:19:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89579]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r89579. Old Status: new New Status: ok User "Hashar" also posted a comment on MediaWiki.r89579. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89579#c17672 Commit summary: fix eol-style (hopefully) Comment: looks good! Welcome :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81914]: Revision status changed
User "Hashar" changed the status of MediaWiki.r81914. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81914#c0 Commit summary: Kill calls to tooltip() and tooltipAndAccesskeyAttribs() from MonoBook and Modern ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81915]: Revision status changed
User "Hashar" changed the status of MediaWiki.r81915. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81915#c0 Commit summary: Follow up r81914. Don't build the manually. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81916]: Revision status changed
User "Hashar" changed the status of MediaWiki.r81916. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81916#c0 Commit summary: MonoBook is now tooltip() and tooltipAndAccesskeyAttribs() free! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81960]: New comment added
User "Hashar" posted a comment on MediaWiki.r81960. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81960#c17671 Commit summary: Since 1.17 a whole lot of extensions have sprouted *.i18n.magic.php files. Most of these files have entries which erroneously omit the English synonym for a magic word. This breaks the extension completely when an affected language is selected. This patch automatically includes synonyms from the fallback localisation, and prevents the case flag from being overridden, thus making extensions resistant to translator error. Comment: With all the follow up, and since it got merged to live site, can we assume this revision is now ok ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82497]: Revision status changed
User "Hashar" changed the status of MediaWiki.r82497. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82497#c0 Commit summary: mw.loader.implement now calls script without setting mw to mediaWiki since this is already globally avaiable * Also shortens a few wrapper functions the same way * Partial revert of r82496. Apparantly mw-alias is not available in startUp module. TODO: Find out why ? (See also r82496 commit message) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82496]: Revision status changed
User "Hashar" changed the status of MediaWiki.r82496. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82496#c0 Commit summary: Using the mw alias for mediaWiki in core. Saves bandwidth and makes sense (there's no point in a wrapper function for ($,mw) if we use jQuery and mediaWiki inside of it). TODO: Since the alias is globally available from the start, the 'mw' argument in the wrapper is redundant, so that should be removed at some point as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81267]: Revision status changed
User "Hashar" changed the status of MediaWiki.r81267. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81267#c0 Commit summary: Fixups to r81266 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88911]: New comment added
User "Hashar" posted a comment on MediaWiki.r88911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88911#c17670 Commit summary: Follow-up r81536: Fix misleading comment in Status and add a comment to LocalFileRestoreBatch::cleanupFailedBatch. Comment: tagging for 1.17 inclusion since it followup r81536 which fixes a possible data lost ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81536]: New comment added
User "Hashar" posted a comment on MediaWiki.r81536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81536#c17669 Commit summary: (bug 19751) Filesystem is now checked during image undeletion * FSRepo::storeBatch() now does an sha1 check unless SKIP_VALIDATION flag is set * Introduced Status::$success in addition to Status::$successcount ** FSRepo::storeBatch() now logs success/failure in this variable * LocalFileRestoreBatch now aborts on failure in FSRepo::storeBatch() and cleans up the already copied files ** Introduced FSRepo::cleanupBatch() for this purpose * SpecialUndelete now aborts if LocalFile::restore() gives a fatal Comment: tagging for 1.17 inclusion since it fixes a possible data lost ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81549]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r81549. Old Status: new New Status: ok User "Hashar" also posted a comment on MediaWiki.r81549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81549#c17668 Commit summary: * (bug 27083) Extension info for Special:Version can include '...' as a special value which is turned into the localized 'others' used for Special:Version author lists. Comment: I do not really like the hack, but it seems good enough anyway. I have documented the change on the wiki: http://www.mediawiki.org/w/index.php?title=Manual:$wgExtensionCredits&diff=408056&oldid=399238 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81034]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r81034. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81034#c17667 Commit summary: First round of $wgArticle removals Comment: Just make sure SQL queries don't increase due to fragmenting process cache. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81579]: Revision status changed
User "Hashar" changed the status of MediaWiki.r81579. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81579#c0 Commit summary: Follow up r81549 to use ... for getting the localized 'others' on extensions not using links or a localised message for that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81034]: New comment added
User "Hashar" posted a comment on MediaWiki.r81034. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81034#c17666 Commit summary: First round of $wgArticle removals Comment: Why do we have to initialize a new article object at the skin level? To me, it looks like a waste of CPU cycles. Can't we just pass the skin the options it needs ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89573]: New comment added, and revision status changed
User "Reedy" changed the status of MediaWiki.r89573. Old Status: new New Status: fixme User "Reedy" also posted a comment on MediaWiki.r89573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89573#c17665 Commit summary: add userinfo file Comment: Please fix your [[Subversion/auto-props|auto props]], and then fix this file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89549]: Revision status changed
User "Reedy" changed the status of MediaWiki.r89549. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89549#c0 Commit summary: follow up r89513: avoid internal error when only invalid revids/pageids are passed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89569]: New comment added
User "Yaron Koren" posted a comment on MediaWiki.r89569. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89569#c17664 Commit summary: Follow-up to r89547 - re-added compatibility with MW < 1.9 Comment: Exactly, that was my thinking. :P I meant 1.19, of course, in case anyone was confused. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89569]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r89569. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89569#c17663 Commit summary: Follow-up to r89547 - re-added compatibility with MW < 1.9 Comment: 1.8 would be pretty old :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89570]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89570. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89570#c0 Commit summary: Fixing one thing breaks another one.. I hope this doesn't break anything :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89566]: New comment added
User "Reedy" posted a comment on MediaWiki.r89566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89566#c17662 Commit summary: Followup r89564 Strip out the ?feed= functionality, update urls to point at the API! Comment: The only thing about this commit, is if we should keep ?feed=blah and HTTP 301 redirect it or something? :/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
On Mon, Jun 6, 2011 at 4:21 PM, Aryeh Gregor wrote: > Hmm, interesting approach. Basically a postprocessor like I was > thinking of, except simpler. I was thinking you'd insert special > markers into the HTML that you'd replace later. But I can't think of > any ways you'd get mismatches with your method, given that the parser > outputs reasonably simple HTML -- in particular, no comments or >
Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
On Sun, Jun 5, 2011 at 6:22 PM, Platonides wrote: > If the user has a stub threshold different than 0, SELECT > page_namespace,page_title FROM pagelinks JOIN page ON ... WHERE > pl_from=$this->mArticleId AND page_len < $user->getStubThreshold(); > > For each of those stub pages: $a = Linker::Link() (ignoring stub > threshold), $b = Linker::Link() (as stub). > Extract the open tag from $a and $b. > str_replace $a with $b in the html. > > Bypassing the whole parsing structure in that way is not pretty, but > it's really efficient. Hmm, interesting approach. Basically a postprocessor like I was thinking of, except simpler. I was thinking you'd insert special markers into the HTML that you'd replace later. But I can't think of any ways you'd get mismatches with your method, given that the parser outputs reasonably simple HTML -- in particular, no comments or
Re: [Wikitech-l] HTML5 on Wikimedia wikis
On Mon, Jun 6, 2011 at 12:09 AM, MZMcBride wrote: > Aryeh mentioned that Wikimedia wikis still aren't using HTML5. I know it was > enabled a few times and is currently disabled. As far as I remember, the > biggest issue was third-party tools and such, which seemed solvable by > announcing the change early (letting any developers know that > test.wikipedia.org is using HTML5 currently, of course) and then making the > switch a few weeks later. Is that generally correct, and if so, can we start > that process? If that's not correct, what are the outstanding issues? There are three major classes of issues that are likely to arise: 1) Visual artifacts due to switching from an almost-standards doctype to a standards doctype. 2) Breakage of XML parsing due to the doctype not having a DTD that includes HTML entities. 3) Bugs in features that are $wgHtml5-only, which haven't been tested on Wikipedia until now. The way to go about switching would be to first change from an XHTML Transitional doctype to XHTML Strict. That will trigger only issues of type (1), which should be minor and easy to fix. Once that's working, switch to , still without enabling $wgHtml5. This will probably cause XML-based screen scrapers to break due to stray named entities. Developers should be on hand to track down and promptly fix any hitherto-unspotted sources of named entities. This will probably cause temporary breakage of various bots, but it shouldn't be for long if there's adequate notice and developers are on hand to fix problems as soon as they're reported. Finally, switching $wgHtml5 to true will actually enable all the HTML5 features, which is the goal. This will probably cause a variety of minor issues, such as breaking regex screen-scrapers and changing appearance or features slightly in a bunch of ways. Unless there are major regex screen-scrapers that happen to be expecting things like type="text/css" that are removed when $wgHtml5 is true, this probably won't cause any big issues, but if we want to be on the safe side, people should be paying attention when the switch is flipped just in case. The two times $wgHtml5 has been enabled before, it had to be shut off due to (2), so I suspect that's the biggest issue. (1) and (3) are likely to be minor. But it shouldn't be a huge deal to switch, with a little planning and preparation, if someone with shell access and a developer or two are interested. The changes themselves are trivial, you just need someone who knows about the potential issues to be on hand to fix them as they're reported and deploy the fixes. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
