[MediaWiki-CodeReview] [Wikimedia r205]: New comment added

[MediaWiki Mail]

User "Awjrichards" posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18922
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:

You've already caught this in a 'Fixme' note, but this should be fixed before 
this ready for production:
/trunk/fundraiser-analysis/classes/DataLoader.py line 432 - potential for 
divide by 0
I'm forgetting where, exactly

This may or may not actually be a problem, but in run_query() on line 544 of 
DataLoader, it looks like there's the possibility for executing arbitrary sql 
files (line 561).  This is probably not that big of a deal, but it's possible 
that directory traversal could be somehow exploited here to execute undesirable 
sql files.  Perhaps this is guarded against wherever this class gets used or is 
otherwise a non-issue depending on implementation, but wanted to raise this as 
a potential issue.

Are the db queries in DataLoader.py TestTableLoader, SquidLogTableLoader, 
ImpressionTableLoader, LandingPageTableLoader safe from potential SQL 
injection? Tough for me to tell from the code - but you may need to escape 
variable data going into those queries.



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Code Review for 1.18

[Ashar Voultoiz]

On 29/06/11 03:03, Mark A. Hershberger wrote:
> Although r47450 is from February 18, 2009, so I'm not sure what the deal
> is there.

Someone is copy pasting the same .html file on each release over and 
over since the tool was created :-)

-- 
Ashar Voultoiz


___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added

[MediaWiki Mail]

User "Hashar" posted a comment on MediaWiki.r90943.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18921
Commit summary:

Disable ns selector checkboxes when 'all' namespace is selected
* based on an idea by Aaron on r90866
* comes with QUnit test
* expect the special 'all' namespace to be the first in the list
* function build on mediawiki.special form r90941

Comment:

Thank you both for the fast code review :-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91037]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91037.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91037#c0
Commit summary:

Stylize and fix some indenting

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91021]: New comment added

[MediaWiki Mail]

User "Yaron Koren" posted a comment on MediaWiki.r91021.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91021#c18920
Commit summary:

Removed setting of hidden field for 'title' value - no longer necessary (?), 
and it caused problems in wikis in certain languages - perhaps all languages 
where the translation of the "Special" namespace contains non-Latin characters

Comment:

Thanks! Somehow, your suggested code works while mine failed. I added it in, in 
r91050.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91049]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91049.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91049#c0
Commit summary:

gah, proper EOL style on INSTALL...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r205]: New comment added

[MediaWiki Mail]

User "Awjrichards" posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18919
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:

When user input might be displayed back to the user, you should make sure it is 
escaped to prevent XSS (take a look at the XSS section here: 
http://www.djangobook.com/en/beta/chapter20/)  This is an issue in some of the 
template files, for instance 
/trunk/fundraiser-analysis/web_reporting/templates/tests/index.html and I 
suspect this is an issue in others as well.

Also, dunno if you're using LML in the django project, but I see unescaped user 
input in there as well - in 
/trunk/fundraiser-analysis/web_reporting/LML/views.py

I'll be taking a look at the DataLoader/DataHelper and other classes later.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r205]: New comment added

[MediaWiki Mail]

User "Renklauf" posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18918
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:

Added general settings files, follow up r212
Removed hard coded path reference, follow up r213
Escaped front end user input, follow up r207

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] Help wanted: Wikimedia engineering/product hiring

[Erik Moeller]

Hello folks,

we have 12 open positions in Wikimedia engineering right now, and a
few more will go up in coming weeks. If you have connections, we'd
appreciate your help hiring for these roles, forwarding this note to
appropriate listservs, tweeting it, etc.

The full listing is at
http://wikimediafoundation.org/wiki/Job_openings , but here are some
key roles that we need help with:

1) Product Managers: We're looking for great people to act as product
owners for three very important initiatives:

- New editor engagement: helping Wikimedia to attract, nurture and
retain new contributors.
- Analytics: supporting the development of systems and tools for
measuring our impact.
- Mobile: helping us reach hundreds of millions of people on mobile
devices and engaging hundreds of thousands of them to contribute in
useful ways.

The product manager role at WMF entails grooming and prioritizing the
product backlog, engaging with the Wikimedia community, commissioning
and organizing research, hands-on testing, but also helping with
across-the-board priorities triage for ongoing product development.

These folks don't have to be product managers by trade, but they need
to be comfortable negotiating compromise while holding the product
vision. They need to treat engineers as equal partners, and be
excellent communicators. Ideally they have strong domain expertise
relevant to their focus area.

We have two of these currently posted:
http://wikimediafoundation.org/wiki/Job_openings/Product_Manager_(Features)
http://wikimediafoundation.org/wiki/Job_openings/Product_Manager_(Analytics)

The mobile one will go up soon, and we'll refine the definition
further. But please use these as reference points for now.

2) Analytics Engineers: We're hiring for two systems engineers to
build out our analytics infrastructure. What exists so far is still
fairly rudimentary, so we need to build scalable logging and tracking
systems for various purposes, e.g.

- geographic breakdown of access and editing activity
- usage data for specific features; A/B testing of features
- search activity, real-time editor retention measures, new activity
visualizations, and more ..

The ideal candidate here likely is someone who's very strong building
out large scale distributed systems, and has experience with NoSQL
technologies, distributed computing, etc.

The relevant JD is here:
http://wikimediafoundation.org/wiki/Job_openings/Systems_Engineer_-_Data_Analytics

3) A strong QA Lead who can help us write and perform test plans with
shoestring and duct tape, i.e. using a combination of test automation,
work with outside vendors, and volunteer-driven testing to strengthen
our product quality. The relevant JD is here:

http://wikimediafoundation.org/wiki/Job_openings/QA_Lead

4) Strong frontend and backend engineers: for features development,
code review, deployment and release management support, and so forth.
Demonstrable open source experience is always a major plus, and while
PHP is learnable, not being predisposed against it helps. :-)

http://wikimediafoundation.org/wiki/Job_openings/Software_Developer_Frontend_(General)
http://wikimediafoundation.org/wiki/Job_openings/Software_Developer_Backend_(General)

Your outreach and support is always appreciated.

All best,
Erik

-- 
Erik Möller
Deputy Director, Wikimedia Foundation

Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [Wikimedia r209]: New comment added

[MediaWiki Mail]

User "Renklauf" posted a comment on Wikimedia.r209.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/209#c18917
Commit summary:

Initial import.

Comment:

very much so ... for some reason my eclipse env wrote a duplicate.  this will 
be fun to delete :S

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91038]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91038.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91038#c0
Commit summary:

add $wgMemc as global

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r210]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r210.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/210#c0
Commit summary:

Updated comments for config

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r209]: New comment added

[MediaWiki Mail]

User "Awjrichards" posted a comment on Wikimedia.r209.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/209#c18916
Commit summary:

Initial import.

Comment:

I assume this was an oops?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r208]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r208.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/208#c0
Commit summary:

Removed reference to harcoded path

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r207]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r207.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/207#c0
Commit summary:

performed Escaping of front end user input

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r206]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r206.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/206#c0
Commit summary:

Updated comments for config

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Code Review for 1.18

[Mark A. Hershberger]

MZMcBride  writes:

> Your bounds seem a little strange here. I don't understand the lower bound
> in particular. Is there some special significance to r47450?

If you look at the CRstats page
(http://toolserver.org/~robla/crstats/crstats.118all.html), you'll see
the bounds match the ones given on that page:

Below is a history of commits and state changes to /trunk/phase3
between r47450 and r87529 since June 1, 2009.

Although r47450 is from February 18, 2009, so I'm not sure what the deal
is there.

Mark.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [Wikimedia r205]: New comment added

[MediaWiki Mail]

User "Awjrichards" posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18900
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:

This is also true with:
/trunk/fundraiser-analysis/web_reporting/settings.py


In /trunk/fundraiser-analysis/web_reporting/manage.py line 5 you have: 

sys.path.append('/home/rfaulkner/trunk/projects/')

It's probably better to not have hardcoded local paths - as wherever this code 
gets checked probably won't have that path in existence and/or it may not 
contain what you expect :p

You have two separate copies of jquery in the same django project - this is 
probably not good practice.

In /trunk/fundraiser-analysis/web_reporting/tests/views.py (add_comment() and 
test() in particular), you are taking user input and performing various actions 
(eg database queries and redisplaying/rendering user input back to the user) 
without sanitizing the values.  This opens a number of vulnerabilities (XSS and 
SQL injection, primarily).  See 
http://www.mediawiki.org/wiki/Security_for_developers for more info.  I imagine 
Django provides some nifty way to sanitize user input.  

Gotta run to a mtg, will ad more later.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91036]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91036.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91036#c0
Commit summary:

MFT r91031: filepage.css fixes

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90941]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r90941.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90941#c0
Commit summary:

mediawiki.special as a dumb JS object

It will be extended later on.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r91031.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c18915
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

Comment:

Yeah, no edit conflicts on CR ;-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r91031.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c0
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r91031.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c18914
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

Comment:

(I'm re-marking this OK assuming your comment submission reset it to new by 
accident. Revert if it was on purpose)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91034]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91034.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91034#c0
Commit summary:

adding api version info

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r68904]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r68904.

Old Status: ok
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c0
Commit summary:

(bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign 
client wikis.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r91031.

Old Status: ok
New Status: new

User "^demon" also posted a comment on MediaWiki.r91031.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c18913
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

Comment:

Not really a regression, but should be backported since it was a problem with 
the original implementation.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r91031.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c0
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91035]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r91035.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91035#c0
Commit summary:

Followup r91034

svn:keywords Id
svn:eol-style native

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r91031.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c18912
Commit summary:

(bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to 
r68904. Yay Roan finally taught me how to use the resourceloader :D

Comment:

Since it's a regression afaig, tagging for backport (to 1.17wmf1 asap)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91033]: New comment added, and revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91033.

Old Status: new
New Status: ok

User "Reedy" also posted a comment on MediaWiki.r91033.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91033#c18911
Commit summary:

Follow-up r90902: Parse error

Comment:

Oh, that explains it...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r86705.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18901
Commit summary:

* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results

Comment:

I've got all tests passing as of r91027. Reedy, I don't know what your problem 
is ;-)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91028]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r91028.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91028#c0
Commit summary:

Adding my USERINFO file

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90747]: New comment added

[MediaWiki Mail]

User "RussNelson" posted a comment on MediaWiki.r90747.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90747#c18910
Commit summary:

getPath() does the wrong thing under SwiftMedia, but getRel() works for 
everything.

Comment:

Yes, it implicitly gets you a read-only copy of the file. I've audited all the 
(checked-in) code which calls File::getPath() and I see no problem with adding 
this semantic to it. There are *many* places where one piece of code or another 
expect the file to have local filesystem semantics. Fortunately, they all 
gateway through File::getPath(), so I think we can "refactor" by changing the 
API. We just say that people shouldn't expect File::getPath() to be lightweight 
on the first call.  The copy is cached, so subsequent calls are lightweight.

There's a LOT of duplicated code in SwiftFile which will be deleted on the 
checkin I'm about to do.  Just reviewing the diff for sanity before I commit.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91021]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r91021.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91021#c18903
Commit summary:

Removed setting of hidden field for 'title' value - no longer necessary (?), 
and it caused problems in wikis in certain languages - perhaps all languages 
where the translation of the "Special" namespace contains non-Latin characters

Comment:

Are you sure this wont break it for people with index.php-style urls?

The normal way to do this is
 Html::hidden( 'title', $this->getTitle()->getPrefixedText() );

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83907]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r83907.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83907#c18909
Commit summary:

Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and 
also to allow a 'flat list' of options

Comment:

It doesn't need to stay hidden. As long ad it is there we know the form is 
"posted",

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83907]: New comment added

[MediaWiki Mail]

User "Happy-melon" posted a comment on MediaWiki.r83907.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83907#c18908
Commit summary:

Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and 
also to allow a 'flat list' of options

Comment:

It wouldn't stay hidden for very long, since all the GET parameters are munged 
into the url on form submission.  That's broadly what is happening in 
action=edit verses action=submit, and it's always seemed a 
very clunky method to me.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90747]: New comment added

[MediaWiki Mail]

User "Brion VIBBER" posted a comment on MediaWiki.r90747.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90747#c18907
Commit summary:

getPath() does the wrong thing under SwiftMedia, but getRel() works for 
everything.

Comment:

If I understand right, this is because SwiftFile::getPath() implicitly copies 
the file to the local filesystem?

I honestly find that pretty worrying; getPath() is not expected to have 
open-ended side effects like that, and this may indicate that the File & 
LocalFile APIs aren't actually very suitable for accessing remote files... 
should it be refactored to include explicit concepts of checking out a 
temporary local file and removing it when done? It looks like the file path 
will be implicitly deleted when the SwiftLocalFile object is destroyed, which 
should keep from leaking on batch operations, but that might still mean a lot 
of unexpected copies being made and deleted.

I also see a fully duplicated getHistory method which has had a couple bits 
swapped out. (It kinda looks like all it needs to do is set 
$this->oldFileFromRowFactory on the SwiftRepo -- which appears to already be 
done -- and then just inherit the entire LocalFile::getHistory method?)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r86705.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18902
Commit summary:

* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results

Comment:

Computers.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r68904.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c18906
Commit summary:

(bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign 
client wikis.

Comment:

Note that the shared repo already has html injection powers if you are fetching 
its description. But instead of including from there, I think the shared repo 
should list the headers that should be added. For instance a  tag 
is not properly rendered since the associated CSS is not present on the other 
sites.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90759]: New comment added

[MediaWiki Mail]

User "Brion VIBBER" posted a comment on MediaWiki.r90759.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90759#c18905
Commit summary:

Let $wgCategoryCollation take a class name as a value so that extensions
can define new Collation classes.

(I plan to commit such an extension shortly)

Wasn't sure if it would be better to make an array mapping collation names => 
class names
instead. However, that seemed to be unneededly complicated so I went with
letting that variable take class names.

Comment:

Could also do this by adding a wfRunHooks call in Collation::factory to handle 
unknown names. This would let extensions add arbitrarily-named collations, 
including accepting parameters (maybe 'myfunkycollation:uppercase' to make 
something that piggybacks on top of another collation, or to accept a 
language-specific parameter). The extension can then pass whatever values it 
needs to the object constructor and simply return the object.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90767]: New comment added

[MediaWiki Mail]

User "Brion VIBBER" posted a comment on MediaWiki.r90767.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90767#c18904
Commit summary:

Correct alignment for RevisionDelete button

Comment:

You know, we really ought to be able to do most of these alignment thingies 
with CSS classes these days... We might want to look into that before changing 
all instances.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89778]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r89778.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89778#c0
Commit summary:

* (bug 29322) Move some iframe-specific code in WikiEditor JS to its proper 
module

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81816]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r81816.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81816#c0
Commit summary:

* Add a amtitle param to meta=allmessages

Only used used when amenableparser is passed; the user can now define the page 
used for {{PAGENAME}} and related stuff instead of being hardcoded to "API"

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] IRC Bug Triage now

[Mark A. Hershberger]

We'll be holding a public IRC bug triage in about 2-3 minutes on
#wikimedia-dev for all who are interested.  We will be using
http://etherpad.wikimedia.org/BugTriage-2011-06 to keep notes as well.

See you there!

Mark.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r87847]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r87847.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87847#c0
Commit summary:

* (bug 26306) Cleaned up stray jquery, jquery.ui, and jquery.json copies in 
Collection extension

jquery & jquery.ui copies here were unused -- already replaced with references 
to core.
jquery.json is also available in core, so switched to using the core copy of 
that too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Code Review for 1.18

[MZMcBride]

Mark A. Hershberger wrote:
> The number of un-reviewed revisions for 1.18 has dropped below 500 for
> all of /trunk and below 200 for phase3:
> 
> mysql> select count(*),cr_status from code_rev where cr_repo_id = 1 \
>and cr_id > 47450 and cr_id < 87529 and cr_path like \
>'/trunk%' group by cr_status;
> +--+---+
> | count(*) | cr_status |
> +--+---+
> |13951 | deferred  |
> |   82 | fixme |
> |  339 | new   |
> |16534 | ok|
> | 1240 | old   |
> | 1585 | resolved  |
> |  793 | reverted  |
> +--+---+
> 7 rows in set (0.06 sec)
> mysql>

Your bounds seem a little strange here. I don't understand the lower bound
in particular. Is there some special significance to r47450? The upper bound
would most logically be r87519 given the "Branch points" document.[1]
Clarification on the meaning behind these values would be appreciated. :-)

MZMcBride

[1] http://www.mediawiki.org/wiki/Branch_points



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r83795]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r83795.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83795#c18899
Commit summary:

Follow-up r83794, r83792: restore new SpecialBlock.php code from r83786.  This 
revision should *not* be broken :D

Comment:

r83792 doesn't seem to have anything to do with this.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] should we join the Unicode Constortium?

[Russell N. Nelson - rnnelson]

Go for it. Def not in our interest to spend money, but if it's just a "our 
interests are aligned" then it's only true.

From: wikitech-l-boun...@lists.wikimedia.org 
[wikitech-l-boun...@lists.wikimedia.org] on behalf of Ryan Kaldari 
[rkald...@wikimedia.org]
Sent: Tuesday, June 28, 2011 5:00 PM
To: wikitech-l@lists.wikimedia.org
Subject: Re: [Wikitech-l] should we join the Unicode Constortium?

BTW, I found out that liaison membership in the Unicode Consortium is
free (and doesn't require us to do anything specifically). You just have
to convince them that the membership would be beneficial to both
organizations. Since it sounds like no one objects, I'd be happy to go
ahead and write something up and get in touch with them about it.

Ryan Kaldari

On 6/27/11 6:18 PM, jida...@jidanni.org wrote:
>> "AG" == Aryeh Gregor  writes:
> AG>  It looks like it would cost $7,900 a year in dues
> I think that would set a bad precedent for the way you fellows spend
> your money. Next thing you know people will say you joined A, now why
> don't you join B, even more worthy, etc. P.S., It is spelled Consortium.
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r83907]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r83907.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83907#c18898
Commit summary:

Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and 
also to allow a 'flat list' of options

Comment:

Can you make a hidden value to GET forms that would tell if the the form has 
been submitted or not?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91025]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r91025.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91025#c0
Commit summary:

contents moved to repository 
http://svn.wikimedia.org/viewvc/wikimedia/trunk/fundraiser-analysis/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r83907]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r83907.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83907#c0
Commit summary:

Some tweaks to HTMLMultiSelect form to make it play nicely with GET forms, and 
also to allow a 'flat list' of options

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90856]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90856.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90856#c0
Commit summary:

Remove disableaccount stuff from r77558. Left out from r86146 reverts.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81190]: New comment added, and revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r81190.

Old Status: new
New Status: ok

User "Reedy" also posted a comment on MediaWiki.r81190.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81190#c18897
Commit summary:

Follow-up r81074: succumb, though it breaks my heart to do so (:P), to American 
linguistic imperialism...

Comment:

British English, fuck yeah!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90855]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r90855.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90855#c18896
Commit summary:

Follow-up r90749: use a new 'autopromote' action for the autopromote rights log 
entries. Removed the 'rightsautocomment' msg.

Comment:

Should use tabs in trunk/phase3/maintenance/language/messages.inc. 


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91022]: New comment added

[MediaWiki Mail]

User "RussNelson" posted a comment on MediaWiki.r91022.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91022#c18895
Commit summary:

UploadStashFile::__construct() can't assume that the mwrepo-produced paths 
match the temp zone.

Comment:

The only change is that the checks on the pathname are skipped if the path came 
from a virtual url. In particular, Swift is returning an actual local pathname 
(which are always temporary anyway), which doesn't match the temp zone (which 
is an actual Swift container whose name doesn't match /tmp).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r79905]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r79905.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79905#c0
Commit summary:

Convert LQT to resource loader.

This probably needs more work, but will do the job for now.
Mostly fixes #20934 because resourceloader automatically rtl's when needed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r205]: New comment added, and revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r205.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on Wikimedia.r205.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/205#c18894
Commit summary:

moving the contents of 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/fundraiser-statistics/fundraiser-scripts/
 for fundraiser analytics and reporting to the wikimedia repository

Comment:


/trunk/fundraiser-analysis/settings.py

You should generecize this file  - you don't want to be checking in login 
credentials or other sensitive configuration settings, even if they'll only 
work on your local machine.  It's bad practice.  One way to get around this is 
to create an 'example' config file - eg settings.py.example - where you have 
sample values for configuration directives.  Then, on whatever system you're 
running the code, you set up individual and local-only copies of the config 
file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added, and revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r90943.

Old Status: fixme
New Status: resolved

User "Brion VIBBER" also posted a comment on MediaWiki.r90943.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18893
Commit summary:

Disable ns selector checkboxes when 'all' namespace is selected
* based on an idea by Aaron on r90866
* comes with QUnit test
* expect the special 'all' namespace to be the first in the list
* function build on mediawiki.special form r90941

Comment:

Ok, all looks good. marking resolved. :D

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90991]: Revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r90991.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90991#c0
Commit summary:

rename test for the ns selector checkboxes

follow up r90943

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90990]: New comment added

[MediaWiki Mail]

User "Brion VIBBER" posted a comment on MediaWiki.r90990.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c18892
Commit summary:

Find 'all' special ns regardless of its rank in the select

This is done by looking for an  element with an empty string value
which denote the special case 'all'.
Also removed a comment in Xml.php asking to keep 'all' as a first element
since it is no longer needed.

Follow up r90943 (comment 18872 by Brion)

Comment:

Shortcut: you can just use $select.val() rather than diving in to find the 
selected option element manually.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90681]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r90681.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90681#c0
Commit summary:

trimming all lines to 80 chars per coding conventions

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90986]: Revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r90986.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90986#c0
Commit summary:

per r90984 CR, cleaner this way

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90740]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r90740.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90740#c0
Commit summary:

Export special page alias for 'fa' for bug 29563

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90990]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r90990.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c0
Commit summary:

Find 'all' special ns regardless of its rank in the select

This is done by looking for an  element with an empty string value
which denote the special case 'all'.
Also removed a comment in Xml.php asking to keep 'all' as a first element
since it is no longer needed.

Follow up r90943 (comment 18872 by Brion)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90858]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r90858.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90858#c18891
Commit summary:

Make parser->getFunctionLang be dependent on title->getPageLanguage() instead 
of $wgContLang, i.e. the page content language instead of the wiki content 
language. This sets the right language on page view + edit for all pages, 
instead of only edit preview on MediaWiki namespace pages (as in EditPage.php).

Comment:

It makes the parser integrate more tightly with the titles.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90792]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r90792.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90792#c0
Commit summary:

Extension to load a different version of jQuery without hacking core. Hooks 
into startup module and loads a WikiModule for MediaWiki:JQuery.js instead

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90795]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r90795.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90795#c0
Commit summary:

Follow-up r90792: typo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90795]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r90795.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90795#c0
Commit summary:

Follow-up r90792: typo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90925]: Revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r90925.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90925#c0
Commit summary:

Follow-up r90742: the parser should call getFunctionLang()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r86705.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18890
Commit summary:

* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results

Comment:

I've got the same failure as Brion, both Sqlite and Mysql. Problem is $this->db 
isn't defined until run(). Could possibly try moving that back into setUp() 
again, but it broke horribly last time I tried.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r86705.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18889
Commit summary:

* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results

Comment:

Sounds like you might be missing some files there in phpunit, not our suite.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91019]: Revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r91019.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91019#c0
Commit summary:

Use getLatest() accessor

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r86705.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c1
Commit summary:

* Remove manual query building in search mysql
* Remove reference to mysql3, no longer supported
* Changed method signatures, I found no class extending this class in extensions
* Tested lightly and returns same results

Comment:

php phpunit.php includes/search/SearchDbTest.php 
PHPUnit 3.5.14 by Sebastian Bergmann.

.

Time: 13 seconds, Memory: 75.00Mb

OK (5 tests, 16 assertions)


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r79417]: New comment added

[MediaWiki Mail]

User "Helder.wiki" posted a comment on MediaWiki.r79417.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/79417#c18887
Commit summary:

Make LiquidThreads use relative URLs instead of absolute URLs.
Fixes bug #26526

Comment:

Could someone replicate these fixes to the version which is in use on 
Portuguese Wikibooks? I'm still seeing the icons on pages like 
[https://secure.wikimedia.org/wikibooks/pt/w/index.php?uselang=en&title=Wikilivros:LiquidThreads#Opini.C3.B5es.2C_testes_e_relatos_de_bugs
 this]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91018]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r91018.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91018#c0
Commit summary:

Use title accessor

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] IRC Bug Triage

[Mark A. Hershberger]

Niklas Laxström  writes:

> On 28 June 2011 01:28, Mark A. Hershberger  wrote:
>> Tomorrow is the first IRC bug triage (finally!).  We'll start the
>> meeting at 2300 UTC (see http://hexm.de/44 for the UTC impaired, like
>> myself).
>
> Does tomorrow mean Tuesday - today for me? Better to always include
> the date too.

Sorry, yes.  And now it is only 1.5 hours away.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r90996]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r90996.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90996#c18886
Commit summary:



Comment:

Please always write a commit message. Extension messages should be prefixed to 
avoid conflict with core messages.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[Wikitech-l] Code Review for 1.18

[Mark A. Hershberger]

The number of un-reviewed revisions for 1.18 has dropped below 500 for
all of /trunk and below 200 for phase3:

mysql> select count(*),cr_status from code_rev where cr_repo_id = 1 \
   and cr_id > 47450 and cr_id < 87529 and cr_path like \
   '/trunk%' group by cr_status;
+--+---+
| count(*) | cr_status |
+--+---+
|13951 | deferred  |
|   82 | fixme |
|  339 | new   |
|16534 | ok|
| 1240 | old   |
| 1585 | resolved  |
|  793 | reverted  |
+--+---+
7 rows in set (0.06 sec)
mysql>

This is great news!

From this and
, It looks
like we *could* drive the number of “new” revisions to 0 by the end of
the week.

That would be stunning.

Mark.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r90921]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90921.

Old Status: fixme
New Status: ok

User "^demon" also posted a comment on MediaWiki.r90921.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90921#c18885
Commit summary:

use new $wgExiv2Command global. Already defined in DefaultSettings so in 
default/unix case, no need to redefine it.

Comment:

Yeah ignore me.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90921]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90921.

Old Status: new
New Status: fixme

User "^demon" also posted a comment on MediaWiki.r90921.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90921#c18884
Commit summary:

use new $wgExiv2Command global. Already defined in DefaultSettings so in 
default/unix case, no need to redefine it.

Comment:

If this is already set in DefaultSettings, why are you overriding it here? Same 
thing with $wgImageMagickConvertCommand.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90997]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90997.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90997#c0
Commit summary:

Localisation updates for ToolserverI18N messages from translatewiki.net 
(2011-06-28 21:03:00)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] should we join the Unicode Constortium?

[Ryan Kaldari]

BTW, I found out that liaison membership in the Unicode Consortium is 
free (and doesn't require us to do anything specifically). You just have 
to convince them that the membership would be beneficial to both 
organizations. Since it sounds like no one objects, I'd be happy to go 
ahead and write something up and get in touch with them about it.

Ryan Kaldari

On 6/27/11 6:18 PM, jida...@jidanni.org wrote:
>> "AG" == Aryeh Gregor  writes:
> AG>  It looks like it would cost $7,900 a year in dues
> I think that would set a bad precedent for the way you fellows spend
> your money. Next thing you know people will say you joined A, now why
> don't you join B, even more worthy, etc. P.S., It is spelled Consortium.
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r84427]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r84427.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84427#c0
Commit summary:

Ugly bug 24375 hack

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90641]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of MediaWiki.r90641.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90641#c0
Commit summary:

fixed grouping

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90540]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of MediaWiki.r90540.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90540#c0
Commit summary:

Added table cell centering to stylesheet

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r81587]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r81587.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81587#c0
Commit summary:

* Converted ConfirmAccount to use RL
* Avoid breaking filecache fallback if DB is down
* Fixed special page alias notice

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90995]: Revision status changed

[MediaWiki Mail]

User "Jack Phoenix" changed the status of MediaWiki.r90995.

Old Status: deferred
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90995#c0
Commit summary:

Revert of changes in r90288 - changes of "else if" to "elseif" are fine in PHP 
code, but not in Javascript code (which has no elseif) - and these were all in 
Javascript code

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90994]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90994.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90994#c0
Commit summary:

Localization update for he.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90990]: New comment added

[MediaWiki Mail]

User "Hashar" posted a comment on MediaWiki.r90990.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90990#c18883
Commit summary:

Find 'all' special ns regardless of its rank in the select

This is done by looking for an  element with an empty string value
which denote the special case 'all'.
Also removed a comment in Xml.php asking to keep 'all' as a first element
since it is no longer needed.

Follow up r90943 (comment 18872 by Brion)

Comment:

Qunit tests pass on my local machine.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90943]: New comment added

[MediaWiki Mail]

User "Hashar" posted a comment on MediaWiki.r90943.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90943#c18882
Commit summary:

Disable ns selector checkboxes when 'all' namespace is selected
* based on an idea by Aaron on r90866
* comes with QUnit test
* expect the special 'all' namespace to be the first in the list
* function build on mediawiki.special form r90941

Comment:

Yes wikitext. That is why I assumed it as the first element. r90990 makes it 
look per value as you suggested.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90632]: Revision status changed

[MediaWiki Mail]

User "Catrope" changed the status of MediaWiki.r90632.

Old Status: new
New Status: ok

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90632#c0
Commit summary:

Fixed event names so they aren't so insane!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r80792]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r80792.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80792#c0
Commit summary:

adding links to other skins in mediaWiki JS test suite. (Previously making sure 
everything works in all skins was a PITA

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r79871]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r79871.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79871#c0
Commit summary:

Added QuickTemplate::getSkin(), useful for extensions when executing hooks 
passing only the template as parameter

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90873]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r90873.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90873#c0
Commit summary:

Added gallery height attribute

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90864]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r90864.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90864#c18881
Commit summary:

Babel CSS: follow the content direction instead of the user language direction 
(support for $wgBetterDirectionality)

Comment:

Why is this file not just loaded through resource loader like everything else?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90967]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90967.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90967#c0
Commit summary:

Followup r90958 for Translatewiki

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90980]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90980.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90980#c0
Commit summary:

Update qunit test runner includes for mediawiki.special.js move in r90968

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90975]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90975.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90975#c0
Commit summary:

Followup r90958 for Translatewiki and fix for r90967 per JanPaul's CE:
* Use correct section Wiki Love, not Wiki Log
* Make 'wikilove-commons-url' optional.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90987]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90987.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90987#c0
Commit summary:

Per siebrand on r85296, the proper path to deprecation is:
1) Behavior/doc change
2) Then warnings
3) Then removal
1 and 2 were rolled into the same release (1.18), so revert the wfDeprecated() 
call in REL1_18. Trunk can still spew warnings, and we shouldn't look to remove 
until sometime in the 1.20 timeframe.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90985]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r90985.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90985#c0
Commit summary:

module name is not shortened

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview