Re: [Wikitech-l] Rendering preferences for math - PDFs

[Federico Leva (Nemo)]

On Tue, Jul 19, 2011 at 1:42 PM, Carl (CBM) wrote:
 > A second issue that has been raised on the wiki [...]

Which wiki? I guess you mean

 
and specifically http://en.wikipedia.org/?diff=440362033&oldid=440359923

Nemo
(hoping to get the Reply-To from pipermail)

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r92545]: New comment added

[MediaWiki Mail]

User "Kaldari" posted a comment on MediaWiki.r92545.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92545#c19829
Commit summary:

updating for new CLDR archive format

Comment:

I swear they changed it. Earlier today there was no core.zip in that directory 
and instead there was common.zip. I guess they changed it back today. Those 
bastards! :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92598]: Revision status changed

[MediaWiki Mail]

User "TheDJ" changed the status of MediaWiki.r92598.

Old Status: new
New Status: fixme

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92598#c0
Commit summary:

$wgUploadNavigationUrl should be used for file redlinks if 
$wgUploadMissingFileUrl is not set. The first was used for this until the 
second was introduced in r69997 (1.17). According to the comments there it was 
broken in 1.16 but as far as I tested it worked in 1.16. In any case, the old 
behavior should be restored as most WMF wikis have set wgUploadNavigationUrl 
but not wgUploadMissingFileUrl.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92549]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r92549.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92549#c19828
Commit summary:

1.18: Back out adaptive message cache (r71412, r71418, r74177, r74179) by 
merging r81444 from REL1_17

Comment:


-   if ( !$wgAdaptiveMessageCache ) {
-   return false;
-   }


That return false should be there in else clause for the if above. Same bug is 
in 1.17 which increases calls to underlying cache system many times.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92598]: New comment added

[MediaWiki Mail]

User "TheDJ" posted a comment on MediaWiki.r92598.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92598#c19827
Commit summary:

$wgUploadNavigationUrl should be used for file redlinks if 
$wgUploadMissingFileUrl is not set. The first was used for this until the 
second was introduced in r69997 (1.17). According to the comments there it was 
broken in 1.16 but as far as I tested it worked in 1.16. In any case, the old 
behavior should be restored as most WMF wikis have set wgUploadNavigationUrl 
but not wgUploadMissingFileUrl.

Comment:

It was broken in 1.16. The redlinks for thumbnails with missing files on en.wp 
would take you to some sort of incorrect location.

See also bug 18885 and r60593 (the latter is what caused the broken 
functionality I think). It think that is required here is a mass change to ALSO 
configure missinglinkurl for the wiki's that have uploadnavigationurl.

Bryan should know more.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92548]: Revision status changed

[MediaWiki Mail]

User "Nikerabbit" changed the status of MediaWiki.r92548.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92548#c0
Commit summary:

updating with new CLDR data, fixing bug 29613

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92545]: New comment added

[MediaWiki Mail]

User "Peachey88" posted a comment on MediaWiki.r92545.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92545#c19826
Commit summary:

updating for new CLDR archive format

Comment:

I think that might be a mistake, since it used to refer to Core, and that is 
still there.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92545]: New comment added

[MediaWiki Mail]

User "Nikerabbit" posted a comment on MediaWiki.r92545.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92545#c19825
Commit summary:

updating for new CLDR archive format

Comment:

What is this common.zip? I don't see it on 
http://www.unicode.org/Public/cldr/2.0.1/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r1]: New comment added

[MediaWiki Mail]

User "Krinkle" posted a comment on MediaWiki.r1.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/1#c19824
Commit summary:

New repository initialized by cvs2svn.

Comment:

[http://www.mediawiki.org/wiki/Special:Code/MediaWiki/1 foo]

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92382]: New comment added

[MediaWiki Mail]

User "NeilK" posted a comment on MediaWiki.r92382.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92382#c19822
Commit summary:

added special page which will serve as admin interface for campaign config

Comment:

We're doing an exercise in code review today at the WMF, so I happened to have 
Brion Vibber right next to me... we reviewed it together. We know that your 
code is right, but it's just a little bit extra mental effort to connect 
$wgUser and $GLOBALS['wgUser']. Plus, people grep for globals with "$wg" 
sometimes.

I don't quite see your point that $GLOBALS['wgUser'] is much safer. We have a 
convention and no other variables should be named $wg-anything.

As for @param types, I know that some of my code does this inconsistently too, 
but we're trying to get better. ;)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92605]: New comment added

[MediaWiki Mail]

User "Owyn" posted a comment on MediaWiki.r92605.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92605#c19823
Commit summary:

added missing null checks in callers of Revision::newNullRevision

Comment:

One question: should the call to wfRunHooks be inside or outside of this null 
check?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Rendering preferences for math - PDFs

[Brion Vibber]

On Tue, Jul 19, 2011 at 1:42 PM, Carl (CBM)  wrote:

> A second issue that has been raised on the wiki is the poor quality of
> math in PDFs generated from articles. The math shows up as a
> low-quality bitmap which is very pixelated and noticeably different
> from the body text. I wanted to pass it along to the list.
>

There's an entry in Bugzilla for this; which was initially closed:
https://bugzilla.wikimedia.org/show_bug.cgi?id=27574

I've gone ahead and re-opened it as it would be nice to fix, but it'll
actually need fixing in PediaPress's mwlib renderer that's used as the
backend for the Collection extension and actually generates the PDFs.

There's some notes on the bug about possible implementation details.

-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r92603]: New comment added

[MediaWiki Mail]

User "Jeroen De Dauw" posted a comment on MediaWiki.r92603.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92603#c19821
Commit summary:

fu r92555

Comment:

Heh... fixed in r92604

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92604]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92604.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92604#c0
Commit summary:

fu r92555

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92603]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92603.

Old Status: new
New Status: ok

User "^demon" also posted a comment on MediaWiki.r92603.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92603#c19820
Commit summary:

fu r92555

Comment:

"licencing" is still misspelled too.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92269]: New comment added

[MediaWiki Mail]

User "Raindrift" posted a comment on MediaWiki.r92269.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92269#c19819
Commit summary:

No longer using the content hash as a file key.  This solves a concurrency 
problem when multiple people use the same account to upload from the same set 
of files.  Each stashed file is now a unique and beautiful snowflake, and the 
content-based deduping that comes at the end of the process can sort it out.

Comment:

Follow-up: r92081

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92081]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r92081.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c19818
Commit summary:

Added us_status column for future expansion re Bryan's suggestion
Implemented changes suggested in code review on r92009:
 constructor bug handling passed repo/stash
 up-to-date timestamp generation
 fetching db handle from repo
 iterating over select results according to convention
 changed uploadstash.us_media_type to enum to mirror image.img_media_type
 removed (most) new references to $wgUser, instead using ApiBase::createContext 
to find the user

Comment:

Tests are working fine for me now again, thanks :) I actually fixed the 
robustness in removeFile() in r92250, so you can ignore that bit :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92382]: New comment added

[MediaWiki Mail]

User "Jeroen De Dauw" posted a comment on MediaWiki.r92382.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92382#c19817
Commit summary:

added special page which will serve as admin interface for campaign config

Comment:

Accessing - spellcheck fail...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91499]: New comment added

[MediaWiki Mail]

User "Kaldari" posted a comment on MediaWiki.r91499.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19816
Commit summary:

another fix for old jQuery UI on live

Comment:

The icons are always 16px by 16px. Thus, if they appear on the left side of the 
button (primary), they should be flush left (left:0). If they appear on the 
right side of the button (secondary), they should be 16px from the right 
(right:16px).

The extra selectors are to make sure that all cases are treated the same. It 
may actually make sense to just condense these into 2 selectors 
(.ui-button-text-icon-primary and .ui-button-text-icon-secondary), but I was 
trying to keep the change as minimal as possible.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92382]: New comment added

[MediaWiki Mail]

User "Jeroen De Dauw" posted a comment on MediaWiki.r92382.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92382#c19815
Commit summary:

added special page which will serve as admin interface for campaign config

Comment:

> don't use $GLOBALS['wgUser'], we use $wgUser everywhere else. 

Why introduce a global into your whole local scope when only using it once? 
Acceding it directly via $GLOBALS seems cleaner.

> just please add types to your @params consistently. 

I normally do, unless it's docs copied from somewhere, or code where I don't 
know what the type is supposed to be.

> change 'uploadcampaigns' to use the 'mwe-upwiz-' prefix

Done in r92602 :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92581]: Revision status changed

[MediaWiki Mail]

User "SPQRobin" changed the status of MediaWiki.r92581.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92581#c0
Commit summary:

Spacing, removed unneded global.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92599]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92599.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92599#c0
Commit summary:

Updating my USERINFO file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92596]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92596.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92596#c0
Commit summary:

Updating my USERINFO file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92081]: Revision status changed

[MediaWiki Mail]

User "Raindrift" changed the status of MediaWiki.r92081.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c0
Commit summary:

Added us_status column for future expansion re Bryan's suggestion
Implemented changes suggested in code review on r92009:
 constructor bug handling passed repo/stash
 up-to-date timestamp generation
 fetching db handle from repo
 iterating over select results according to convention
 changed uploadstash.us_media_type to enum to mirror image.img_media_type
 removed (most) new references to $wgUser, instead using ApiBase::createContext 
to find the user

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92081]: New comment added

[MediaWiki Mail]

User "Raindrift" posted a comment on MediaWiki.r92081.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92081#c19814
Commit summary:

Added us_status column for future expansion re Bryan's suggestion
Implemented changes suggested in code review on r92009:
 constructor bug handling passed repo/stash
 up-to-date timestamp generation
 fetching db handle from repo
 iterating over select results according to convention
 changed uploadstash.us_media_type to enum to mirror image.img_media_type
 removed (most) new references to $wgUser, instead using ApiBase::createContext 
to find the user

Comment:

Tested, and it passes unit tests as of r92269 (my ImageMagick got broken, so 
those tests were ignored and I missed it).  I'd appreciate suggestions for how 
to make the code more robust than it already is...  if the key isn't there, 
there's not much that can be done.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92277]: New comment added

[MediaWiki Mail]

User "Catrope" posted a comment on MediaWiki.r92277.

Full URL: 
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92277#c19813
Commit summary:

MoodBar: store edit count at time of feedback in the database.

Comment:

"It" being the user's edit count, which is loaded in two conflicting ways.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92291]: Revision status changed

[MediaWiki Mail]

User "Krinkle" changed the status of MediaWiki.r92291.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92291#c0
Commit summary:

formatting tweaks for hi.wiki

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92201]: New comment added

[MediaWiki Mail]

User "Werdna" posted a comment on MediaWiki.r92201.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92201#c19812
Commit summary:

Commit Special:MoodBar, shows feedback in a rudimentary way. Copy and modify 
from SpecialCommunityApplications.php

Comment:

Should be replaced with a pager + maintenance script.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92382]: New comment added, and revision status changed

[MediaWiki Mail]

User "NeilK" changed the status of MediaWiki.r92382.

Old Status: new
New Status: ok

User "NeilK" also posted a comment on MediaWiki.r92382.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92382#c19811
Commit summary:

added special page which will serve as admin interface for campaign config

Comment:

I'm marking this ok, but just a few fixes for consistency:

* change 'uploadcampaigns' to use the 'mwe-upwiz-' prefix
* thanks for adding docs! just please add types to your @params consistently.
* don't use $GLOBALS['wgUser'], we use $wgUser everywhere else.



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92597]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92597.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92597#c0
Commit summary:

fix issues after code review

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92510]: Revision status changed

[MediaWiki Mail]

User "Trevor Parscal" changed the status of MediaWiki.r92510.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92510#c0
Commit summary:

code clean-up: updating method names, adding comments, etc.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91768]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r91768.

Old Status: new
New Status: ok

User "^demon" also posted a comment on MediaWiki.r91768.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91768#c19810
Commit summary:

WURFL support in MW Memcache interface

Comment:

Could use a little more docs, and some whitespace cleanup. Otherwise ok :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92224]: Revision status changed

[MediaWiki Mail]

User "Trevor Parscal" changed the status of MediaWiki.r92224.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92224#c0
Commit summary:

follow-up to r92037 - making log details more localizable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92214]: Revision status changed

[MediaWiki Mail]

User "Trevor Parscal" changed the status of MediaWiki.r92214.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92214#c0
Commit summary:

follow-up to r91522, calling static methods as static methods

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92277]: New comment added

[MediaWiki Mail]

User "Werdna" posted a comment on MediaWiki.r92277.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92277#c19809
Commit summary:

MoodBar: store edit count at time of feedback in the database.

Comment:

(Also, use ! $this->getProperty('id'), instead of a weak comparison with null)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92212]: Revision status changed

[MediaWiki Mail]

User "Trevor Parscal" changed the status of MediaWiki.r92212.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92212#c0
Commit summary:

follow-up to r92042 - making more localizable

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92277]: Revision status changed

[MediaWiki Mail]

User "Werdna" changed the status of MediaWiki.r92277.

Old Status: new
New Status: fixme

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92277#c0
Commit summary:

MoodBar: store edit count at time of feedback in the database.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92277]: New comment added

[MediaWiki Mail]

User "Werdna" posted a comment on MediaWiki.r92277.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92277#c19808
Commit summary:

MoodBar: store edit count at time of feedback in the database.

Comment:

It's overwritten in MBFeedbackItem because setProperties() is called by 
newFromRow

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92551]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92551.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92551#c0
Commit summary:

Follow up to r91561: Use the canonical class names.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92564]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92564.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92564#c0
Commit summary:

Follow up r91561. Use canonical class names.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92506]: New comment added, and revision status changed

[MediaWiki Mail]

User "Brion VIBBER" changed the status of MediaWiki.r92506.

Old Status: new
New Status: ok

User "Brion VIBBER" also posted a comment on MediaWiki.r92506.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92506#c19807
Commit summary:

Refactored section assembly code to be more readable
Added a hook that's called for each section.  This allows sections to be 
addressed separately at the document level, for example by wrapping each in a 
div (as in the reverted r50769).  This in-turn enables richer section-specific 
UI, like highlighting or in-line editing.

Comment:

Marking ok, but leaving todo tag for the hooks doc.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92332]: New comment added

[MediaWiki Mail]

User "Trevor Parscal" posted a comment on MediaWiki.r92332.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92332#c19806
Commit summary:

html:key should be self-closing in jquery.localize unit tests.

More IE6, 7 and 8 fixes for jquery.localize unit tests.

html:key should be self-closing. This was in most tests, but accidentally 
forgotten in a few. Other browsers are looser on this, but IE is very strict 
about it.

Comment:

These tests may still be broken, since jquery.localize works in IE6/IE7 in 
production (ArticleFeedback uses it)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92593]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92593.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92593#c0
Commit summary:

adding userinfo

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92332]: Revision status changed

[MediaWiki Mail]

User "Trevor Parscal" changed the status of MediaWiki.r92332.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92332#c0
Commit summary:

html:key should be self-closing in jquery.localize unit tests.

More IE6, 7 and 8 fixes for jquery.localize unit tests.

html:key should be self-closing. This was in most tests, but accidentally 
forgotten in a few. Other browsers are looser on this, but IE is very strict 
about it.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92009]: Revision status changed

[MediaWiki Mail]

User "Raindrift" changed the status of MediaWiki.r92009.

Old Status: fixme
New Status: new

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92009#c0
Commit summary:

Refactored UploadStash and related classes to use the database for file 
metadata storage instead of the session, see bug 26179

Tweaked the UploadWizard to work properly with the new backend code, updated 
tests

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] should we join the Unicode Constortium?

[Alolita Sharma]

Ryan,

Great news!

Alolita

On Tue, Jul 19, 2011 at 3:24 PM, Platonides  wrote:
>
> Congratulations!
>
>
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Re: [Wikitech-l] should we join the Unicode Constortium?

[Platonides]

Congratulations!



___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r92588]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92588.

Old Status: fixme
New Status: resolved

User "^demon" also posted a comment on MediaWiki.r92588.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19805
Commit summary:

Follow up r91419. A boolean attribute can be both the empty string and its name 
[http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes]
We use the later since that's what xhtml1 required 
[http://www.w3.org/TR/xhtml1/#h-4.5].

Comment:

Works with the followup, thanks!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92590]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92590.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92590#c0
Commit summary:

Follow-up r92588. Make it work regardless of $wgHtml5

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92588]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r92588.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19804
Commit summary:

Follow up r91419. A boolean attribute can be both the empty string and its name 
[http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes]
We use the later since that's what xhtml1 required 
[http://www.w3.org/TR/xhtml1/#h-4.5].

Comment:

I had tried changing $wgHtml5 without noticing it was overwritten again some 
lines below. Fixed in r92590.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92588]: New comment added

[MediaWiki Mail]

User "^demon" posted a comment on MediaWiki.r92588.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19803
Commit summary:

Follow up r91419. A boolean attribute can be both the empty string and its name 
[http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes]
We use the later since that's what xhtml1 required 
[http://www.w3.org/TR/xhtml1/#h-4.5].

Comment:

Perhaps we have different config? $wgHtml5 related perhaps?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92588]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r92588.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19802
Commit summary:

Follow up r91419. A boolean attribute can be both the empty string and its name 
[http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes]
We use the later since that's what xhtml1 required 
[http://www.w3.org/TR/xhtml1/#h-4.5].

Comment:

Passes for me. That's precisely why I changed it... it was failing.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92588]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92588.

Old Status: new
New Status: fixme

User "^demon" also posted a comment on MediaWiki.r92588.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92588#c19801
Commit summary:

Follow up r91419. A boolean attribute can be both the empty string and its name 
[http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxes.html#boolean-attributes]
We use the later since that's what xhtml1 required 
[http://www.w3.org/TR/xhtml1/#h-4.5].

Comment:

Breaks tests:

$ ./phpunit.php includes/HtmlTest.php 
PHPUnit 3.5.13 by Sebastian Bergmann.

.F.

Time: 0 seconds, Memory: 17.75Mb

There was 1 failure:

1) HtmlTest::testExpandAttributesForBooleans
Boolean attributes skip value output
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
- selected="selected"
+ selected=""

/opt/local/apache2/htdocs/phase3/tests/phpunit/includes/HtmlTest.php:54
/opt/local/apache2/htdocs/phase3/tests/phpunit/MediaWikiTestCase.php:64
/opt/local/apache2/htdocs/phase3/tests/phpunit/MediaWikiPHPUnitCommand.php:20
/opt/local/apache2/htdocs/phase3/tests/phpunit/phpunit.php:60

FAILURES!
Tests: 3, Assertions: 10, Failures: 1.


___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92528]: New comment added

[MediaWiki Mail]

User "RobLa-WMF" posted a comment on MediaWiki.r92528.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92528#c19800
Commit summary:

(bug 19838) API does not use interwiki cache.

Patch by Beau; modified to work with current code.

Comment:

Roan swears he tested this  :)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92585]: Revision status changed

[MediaWiki Mail]

User "Reedy" changed the status of MediaWiki.r92585.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92585#c0
Commit summary:

svn:eol-style native

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92563]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r92563.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92563#c19799
Commit summary:

Expand the defines from JSTokenizer::__construct() placing them at the top of 
the file.
This fixes the Notices that would be produced if several JSTokenizer were 
instantiated.
jsminplus was added in r91591.

Defines code was generated with:
$js = new JSTokenizer();
foreach ($js->opTypeNames as $operand => $name) echo "define('OP_$name', 
'$operand');\n";
foreach ($js->keywords as $keyword) echo "define('KEYWORD_" . 
strtoupper($keyword) . "', '$keyword');\n";

Comment:

I sent an email to Tino Zijdel.

Upstream is http://crisp.tweakblogs.net/blog/cat/716 That project seem to have 
an old version imported.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] should we join the Unicode Constortium?

[Paul Houle]

  On 7/19/2011 2:41 PM, Ryan Kaldari wrote:
> The Wikimedia Foundation is now an official liaison member of the
> Unicode Consortium:
> http://www.unicode.org/consortium/memblist.html#liais
>
> Rick McGowan is the Unicode representative to Wikimedia, and I'll be
> serving as Wikimedia's respresentative to Unicode until our new
> localization engineers come on board.
>
> Ryan Kaldari
>
 Awesome!

 It's about time that Wikimedia,  such a leader in multilingual 
text,  has got some input into the process.

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r92576]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92576.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92576#c0
Commit summary:

Remove the globals. r91570 was wrong saying that parent::setUp()
would initialise those vars (this class parent is MediaWikiTestCase,
not MediaWikiLangTestCase) but the language doesn't seem to matter.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91570]: Revision status changed

[MediaWiki Mail]

User "Platonides" changed the status of MediaWiki.r91570.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91570#c0
Commit summary:

Call parent::setUp() and allow it to do lang setup stuff

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90430]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90430.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90430#c0
Commit summary:

Fixes for r80864 for 1.18 backport:
* Use camel case in tableName and dbName, dontrunallyourwordstogetherlikethis
* Call the function factory() instead of newFromType(), for consistency with 
the rest of MediaWiki

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90753]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90753.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90753#c0
Commit summary:

Follow-up r90749:
* Removed useless ufg_group index from user_former_groups
* Index name consistency

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90756]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90756.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90756#c0
Commit summary:

(bug 25390) autoreview privilege should be removeable like editor (uses r90749)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90757]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90757.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90757#c0
Commit summary:

Follow-up r90749: pushed down accessing of $wgAutopromoteOnce to 
getAutopromoteOnceGroups()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90776]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90776.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90776#c0
Commit summary:

* Follow-up r90749
** Tweaked addAutopromoteOnceGroups() calls for performance
** Some doc tweaks and fixes
* Added NS_SPECIAL short-circuit on $wgTitle for file cache and removed 
unnecessary "is null" check
* Pushed "$action != 'raw'" check into HTMLFileCache
* Removed useless return value from performRequest()
* Added type hint to performAction()

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92574]: Revision status changed

[MediaWiki Mail]

User "SPQRobin" changed the status of MediaWiki.r92574.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92574#c0
Commit summary:

Follow-up r91518

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r90855]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r90855.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90855#c0
Commit summary:

Follow-up r90749: use a new 'autopromote' action for the autopromote rights log 
entries. Removed the 'rightsautocomment' msg.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r88501]: New comment added, and revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r88501.

Old Status: new
New Status: ok

User "^demon" also posted a comment on MediaWiki.r88501.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88501#c19798
Commit summary:

Patch for Bug #29040, “Web installer fails to show help boxes”
fix from William Demchick

Comment:

Typo in commit summary, referring to bug 29042.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r89389]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r89389.

Old Status: new
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89389#c0
Commit summary:

forward port r88929

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92057]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92057.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92057#c0
Commit summary:

(bug 120781) Move 'mainpagetext' messages to installer's .i18n file.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92565]: Revision status changed

[MediaWiki Mail]

User "^demon" changed the status of MediaWiki.r92565.

Old Status: new
New Status: deferred

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92565#c0
Commit summary:

Localisation updates for core and extension messages from translatewiki.net 
(2011-07-19 19:45:00 UTC)

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r318]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r318.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/318#c0
Commit summary:

more realistic test amounts

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] Rendering preferences for math - PDFs

[Carl (CBM)]

A second issue that has been raised on the wiki is the poor quality of
math in PDFs generated from articles. The math shows up as a
low-quality bitmap which is very pixelated and noticeably different
from the body text. I wanted to pass it along to the list.

- Carl

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [Wikimedia r316]: New comment added, and revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r316.

Old Status: new
New Status: reverted

User "Awjrichards" also posted a comment on Wikimedia.r316.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/316#c19797
Commit summary:

adding call to date_default_timezone_set so Drupal wont complain

Comment:

Reverted in r351.  Using date_default_timezone_set() here doesn't really make 
sense.  If you're just doing this for testing purposes, put it into a 
test-case.  This value should probably be either detected and set or set in 
php.ini, rather than hardcoded in the script

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] RFC: Should we drop the rendering preferences for math?

[Carl (CBM)]

On Tue, Jul 19, 2011 at 4:03 PM, Ryan Kaldari  wrote:
> Sounds like someone should propose MathJax as a gadget:
> http://en.wikipedia.org/wiki/Wikipedia:Gadget/proposals

That solves some of the problems, but making it a gadget isn't
technically very different from just putting it in user javascript.

Not all the MathJax files are javascript: there are also web fonts and
fallback image fonts. Ideally these would be served from Wikimedia
servers.  The system they are using right now loads them from off-site
somewhere, and that would not be fixable by the gadget system.  Users
can also install the fonts locally but that is not a good solution for
a widespread roll-out.

The ideal implementation would be a system that detects whether the
user has javascript enabled and a decent browser, and if so rolls them
over to MathJax automatically. Users who fail that test or who
intentionally opt out would receive images only.  This would
completely replace the current system (but re-use texvc to make the
images).

This system would not be hard to implement, but there is little
incentive for anyone to spend time on it without some pre-commitment
from the site admins to make it live.  If we just want something that
users can opt in to get, we already have that.

-  Carl

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r87308]: New comment added

[MediaWiki Mail]

User "Kaldari" posted a comment on MediaWiki.r87308.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87308#c19796
Commit summary:

better language handling - abandon magic language switch in favor of using 
int:lang as parameter, use parser->getFunctionLang() instead of wgContLanguage 
in case of use in interface messages

Comment:

Fixed in r92571 and r92572.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92568]: New comment added, and revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r92568.

Old Status: new
New Status: ok

User "Aaron Schulz" also posted a comment on MediaWiki.r92568.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92568#c19795
Commit summary:

r91784 forgot to change one instance of $wgUser to $user

Comment:

Wow, didn't catch that one!

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91784]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r91784.

Old Status: ok
New Status: resolved

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91784#c0
Commit summary:

Pass the User object to RecentChange::doMarkPatrolled() instead of relying on 
$wgUser

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r87308]: New comment added

[MediaWiki Mail]

User "Kaldari" posted a comment on MediaWiki.r87308.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87308#c19794
Commit summary:

better language handling - abandon magic language switch in favor of using 
int:lang as parameter, use parser->getFunctionLang() instead of wgContLanguage 
in case of use in interface messages

Comment:

int:lang doesn't exist on most wikis. I'll put in some defensive programming so 
that it fails gracefully.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91591]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r91591.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91591#c19793
Commit summary:

Followup r83885: add JSMin+ 1.3 to use its parser to verify output of 
JavaScriptMinifierTest unit test cases. Had to change some of the test cases 
because they were not valid JavaScript programs -- one of the quoting tests was 
incorrectly quoted in the PHP sources, and several tests around return, 
continue, and break keywords failed due to not using them in the contexts that 
they require.

http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html
JSMin+ under MPL 1.1/ GPL 2.0 / LGPL 2.1 license.

Comment:

I fixed it in r92563 (also modified it in r92560) and emailed upstream about 
them.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92563]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r92563.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92563#c19792
Commit summary:

Expand the defines from JSTokenizer::__construct() placing them at the top of 
the file.
This fixes the Notices that would be produced if several JSTokenizer were 
instantiated.
jsminplus was added in r91591.

Defines code was generated with:
$js = new JSTokenizer();
foreach ($js->opTypeNames as $operand => $name) echo "define('OP_$name', 
'$operand');\n";
foreach ($js->keywords as $keyword) echo "define('KEYWORD_" . 
strtoupper($keyword) . "', '$keyword');\n";

Comment:

Can we get this pushed upstream?

Though, I'm not sure where that is.. 
[http://code.google.com/p/minify/source/browse/trunk/min/lib/JSMinPlus.php] is 
1.1...

http://code.google.com/p/minify/

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92560]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r92560.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92560#c19791
Commit summary:

Remove double ; and final ?> from jsminplus (imported in r91591).
This should be uncontroversial.

Comment:

Got really removed in r92563

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92560]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r92560.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92560#c19790
Commit summary:

Remove double ; and final ?> from jsminplus (imported in r91591).
This should be uncontroversial.

Comment:

The ?> is still there...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92555]: New comment added

[MediaWiki Mail]

User "Siebrand" posted a comment on MediaWiki.r92555.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92555#c19789
Commit summary:

work on upload campaign configuration

Comment:

Typo: skipp -> skip 

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Re: [Wikitech-l] RFC: Should we drop the rendering preferences for math?

[Ryan Kaldari]

Sounds like someone should propose MathJax as a gadget:
http://en.wikipedia.org/wiki/Wikipedia:Gadget/proposals

Ryan Kaldari

On 7/19/11 8:58 AM, Carl (CBM) wrote:
> On Mon, Jul 18, 2011 at 8:38 PM, Brion Vibber  wrote:
>> It's conceivable that a few folks really honestly prefer to see the latex
>> source in their graphical browsers (should at least do a quick stat check to
>> see if anybody uses it on purpose), but I wouldn't mind removing that
>> either.
> Some people are using this method to have MathJax render the math on
> Wikipedia pages, by installing the MathJax javascript in their user
> javascript.  Disabling the text-only option would also break this.
>
> It would really be worthwhile for us to look into making MathJax
> available as an option for all users without forcing them to modify
> their user javascript.  It's basically just a few javascript files and
> some static files on a webserver. They claim very broad browser
> compatibility (
> http://www.mathjax.org/resources/browser-compatibility/ ) , and
> everything is released under the Apache license IIRC.
>
> - Carl
>
> ___
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [Wikimedia r252]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r252.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/252#c0
Commit summary:

Adds the function showClock to WM_TestCase.
It's basically a stopwatch for using inside unit tests. Could be used to assert 
that certain functions clock in under a certain amount of time.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r346]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r346.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/346#c0
Commit summary:

Cleans up some messes discovered while running the simpletests in drush.
* Only tries to stomp disconnect at the end of a batch import if you're still 
connected.
* Cleans up some typecasty-type things around getting data into the database
* Cleans up the drush "errors" that pop up running simpletest (which usually 
aren't literal php errors anyway, and come up looking fairly alarming)
* Modifies the stubby messages sent out by the tests, to contain transaction 
ids (or not) as needed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r276]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r276.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/276#c0
Commit summary:

followup r265
Adds a module for testing variables, and requires a testing email address in 
order for the tests in queue2civicrm to proceed.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r268]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r268.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/268#c0
Commit summary:

followup r267
Cleans up some warnings discovered after the test was put in place, for 
failmail.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r267]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r267.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/267#c0
Commit summary:

followup r229
Cleans up a lot of things surrounding the fail mail, and adds a test for batch 
process to determine that things are being properly consumed (or not).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91591]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r91591.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91591#c19788
Commit summary:

Followup r83885: add JSMin+ 1.3 to use its parser to verify output of 
JavaScriptMinifierTest unit test cases. Had to change some of the test cases 
because they were not valid JavaScript programs -- one of the quoting tests was 
incorrectly quoted in the PHP sources, and several tests around return, 
continue, and break keywords failed due to not using them in the contexts that 
they require.

http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html
JSMin+ under MPL 1.1/ GPL 2.0 / LGPL 2.1 license.

Comment:

Lovely

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r255]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r255.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/255#c0
Commit summary:

Card #184
Moves the normalize functions into the local verify and stage function for the 
message, in the name of cleanliness.
Fixes a typo in an array key
Adds a transaction to testRequiredFields, to make sure that fields with default 
values are not overwriting the original message with the dummy defaults.
Adds testCurrencyConversion test, to verify that currencies other than USD are 
being converted (and USD stays the same).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r253]: New comment added, and revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r253.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on Wikimedia.r253.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/253#c19787
Commit summary:

For card 184:
Adds the test that determines if required tests are, in fact, required.
Cleans up a lot of array key variable checks so php won't throw warnings.

Comment:


-   if ($contribution['thankyou_date']) {
+   if (array_key_exists('thankyou_date', $contribution)) {
return -2;
}


Don't you also need to check the value of $contribution['thankyou_date'] here?  
What if it's null?

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r251]: New comment added, and revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r251.

Old Status: new
New Status: fixme

User "Awjrichards" also posted a comment on Wikimedia.r251.

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/251#c19786
Commit summary:

Additional changes for card #184
Adds a configurable path for the stomp libraries
Fixes logic error throwing a review tag add error
Adds a verify and stage function to take care of all required fields (both 
actually required, and required to be some value by later code)
Fixes the insert into contribution_tracking (was missing a single-quote)
Changes the simpletest to only output E_ALL errors to cut down the noise in 
Drush.

Comment:

In +++ 
trunk/fundraising-civicrm/sites/all/modules/queue2civicrm/queue2civicrm.module  
 (revision 251), you have:

+function queue2civicrm_verify_and_stage($msg){
+   $required = array(
+   'email' => '',
+   'gross' => '',
+   'original_currency' => '',
+   'gateway' => '',
+   'gateway_txn_id' => ''
+   );
+
+   foreach ($required as $key=>$value){
+   if (!isset($msg[$key])){
+   watchdog('queue2civicrm', "Required Field '$key' not 
found in message:" . print_r($msg, true), WATCHDOG_ERROR);
+   drush_set_error("CIVI_REQ_FIELD", "Required Field 
'$key' not found in message:" . print_r($msg, true));
+   return false;
+   }
+   }


This isn't something I'd consider a blocker for deployment, but you might 
consider returning false on missing req'd fields after checking /each/ of the 
required fields.  As it's written now, it'll return false on the first 
identified missing req'd field.  It's always a PITA when you think you're only 
missing one req'd field, try again, and then are told about another req'd field 
you're missing.  IMHO, best to aggregate all the errors and alert once.


+   $defaults = array(
+   'date' => time(), //defaulting to now. @fixme: if you can think 
of a better thing to do in the name of historical exchange rates.
+   'first_name' => 'Chester',
+   'middle_name' => '',
+   'last_name' => 'McDefault',
+   //'original_gross' => ''
+   );
+
+   $msg = array_merge($defaults, $msg);

I'm concerned this might not necessarily work as expected.  For instance, 
before the merge in the event that $msg['first_name'] = '';, after 
the merge you'd have an empty string for the first name.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r245]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r245.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/245#c0
Commit summary:

Fixes two things in the Stomp libraries:
$header variable in Stomp.php
Reference to Exception.php in Frame.php

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [Wikimedia r229]: Revision status changed

[MediaWiki Mail]

User "Awjrichards" changed the status of Wikimedia.r229.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/229#c0
Commit summary:

Starting to address the issues in story card #189.
Makes sure  that the stomp connection behaves as expected (with an additional 
two retries)
Adds some error handling (incomplete).
Looks up a few civicrm-specific values that had been hard-coded.
This includes a couple additions so we can run simpletests for the module 
(though, most of them only make sense via drush, as none of the code we're 
testing is really accessed through the UI anyway).

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91591]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r91591.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91591#c19785
Commit summary:

Followup r83885: add JSMin+ 1.3 to use its parser to verify output of 
JavaScriptMinifierTest unit test cases. Had to change some of the test cases 
because they were not valid JavaScript programs -- one of the quoting tests was 
incorrectly quoted in the PHP sources, and several tests around return, 
continue, and break keywords failed due to not using them in the contexts that 
they require.

http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html
JSMin+ under MPL 1.1/ GPL 2.0 / LGPL 2.1 license.

Comment:

Ok, I found it. They are dynamically defined at JSTokenizer::__construct.

Which means that if you constructo two JSTokenizer you get a bunch of PHP 
Notices...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91591]: New comment added

[MediaWiki Mail]

User "Reedy" posted a comment on MediaWiki.r91591.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91591#c19784
Commit summary:

Followup r83885: add JSMin+ 1.3 to use its parser to verify output of 
JavaScriptMinifierTest unit test cases. Had to change some of the test cases 
because they were not valid JavaScript programs -- one of the quoting tests was 
incorrectly quoted in the PHP sources, and several tests around return, 
continue, and break keywords failed due to not using them in the contexts that 
they require.

http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html
JSMin+ under MPL 1.1/ GPL 2.0 / LGPL 2.1 license.

Comment:

^ I was looking at those before...

Googling found little...

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r91591]: New comment added

[MediaWiki Mail]

User "Platonides" posted a comment on MediaWiki.r91591.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91591#c19783
Commit summary:

Followup r83885: add JSMin+ 1.3 to use its parser to verify output of 
JavaScriptMinifierTest unit test cases. Had to change some of the test cases 
because they were not valid JavaScript programs -- one of the quoting tests was 
incorrectly quoted in the PHP sources, and several tests around return, 
continue, and break keywords failed due to not using them in the contexts that 
they require.

http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html
JSMin+ under MPL 1.1/ GPL 2.0 / LGPL 2.1 license.

Comment:

Is jsminplus.php complete?

Where are all these constants defined?

KEYWORD_BREAK
KEYWORD_CASE
KEYWORD_CATCH
KEYWORD_CONST
KEYWORD_CONTINUE
KEYWORD_DEBUGGER
KEYWORD_DEFAULT
KEYWORD_DELETE
KEYWORD_DO
KEYWORD_ELSE
KEYWORD_FALSE
KEYWORD_FINALLY
KEYWORD_FOR
KEYWORD_FUNCTION
KEYWORD_IF
KEYWORD_IN
KEYWORD_INSTANCEOF
KEYWORD_NEW
KEYWORD_NULL
KEYWORD_RETURN
KEYWORD_SWITCH
KEYWORD_THIS
KEYWORD_THROW
KEYWORD_TRUE
KEYWORD_TRY
KEYWORD_TYPEOF
KEYWORD_VAR
KEYWORD_VOID
KEYWORD_WHILE
KEYWORD_WITH
OP_AND
OP_ASSIGN
OP_BITWISE_AND
OP_BITWISE_NOT
OP_BITWISE_OR
OP_BITWISE_XOR
OP_COLON
OP_COMMA
OP_DECREMENT
OP_DIV
OP_DOT
OP_EQ
OP_GE
OP_GT
OP_HOOK
OP_INCREMENT
OP_LE
OP_LEFT_BRACKET
OP_LEFT_CURLY
OP_LEFT_PAREN
OP_LSH
OP_LT
OP_MINUS
OP_MOD
OP_MUL
OP_NE
OP_NOT
OP_OR
OP_PLUS
OP_RIGHT_BRACKET
OP_RIGHT_CURLY
OP_RIGHT_PAREN
OP_RSH
OP_SEMICOLON
OP_STRICT_EQ
OP_STRICT_NE
OP_UNARY_MINUS
OP_UNARY_PLUS
OP_URSH



___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92552]: Revision status changed

[MediaWiki Mail]

User "Aaron Schulz" changed the status of MediaWiki.r92552.

Old Status: new
New Status: ok

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92552#c0
Commit summary:

Profiling errors. r92106 missed a wfProfileOut
r92118 added a wfProfileIn but not all returns were covered. Also changed its 
spaces to tabs.

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

[MediaWiki-CodeReview] [MediaWiki r92205]: Revision status changed

[MediaWiki Mail]

User "SPQRobin" changed the status of MediaWiki.r92205.

Old Status: new
New Status: reverted

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92205#c0
Commit summary:

Use Linker::link*() functions

___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview