[MediaWiki-CodeReview] [MediaWiki r91654]: New comment added
User "Dantman" posted a comment on MediaWiki.r91654. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91654#c20143 Commit summary: Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it more portable (not all wikis do headItems the same). Comment: I think that code needs two tweaks before it's put into core: * We need something that can be feature tested. Like the MW_SUPPORTS_PARSERFIRSTCALLINIT constant was added for testing. property: is just part of the string and if we just drop that in there is no way to tell if the feature is supported or not, so the extension will break pre-1.19 * property: is not "Open Graph" it's part of RDFa, should probably fix the comments before inclusion into core. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91654]: New comment added
User "SColombo" posted a comment on MediaWiki.r91654. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91654#c20142 Commit summary: Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it more portable (not all wikis do headItems the same). Comment: Yikes! I didn't realize that was a Wikia-specific hack in OutputPage. I thought I checked, but now I see that it definitely isn't in core. Change was here: http://trac.wikia-code.com/changeset/35596%20#file1 Will merge the change in and then try to make some test code. Is there an already-existing test that this would be a good addition to? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91654]: New comment added, and revision status changed
User "Dantman" changed the status of MediaWiki.r91654. Old Status: ok New Status: fixme User "Dantman" also posted a comment on MediaWiki.r91654. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91654#c20141 Commit summary: Put the OpenGraphMeta info into meta tags section of OutputPage. Makes it more portable (not all wikis do headItems the same). Comment: This change breaks OpenGraphMeta on vanilla mediawiki. becomes and Facebook now completely ignores it. If there is a Wikia specific hack in place on Wikia's codebase making property: work, please commit it to MediaWiki's core trunk and include a way to feature test for it so that this extension can work outside of Wikia. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Please welcome Ben Hartshorne and Daniel Zahn
Welcome - I'm looking forward to working with you both! On Sun, Jul 24, 2011 at 3:28 PM, Platonides wrote: > Welcome both of you. > Daniel, I think you are going to be assigned bug 14890 :) > > > > ___ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > -- Arthur Richards Software Engineer Fundraising/Features/Offline/Mobile [[User:Awjrichards]] IRC: awjr +1-415-839-6885 x6687 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93123]: Revision status changed
User "^demon" changed the status of MediaWiki.r93123. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93123#c0 Commit summary: merged updates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92612]: Revision status changed
User "^demon" changed the status of MediaWiki.r92612. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92612#c0 Commit summary: Cleaned up mwversionsinuse bash script (committed by accident in r92611) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92272]: Revision status changed
User "^demon" changed the status of MediaWiki.r92272. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92272#c0 Commit summary: Merged in live CommonSettings.php changes...sigh ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93143]: Revision status changed
User "^demon" changed the status of MediaWiki.r93143. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93143#c0 Commit summary: Fixed text selection in lists * Added recursive line index finding * Added support for n+1 virtual offsets ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93106]: Revision status changed
User "^demon" changed the status of MediaWiki.r93106. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93106#c0 Commit summary: MFT 93103. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93142]: Revision status changed
User "^demon" changed the status of MediaWiki.r93142. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93142#c0 Commit summary: Fix end of lines in lists - virtual line endings ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93062]: New comment added
User "Krinkle" posted a comment on MediaWiki.r93062. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93062#c20140 Commit summary: r92054: Some IE fixes Comment: A more descriptive commit message would be helpful. What "some IE fixes" ? What was broken ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92153]: Revision status changed
User "Krinkle" changed the status of MediaWiki.r92153. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92153#c0 Commit summary: r92054 : Remove leftover space ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93063]: New comment added
User "Krinkle" posted a comment on MediaWiki.r93063. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93063#c20139 Commit summary: mw.user.js: Make sessionId public Comment: Why make this public ? The current user's ID should be available through mw.user.sessionId(). Where would you use generateId() for directly ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added
User "^demon" posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20138 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work either way. Comment: I see no reason for getting panties in a bunch over it...it looks just fine to me. TBH: this fix can probably be merge straight to 1.17wmf1 and then reverted in trunk. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93138]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93138. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93138#c0 Commit summary: Made setSiteInfoForWiki() check a new MW_LANG env variable (for use by extract2.php) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93141]: New comment added
User "Catrope" posted a comment on MediaWiki.r93141. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93141#c20137 Commit summary: Add support for relative-protocol urls in mw.loader.load Comment: Untagging 1.17, which doesn't support protocol-relative URLs anyway. 1.17wmf1 and 1.18 should still get this though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93141]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93141. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93141#c0 Commit summary: Add support for relative-protocol urls in mw.loader.load ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93140]: Revision status changed
User "^demon" changed the status of MediaWiki.r93140. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93140#c0 Commit summary: Tag for version 0.2.8 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93058]: Revision status changed
User "^demon" changed the status of MediaWiki.r93058. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93058#c0 Commit summary: Reverted r92489 and added/use hideDeprecated() to MW test framework ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92932]: Revision status changed
User "^demon" changed the status of MediaWiki.r92932. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92932#c0 Commit summary: Follow-up r86482, r86485: removed user_name portion of user_email index per CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92938]: Revision status changed
User "^demon" changed the status of MediaWiki.r92938. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92938#c0 Commit summary: MFT r92937 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92937]: Revision status changed
User "^demon" changed the status of MediaWiki.r92937. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92937#c0 Commit summary: Dummy-proof incLoginThrottle/clearLoginThrottle with trim() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91208]: Revision status changed
User "^demon" changed the status of MediaWiki.r91208. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91208#c0 Commit summary: * Marked WikiCategoryPage::hasViewableContent() as "public" * Renamed WikiPage::getID -> WikiPage::getId * Fixed undefined $changed var from r91180 * Various doc tweaks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91441]: Revision status changed
User "^demon" changed the status of MediaWiki.r91441. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91441#c0 Commit summary: Added percentages to ProfilerSimpleText ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91503]: Revision status changed
User "^demon" changed the status of MediaWiki.r91503. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91503#c0 Commit summary: Division by zero ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added
User "Dantman" posted a comment on MediaWiki.r93137. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93137#c20136 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work either way. Comment: Sure, but separating the class_exists into two whole conditional blocks and completely duplicating the $this->mUpload = new UploadFromStash(...);? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91976]: New comment added
User "^demon" posted a comment on MediaWiki.r91976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91976#c20135 Commit summary: New "Asirra" module, from the Asirra extension by Bachsau Comment: The HTTP wrappers are in includes/HttpFunctions.php. You probably can just use Http::get(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91976]: New comment added
User "Bachsau" posted a comment on MediaWiki.r91976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91976#c20134 Commit summary: New "Asirra" module, from the Asirra extension by Bachsau Comment: I couldn't find any data which is exported through JS and input by a user, so that it would need escaping. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93133]: Revision status changed
User "^demon" changed the status of MediaWiki.r93133. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93133#c0 Commit summary: Whitespace fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91976]: New comment added
User "Bachsau" posted a comment on MediaWiki.r91976. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91976#c20133 Commit summary: New "Asirra" module, from the Asirra extension by Bachsau Comment: Thank you for commenting. Please note I'm doing this in my free time and updates are coming when I've time for it. When I started to code Asirra on 1.15 there was no $wgExtensionAssetsPath and I also tried to find information about http wrappers and even xml parsers in MediaWiki, but without success. Documentation on MediaWiki is horrible. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93135]: Revision status changed
User "^demon" changed the status of MediaWiki.r93135. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93135#c0 Commit summary: Fix typo in qqq messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added
User "^demon" posted a comment on MediaWiki.r93137. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93137#c20132 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work either way. Comment: Comments are nice. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93137]: New comment added
User "Dantman" posted a comment on MediaWiki.r93137. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93137#c20131 Commit summary: Added a workaround for the lack of RequestContext in 1.17, so this code can be rolled into production. This code can be removed in 1.18+, but it'll work either way. Comment: This seams a little verbose, that could be done in one line instead of 7+comments. $this->mUpload = new UploadFromStash( class_exists( 'RequestContext' ) ? $this->createContext()->user : $GLOBALS['wgUser'] ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93128]: Revision status changed
User "^demon" changed the status of MediaWiki.r93128. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93128#c0 Commit summary: style fix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93132]: Revision status changed
User "^demon" changed the status of MediaWiki.r93132. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93132#c0 Commit summary: Adding __METHOD__ to parameters passed to wfMkdirParents() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93074]: Revision status changed
User "^demon" changed the status of MediaWiki.r93074. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93074#c0 Commit summary: svn:eol-style native for r93073 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93136]: Revision status changed
User "^demon" changed the status of MediaWiki.r93136. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93136#c0 Commit summary: More wfMkdirParents() __METHOD__ additions ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93009]: Revision status changed
User "^demon" changed the status of MediaWiki.r93009. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93009#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-07-24 19:50:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93117]: Revision status changed
User "^demon" changed the status of MediaWiki.r93117. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93117#c0 Commit summary: added since tag ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93013]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93013. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93013#c0 Commit summary: More mediawiki.js cleanup (addScript AJAX) - Update and merge in jQuery fixes: -- Dereference script (added) -- Order of actions -- Regex instead of two string comparisons -- Unit tests still pass :) Follows up: r92933, 93012 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93045]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93045. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93045#c0 Commit summary: Removing redundant check from $.fn.goIn/Out code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93124]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93124. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93124#c0 Commit summary: MoodBar front-end (IE8 now triggers browserDisabled) - IE8 has too many issues. Due to limited time we've decided to hide MoodBar in IE8 for now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93012]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93012. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93012#c0 Commit summary: More mediawiki.js cleanup - Convert prototype object modifications into object literal. Saves bandwidth (less characters) and speeds up execution (no need to access 2 level deep object member repetitively). Local testing (Chrome Web Inspector) shows 14.80KB to 14.67KB (non-cached, debug=false), and execution time on cached request 32ms to 25ms. - Un-indent 1 tab for d.setTime (Follows up r92964) - Whitespace consistency - Move var statements to top of loader's addScript Follows up: r92933 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92906]: New comment added
User "Werdna" posted a comment on MediaWiki.r92906. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92906#c20130 Commit summary: Wording updates Comment: You're awesome. :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93125]: Revision status changed
User "MaxSem" changed the status of MediaWiki.r93125. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93125#c0 Commit summary: RL2: Merge r93052 from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added
User "DieBuche" posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20129
Commit summary:
* Ignore any or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
There more than 3. Theoretically unlimited. "Why do you want to remove category
A, add Category C, change Category D to F and remove Category Z?"
I can switch to a simpler system though, if you think that this is impossible.
Something like: "Why do you want to make the following changes: * Add X \n *
Delete Y \n ... "
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93016]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93016. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93016#c0 Commit summary: Adding documentation for mw.loader.register ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92844]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92844. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92844#c0 Commit summary: Refactored cdb handling so that we have a dat and a cdb file. refreshWikiversionCDB builds that later from the former. This makes the addWiki.php changes easier and allows for manual version changes to a wiki (which we want). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93089]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93089. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93089#c0 Commit summary: Improved error messages from r92844 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93087]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93087.
Old Status: new
New Status: ok
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93087#c0
Commit summary:
MoodBar front-end dev, adjustments for v1.0:
* Refactor content swapping. Add support to swap to "blank user input" state,
which will be used when the trigger is clicked and the overlay was hidden.
Previously this state couldn't be swapped to since it requires a lot of extra
bindings, now the swapper detects this state and calls
prepareUserinputContent() which was merged out of core()
* Rename *-using messages to *-editing. Maybe r92906 should've introduced a new
bucket rather than re-using the existing one, but now that it has changed it
makes sense to adjust the bucket names. Upping version.
* Adding missing message keys for ext.moodBar.core in MoodBar.php, some
bucket's messages were not loaded
* Using is(':hidden') instead of !is(':visible'). jQuery's expression filter
for "visible" uses "!hidden" internally. Might as well use "hidden" directly
instead of "!visible"
* Adding overlayTitle to the bucket-roulation. Previously only the trigger's
link-text was changed per bucket, now the title changes as well (using the new
jquery.localize "keys" feature).
* Removing "moodbar" usergroup. This data is currently unfiltered and
considered to be private and sensitive. Bureaucrats should not be able to add
users to this group by default. The addition to wgAvailableRights stays so
wikis can add this userright to a group that they trust (eg. "staff"), but not
added to any group by default.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93049]: Revision status changed
User "Reedy" changed the status of MediaWiki.r93049. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93049#c0 Commit summary: 1.16: Fixed undefined variable error in recentchanges API module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93113]: New comment added
User "Reedy" posted a comment on MediaWiki.r93113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93113#c20128 Commit summary: Trim trailing whitespace Comment: It became whitespace! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93113]: New comment added, and revision status changed
User "Aaron Schulz" changed the status of MediaWiki.r93113. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r93113. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93113#c20127 Commit summary: Trim trailing whitespace Comment: getPossibleErrors change wasn't whitespace ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93116]: Revision status changed
User "Aaron Schulz" changed the status of MediaWiki.r93116. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93116#c0 Commit summary: Trim whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79408]: Revision status changed
User "Awjrichards" changed the status of MediaWiki.r79408. Old Status: deferred New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79408#c0 Commit summary: adding country to tracking table ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93111]: Revision status changed
User "Reedy" changed the status of MediaWiki.r93111. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93111#c0 Commit summary: Fix typo in r93071 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: New comment added
User "Platonides" posted a comment on MediaWiki.r85886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c20126 Commit summary: No need to quote just to avoid the prefixes. Comment: The usual way. Perhaps CodeReview noticed that I lowered the status from ok ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92871]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92871. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92871#c0 Commit summary: ArticleFeedback: reverse the sort order of highs so the best appear first ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93110]: Revision status changed
User "^demon" changed the status of MediaWiki.r93110. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93110#c0 Commit summary: Followup r93087 for translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93108]: Revision status changed
User "^demon" changed the status of MediaWiki.r93108. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93108#c0 Commit summary: Stop users marking their own revisions resolved (as well as ok) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93109]: Revision status changed
User "^demon" changed the status of MediaWiki.r93109. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93109#c0 Commit summary: Followup r93108, add "or Resolved" to right-codereview-review-own ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r85886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c20125 Commit summary: No need to quote just to avoid the prefixes. Comment: I thought neither were allowed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: New comment added
User "Reedy" posted a comment on MediaWiki.r85886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c20124 Commit summary: No need to quote just to avoid the prefixes. Comment: AFAIK we only stopped people ok'ing their own, not RESOLVED'ing them.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93105]: Revision status changed
User "^demon" changed the status of MediaWiki.r93105. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93105#c0 Commit summary: Make Chad happy ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93107]: Revision status changed
User "^demon" changed the status of MediaWiki.r93107. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93107#c0 Commit summary: Removed code lost in r93105, wtf. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: New comment added
User "^demon" posted a comment on MediaWiki.r85886. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c20123 Commit summary: No need to quote just to avoid the prefixes. Comment: Curious...how did you manage to mark you own revision "resolved?" It shouldn't allow that ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93103]: Revision status changed
User "^demon" changed the status of MediaWiki.r93103. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93103#c0 Commit summary: r85886 broke $wgSharedPrefix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added, and revision status changed
User "Raymond" changed the status of MediaWiki.r93090.
Old Status: new
New Status: fixme
User "Raymond" also posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20122
Commit summary:
* Ignore any or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
This is lego style and makes a lot of problems with many languages;
'ajax-category-question'=> 'Why do you want to $1?',
I suggest to use complete sentences per case. As I see 3 are needed only.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93105]: New comment added
User "^demon" posted a comment on MediaWiki.r93105. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93105#c20121 Commit summary: Make Chad happy ;) Comment: You removed include_once. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93099]: Revision status changed
User "^demon" changed the status of MediaWiki.r93099. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93099#c0 Commit summary: MFT r92958 (handled conflict) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added
User "Raymond" posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20120
Commit summary:
* Ignore any or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
Please note, trailing spaces will be trimmed automatically:
+'ajax-category-and' => ' and ',
Isn't it possible to use the core message
'and' => ' and',
if needed together with the other core message:
'word-separator' => ' '
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92247]: Revision status changed
User "NeilK" changed the status of MediaWiki.r92247. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92247#c0 Commit summary: Stylize ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: Revision status changed
User "Platonides" changed the status of MediaWiki.r85886. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c0 Commit summary: No need to quote just to avoid the prefixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93098]: Revision status changed
User "^demon" changed the status of MediaWiki.r93098. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93098#c0 Commit summary: Added include_once to shouldExecute() check ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92958]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r92958. Old Status: new New Status: ok User "^demon" also posted a comment on MediaWiki.r92958. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92958#c20119 Commit summary: Changed Maintenance::shouldExecute() to allow for multiple requires() in the stack. This avoids failing over requires due to Het wrappers. Comment: Two minor things, otherwise this is ok: * We should probably add include_once, just for safety. That was my fault anyway, you just copied it. * Move the count() near the beginning and reuse it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92844]: Revision status changed
User "Aaron Schulz" changed the status of MediaWiki.r92844. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92844#c0 Commit summary: Refactored cdb handling so that we have a dat and a cdb file. refreshWikiversionCDB builds that later from the former. This makes the addWiki.php changes easier and allows for manual version changes to a wiki (which we want). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r79518]: Revision status changed
User "Aaron Schulz" changed the status of MediaWiki.r79518. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/79518#c0 Commit summary: * Modified Article::loadPageData() to use a slave database connection and pageDataFromTitle() instead of pageDataFromId() in the default case, as in Wiki.php (this also saves a query since the ID will be fetched with other fileds) * Removed the loadPageData() call for the initial article in Wiki.php, will be triggered by the isRedirect() call 7 lines below if needed (this was not needed if $target is set by the InitializeArticleMaybeRedirect hook), but kept the second one (same as above, Article::exists() triggers Title::getArticleId() that would use one query to get id and a second one is needed to get the complete page data) * Modified Article::fetchContent() to use common code (loadPageData()) and to only call it if really needed ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84525]: Revision status changed
User "Catrope" changed the status of MediaWiki.r84525. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/84525#c0 Commit summary: Fixed daft error in r84523 so "angry" autoblocks work again ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added
User "^demon" posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20118
Commit summary:
* Ignore any or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
Removing 1.18 tag, AjaxCategories was removed from 1.18 and will not be
backported.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92112]: New comment added
User "DieBuche" posted a comment on MediaWiki.r92112. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92112#c20117 Commit summary: Rewrite ajaxCategories for ResourceLoader. Add some missing functionality (edit categories and more). Move styles from shared.css into own stylesheet. Fix regex bugs Comment: Done in r93090 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93090]: New comment added
User "DieBuche" posted a comment on MediaWiki.r93090.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93090#c20116
Commit summary:
* Ignore any or comment sections
* More natural messages
* Respect wgCaseSensitiveNamespaces
* Regex: Add possible whitespace between "[[Category:" and the category name. (
[[Category: Foo]] )
* Make nearly all functions publicly accessible
* Add "cancel all" button
* Submit on enter keypress
* Check for redirects
* Color links correctly based on existance of category page
* Add a summary of the changes done into the edit summary ('+Category:foo,
-Category:Bar: Foo is not correct...')
* Add more error handlers
* Add more hooks ( afterChange/Delete/add ).
* Pass category names to the hooks
* Allow hooks to abort by returning false
* Handle sortkey correctly in all operations
* Move addCategory form below categories.
* Fix any known IE6 and IE7 bugs.
* Add more documentation
Comment:
Forgot to mention in commit msg: This is a followup to r92112
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93088]: Revision status changed
User "Jack Phoenix" changed the status of MediaWiki.r93088. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93088#c0 Commit summary: Replacing my nick with my real name in CREDITS ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93037]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93037. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93037#c0 Commit summary: w/s fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93035]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93035. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93035#c0 Commit summary: * scap changes: ** Make sure we error-check wmf-config & multiversion code ** Refresh the wikiversions.cdb file on scap ** Removed php-1.17 reference (svn info) ** Call mwversionsinuse with the --home parameter (we don't want the usr/ .dat file here) * Changed scap-1skins to iterate over the active MW versions * Changed sync-l10nupdate to only work on a single MW version (1st argument), l10nupdate already calls it once per version ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93034]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93034. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93034#c0 Commit summary: Fix r93024: removed excess brackets ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93033]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93033. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93033#c0 Commit summary: Follow-up r93032: fixed use of $options var. Restored newline in output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93032]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93032. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93032#c0 Commit summary: * Ported mwversionsinuse code to activeMWVersions PHP script file. mwversionsinuse is now a thin wrapper around activeMWVersions. * activeMWVersions has a '--home' option (to be used by scap). * mwscript comment tweak. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93085]: New comment added, and revision status changed
User "Jeroen De Dauw" changed the status of MediaWiki.r93085. Old Status: deferred New Status: ok User "Jeroen De Dauw" also posted a comment on MediaWiki.r93085. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93085#c20115 Commit summary: set elements to display:none explicitly (workaround for css loaded late by RL) Comment: Awesome, thnx for fixing :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92923]: New comment added
User "DieBuche" posted a comment on MediaWiki.r92923. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92923#c20114 Commit summary: Followup r86622: add initial QUnit test cases for jquery.textSelection module. * tests .textSelection()'s encapsulateText method mostly (also uses setSelection, getContents, and getSelection) * examples from WikiEditor toolbar: sig, bold, h2 (ownline), ulist (ownline & splitlines) * confirms that splitlines works more or less as expected, at least for basic single-line, single split-line, and multi-line cases Doesn't test the WikiEditor iframe mode since that's in a separate extension; when it's possible to test those things too, that'll need to be run there. One of the h2 tests fails in IE6, returning selected text that's offset by one character from what's expected. I'm not sure whether it's actually selecting the wrong text or whether it's returning the wrong text -- needs further investigation. Also note that there's no setContents submethod in textSelection, despite there being some notes about one. Comment: This revealed some bugs in Opera http://toolserver.org/~krinkle/testswarm/?state=runresults&run_id=2100&client_id=3554 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93028]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93028. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93028#c0 Commit summary: Changed getMediaWikiCli() to use /home or /usr for requested script based on whether the home/ or usr/ copy of MWScript.php was called. This makes it more consistent with how things are now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93024]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93024. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93024#c0 Commit summary: * Use error_reporting( E_ALL ) in more places * Simplified mwscript a bit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93018]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r93018. Old Status: new New Status: ok User "Catrope" also posted a comment on MediaWiki.r93018. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93018#c20113 Commit summary: Added possible error msg to refreshWikiversionsCDB for rename() Comment: Alright, this addresses most of my earlier CR comment, except that there were two instances where "Unable to create wikiversions.cdb" was thrown and you only changed one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93014]: Revision status changed
User "Catrope" changed the status of MediaWiki.r93014. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93014#c0 Commit summary: Initial checkin of scap-1skins (from wikimedia-task-appserver) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92977]: New comment added
User "Catrope" posted a comment on MediaWiki.r92977. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92977#c20112 Commit summary: * Version ExtensionMessages.php * Fixed error msg wording (it's the .dat file we read) Comment: CommonSettings change is OK. Shell changes look sane but someone else needs to look at those. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92974]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92974. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92974#c0 Commit summary: checkin of scap script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92957]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92957. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92957#c0 Commit summary: Improved getVersion() error messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92844]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r92844. Old Status: new New Status: fixme User "Catrope" also posted a comment on MediaWiki.r92844. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92844#c20111 Commit summary: Refactored cdb handling so that we have a dat and a cdb file. refreshWikiversionCDB builds that later from the former. This makes the addWiki.php changes easier and allows for manual version changes to a wiki (which we want). Comment: + die( "Unable to create wikiversions.cdb.\n" ); Both instances of this error message should say wikiversions.cdb.tmp instead. OK otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92847]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92847. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92847#c0 Commit summary: This needs to use that dat file, not the cdb one ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92831]: New comment added
User "Aaron Schulz" posted a comment on MediaWiki.r92831. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92831#c20110 Commit summary: * Added cdbmake file back and cleaned up some .cdb file generation confusion * Merged some CommonSettings changes Comment: This stuff was killed anyway ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92831]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r92831. Old Status: new New Status: ok User "Catrope" also posted a comment on MediaWiki.r92831. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92831#c20109 Commit summary: * Added cdbmake file back and cleaned up some .cdb file generation confusion * Merged some CommonSettings changes Comment: + passthru( sprintf( + "$common/multiversion/cdbmake-12.sh %s %s < $common/wikiversions.dat", + "$common/wikiversions.cdb", + "$common/wikiversions.dat.tmp" + ) ); The use of sprintf here comes across as unnecessarily funky to me (the arguments are constants). OK otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
