[Wikitech-l] Haifa Hackathon schedule / Lightning talks proposals
Shalom all, A draft schedule for the Haifa Hackathon has been published: http://wikimania2011.wikimedia.org/wiki/Developer_Days Some last details are being worked out. In particular, there are still many slots for 5-minute lightning talks every hour. Many of the topics listed under the Topics heading on that page can be subjects of lightning talks, so if you can present it as a lightning, please add it at the bottom. See you in Haifa... in two days!! -- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93573]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93573#c20320 Commit summary: Added README file. Comment: svn:eol-style missing? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93574]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93574. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93574#c20321 Commit summary: Added 'add to article selection' functionality Comment: svn:eol-style missing? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93549]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r93549. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93549#c0 Commit summary: fu r93545: Add message for the new user right ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93548]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r93548. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93548#c0 Commit summary: fu r93541: Add new special page to the corresponding alias file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] How to handle a large change w/ no commit access
Hey all. In light of recent discussions on this list about using branches and not commit broken code, I'd like to ask for some advice. Firstly, a little on me. I'm an amateur programmer, and more than a bit rubbish at times (despite PHP being my strongest language). I've submitted a number of patches to Bugzilla, prodded people on IRC, etc. and they've been reviewed and accepted with minor changes. They've all been small, easily readable patches for paper cut bugs so far. More recently, I've been having a prod at some of the page protection code. My goal currently is to make it possible to overlay different editing restrictions e.g. to make it possible to have a temporary surge in protection to +sysop without touching the underlying +autoconfirmed. I've been having some success with the basic operations, although it has required an additional pr_id column to be added to page_restrictions and a couple of key changes. Obviously my code would need substantial review when I'm done, particularly to consider the many odd cases that come up when you've got 10 million visitors and not just 1. So, two questions: * Should I write up my proposed changes for people to comment on? If so, where? How should I publicise it? What sort of things should I mention? * Am I in danger of essentially creating one large patch which then has to be commited all in one go? Should I try to avoid this? How? Thanks all and apologies for some many questions, Harry (User:Jarry1250) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] How to handle a large change w/ no commit access
1. Write up a proposal somewhere (Eg: in your userspace on wiki then share the link around or post it to the mailing list) 2. Apply for commit access (link to the proposal/patches you have done etc etc, we do have the ability to give access to certain sections of the SVN such as branches without allowing committing to to the main trunk of mediawiki (/phase3/)) Although some people may recommend doing major changes off site (eg: github), I highly recommend against this since most of our devs don't want to have to go offsite to review code changes unless you do it via a Git to SVN gateway system/setup (eg: Brion does this for some work). ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ask the Developers panel at Wikimania
On Sat, Jul 30, 2011 at 6:16 PM, Daniel Kinzler dan...@brightbyte.de wrote: Hi all! Ask you may know, there will be an Ask the Developers panel at Wikimania. However, there are no developers to ask, yet :) To make this work, we need a few lead WMF developers on the stage, ready to answer questions. So please let me know if you would be willing to do that, or tell me who I could ask to take part in the panel. I'm in! Roan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93590]: New comment added, and revision status changed
User TheDJ changed the status of MediaWiki.r93590. Old Status: new New Status: fixme User TheDJ also posted a comment on MediaWiki.r93590. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93590#c20322 Commit summary: var server, is not being used by any of the scripts atm. Remove it since hard coded as en.wikipedia.org. Comment: hmm, perhaps this is used by json ? Should check with hcatlin... in that case should be replaced with wgServer of course. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How to handle a large change w/ no commit access
On Sun, Jul 31, 2011 at 3:46 AM, K. Peachey p858sn...@gmail.com wrote: 1. Write up a proposal somewhere (Eg: in your userspace on wiki then share the link around or post it to the mailing list) 2. Apply for commit access (link to the proposal/patches you have done etc etc, we do have the ability to give access to certain sections of the SVN such as branches without allowing committing to to the main trunk of mediawiki (/phase3/)) Although some people may recommend doing major changes off site (eg: github), I highly recommend against this since most of our devs don't want to have to go offsite to review code changes unless you do it via a Git to SVN gateway system/setup (eg: Brion does this for some work). I usually do that for self-contained pieces like a new extension -- this can be built in isolation (but in a way that you can share for ongoing review and testing), then pushed over to SVN when it's ready. It can be a little trickier to do for existing core code that way. (Extensions are also easier to develop straight in SVN, since new ones don't have to be backwards-compatible! It's ok to check it in and have it a little flaky still if it's not yet completed or used.) Generally speaking the best thing is to start tossing the idea around here on the list ( write up a page on www.mediawiki.org/wiki/RFC); if there's a relevant bugzilla entry, start posting patches there when code's ready to be tested / reviewed. We're trying to find ways to make the communication - review - response feedback look more reliable, so feel free to speak up if you're not getting clear directions! For big changes, usually there's an advantage to splitting it up into smaller pieces. You can then do various parts of the change relatively independently; changing one thing at a time. This can make the code easier to follow for reviewers, but even more importantly makes each change easier to understand *and test*... and in many cases, self-contained stages mean that we can make the actual commits incrementally without breaking backwards-compatbility. -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Ask the Developers panel at Wikimania
I suppose I can make that :D -- brion On Sat, Jul 30, 2011 at 9:16 AM, Daniel Kinzler dan...@brightbyte.dewrote: Hi all! Ask you may know, there will be an Ask the Developers panel at Wikimania. However, there are no developers to ask, yet :) To make this work, we need a few lead WMF developers on the stage, ready to answer questions. So please let me know if you would be willing to do that, or tell me who I could ask to take part in the panel. In any case I want to invite all developers to be there at least in the audience, so specific questions can be answered directly by someone working on that topic. Originally, this sessions was planned as a fish bowl type discussion on Danes' suggestion, which would remove the distinction between panelists and audience. But since she won't be there and I don't have any experience with that kind of thing, it's going to be a regular panel. The session is scheduled in the block starting on 10:15 on Friday. Shortly before that, Guillome has his Wikimedia technical staff vs. the_World - perhaps we could arrange to combine or rather links these two events? Have the ask the devs basically as the discussion round to staff vs. world? What do you think? See you in Haifa, hopefully for the Hacking Days already -- daniel * http://wikimania2011.wikimedia.org/wiki/Submissions/Ask_the_Developers * http://wikimania2011.wikimedia.org/wiki/Submissions/Wikimedia_technical_staff_vs._the_World ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93594]: New comment added, and revision status changed
User Jeroen De Dauw changed the status of MediaWiki.r93594. Old Status: deferred New Status: ok User Jeroen De Dauw also posted a comment on MediaWiki.r93594. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93594#c20323 Commit summary: Fix to r85127 - better check for SMW 1.6 Comment: Ah, now I fully get what you where talking about; seems like I didn't know this method was still present for some types when making this commit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93573]: New comment added
User Jlemley posted a comment on MediaWiki.r93573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93573#c20324 Commit summary: Added README file. Comment: Fixed - thank you! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93573]: New comment added
User Jlemley posted a comment on MediaWiki.r93573. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93573#c20325 Commit summary: Added README file. Comment: Funny thing about that. I could not find a way to set this in Auto-props for files with no extension. I even tried adding *. with the wrapping fix, but it's still not there. Is there a way to automatically do this? In the meantime, I manually set that property on the readme file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93494]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r93494. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93494#c0 Commit summary: move call to getAllCapabilities to after test for isSpecific on device ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93595]: New comment added
User Eloquence posted a comment on MediaWiki.r93595. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93595#c20326 Commit summary: Instead of scraping the page title, use the actual title from the title object (and the actual title) Comment: Mh, I'm guessing the wurfl-config.xml change was accidentally committed as part of this rev? It did have the nice side effect of fixing WURFL for me. ;-) Obviously hardcoding config options here is wrong -- would be nice to move this into a config flag for the extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93595]: New comment added
User TheDJ posted a comment on MediaWiki.r93595. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93595#c20327 Commit summary: Instead of scraping the page title, use the actual title from the title object (and the actual title) Comment: Thx. Yeah I already made a note somewhere that we really should be using inmemoryconfig of wurfl. http://www.scientiamobile.com/api-doc/php/WURFL_Configuration/WURFL_Configuration_InMemoryConfig.html ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added
User Hashar posted a comment on MediaWiki.r93607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20328 Commit summary: Being a father [X] Checked! Comment: This commit is proud to announce the birth of hashar's daughter. /me offers a round of Champagne! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added
User MZMcBride posted a comment on MediaWiki.r93607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20329 Commit summary: Being a father [X] Checked! Comment: Congrats! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93607]: Revision status changed
User Platonides changed the status of MediaWiki.r93607. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c0 Commit summary: Being a father [X] Checked! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] How to handle a large change w/ no commit access
K. Peachey wrote: 1. Write up a proposal somewhere (Eg: in your userspace on wiki then share the link around or post it to the mailing list) 2. Apply for commit access (link to the proposal/patches you have done etc etc, we do have the ability to give access to certain sections of the SVN such as branches without allowing committing to to the main trunk of mediawiki (/phase3/)) Although some people may recommend doing major changes off site (eg: github), I highly recommend against this since most of our devs don't want to have to go offsite to review code changes unless you do it via a Git to SVN gateway system/setup (eg: Brion does this for some work). I agree with the above. We should have some path in /branches for these kind of branches, eg. /branches/pastebin. Then I would be easy to grant access there to some non-core users. I would then copy the files and start working with the proposal (however, you don't need a complete rewrite before gathering feedback). ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r93461]: New comment added
User Platonides posted a comment on MediaWiki.r93461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93461#c20330 Commit summary: move current exhbit format to a not-used dir since it's not working properly, but can be further fixed later Comment: Deleting folders with extenals are problematic since the external folder is still there, and the old folder refuses to be deleted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added
User Reedy posted a comment on MediaWiki.r93607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20331 Commit summary: Being a father [X] Checked! Comment: The signoff literally made me lol. $hashar-manPoints++; Congratulations! We'll see you in a few weeks then? :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93530]: New comment added
User Platonides posted a comment on MediaWiki.r93530. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93530#c20332 Commit summary: Merge iwtransclusion branch into trunk Comment: I think it would have been nice to announce this merge in wikitech-l Why does the interwiki need to pass through the Preprocessor? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93461]: New comment added
User Jeroen De Dauw posted a comment on MediaWiki.r93461. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93461#c20333 Commit summary: move current exhbit format to a not-used dir since it's not working properly, but can be further fixed later Comment: Well, it svn mv'd it, not deleted it... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93461]: New comment added
User Platonides posted a comment on MediaWiki.r93461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93461#c20334 Commit summary: move current exhbit format to a not-used dir since it's not working properly, but can be further fixed later Comment: It's part of subversion quirks, moves are stored as delete + copy . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93607]: New comment added
User Platonides posted a comment on MediaWiki.r93607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93607#c20335 Commit summary: Being a father [X] Checked! Comment: We should assign him bug 167801! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93530]: New comment added
User Platonides posted a comment on MediaWiki.r93530. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93530#c20336 Commit summary: Merge iwtransclusion branch into trunk Comment: I think those files should have got merge properties. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93530]: New comment added
User Reedy posted a comment on MediaWiki.r93530. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93530#c20337 Commit summary: Merge iwtransclusion branch into trunk Comment: I've no idea why it does. It's not my code And I think it was, sometime fairly recently... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Bugzilla Weekly Report
MediaWiki Bugzilla Report for July 25, 2011 - August 01, 2011 Status changes this week Bugs NEW : 225 Bugs ASSIGNED : 23 Bugs REOPENED : 34 Bugs RESOLVED : 138 Total bugs still open: 5878 Resolutions for the week: Bugs marked FIXED : 73 Bugs marked REMIND : 0 Bugs marked INVALID: 38 Bugs marked DUPLICATE : 12 Bugs marked WONTFIX: 7 Bugs marked WORKSFORME : 6 Bugs marked LATER : 3 Bugs marked MOVED : 0 Specific Product/Component Resolutions User Metrics New Bugs Per Component Parser 9 General/Unknown 7 Special pages 6 MobileFrontend 5 General/Unknown 5 New Bugs Per Product MediaWiki 34 Wikimedia 11 MediaWiki extensions22 mwdumper1 Wikipedia Mobile1 Top 5 Bug Resolvers innocentkiller [AT] gmail.com 31 sam [AT] reedyboy.net 28 jeroen_dedauw [AT] yahoo.com7 brion [AT] wikimedia.org7 hashar [AT] free.fr 5 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
