[MediaWiki-CodeReview] [MediaWiki r94603]: New comment added
User "Wikinaut" posted a comment on MediaWiki.r94603. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94603#c20881 Commit summary: fix of a whitespace problem in the i18n system message Comment: I don't know what happened exactly, but the previous version did not work (the [[MediaWiki:Rss-feed]] was not set). After reediting, committing and checking the new chechout, it does work now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94558]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r94558. Old Status: fixme New Status: reverted User "Hashar" also posted a comment on MediaWiki.r94558. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94558#c20882 Commit summary: Tests for wfGetIP() follow up r89407 * wfGetIP() now support resetting its internal static variable. Thanks to Platonides which introduced this trick with r92960. * Various tests for $_SERVER['REMOTE_ADDR'] and $wgCommandLineMode. TODO: - implements tests for XFF headers. TEST PLAN: $ ./phpunit.php --filter wfGetIP --testdox PHPUnit 3.5.14 by Sebastian Bergmann. wfGetIP [x] Get loopback address when in command line [x] Get from server remote addr [x] Lack of remote addr throw an exception $ Comment: Reverted. Will fix it later :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Dropping PHP 5.2 support
On 16 August 2011 02:38, Jay Ashworth wrote: > Note that I just installed 1.17 on CentOS *5.6*, and the shipping PHP there > is still 5.1.x; I had to set up epel to pull in something as new as 5.3.6 > to get it to run at all. > I admit I was surprised that something as new as C5.6 didn't have a new enough > PHP for our current production release, but there you have it. Yeah, I got caught by this putting 1.17 on RHEL5. I ended up compiling PHP 5.3.6 from source just to generate a suitably up-to-date libphp5.so. In practical terms, RHEL and its derivatives these days is the old software graveyard Debian used to have a reputation for being. I suppose the question is "what's on common cheap generic hosting these days?" The people using generic hosting will be the ones without the ability to upgrade without changing hosting company. - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94038]: New comment added
User "Santhosh.thottingal" posted a comment on MediaWiki.r94038. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94038#c20883 Commit summary: Remove implementation of font-scale. Need to find a better way to achieve uniform scaling. Marking as TODO item for now. Comment: This commit address r91815 code review. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90092]: New comment added
User "Hashar" posted a comment on MediaWiki.r90092. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90092#c20884 Commit summary: fix for bug29371 . regex wordwrap with UTF8: do not use \b metacharacter. The problem is that JavaScript recognizes word boundaries only before/after ASCII letters (and numbers/underscore) Comment: Basic framework in r94609 . You should be able to add more tests easily from there. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80248]: New comment added
User "Mormegil" posted a comment on MediaWiki.r80248. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80248#c20885 Commit summary: Implement Message::isBlank and Message::isDisabled. And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods. Comment: There are two still unfixed bad boolean checks in ProtectionForm.php: Both checks at http://goo.gl/urWec are inverted. See [[bugzilla:30391]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] sidebar statistics
On Tue, Aug 16, 2011 at 8:30 AM, Amir E. Aharoni wrote: > 2011/8/16 MZMcBride : >> An extension such as ClickTracking is probably a much better option if you >> can get local consensus and sysadmin support. > > Are there any special implications i should know about? Privacy? > Performance? Anything else? > As for privacy: for each event, we store * the kind of event (e.g. 'clicked on the recent changes link in the sidebar') * the timestamp, with second-level granularity, in UTC (just like for edits) * whether the user was logged in * the user's lifetime edit count at the time of the event * the number of edits the user made in the 1, 3 and 6 months preceding the event This is all tracked in a database table that is not shared with the outside world. The data we'll give you will be in some aggregated form like "on September 2nd between 16:00 and 17:00 UTC, the recent changes link was clicked 40 times, of which 30 clicks were by users with a lifetime edit count greater than 10". So aside from the fact that we store some mildly stalkerish (but not personally identifiable, unless your edit count differs substantially from everyone else's such that you can be identified by your edit count alone) information privately, the information we make public shouldn't be privacy-sensitive, right? As for performance, we'll be fine. As I said, we've run this kind of thing on wikis before (including enwiki, which is a little bit higher-traffic than hewiki) and we were fine. We just didn't do much with the data at the time IIRC (apart from looking at 'how many times was each link clicked for the duration of the tracking', which only tells you which links are used and which aren't), and it's too old to be useful now. Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94522]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94522. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94522#c0 Commit summary: added to rel notes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94518]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94518. Old Status: deferred New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94518#c0 Commit summary: Update Wikia MediaWiki extension support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94519]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94519. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94519#c0 Commit summary: Update Wikia MediaWiki extension support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r93985. Old Status: deferred New Status: new User "Nikerabbit" also posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c20886 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Seems to silently break Translate extension for older version which don't have this hook. I think that is acceptable given the minor impact, not many people rely on this behavior. I'd like to break the onPageContentLanguage to two different functions, since code under tag/ should only handle page translation feature related stuff. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93816]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r93816. Old Status: deferred New Status: ok User "Nikerabbit" also posted a comment on MediaWiki.r93816. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93816#c20887 Commit summary: Disable magic word Li10n for ParserFunctions extension. Doing it the Special:Magic way sucks. Comment: I would have done the same. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92956]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r92956. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92956#c20888 Commit summary: DifferenceEngine: introduce setDiffLang() to change the language in which the diff text is written. Translate: set the the diff text according to the source language, on Special:PageTranslation and the translation messages. (Also fix direction of CSS class mw-translate-fuzzy). Comment: I think mDiffLang should be protected, and I'd rename the function to setTextLanguage(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94526]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94526. Old Status: new New Status: ok User "Nikerabbit" also posted a comment on MediaWiki.r94526. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94526#c20889 Commit summary: updated mwe-upwiz-invalid-session-key error in i18n for all languages, followup to r92009 Comment: Renaming the key in English is sufficient. Translatewiki.net will handle moving all translations, retaining history and fuzzy status (whether translation is up to date). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91815]: New comment added, and revision status changed
User "Santhosh.thottingal" changed the status of MediaWiki.r91815. Old Status: fixme New Status: new User "Santhosh.thottingal" also posted a comment on MediaWiki.r91815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91815#c20890 Commit summary: if we scale the $(body), interface is becoming wrong. Apply the font scaling, if present in configuration to selected nodes. Comment: Changing to new since it is addressed in r94038 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91815]: New comment added
User "Santhosh.thottingal" posted a comment on MediaWiki.r91815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91815#c20891 Commit summary: if we scale the $(body), interface is becoming wrong. Apply the font scaling, if present in configuration to selected nodes. Comment: Changing to new since it is addressed in r94038 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82212]: New comment added, and revision status changed
User "Yaron Koren" changed the status of MediaWiki.r82212. Old Status: fixme New Status: new User "Yaron Koren" also posted a comment on MediaWiki.r82212. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82212#c20892 Commit summary: Added handling for regular expressions Comment: Changing status from "fixme" back to "new" - I think the bugs found were all addressed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94614]: New comment added
User "Hashar" posted a comment on MediaWiki.r94614. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94614#c20893 Commit summary: force QUnit charset to UTF-8 Comment: Make the output of r94609, which use 'Ö', correct in the output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90613]: Revision status changed
User "Hashar" changed the status of MediaWiki.r90613. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90613#c0 Commit summary: Followup r90595: Tweak tablesorter tests so they run on r86088 version of jquery.tablesorter.js -- which actually passes these tests. The key regressions appear to have come in in r86337. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94614]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r94614. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94614#c20894 Commit summary: force QUnit charset to UTF-8 Comment: Seems to be ok unless server is configured to sent wrong encoding. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Reclaiming a lost account on a private wiki: impossible
http://wiki.dikurevy.dk/Speciel:PasswordReset?uselang=en Seriously? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Reclaiming a lost account on a private wiki: impossible
make the wiki less private for a second, request the password and voila 2011/8/16 Svip > http://wiki.dikurevy.dk/Speciel:PasswordReset?uselang=en > > Seriously? > > ___ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > -- Kind regards, Huib Laurens WickedWay.nl Webhosting the wicked way. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Reclaiming a lost account on a private wiki: impossible
On 16 August 2011 12:47, Huib Laurens wrote: > make the wiki less private for a second, request the password and voila Assume that it is a company or community wiki that people are invited into. That means several accounts will be using the wiki and an administrator may not always be available to make it less private for a moment. It is not *my* account that is lost, it is another one's. Perhaps allow sysops to request passwordresets for other users? ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Reclaiming a lost account on a private wiki: impossible
On Tue, Aug 16, 2011 at 12:45 PM, Svip wrote: > http://wiki.dikurevy.dk/Speciel:PasswordReset?uselang=en > > Seriously? > You should put Special:PasswordReset in $wgWhiteListSomething. Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Reclaiming a lost account on a private wiki: impossible
On Tue, Aug 16, 2011 at 12:52 PM, Bryan Tong Minh wrote: > You should put Special:PasswordReset in $wgWhiteListSomething. > https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Manual:$wgWhitelistRead Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94536]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r94536. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94536#c20895 Commit summary: Fixed incorrect usage of || operator, added test removed spurious use of empty() listFiles() was broken, now works followup to r92009 Comment: Hmph, the type of mLocalFile is not stated anywhere. I guess it's not a string but object|null. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94527]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94527. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94527#c0 Commit summary: Account for Math being moved to an extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added, and revision status changed
User "IAlex" changed the status of MediaWiki.r93758.
Old Status: fixme
New Status: new
User "IAlex" also posted a comment on MediaWiki.r93758.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93758#c20896
Commit summary:
* (bug 15558) Allow includable special pages to be parameterized using wiki
syntax
* Changed SpecialPageFactory::capturePath() to take the same parameters as
SpecialPageFactory::executePath() (except the last one) and made it always
return a bool instead of bool-or-string. The result HTML can be fetched from
the OutputPage object of the context.
* Added module styles, scritps and messages members to ParserOutput in addition
to modules. The first one is needed to display Special:RecentChanges correctly
when transcluded since EnhancedChangesList::beginRecentChangesList() calls
addModuleStyles( 'mediawiki.special.changeslist' )
Yes, this means that you can use {{Special:Recentchanges|enhanced=0}} to use
the old changes list. For the ones that wonder,
{{Special:Recentchanges|uselang=something}} will not work since the Language
object is forced to the one used by the parser.
Comment:
Removed in r94619.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93758]: New comment added
User "IAlex" posted a comment on MediaWiki.r93758.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/93758#c20897
Commit summary:
* (bug 15558) Allow includable special pages to be parameterized using wiki
syntax
* Changed SpecialPageFactory::capturePath() to take the same parameters as
SpecialPageFactory::executePath() (except the last one) and made it always
return a bool instead of bool-or-string. The result HTML can be fetched from
the OutputPage object of the context.
* Added module styles, scritps and messages members to ParserOutput in addition
to modules. The first one is needed to display Special:RecentChanges correctly
when transcluded since EnhancedChangesList::beginRecentChangesList() calls
addModuleStyles( 'mediawiki.special.changeslist' )
Yes, this means that you can use {{Special:Recentchanges|enhanced=0}} to use
the old changes list. For the ones that wonder,
{{Special:Recentchanges|uselang=something}} will not work since the Language
object is forced to the one used by the parser.
Comment:
Removed in r94619.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94540]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94540. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94540#c0 Commit summary: checking for existence of mLocalFile in stashFile() was inverted followup to r94536 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94536]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r94536. Old Status: new New Status: resolved User "Catrope" also posted a comment on MediaWiki.r94536. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94536#c20898 Commit summary: Fixed incorrect usage of || operator, added test removed spurious use of empty() listFiles() was broken, now works followup to r92009 Comment: + return preg_match( UploadStash::KEY_FORMAT_REGEX, $key ) ? true : false; Instead of ? true : false a cast to boolean is preferred: return (bool)preg_match( . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83707]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r83707. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83707#c0 Commit summary: Made some improvements to SQL, including use of addQuotes() - follow-up to r82212 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84054]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r84054. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84054#c0 Commit summary: Added escaping so that a search string containing a space can be used on page names ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91815]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r91815. Old Status: new New Status: resolved User "Nikerabbit" also posted a comment on MediaWiki.r91815. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91815#c20899 Commit summary: if we scale the $(body), interface is becoming wrong. Apply the font scaling, if present in configuration to selected nodes. Comment: Marking as resolved. Scaling is currently disabled until we figure out a way to do it that is good enough. That discussion doesn't need to be in here. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94551]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94551. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94551#c0 Commit summary: Renaming SF_FormClasses.php to SF_TemplateInForm.php, as first step in splitting into two files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94553]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94553. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94553#c0 Commit summary: Split SF_FormClasses.php into two files, SF_Form.php and SF_TemplateInForm.php - now there's one class per file, which is the right approach ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94551]: Revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94551. Old Status: ok New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94551#c0 Commit summary: Renaming SF_FormClasses.php to SF_TemplateInForm.php, as first step in splitting into two files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94564]: New comment added, and revision status changed
User "Nikerabbit" changed the status of MediaWiki.r94564. Old Status: new New Status: fixme User "Nikerabbit" also posted a comment on MediaWiki.r94564. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94564#c20900 Commit summary: add support to render the main page content in a sane way Comment: Why is there both $mAction and $action, which are both set to the same and never changed? Besides ''m'' prefix refers to member variables. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94566]: New comment added
User "Nikerabbit" posted a comment on MediaWiki.r94566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94566#c20901 Commit summary: fix for fatal error caused by call to isMainPage Comment: What was the error? The replacement looks wrong and inefficient? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94592]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r94592.
Old Status: new
New Status: ok
User "Catrope" also posted a comment on MediaWiki.r94592.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94592#c20902
Commit summary:
Removed complex replag handling, now just query master when record isn't
present on slave.
followup to r92009
Comment:
+ protected function fetchFileMetadata( $key, $readFromMaster = false ) {
Instead of using a meaningless boolean parameter (there are lots of legacy ones
in MW, but we've turned against this style lately), please do something like
$readFromDBType = DB_SLAVE which the caller then overrides to
DB_MASTER. A call to fetchfileMetadata( $key, DB_MASTER
) is more meaningful than a call to fetchFileMetadata( $key, true
) .
(In normal cases, that means you can feed $readFromDBType directly
into wfGetDB() as well, but your case is different because of the
filerepo stuff.)
Otherwise OK, marking as such.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94594]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r94594.
Old Status: new
New Status: ok
User "Catrope" also posted a comment on MediaWiki.r94594.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94594#c20903
Commit summary:
Removed the ability to pass a key into stashFile(), which simplifies the stash
row creation a great deal.
Updated UploadFromUrlJob to properly use the database stash
followup to r92200
Comment:
* @param $key String: (optional) the file key used to find the file
info again. If not supplied, a key will be autogenerated.
* @return UploadStashFile stashed file
*/
- public function stashFile( $key = null ) {
+ public function stashFile() {
In this and pretty much every other instance, by the looks of it, you've
removed the parameter from the function prototype but not from the doc comment.
// if a row exists but previous checks on it passed, let the
current user take over this key.
This comment doesn't make sense anymore and should be removed.
Why is the session still being used in UploadFromUrlJob?
OK otherwise, marking as such, tagging todo for the comment issues.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94601]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94601. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94601#c0 Commit summary: follow-up r88171 - fix fatal if suggested filename has illegal character in it. Check to make sure the title object actual exists, before checking its namespace, since alll the does this have illegal chars check is done after the does it start with file: check. For future note though, when using upload by url feature, the suggested destination name when you put http://upload.wikimedia.org/wikipedia/commons/e/e0/Petrorhagia_prolifera_%281%29.JPG is illegal, which is probably not very user-friendly (filed as bug 30390) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94604]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94604. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94604#c0 Commit summary: Removed unused MW_DBNAME crap ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94606]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94606. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94606#c0 Commit summary: Merged scap-1versions into scap ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94608]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r94608. Old Status: new New Status: ok User "Catrope" also posted a comment on MediaWiki.r94608. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94608#c20904 Commit summary: Fixed XSS Comment: Good catch. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94566]: New comment added
User "Catrope" posted a comment on MediaWiki.r94566. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94566#c20905 Commit summary: fix for fatal error caused by call to isMainPage Comment: Title::isMainPage() is not available in 1.17wmf1, which caused a fatal error when we deployed the code to testwiki. Yes, this is inefficient and wrong (false positive if both the main page and self::$title don't exist). What you want is Title::newMainPage()->equals( self::$title ) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92200]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92200. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92200#c0 Commit summary: fixed a condition where re-uploading a file that's already stashed causes breakage. This mirrors the previous session-based behavior as closely as possible. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94548]: Revision status changed
User "Catrope" changed the status of MediaWiki.r94548. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94548#c0 Commit summary: Followup r92430 per CR, like r94448 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92009]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92009. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92009#c0 Commit summary: Refactored UploadStash and related classes to use the database for file metadata storage instead of the session, see bug 26179 Tweaked the UploadWizard to work properly with the new backend code, updated tests ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94482]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r94482. Old Status: new New Status: fixme User "Catrope" also posted a comment on MediaWiki.r94482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/94482#c20906 Commit summary: Follow-up r92559: * Use preg_quote() for arrays going to regexes * Proper escaping for InfoPage->mFormatTitle and status message * Use wgOut->addModuleStyles() to prevent flash of unstyled content * Use $wgExtensionAssetsPath to form extension directory * Remove unneeded isset()s * Also, prevent php notices in onShowMissingArticle() Comment: + $link = self::getSubdomain( $prefix2['lang'], $p, + ( $title->getNsText() ? $title->getNsText() . ':' : '' ) . $prefix2['realtitle'] ); Why did you intentionally duplicate this code? Per Nikerabbit, you should pass '/' as the second param to preg_quote(). You can do this in two ways: either create a private static wrapper function that returns preg_quote( $foo, '/' ), or use array_map( 'preg_quote', $arr, array_fill( 0, count( $arr ), '/' ) ); . ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92559]: Revision status changed
User "Catrope" changed the status of MediaWiki.r92559. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/92559#c0 Commit summary: Major update of stable features from development code. * For non-existing info pages (Wx/xx[x] pages), add a welcome page (either missing, existing or closed wikis) * It automatically checks the database list if available (which is the case on WMF wikis), like SiteMatrix * Pages belonging to existing wikis are not editable and show a link to the existing wiki. You will be redirected automatically if URL &testwiki or your preference is set to that test wiki. * Show a logo per-project, and possibility to set it per-wiki (if URL &testwiki or your preference is set to that test wiki) This is developed against 1.17wmf1 so everything should work on Incubator itself. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89408. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89408#c0 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89397]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89397. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89397#c0 Commit summary: (bug 28840) If the query string hits bug 28235, redirect to a safer URL instead of showing an unhelpful error message. IE 6 will only use the extension of the final destination for its cache filename. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88488]: Revision status changed
User "Catrope" changed the status of MediaWiki.r88488. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88488#c0 Commit summary: Similarise queries to that of SpecialWatchlist ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89545]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89545. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89545#c0 Commit summary: WatchAction requires token (BREAKING CHANGE) * (bug 27655) Require token for watching/unwatching pages * Previously done for API (bug 29070) in r88522 * As with markpatrolled, the tokens are not compatible and made that way on purpose. The API requires the POST method and uses a universal token per-session. Since the front-end is all GET based (also per convention like in markpatrolled and rollback) they are stronger salted (title / action specific) * ajax.watch used the API already and was switched in r88554. * The actual watching/unwatching code was moved from WatchAction->onView to WatchAction::doWatch. This was done to allow the API to do the action without needing to generate a token like the front-end needs (or having to duplicate code). It is now similar to RecentChange::markPatrolled (in that it also a "central" function that does not care about tokens, it's called after the token-handling) * JavaScript / Gadgets that utilize action=watch in their scripts: ** Effects should be minimal as they should be using the API (see r88522 and wikitech-l) ** If they use index.php and scrap the link from the page, they can continue to do so. * There are links to the watch action all over the place. I've tried to catch most of them, but there may be some I miss. Migration in most cases is just a matter of adding an array item to the $query for: 'token' => WatchAction::getWatchToken( $title, $user [, $action] ) or changing: Action::factory( 'watch', $article )->execute(); to: WatchAction::doWatch( $title, $user ); While replacing the usages in some cases an instance of Article() no longer had to be created, in others $wgUser had to be retrieved from global (which was implied before but needs to be given directly now) Other notes: * Article->unwatch() and Article->watch(), which were deprecated as of 1.18 and are no longer used in core, may be broken in scenarios where the Request does not have a 'token' but is making a call to $article->watch() * Some extensions need to be fixed, I'm currently running a grep search and will fix them a.s.a.p [1] http://www.mediawiki.org/wiki/ResourceLoader/Default_modules?mw.user#tokens ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89082]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89082. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89082#c0 Commit summary: Adding or adjusting front-end function and variable documentation per our conventions. Also did some trivial clean up, JSHint fixes and performance optimizations while at it. (per http://www.mediawiki.org/wiki/JavaScript_performance ) * Missing semicolons. * [mediawiki.js Line 540] Unreachable 'registry' after 'throw'. * [mediawiki.log.js] Checked for window.console but used console. * Added callback option to mw.util.toggleToc (forwarded to jQuery.fn.slideUp/Down) * Made mw.log argument more descriptive (logmsg instead of string) * Using deepEqual(, true) instead of ok() when asserting true. (ok() is like casting a boolean (or a plain if() statement) to verify that something is not falsy) Added missing test suites for: * mw.util.toggleToc (follow-up r88732, Dummy check was introduced in r87898) /me has been infected by Reedy and will be doing more of this tonight. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87743]: Revision status changed
User "Catrope" changed the status of MediaWiki.r87743. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87743#c0 Commit summary: jquery.makeCollapsible improvements * Check for validness of $defaultToggle only needed once (Follow-up r83309 CR) * The new jQuery sortable plugin caused a minor breakage in other actions bound within table cells. Since, in contrary to the old wikibits script, the entire is clickable and the triangle is a background image. This means anything that is clickable inside the (such as [Collapse] propagates/bubbles up to the and causes the column to be re-sorted. In other words, collapsing a table caused the last column to be sorted, and when expanded again in the opposite order. Fixed by adding event.stopPropagation(); (note, not "return false" as there may be custom events bound to the anchor tag which should be fired as well. We just need to stop propagation not all other event, such as for customToggles). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89610]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89610. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89610#c0 Commit summary: Fix bug that brakes the 'jquery.tabIndex > firstTabIndex' test in IE8/IE9. Some values default to a "unknown" string. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r80248]: Revision status changed
User "Dantman" changed the status of MediaWiki.r80248. Old Status: resolved New Status: fixme Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/80248#c0 Commit summary: Implement Message::isBlank and Message::isDisabled. And while we're at it... update a random assortment of code using wfEmptyMsg to use the new wfMessage class and our exists/isBlank/isDisabled methods. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89853]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r89853. Old Status: new New Status: resolved User "Catrope" also posted a comment on MediaWiki.r89853. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89853#c20907 Commit summary: Added jquery.qunit.completenessTest.js (A jQuery/QUnit test coverage utility) * Added to /resources * Conditionally loaded (condition being that the url parameter "completenesstest" has a truthy value) * Fixed a test that was using === and true * Setting an added method somewhere back to undefined so it won't be listed as a potential "missing test". Comment: + console.log( 'CompletenessTest.ACTION_CHECK', that ); So this code assumes console.log() will be callable? Doesn't that cause JS errors on browsers where it's not present? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89942]: Revision status changed
User "Catrope" changed the status of MediaWiki.r89942. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89942#c0 Commit summary: Replacing strictEqual-assertion with a more useful QUnit.push that includes the expected and actual values in the html output. This way debugging problems from the TestSwarm will be easier. This way we end up with: "Expected: > 100, Result: 99" instead of: "Expected: true, Result: false" which could virtually mean anything (even null, undefined, string, array, you name it) * Also fixed issue in jquery.colorUtil.js ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94623]: Revision status changed
User "^demon" changed the status of MediaWiki.r94623. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94623#c0 Commit summary: Fix a few typos in messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94632]: Revision status changed
User "^demon" changed the status of MediaWiki.r94632. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94632#c0 Commit summary: Add plural support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94633]: Revision status changed
User "^demon" changed the status of MediaWiki.r94633. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94633#c0 Commit summary: Localise numbers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94635]: Revision status changed
User "^demon" changed the status of MediaWiki.r94635. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94635#c0 Commit summary: Update punctuation. Use capital after colon (US English) Remove trailing whitespace in 'en' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94630]: Revision status changed
User "^demon" changed the status of MediaWiki.r94630. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94630#c0 Commit summary: Followup r89545: add ,0 to Article constructor call ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94629]: Revision status changed
User "^demon" changed the status of MediaWiki.r94629. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94629#c0 Commit summary: Followup r90041: keep naming of watch and unwatch calls consistent ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94631]: Revision status changed
User "^demon" changed the status of MediaWiki.r94631. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94631#c0 Commit summary: Follow-up r92631: correct plural. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94628]: Revision status changed
User "^demon" changed the status of MediaWiki.r94628. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94628#c0 Commit summary: Add link to special page. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94637]: Revision status changed
User "^demon" changed the status of MediaWiki.r94637. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94637#c0 Commit summary: Fix typo. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94622]: Revision status changed
User "^demon" changed the status of MediaWiki.r94622. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94622#c0 Commit summary: Move magic i18n to its own file. Translate extension cannot handle messages and magic in the same file. Update Translate config accordingly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94614]: Revision status changed
User "^demon" changed the status of MediaWiki.r94614. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94614#c0 Commit summary: force QUnit charset to UTF-8 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94615]: Revision status changed
User "^demon" changed the status of MediaWiki.r94615. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94615#c0 Commit summary: correct number of tests fu r94609 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94610]: Revision status changed
User "^demon" changed the status of MediaWiki.r94610. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94610#c0 Commit summary: Fix typo. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94620]: Revision status changed
User "^demon" changed the status of MediaWiki.r94620. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94620#c0 Commit summary: Stylize QPoll extension. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94621]: Revision status changed
User "^demon" changed the status of MediaWiki.r94621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94621#c0 Commit summary: Update punctuation for error messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94618]: Revision status changed
User "^demon" changed the status of MediaWiki.r94618. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94618#c0 Commit summary: Fix XSS in CreateBox. Patch by Mark Goodwin from Mozilla. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86335]: New comment added, and revision status changed
User "MarkAHershberger" changed the status of MediaWiki.r86335. Old Status: fixme New Status: ok User "MarkAHershberger" also posted a comment on MediaWiki.r86335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86335#c20908 Commit summary: (bug 28583) chase down and beat to death external calls of functions marked /*private*/, and make those declarations actually binding. Patch by yuvipanda. Comment: Removing FIXME after discussing with Chad. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94575]: Revision status changed
User "Hashar" changed the status of MediaWiki.r94575. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94575#c0 Commit summary: avoid playing with $_SERVER in test for now fu r94558 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94282]: New comment added
User "Jack Phoenix" posted a comment on MediaWiki.r94282. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94282#c20909 Commit summary: Use Parser::preprocess() instead of Parser::transformMsg() Fixme: couldn't find any use of these two methods, should they be removed entirely? Comment: You're right, updateCreatedOpinionsCount() and updatePublishedOpinionsCount() are currently unused (and a bit ugly too, as you can see — for example, the hardcoded "Opinions by User X" string and whatnot). Both of these functions are related to the BlogPage extension (which I've been working on) and as such I've moved updateCreatedOpinionsCount() to BlogPage and I plan to remove both functions from the UserStatsTrack class once BlogPage is complete. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94577]: New comment added, and revision status changed
User "Hashar" changed the status of MediaWiki.r94577. Old Status: ok New Status: reverted User "Hashar" also posted a comment on MediaWiki.r94577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94577#c20910 Commit summary: back off r94558: - reverts ./includes/ProxyTools.php - marks tests broken In our test suite, the first call to wfGetIP() set the static variable. Hence the remaining of the code is only tested on the first call to it. Resetting the static variable enlight a bug somewhere in our code where we are calling wfGetIP() but can not reliably get an IP, somehow REMOTE_ADDR does not exist and $wgCommandLineMode is disabled. Will have to track this bug further when I got time. Comment: r94558 reintroduced with r94638 which is a reversion of this r94577. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94488]: Revision status changed
User "^demon" changed the status of MediaWiki.r94488. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94488#c0 Commit summary: * Follow-up r92673: add documentation on how to use $wgDnsBlacklistUrls to DefaultSettings (lifted from the Manual page on mediawiki.org) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92673]: Revision status changed
User "^demon" changed the status of MediaWiki.r92673. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92673#c0 Commit summary: * $wgDnsBlacklistUrls now accepts an array with url and key as the elements to work with DNSBLs that require keys, such as Project Honeypot. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94489]: Revision status changed
User "^demon" changed the status of MediaWiki.r94489. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94489#c0 Commit summary: * Revert r94487 and r19889 to an extent -- ONLY check for the X-Forwarded-For header when we are behind a proxy, as mostly every properly configured proxy software sets it, and attempting to support those that do not opens up the ability to spoof IP addresses by setting arbitrary headers. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94264]: Revision status changed
User "^demon" changed the status of MediaWiki.r94264. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94264#c0 Commit summary: adding $wgRequest global ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94300]: Revision status changed
User "^demon" changed the status of MediaWiki.r94300. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94300#c0 Commit summary: fix title ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Reclaiming a lost account on a private wiki: impossible
On Tue, Aug 16, 2011 at 6:52 AM, Bryan Tong Minh wrote: > You should put Special:PasswordReset in $wgWhiteListSomething. > Shouldn't that be there by default like Special:UserLogin? Svip has a valid point. If they forgot their password, they wouldn't be able to login to request a new one. -- Casey Brown Cbrown1023 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94301]: New comment added, and revision status changed
User "^demon" changed the status of MediaWiki.r94301. Old Status: new New Status: ok User "^demon" also posted a comment on MediaWiki.r94301. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94301#c20911 Commit summary: Localisation update for core and extension messages from translatewiki.net (2011-08-11 19:50:00) Comment: Just for reference, there's no need to merge these i18n updates. LocalisationUpdate updates the translations nightly automatically from trunk :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] FIXMEs for 1.18
On Mon, Aug 15, 2011 at 11:45 PM, Mark A. Hershberger wrote: > DO NOT change your fixme'd revisions to "resolved"! Please, only change > them to "new". > You can't anyway, we finally fixed that. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94343]: New comment added
User "^demon" posted a comment on MediaWiki.r94343.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94343#c20912
Commit summary:
Add a new type of ballot: Radio range with comment. Solicits the user for
comments, and sticks it in the ballot. This means that the size of ballots
changes, but not on the basis of the vote they take, which is the important
reason why ballot size cannot differ by the user (to avoid revealing the actual
votes).
Comment:
"for ( $offset = 0; $offset < strlen( $record ); $offset += $itemLength ) {"
Move the strlen() call above the loop?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94509]: Revision status changed
User "^demon" changed the status of MediaWiki.r94509. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94509#c0 Commit summary: Followup r94404: remove LOCK IN SHARE MODE because locking reads are evil, per Tim. Will implement a better solution to prevent counter drift without locking reads, but that involves changing the DB schema a bit so I want to discuss that with Howie and Dario first ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92956]: New comment added
User "SPQRobin" posted a comment on MediaWiki.r92956. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92956#c20913 Commit summary: DifferenceEngine: introduce setDiffLang() to change the language in which the diff text is written. Translate: set the the diff text according to the source language, on Special:PageTranslation and the translation messages. (Also fix direction of CSS class mw-translate-fuzzy). Comment: Hmm, I always wonder ''when'' a variable should be protected. Most others like mOldtext are neither protected... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User "SPQRobin" posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c20914 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Yeah, or we can move the function to a general file/class. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90331]: New comment added, and revision status changed
User "Catrope" changed the status of MediaWiki.r90331.
Old Status: new
New Status: resolved
User "Catrope" also posted a comment on MediaWiki.r90331.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90331#c20915
Commit summary:
Implement mw.Title in core
* Based on UploadWizard/resources/mw.Title.js
* Refactored to use local scope and prototypes instead of re-declaring them
per-instance in the private scope through 'this' (re-use by reference, faster
instantiation and performance)
* Fix potential ReferenceError in the check for wgArticlePath (inline if
statements will fail for undeclared variables, needs typeof undefined check).
Using mw.config instead to avoid this problem.
* The following two methods were not ported from UploadWizard because they were
or became redundant and/or merged with another method:
-- setNameText (redundant with the improved setName)
-- setPrefix (redundant wit the improved setNamespace)
* Ported all jasmine tests to QUnit. Left them exactly the same to make sure
it's compatible with UploadWizard. Perhaps I'll expand or adjust the suite
later to be less file-specific, but for now make letting this revision go
through TestSwarm to be sure it's compatible and behaves exactly the same.
* Added getName() method instead, replacing direct access to '_name' This in
order to check for wgCaseSensitiveNamespaces (bug 29441; r90234)
-- Prevents breakages on wiktionary and other wikis with case sensitivity. ie.
on a Wiktionary:
new mw.Title('apple').toString()
> "Apple"
-- This fix will make it return 'apple' instead of 'Apple' (that is, if 0 is in
wgCaseSensitiveNamespaces).
* There used to be a strip-bug in scenarios where a namespace-like string
appears inside of a title. Imagine pagename: "Category:Wikipedia:Foo bar"
(exist on several wikis; NS_CATEGORY= 14)
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Foo_bar" // Stripped "Wikipedia:" !!
In order to fix this:
-- Removed assumption that every title has a namespace prefix.
UploadWizard/mw.Title has one initialization RegExp (which was ported as-is to
"setAll"). In addition there is now a "setNameAndExtension" method (which
doesn't extract or set the namespace). Now the above case:
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Wikipedia_Foo_bar" // Better, but now the colon is gone..
-- In order to fix that, "\x3a" was removed from the clean() function. Colons
are valid in MediaWiki titles, no need to escape.
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Wikipedia:Foo_bar" // Yay!
* Last but not least, another little bug fixed due to the previous point. It
also fixed a thrown exception in case a colon is part of the title in the main
namespace (not rare for movies and books):
new mw.Title( 'The Wiki: Awesomeness')
> Error: mw.Title> Unrecognized canonical namespace: the_wiki
This exception is thrown from setNamespace(). That exception would make sense
if setNamespace() was called by the user direcly, but when called from setAll()
it should gracefully fallback by putting the prefix in the name instead and
assuming NS_MAIN (just like the server side does). To achieve this I added a
try/catch around setAll() and fallback to the new setNameAndExtension().
* Passes JSHint.
* Additional feature: exists(). Return true/false if known, otherwise null.
Extensions can populate this for titles they are interested in and the
front-end can construct url's and UI elements with correct redlink-status.
Gadgets can populate it as well but that would require an API-request to get
the information. A bit of a stub for later use, although I think it works fine.
* Bugfix in jquery.qunit.completenessTest.js (first triggered by the
introduction of mw.Title). Don't traverse the 'constructor' property (recursive
loop, ouch!)
---
(bug 29397) Implement mw.Title module in core
Comment:
Reviewing mediawiki.Title.js at trunk state, all comments here in lieu.
+ if ( s !== undefined ) {
...
+ if ( s !== null && s !== undefined ) {
Suggest using typeof s == 'string' instead, because you're about
to call s.replace(). Also, if clean() and
text() check the type of their input, so should
fixExt().
// toLowerCase throws exception on null/undefined. Return early.
if ( ns == null ) {
return false;
}
Why not check typeof ns == 'string' here too?
var matches = raw.match( /^(?:)?(.*?)(?:\.(\w{1,5}))?$/ );
(?:)? means 'non-capturing match of emptiness, optional', so
that's totally useless. I quickly tried removing it locally and it didn't break
any tests; I can't imagine it's actually doing anything other than confusing
the hell out of anyone who reads that regex.
Why does Title.exist.set() return anything? It always returns true, there is no
way it will ever return anything else, so it might as well be a void f
[MediaWiki-CodeReview] [MediaWiki r83080]: New comment added, and revision status changed
User "IAlex" changed the status of MediaWiki.r83080. Old Status: fixme New Status: new User "IAlex" also posted a comment on MediaWiki.r83080. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/83080#c20916 Commit summary: Per Platonides, fix for r82686: make ApiUploadTest work again Added option request parameter to User::editToken() and User::matchEditToken() and use them where possible from the api. Also removed $_SESSION usage since it's no longer needed Comment: Fixed in r94640. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] is_callable( $realFunction )
Hey,
I just got a bug report for the following code:
$realFunction = array( 'OutputPage', 'includeJQuery' );
if ( is_callable( $realFunction ) ) {
//...
}
The user is getting a strict warning because the includeJQuery is not
static. Now I'm wondering why this check is done in such an odd way to begin
with, this would be a lot simpler:
if ( method_exists( $wgOut, 'includeJQuery' ) ) { ... }
I vaguely remember someone saying something about this beeing needed for
HipHop, but can't find this documented anywhere where such checks are used.
So can someone enlighten me here? :)
Cheers
--
Jeroen De Dauw
http://www.bn2vs.com
Don't panic. Don't be evil.
--
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] sidebar statistics
Amir E. Aharoni wrote: > 2011/8/16 MZMcBride : >> An extension such as ClickTracking is probably a much better option if you >> can get local consensus and sysadmin support. > > Are there any special implications i should know about? Privacy? > Performance? Anything else? Roan thoroughly covered the privacy and performance concerns. To clarify what I meant by "sysadmin support," you'll need a sysadmin to fulfill the "shell" bug in a timely manner (to enable the extension, once there's consensus) and you'll need a sysadmin to aggregate the stats for you (as Roan noted), as I don't believe this information will be considered public. It looks like there are partial views for the tables (click_tracking and click_tracking_events) on the Toolserver, for what it's worth. MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] sidebar statistics
On Tue, Aug 16, 2011 at 4:47 PM, MZMcBride wrote: > It looks like there are partial views for the tables (click_tracking and > click_tracking_events) on the Toolserver, for what it's worth. > Oh wow, I had no idea those were there. I'm not entirely sure that's a good idea. It's a partial view but it only suppresses the session_id field. Anyway, I'll let the toolserver folks decide on the privacy concerns around exposing the edit count fields (like I said, that can be identifiable information in certain cases). This does mean anyone with a toolserver account can do analysis on the data as it comes in, which is a good thing cause it means less work for me :) Roan Kattouw (Catrope) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r94584]: Revision status changed
User "^demon" changed the status of MediaWiki.r94584. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94584#c0 Commit summary: Removed more extraneous parenthesis ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90331]: New comment added
User "Catrope" posted a comment on MediaWiki.r90331.
Full URL:
https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90331#c20917
Commit summary:
Implement mw.Title in core
* Based on UploadWizard/resources/mw.Title.js
* Refactored to use local scope and prototypes instead of re-declaring them
per-instance in the private scope through 'this' (re-use by reference, faster
instantiation and performance)
* Fix potential ReferenceError in the check for wgArticlePath (inline if
statements will fail for undeclared variables, needs typeof undefined check).
Using mw.config instead to avoid this problem.
* The following two methods were not ported from UploadWizard because they were
or became redundant and/or merged with another method:
-- setNameText (redundant with the improved setName)
-- setPrefix (redundant wit the improved setNamespace)
* Ported all jasmine tests to QUnit. Left them exactly the same to make sure
it's compatible with UploadWizard. Perhaps I'll expand or adjust the suite
later to be less file-specific, but for now make letting this revision go
through TestSwarm to be sure it's compatible and behaves exactly the same.
* Added getName() method instead, replacing direct access to '_name' This in
order to check for wgCaseSensitiveNamespaces (bug 29441; r90234)
-- Prevents breakages on wiktionary and other wikis with case sensitivity. ie.
on a Wiktionary:
new mw.Title('apple').toString()
> "Apple"
-- This fix will make it return 'apple' instead of 'Apple' (that is, if 0 is in
wgCaseSensitiveNamespaces).
* There used to be a strip-bug in scenarios where a namespace-like string
appears inside of a title. Imagine pagename: "Category:Wikipedia:Foo bar"
(exist on several wikis; NS_CATEGORY= 14)
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Foo_bar" // Stripped "Wikipedia:" !!
In order to fix this:
-- Removed assumption that every title has a namespace prefix.
UploadWizard/mw.Title has one initialization RegExp (which was ported as-is to
"setAll"). In addition there is now a "setNameAndExtension" method (which
doesn't extract or set the namespace). Now the above case:
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Wikipedia_Foo_bar" // Better, but now the colon is gone..
-- In order to fix that, "\x3a" was removed from the clean() function. Colons
are valid in MediaWiki titles, no need to escape.
new mw.Title( 'Wikipedia:Foo bar', 14 ).toString()
> "Category:Wikipedia:Foo_bar" // Yay!
* Last but not least, another little bug fixed due to the previous point. It
also fixed a thrown exception in case a colon is part of the title in the main
namespace (not rare for movies and books):
new mw.Title( 'The Wiki: Awesomeness')
> Error: mw.Title> Unrecognized canonical namespace: the_wiki
This exception is thrown from setNamespace(). That exception would make sense
if setNamespace() was called by the user direcly, but when called from setAll()
it should gracefully fallback by putting the prefix in the name instead and
assuming NS_MAIN (just like the server side does). To achieve this I added a
try/catch around setAll() and fallback to the new setNameAndExtension().
* Passes JSHint.
* Additional feature: exists(). Return true/false if known, otherwise null.
Extensions can populate this for titles they are interested in and the
front-end can construct url's and UI elements with correct redlink-status.
Gadgets can populate it as well but that would require an API-request to get
the information. A bit of a stub for later use, although I think it works fine.
* Bugfix in jquery.qunit.completenessTest.js (first triggered by the
introduction of mw.Title). Don't traverse the 'constructor' property (recursive
loop, ouch!)
---
(bug 29397) Implement mw.Title module in core
Comment:
Also, please unpick your commits: don't combine the addition of a new module
with changes to another random component (completeness test).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
