[MediaWiki-CodeReview] [MediaWiki r90461]: New comment added
User Tim Starling posted a comment on MediaWiki.r90461. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90461#c21913 Commit summary: Expand return documentation for r84357 Comment: That's no excuse. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96266]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96266. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96266#c21915 Commit summary: work on db object classes Comment: Uuh PHP 5.3 already? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96266]: New comment added
User Alphos posted a comment on MediaWiki.r96266. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96266#c21916 Commit summary: work on db object classes Comment: PHP 5.2 is [http://www.php.net/archive/2010.php#id2010-12-16-1 not supported anymore for quite some time now], I'd say it's about time we too stop supporting it ;-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96267]: New comment added
User Raymond posted a comment on MediaWiki.r96267. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96267#c21917 Commit summary: (bug 26170) MediaWiki:Globalblocking-blocked should have a variable for the user's IP address Some other tweaks (whitespace, docs, ..) Comment: Why not add the IP address to the message itself? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84357]: Revision status changed
User Tim Starling changed the status of MediaWiki.r84357. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84357 Commit summary: * (Bug 14005) editing section 0 of an existing but empty page gives no such section error Tested, with minor tweak. Also removed now un-needed code Patch by Harry Burt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84451]: Revision status changed
User Tim Starling changed the status of MediaWiki.r84451. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84451 Commit summary: Reinstate some lines added during r84357 I guess they're used on some code paths... As it's not an unconditional return... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90461]: Revision status changed
User Tim Starling changed the status of MediaWiki.r90461. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90461 Commit summary: Expand return documentation for r84357 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95631]: New comment added
User TheDJ posted a comment on MediaWiki.r95631. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95631#c21918 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. Comment: I would appreciate it if someone can undo all my RL changes to LQT. I don't have the time to work on this, and the fixme's emails are annoying. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85988]: Revision status changed
User Tim Starling changed the status of MediaWiki.r85988. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85988 Commit summary: Tables: Fix Bug 20078, add test for it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95631]: New comment added
User Catrope posted a comment on MediaWiki.r95631. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95631#c21919 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. Comment: I'm on it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89525]: New comment added
User Tim Starling posted a comment on MediaWiki.r89525. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89525#c21920 Commit summary: Replace the text directly instead of using the StripState object since it will be unstripped just after the call replaceTransparentTags(), but left the call unstripGeneral() for the benefit of Poem extension that use it to escape the br / tag Comment: What is the point of this? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94995]: New comment added
User Catrope posted a comment on MediaWiki.r94995.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94995#c21921
Commit summary:
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing
$wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce
$wgCanonicalServer for these purposes instead. This revision introduces two new
hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified
version of $wgServer but in practice can be anything that you'd like to be used
in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC
and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a
hook for WMF usage (which will be needed as long as secure.wikimedia.org is
used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history,
the other escapeFooURL() functions don't have a $variant parameter; I decided
not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling
getInternalURL() (or getCanonicalURL()) and regexing the title parameter out,
obtain the path to index.php using $wgCanonicalServer . $wgScript and append
params to that. Sadly, we need to add a hook here to support the secure server
hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions,
which work just like {{fullurl:}} and {{fullurle:}} except that they use
getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993
(protocol-relative URLs appear in e-mail notifications)
Comment:
Hmm, right. I just copied the code from getInternalUrl(). I have, in fact,
already added PROTO_CANONICAL in r95006, so I'll just use it here.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95971]: New comment added
User Catrope posted a comment on MediaWiki.r95971. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95971#c21922 Commit summary: RL2: Kill a bunch of unneeded properties (covered in the JSON blob) in list=gadgets. We don't need to keep them around for back compat because list=gadgets was introduced in 1.18, as long as we update the 1.18 module to match the return format of this module (which I will do later) Comment: How did I not already do this in r96006? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95971]: Revision status changed
User Krinkle changed the status of MediaWiki.r95971. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95971 Commit summary: RL2: Kill a bunch of unneeded properties (covered in the JSON blob) in list=gadgets. We don't need to keep them around for back compat because list=gadgets was introduced in 1.18, as long as we update the 1.18 module to match the return format of this module (which I will do later) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96110]: New comment added
User Santhosh.thottingal posted a comment on MediaWiki.r96110. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96110#c21924 Commit summary: Moved import.js to RL - the script itself needs to be rewritten (I could use help on that!) Comment: Shall we use '$' instead of 'jQuery' consistently? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96110]: New comment added
User Dantman posted a comment on MediaWiki.r96110.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96110#c21925
Commit summary:
Moved import.js to RL - the script itself needs to be rewritten (I could use
help on that!)
Comment:
Wrap it in a (function($) { [...] })(jQuery);
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94995]: New comment added
User Catrope posted a comment on MediaWiki.r94995.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94995#c21926
Commit summary:
Per CR on r44412 and my promise in the commit summary of r94990, stop abusing
$wgInternalServer (intended for Squid URLs) for IRC/e-mail URLs and introduce
$wgCanonicalServer for these purposes instead. This revision introduces two new
hooks for WMF hacks, in exchange for making the core code saner.
* Introduce $wgCanonicalServer, which should typically be a fully qualified
version of $wgServer but in practice can be anything that you'd like to be used
in IRC/e-mail notifs
** Default value is $wgServer, expanded to http:// if protocol-relative
** This means you can easily set HTTPS as the 'default' protocol to use in IRC
and e-mail notifs by setting $wgCanonicalServer to https://example.com
* Introduce Title::getCanonicalURL(). Similar to getInternalURL(), including a
hook for WMF usage (which will be needed as long as secure.wikimedia.org is
used)
** Also add escapeCanonicalURL(). Due to some ridiculous accident of history,
the other escapeFooURL() functions don't have a $variant parameter; I decided
not to follow that bad example
* Reinstate the spirit of r44406 and r44412: instead of calling
getInternalURL() (or getCanonicalURL()) and regexing the title parameter out,
obtain the path to index.php using $wgCanonicalServer . $wgScript and append
params to that. Sadly, we need to add a hook here to support the secure server
hack for WMF, but that's the price of saner code in this case
* Introduce the {{canonicalurl:}} and {{canonicalurle:}} parser functions,
which work just like {{fullurl:}} and {{fullurle:}} except that they use
getCanonicalURL() instead of getFullURL()
* Use {{canonicalurl:}} in the enotif_body message, fixing bug 29993
(protocol-relative URLs appear in e-mail notifications)
Comment:
Dan already did it in r96180.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96273]: Revision status changed
User Catrope changed the status of MediaWiki.r96273. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96273 Commit summary: Followup r96180, I can't believe I did't notice I accidentally killed the hook name. While I'm at it, add missing $variant parameters to every 'Get*URL' hook in Title. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96180]: Revision status changed
User Catrope changed the status of MediaWiki.r96180. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96180 Commit summary: Use wfExpandUrl+PROTO_CANONICAL inside of getCanonicalURL instead of just prepending the url so this does not break on interwiki and action=render ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96271]: Revision status changed
User Catrope changed the status of MediaWiki.r96271. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96271 Commit summary: Reverted r84357 and r90461 and fixed the bug in a better way: in an empty document, consider section zero to exist, and to be empty, effectively representing the whole document. This allows section zero of a blank page to be viewed and edited with no updates to EditPage. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95260]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95260.
Old Status: new
New Status: ok
User Catrope also posted a comment on MediaWiki.r95260.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95260#c21927
Commit summary:
add functions that support close and rename of output files as they are being
written, used to write out checkpoint files at regular intervals during XML
dump production
Comment:
Fixed some things that irked me in r96275.
pre
+ function closeRenameAndReopen( $newname ) {
+ function rename( $newname ) {
+ function getFilename() {
/pre
These functions are undocumented. closeRenameAndReopen() was documented in a
subclass, so I moved that doc comment up to the parent class, but the other two
aren't documented anywhere.
pre
+ $command = 7za a -bd -si . wfEscapeShellArg( $file );
+ $command .= ' ' . wfGetNull() . ' 21';
/pre
The command building, both here and in DumpPipeOutput, is duplicated and should
be factored out.
Good enough for deployment, so marking OK, but please do document the new code
and fix the code duplication you introduced.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95272]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95272.
Old Status: new
New Status: ok
User Catrope also posted a comment on MediaWiki.r95272.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95272#c21928
Commit summary:
add support for writing out checkpoint files of xml dump at regular intervals
(close and rename file based on filename pattern which includes first and last
page id written)
Comment:
pre
+ $count = substr_count ($checkpointFile,%s);
+ if (substr_count ($checkpointFile,%s) != 2) {
/pre
Huh? :P You should use $count in the if here.
pre
+ $filenameList = $this-egress-getFilename();
+ if (! is_array($filenameList)) {
+ $filenameList = array( $filenameList );
+ }
/pre
You can also do this with code$filenameList =
(array)$this-egress-getFilename();/code , provided that the return value of
that function isn't an object. Besides, it seems you don't even need it here:
codecount( 'a string' ) === 1/code
pre
+ # we wrote some stuff after last checkpoint that needs
renamed */
/pre
Interesting comment style ;)
pre
+ $firstPageID =
str_pad($this-firstPageWritten,9,0,STR_PAD_LEFT);
+ $lastPageID =
str_pad($this-lastPageWritten,9,0,STR_PAD_LEFT);
/pre
Wouldn't you be able to do this inside the printf format string using
code%09d/code ?
pre
+ $newFilenames[] = $fileinfo{'dirname'}
. '/' . $checkpointNameFilledIn;
/pre
I'm pretty sure the code{'dirname'}/code syntax is deprecated in favor of
code['dirname']/code and I'm surprised it even worked: AFAIK the only use
of braces that way was to get the n-th character of a string with
code$str{2}/code .
OK otherwise, marking as such.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95604]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r95604. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r95604. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95604#c21929 Commit summary: define and use closeAndRename() after last write of xml dump file; convert from popen (child inherits all open descriptors and there is no workaround) to proc_open (CLOEXEC set on all descriptors), needed so close and rename doesn't hang forever if a child (prefetcher) is forked Comment: pre +# pclose( $this-handle ); /pre Leftover debugging code or something? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88639]: Revision status changed
User Catrope changed the status of MediaWiki.r88639. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88639 Commit summary: (bug 27756, bug 26328) Removed AJAX preview (on diff) loading: causes more trouble than it's worth. If any reincarnation is added it must handle these problems (which involve rethinking the page loading model). Also, diffs use the current page cache when possible. The focus should be on avoiding fragmentation. Additionally, diffonly=0 in review links could be altered (we already enumerate template/file changes). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96200]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r96200. Old Status: new New Status: ok User Catrope also posted a comment on MediaWiki.r96200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96200#c21930 Commit summary: [RL2] Follow-up r96014: getText instead of getPrefixedText, we need it without namespace Comment: D'oh! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96201]: Revision status changed
User Catrope changed the status of MediaWiki.r96201. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96201 Commit summary: [ResourceLoader2] 'timestamp' 'definitiontimestamp' to avoid confusion (Follows-up r95965) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95955]: Revision status changed
User Catrope changed the status of MediaWiki.r95955. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95955 Commit summary: Follows-up r95954: Fix case ganames and ganames=. Falsey is not enough, empty string or empty array should be used as 'has filter, no titles' ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96013]: New comment added
User Catrope posted a comment on MediaWiki.r96013. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96013#c21931 Commit summary: RL2: Fix bug where the preferences page was messed up when a description was empty, and the titles weren't included. Now using $title: $description Comment: Was this fixed in r96215? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92141]: New comment added
User Bawolff posted a comment on MediaWiki.r92141. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92141#c21932 Commit summary: Babel: (bug 29663) Babel doesn't validate babel-autocreate-user message - do nothing if the username is invalid. Also, do not create categories if the user is blocked. NewUserMessage: Fix fatal error when username is invalid. Instead, do nothing. Comment: Oh whoops. For some reason I thought the default level was usable. Please ignore my comment then :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96172]: Revision status changed
User Catrope changed the status of MediaWiki.r96172. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96172 Commit summary: Correct spelling of dependencies Follow up to r95631 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96277]: Revision status changed
User Jack Phoenix changed the status of MediaWiki.r96277. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96277 Commit summary: Stylize Export.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95631]: New comment added
User Catrope posted a comment on MediaWiki.r95631. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95631#c21933 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. Comment: pre + 'query.async', 'jquery.cookie') /pre That was another misspelling, and probably the real reason LQT exploded on TranslateWiki. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95631]: Revision status changed
User Catrope changed the status of MediaWiki.r95631. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95631 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96206]: Revision status changed
User Catrope changed the status of MediaWiki.r96206. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96206 Commit summary: Revert r96172. This broke replies on Special:NewMessages, possibly more. * Focus didn't go to edit area on reply. * Spinning ball was active all the time after clicking reply, and only stopped after reload of the page or saving the reply. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95631]: New comment added
User Catrope posted a comment on MediaWiki.r95631. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95631#c21934 Commit summary: Follow up to r79941 To me it doesn't seem like there is a reason that the modules should be publicized in the api. The modules need to be loaded locally, so the dependancy is already on local loading. Adding a new ext.liquidThreads.edit module to do the loading of the edit mode of lqt as well as dependancy loading. Comment: Ended up just reverting this revision; I looked at pulling out all RL-related stuff in LQT but that would be too nightmarish. Not setting r79941 back to fixme since things apparently worked fine, it just wasn't done nicely. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96110]: New comment added
User Nikerabbit posted a comment on MediaWiki.r96110. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96110#c21935 Commit summary: Moved import.js to RL - the script itself needs to be rewritten (I could use help on that!) Comment: This script is broken. It needs to be rewritten, but I don't know how to enable autocompletion on input fields on trunk. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96276]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96276. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96276 Commit summary: Whitespace fixes for r95272, r95604 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88029]: New comment added
User VitaliyFilippov posted a comment on MediaWiki.r88029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88029#c21936 Commit summary: Localisation updates for magic word aliases for extensions from http://translatewiki.net. Comment: For Wikilog extension, english magic words aliases in other languages are removed in this revision. This is incorrect, they should be added back. I don't know what is the correct way to do it, so please somebody fix it :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96275]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r96275. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r96275. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96275#c21938 Commit summary: Fixes for r95260: * Use protected instead of var * Move documentation of closeRenameAndReopen() to parent class. Add a TODO for the other undocumented methods introduced in r95260 * Use the correct method name in the exceptions by using __METHOD__; messages were copypasted from one method to the other without changing anything. Also fix a typo (argumnts) * Minor coding style bit, will commit more style fixes in a minute Comment: Fatal error: Access level to DumpPipeOutput::$filename must be public (as in class DumpFileOutput) in ./includes/Export.php on line 870 (wasn't a hook supposed to be in place now?) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88029]: New comment added
User Siebrand posted a comment on MediaWiki.r88029. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88029#c21939 Commit summary: Localisation updates for magic word aliases for extensions from http://translatewiki.net. Comment: English language aliases for magic words are added by default in trunk. If you would like the extension to work with an earlier version of MediaWiki, please use the extension version from the same branch your MediaWiki instance originates from. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95959]: New comment added
User Platonides posted a comment on MediaWiki.r95959. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95959#c21940 Commit summary: Followup r95957, add =null to Skin::outputPage too Comment: Ok. I hope /that/ is not broken later. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Reversing Add HTML Meta and Title extension
We have Add HTML Meta and Title extension installed. ( http://www.mediawiki.org/wiki/Extension:Add_HTML_Meta_and_Title). We can easily ADD tags, but we don't see a method for removing them, or even modifying them. I don't even know where the information we add is being kept (Though i am sure its probably in the database, i have looked, and fear it might be kept in the BLOB blocks, and i have no idea how to vew/modify those fields, or if i would even want to. Someone mind looking at this extension and helping me understand where the data is kept, or how to remove/modify what the extension does to a page? What is completely confusing is that the Extension lets you use the Page Editor (i don't know the proper name) where the content of the page is created to add, using some special formatting. But once you save, the text you enter disappears, so you can't change it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Serialisation vs. PHP
On 04/09/11 20:31, Max Semenik wrote: Am I right in my guess that while loading data tables from serialized files is faster than interpreting them in PHP, the situation is reversed in HipHop where tables can be precompiled? Feel free to write benchmarks for those. We have a class to do so in maintenance/benchmarks . HipHop compilation is straightforward (make sure to use the patches for libcurl and lib_I_DONT_REMEMBER). MediaWiki compilation can cause some troubles though. You also want to contact Tim Starling to talk about it. -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Proposed chat system
On 05/09/11 02:17, Mono mium wrote: Hi there, I'm working on a live help system. I'll send more information as development progresses, but I simply wanted to let you know that this is in progress. Make sure to send the code early on. You will attract some developers, get tips, and useful feedbacks :) -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95525]: Revision status changed
User Catrope changed the status of MediaWiki.r95525. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95525 Commit summary: Follow-up r81074: fix typos in some unit names and messages (mili instead of milli). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96227]: Revision status changed
User Catrope changed the status of MediaWiki.r96227. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96227 Commit summary: Specify no oldid ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84007]: Revision status changed
User Catrope changed the status of MediaWiki.r84007. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84007 Commit summary: Fix bug 27887, caused by r82686: inject session data into FauxRequest s used on save, and pull it out of the FauxRequest object when it is used to generate an inline edit form. This means that tokens are properly propagated when they are generated in inline edit forms and used on the internal edit save. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92924]: Revision status changed
User Catrope changed the status of MediaWiki.r92924. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92924 Commit summary: * Moved email changing from sp:Preferences to new sp:ChangeEmail, which requires confirming the user password. This reduces the impact of session hijacking, which was increased slightly with r86482. Changing a password already required confirming the old one. This change closes the loophole of changing the email address and then doing a reset. * Parse 'mailerror' message correctly ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86482]: Revision status changed
User Catrope changed the status of MediaWiki.r86482. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86482 Commit summary: (bug 13015, bug 18347, bug 18996, bug 20473, bug 23669, bug 28244) separate the password-reset request dialogue from SpecialUserlogin. * Refactor with all the latest bells and whistles * Allow wikis to enable resettting by entering an email address (bug 13015). This is currently an unindexed query, but it is disabled by default so no immediate problem. * Allow resetting to be disabled entirely (bug 20473). * Don't send registered users' IP addresses in the emails (bug 18347) * Check that a user is not globally blocked before letting them send messages (bug 23669) * Display a more useful error message when an account exists globally but not locally (bug 18996). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87731]: New comment added
User Catrope posted a comment on MediaWiki.r87731. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87731#c21942 Commit summary: Automatic testing of SQLite updates from all (previoisly) supported versions Comment: ??? I think that rev has the wrong followup number. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96174]: Revision status changed
User Catrope changed the status of MediaWiki.r96174. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96174 Commit summary: Fix r87731: update site stats only when explicitly asked to do so ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95343]: New comment added
User Catrope posted a comment on MediaWiki.r95343. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95343#c21947 Commit summary: (bug 24037) Allow transclusion from the beginning of the page to a certain section. Patch by Beau Comment: Bug number seems to be wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96303]: Revision status changed
User Meno25 changed the status of MediaWiki.r96303. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96303 Commit summary: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88008]: Revision status changed
User Catrope changed the status of MediaWiki.r88008. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88008 Commit summary: * bug 24037 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88019]: Revision status changed
User Catrope changed the status of MediaWiki.r88019. Old Status: resolved New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88019 Commit summary: * fixed as per comment on r88008 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88024]: Revision status changed
User Catrope changed the status of MediaWiki.r88024. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88024 Commit summary: * partial revert of r88019. Left the messages in for now ... don't know ... those mesages seem logical to me, i know domas might not like it, but they are still displayed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88111]: Revision status changed
User Catrope changed the status of MediaWiki.r88111. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88111 Commit summary: * added an option to toggle the display of diff size with a warning message. * in misermode this option is disabled ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88117]: Revision status changed
User Catrope changed the status of MediaWiki.r88117. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88117 Commit summary: * added alternative revison size display if diff size is not selected ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88252]: Revision status changed
User Catrope changed the status of MediaWiki.r88252. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88252 Commit summary: Remove verboseness (image and infobox) in Special:Contributions for diff size display as added in r88111. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96081]: Revision status changed
User Catrope changed the status of MediaWiki.r96081. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96081 Commit summary: * added redundand join condition for index usage as per comment on CR r88008 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96081]: New comment added
User Catrope posted a comment on MediaWiki.r96081. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96081#c21948 Commit summary: * added redundand join condition for index usage as per comment on CR r88008 Comment: Hmm, re-adding 1.18 tag, needs to be merged so its revert in r96306 will merge cleanly. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95496]: New comment added
User Catrope posted a comment on MediaWiki.r95496. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95496#c21949 Commit summary: Revert r8811 Reverting followups r88117, 88252 Comment: Fixed properly in r96306 by reverting the entire r88008 saga. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90371]: Revision status changed
User Catrope changed the status of MediaWiki.r90371. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90371 Commit summary: (bug 29437) Multiple apostrophes in deleted article title cause odd rendering Fixed by wrapping the username in corresponding messages in nowiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96218]: Revision status changed
User Catrope changed the status of MediaWiki.r96218. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96218 Commit summary: Followup r96217: Update Daddio. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96217]: Revision status changed
User Catrope changed the status of MediaWiki.r96217. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96217 Commit summary: Followup r87340: Post-hook swap bodytext into a new bodycontent key and append printfooter and debughtml to bodytext so that we get the same behaviour as before for skins, the advantage of letting extensions modify them separately, and let skins opt-in to the ability to display these separately. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93062]: Revision status changed
User Krinkle changed the status of MediaWiki.r93062. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93062 Commit summary: r92054: Some IE fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91772]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r91772.
Old Status: new
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r91772.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91772#c21950
Commit summary:
Inline CSS is bad in itself and bad for RTL support (why was there even a
message containing CSS?)
Comment:
I didn't understand the codemw-align-start/end/code and
codemw-float-start/end/code at first, but SPQRobin explained it to me.
Repeating here in my own words for later reference.
codemw-float-start/end/code allows to float an element to the side where
either the text starts, or to the opposite side.
For example, if a diagram should be floated to the right of the page in an LTR
context, then it should float to the left of the page in an RTL context. On
such element you could use codemw-float-end/code.
That's all nice. But from a front-end perspective it's not very semantic in my
opinion and it doesn't solve anything.
Consider the following example:
pre
--- CSS
.mw-float-left {
float: left; /* flipped by ResourceLoader */
}
.mw-float-end {
float: right; /* flipped by ResourceLoader */
}
.infobox {
border: 1px solid grey;
...
}
--- HTML
div class=infobox mw-float-end
...
/div
/pre
I would rather have us do the following, and therewith separate presentation
from content.
pre
-- CSS
.infobox {
float: right; /* flipped by ResourceLoader as needed */
border: 1px solid grey;
...
}
--- HTML
div class=infobox ... /div
/pe
To use an extreme example: Suppose there's a class for error that is declared
like code.error { color: red; }/code and another called love:
code.love { color: red; }/code, we wouldn't go and use a class red-text
and use codenowikidiv class=red-text/nowiki/code for both
That's the opposite of what CSS is meant to be used for. Marking fixme. Use
meaningful classes for elements that need special presentation (ie.
mw-collection-label-download).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Krinkle posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21951 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Another problem is that these two special pages are enabled, accessible and listed on Special:SpecialPages by default. That's not supposed to happen ad 99% of wikis will not have anything global and doesn't need this. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Krinkle posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21952 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: I agree, this seems like a perfect thing to go into an extension. A few side notes: * It uses global $wgUser-getSkin(); ** No need for globals here. OutputPage extends ContextSource which means it has both getUser and getSkin on itself. * CSS classnames used like codedistantTemplatesUsed/code and codemw-templatesUsedExplanation/code should user lowercase and separation by dash, and where needed prefixed with atleast codemw-/code. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95396]: New comment added
User Reedy posted a comment on MediaWiki.r95396. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95396#c21953 Commit summary: Merge the iwtransclusion branch back into trunk Hexmode fixed broken unit tests in revisions after last time Comment: Indeed, which was the way when the code was written. This was a merge into trunk, not a merge and fix every issue ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86714]: New comment added
User SPQRobin posted a comment on MediaWiki.r86714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86714#c21954 Commit summary: Allow extensions to customize the search forms. This required some cleanup and refactoring to special:search and search engine. Should be fully backwards compatible. Lightly tested, but only with MySQL search backend. Introduces concept of search profiles, which replace long list of namespaces in the url. Comment: FYI, I created [[Manual:Hooks/SpecialSearchProfileForm]] and [[Manual:Hooks/SpecialSearchSetupEngine]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81074]: New comment added, and revision status changed
User Tim Starling changed the status of MediaWiki.r81074.
Old Status: new
New Status: fixme
User Tim Starling also posted a comment on MediaWiki.r81074.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81074#c21955
Commit summary:
(bug 235) parser function for conversion of units of measurement.
[[Template:Convert]] on enwiki is a behemoth of a construction that just about
manages to do this sort of conversion, taking {{convert|5|mi|km}} and
outputting 5 miles (8 km), etc. To port this to another wiki requires
copying over three and a half thousand subtemplates. The additional load
produced by including numerous copies of this template is measurable on large
pages on enwiki, and it eats voraciously into the template limits.
This revision introduces {{#convert: 5 mi | km }}, outputting 8 km or
thereabouts. See http://www.mediawiki.org/wiki/User:Happy-melon/Convert for
more details, or look at the examples in the parser tests.
In a very rough profile, comparing 50 calls to {{convert}} verses the same 50
calls to the wrapper template shown at the link above, the parser function
implementation reduces page load time by 72%, preprocessor node count by 83%,
post-expand include size by 86% and template argument size by 97%. More
detailed profiling would probably reveal places where extra caching could
improve performance further.
The primary reason for putting it in ParserFunctions instead of its own
extension is availability: PFs are already available across the cluster, and
it's accepted as an essential extension for any wiki wishing to emulate or
mirror WMF content. One less separate extension installed on the cluster is
one less extension which has to be matched by reusers.
It's still missing a lot of units, which I ran out of patience to copy from
{{convert}}; I thought I'd get some feedback on the infrastructure first.
Comment:
Actually the measure of tyre pressure is pounds-force per square inch, not
foot-pounds per square inch. See [[w:Pounds per square inch]]. Dimensional
analysis is a useful technique, it would have identified your error here.
Dimensional analysis can cope with reciprocals.
Spelling differences are best dealt with by using abbreviations, which are
consistent and international. A style guide I once read recommended that
abbreviations should always be used in preference to the unit names, since this
convention avoids an unfortunate ambiguity between rad as an abbreviation for
radians, and rad the unit name which is abbreviated to rd. Also they are
shorter. However nowiki{{convert}}/nowiki on Wikipedia uses full names by
default so I suppose we should follow suit here.
It seems kind of strange to adopt the spelling conventions for metric units
from the most obstinate anti-metric country in the world as our default. The
Wikipedia templates do not take this approach, they use the British spelling by
default, and allow an sp=us parameter to access the American spelling.
I suggest adding a method for configuring the language variant to be used on a
wiki for unit name display. This would allow the new parser function to match
the style used on Wikipedia and avoid the need for #language=en-gb to be added
to every invocation. Setting fixme status for this feature request.
Ideally it should provide a map of base languages to sensible defaults, to
provide Wikipedia-like functionality to small wikis without configuration, e.g.:
pre
$wgPFUnitLanguageVariants = array(
'en' = 'en-gb'
);
/pre
If $wgContLang is present as a key in the array, the language in the value of
that element would be used by default for ConvertParser::$language.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81074]: New comment added
User Tim Starling posted a comment on MediaWiki.r81074.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81074#c21956
Commit summary:
(bug 235) parser function for conversion of units of measurement.
[[Template:Convert]] on enwiki is a behemoth of a construction that just about
manages to do this sort of conversion, taking {{convert|5|mi|km}} and
outputting 5 miles (8 km), etc. To port this to another wiki requires
copying over three and a half thousand subtemplates. The additional load
produced by including numerous copies of this template is measurable on large
pages on enwiki, and it eats voraciously into the template limits.
This revision introduces {{#convert: 5 mi | km }}, outputting 8 km or
thereabouts. See http://www.mediawiki.org/wiki/User:Happy-melon/Convert for
more details, or look at the examples in the parser tests.
In a very rough profile, comparing 50 calls to {{convert}} verses the same 50
calls to the wrapper template shown at the link above, the parser function
implementation reduces page load time by 72%, preprocessor node count by 83%,
post-expand include size by 86% and template argument size by 97%. More
detailed profiling would probably reveal places where extra caching could
improve performance further.
The primary reason for putting it in ParserFunctions instead of its own
extension is availability: PFs are already available across the cluster, and
it's accepted as an essential extension for any wiki wishing to emulate or
mirror WMF content. One less separate extension installed on the cluster is
one less extension which has to be matched by reusers.
It's still missing a lot of units, which I ran out of patience to copy from
{{convert}}; I thought I'd get some feedback on the infrastructure first.
Comment:
The reason I made ExprError derive from Exception instead of MWException is
because ExprErrors are never allowed to propagate to the calling code, they are
always caught and converted to an error message. So they are private to the
extension and do not need the MediaWiki-specific formatting code in MWException.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96312]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r96312. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r96312. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96312#c21957 Commit summary: release notes for r96311 Comment: Should be phrased as no longer can. Currently it sounds like you're adding the feature, when in fact you're fixing the bug. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95469]: Revision status changed
User ^demon changed the status of MediaWiki.r95469. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95469 Commit summary: fu r95191: Make 2 messages optinal per Jack's CR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95594]: Revision status changed
User ^demon changed the status of MediaWiki.r95594. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95594 Commit summary: fu r95396 Fix function name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95655]: Revision status changed
User ^demon changed the status of MediaWiki.r95655. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95655 Commit summary: * (bug 16428) Include permalink in printable version ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96308]: Revision status changed
User ^demon changed the status of MediaWiki.r96308. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96308 Commit summary: release-notes for r96307 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94766]: Revision status changed
User ^demon changed the status of MediaWiki.r94766. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94766 Commit summary: Followup r94421 which, per CR, broke in non-English content languages because of key mismatches due to localized namespace names. Now ensuring all titles go through getPrefixedDBkey() before we compare them, so they're always normalized. This also ensures we don't get underscore vs. space confusion, which is something that the previous code did right by accident. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95467]: Revision status changed
User ^demon changed the status of MediaWiki.r95467. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95467 Commit summary: Followup r92155, move preferences-specific code introduced in HTMLForm to Preferences.php. Dropping $displayTitle and replacing it with something else is OK since $displayTitle was introduced as a hack for the preferences form anyway ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95619]: Revision status changed
User ^demon changed the status of MediaWiki.r95619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95619 Commit summary: ClickTracking: * Fix misnested transactions (BEGIN inside the loop, COMMIT outside the loop) * Fix indentation * Add FIXME about $.trackAction() not working reliably when called right before submitting a form ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95887]: Revision status changed
User ^demon changed the status of MediaWiki.r95887. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95887 Commit summary: 1.17wmf1: MFT UploadWizard fixes r95691, r95726, r95727, r95793, r95815, r95829, r95876, r95880 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95895]: Revision status changed
User ^demon changed the status of MediaWiki.r95895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95895 Commit summary: 1.17wmf1: Update MoodBar to trunk state ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93706]: Revision status changed
User ^demon changed the status of MediaWiki.r93706. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93706 Commit summary: adding pokey graphic to Moodbar pop-up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95949]: Revision status changed
User ^demon changed the status of MediaWiki.r95949. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95949 Commit summary: Followup r95947, undo accidental revert of r95946. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95947]: Revision status changed
User ^demon changed the status of MediaWiki.r95947. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95947 Commit summary: Fix indentation in r95396 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95946]: Revision status changed
User ^demon changed the status of MediaWiki.r95946. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95946 Commit summary: Add Title::isSubpageOf to use when you want to make tests like $title-isSubpageOf( $someUserpage ); ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95977]: Revision status changed
User ^demon changed the status of MediaWiki.r95977. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95977 Commit summary: Remove type hint that broke r95975 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95975]: Revision status changed
User ^demon changed the status of MediaWiki.r95975. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95975 Commit summary: Add ResourceLoaderContext::newDummyContext() function ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96228]: Revision status changed
User ^demon changed the status of MediaWiki.r96228. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96228 Commit summary: (bug 30735) Use protocol-relative URL for geoiplookup. Should not be deployed until bug 30330 (geoip returns bad data over HTTPS) is fixed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96286]: Revision status changed
User ^demon changed the status of MediaWiki.r96286. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96286 Commit summary: Fix r95653: as reported on bug 30680, this broke Collection. Expanding $wgScriptPath using $wgCanonicalServer results in a mix of secure and non-secure URL patterns. Going back to PROTO_CURRENT which doesn't have this problem ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96278]: Revision status changed
User ^demon changed the status of MediaWiki.r96278. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96278 Commit summary: Revert r95631, should be enough to fix the issues with LQT edit form. TheDJ asked me to revert all of his RL-related LQT commits but that would be such a mess that I'd rather not do that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96274]: Revision status changed
User ^demon changed the status of MediaWiki.r96274. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96274 Commit summary: Followup r96180: remove unused global $wgCanonicalServer ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96283]: Revision status changed
User ^demon changed the status of MediaWiki.r96283. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96283 Commit summary: wmerrors: Use protocol-relative URLs in links on error page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96287]: Revision status changed
User ^demon changed the status of MediaWiki.r96287. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96287 Commit summary: Make the evil InitialiseSettings.php parser in lsearch look for wgCanonicalServer rather than wgServer due to issues caused by protocol-relative URLs ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96244]: Revision status changed
User ^demon changed the status of MediaWiki.r96244. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96244 Commit summary: WikiHiero: updated readme ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Serialisation vs. PHP
On Mon, Sep 5, 2011 at 9:16 PM, Ashar Voultoiz hashar+...@free.fr wrote: On 04/09/11 20:31, Max Semenik wrote: Am I right in my guess that while loading data tables from serialized files is faster than interpreting them in PHP, the situation is reversed in HipHop where tables can be precompiled? Feel free to write benchmarks for those. We have a class to do so in maintenance/benchmarks . Yet a simple yes or no from someone who already has experience with it would have saved some time;) Anyway, the code has already been committed in r96288 by the time of your reply. On Tue, Sep 6, 2011 at 12:59 AM, Platonides platoni...@gmail.com wrote: Ashar Voultoiz wrote: HipHop compilation is straightforward (make sure to use the patches for libcurl and lib_I_DONT_REMEMBER). MediaWiki compilation can cause some troubles though. Yet I was unable to do so. Worked pretty straightforward for me on Ubuntu. I remeber I used an instruction from mw.o, but couldn't find it now. -- Best regards, Max Semenik ([[User:MaxSem]]) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96298]: New comment added
User ^demon posted a comment on MediaWiki.r96298. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96298#c21958 Commit summary: Another thing that's been bothering me, skins shouldn't have to access $wgSitenotice directly when we have a logopath. Comment: $wgSitename or $wgSitenotice? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96296]: Revision status changed
User ^demon changed the status of MediaWiki.r96296. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96296 Commit summary: Partially revert/fix r96295: only use Gothic script per Siebrand ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96293]: Revision status changed
User ^demon changed the status of MediaWiki.r96293. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96293 Commit summary: update packaging of results ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
