[MediaWiki-CodeReview] [MediaWiki r97681]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97681. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97681 Commit summary: Fixup mixed tabs and spaces ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97689]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97689. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97689 Commit summary: Follow-up to r97273 - re-added compatibility for MW 1.17 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75585]: New comment added
User Hashar posted a comment on MediaWiki.r75585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75585#c22891 Commit summary: Optional feature to login through HTTPS and come back to HTTP. Based on an idea by George Herbert george dot herbert at gmail dot com http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/050065.html Comment: Does not set returnto on secure Userlogin link. Firefishy, can you please report it as a bug at https://bugzilla.wikimedia.org/ ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97350]: New comment added
User Afeldman posted a comment on MediaWiki.r97350. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97350#c22892 Commit summary: adding index to ArticleFeedback for reporting Comment: merged into trunk in r97352 - I probably went about that the wrong way ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97342]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97342. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97342#c22893 Commit summary: Merged in changes from LogEventsList which prevent missing usernames in log-lines and adds hook LogEventsListShowLogExtract. Part of merge from here: http://www.mediawiki.org/wiki/Wikia_code Comment: Hook seems fine yes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97702]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97702. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97702 Commit summary: Removed debugging code from r97701 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97658]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r97658. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r97658. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97658#c22894 Commit summary: * Made IndexPager extend ContextSource * Updated special pages using IndexPager or one if its subclasses to pass the context object and use it instead of global variables * Call Linker methods statically * Changed LogPager::getUser() to LogPager::getAuthor() to avoid conflict with ContextSource::getUser() Comment: Done in r97703. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97609]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97609. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97609 Commit summary: Narayam: Update Nepali transliteration using rules from Nepali wikipedia. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96945]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96945. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96945 Commit summary: * bump version to 0.3.1 * stylize.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97644]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97644. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97644 Commit summary: Tweak 'mwe-upwiz-more-options' per suggestion of Wouter Hagens. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92636]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r92636. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92636 Commit summary: Use wfMessage() functions, and rewrite/clean-up showForm() using Html and Xml functions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92529]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r92529. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92529 Commit summary: * Use interwiki cache (per r92528) * Use ResourceLoader for css * Some code clean-up/improvements This version is only compatible with 1.19 (r92528) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r92973]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r92973. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/92973 Commit summary: Pass default url as parameter for wgRequest-getVal( 'wpInterwikiURL' ) per ^demon on r92672. Also for wgRequest-getVal( 'prefix' ) alternative of wgRequest-getVal( 'wpInterwikiPrefix' ). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93269]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r93269. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93269 Commit summary: Fix toc margin in modern skin per DieBuche on r90743 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: New comment added
User Nikerabbit posted a comment on MediaWiki.r93985. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985#c22895 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... Comment: Robin: can you do the split? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96138]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96138. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96138 Commit summary: * Call core function Language::getTranslatedLanguageName() if found, instead of CLDR extension. Exists since v1.18. * Fix r95582 r96122: only load code for ListUsers if higher than v1.17 (because it doesn't work in 1.17). This keeps backwards-compatibility with 1.17, but loads more features in 1.18+. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96122]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96122. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r96122. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96122#c22896 Commit summary: * Use more specific css for .subpages and mark it important, because it's overridden by other css * Make ListUsersTestWiki work for incubator option; reuse existing IncubatorTest::getUrlParam(); nicer SQL queries with arrays * Remove link in user right message Comment: You should try to get rid of wfMsgWikiHtml, it is going to be deprecated. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95582]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95582. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95582 Commit summary: Ability to filter list of users based on their test wiki preference ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95611]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95611. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95611 Commit summary: Properly mark the language and direction of the readonly textarea ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96161]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96161. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96161 Commit summary: * Avoid CSS border bug in Chrome where 'left' displays at the right for td elements with dir=rtl (reported as Chromium bug 95253) * Remove direction: ltr; that is unneeded since r91171 (HTML is better than CSS for RTL support) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96222]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96222. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96222 Commit summary: Explain what $wgDummyLanguageCodes does, and remove 'iu' from it as it should be selectable on the installer (it has a LanguageConverter so it should be possible to use that). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96258]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96258. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96258 Commit summary: whoops, fix r96257 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96737]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96737. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96737 Commit summary: Correctly parse interface messages as such, so it doesn't get converted according to the content language (like r96257/r94395/r94279) Also whitespace fix in MessagesEn for r96723 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Updates for EXIF rotated photos in trunk 1.18
On Wed, Sep 21, 2011 at 12:54 AM, Brion Vibber br...@pobox.com wrote: I've applied these fixes to trunk, REL1_18, and 1.18wmf1 -- phpunit test cases have been updated, but it's still conceivable something could be wrong so please do test. :) Great work Brion! Bryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r96257]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96257. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96257 Commit summary: Correctly parse interface messages as such, so it doesn't get converted according to the content language (like r94395/r94279) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96141]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96141. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96141 Commit summary: Drop support for 1.17 and below, as version_compare() doesn't work properly and 1.18 will be deployed to wmf wikis soon anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96265]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96265. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96265 Commit summary: (bug 30679) Some installer fields should always be LTR Patch by Amir E. Aharoni (some whitespace fixes) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96267]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96267. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96267 Commit summary: (bug 26170) MediaWiki:Globalblocking-blocked should have a variable for the user's IP address Some other tweaks (whitespace, docs, ..) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96285]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96285. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96285 Commit summary: Add missing authors to message files that were in the past imported/copied from the respective Wikipedias Add one message to ks-arab/ks-deva from kswiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96295]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96295. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96295 Commit summary: * Split MessagesGot file into Latin and Gothic script files; add usable messages from gotwiki * Add usable messages from bmwiki to MessagesBm * Rebuilt these files ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96665]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96665. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96665 Commit summary: Use static Linker, fixes Fatal error: Call to a member function link() on a non-object in SpecialCite.php, when using monobook skin ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96712]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96712. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96712 Commit summary: Conversion script between Tifinagh and Latin for the Tachelhit language Preferences: made getLanguageNames include those that don't have a Messages file ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96801]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96801. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96801 Commit summary: Show the right message on Special:SpecialPages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97636]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97636. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97636#c22897 Commit summary: Re-do several things of r96798 in preparation of re-doing the rest (there's a bug somewhere that needs fixing). * Do additional validation and is_array() check in LanguageConverter * Make redirects be in content language again (remove from Title-getPageLanguage()) * Pass title object from ParserCache to ParserOptions-optionsHash Comment: pre + $this-mRules = + $this-mConverter-autoConvert( $this-mRules, + $variantFallback ); /pre Can you do something about that huge indentation? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97636]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97636. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97636#c22898 Commit summary: Re-do several things of r96798 in preparation of re-doing the rest (there's a bug somewhere that needs fixing). * Do additional validation and is_array() check in LanguageConverter * Make redirects be in content language again (remove from Title-getPageLanguage()) * Pass title object from ParserCache to ParserOptions-optionsHash Comment: In optionsHash it would be nice to document in what revision the new param was introduced. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97637]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97637. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97637 Commit summary: r97636: ParserCache meant to be committed already too ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93246]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r93246. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r93246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93246#c22899 Commit summary: (bug 15641) prevent blocked administrators from accessing deleted revisions. Comment: The access checking should be done only once. Otherwise it is bound to get out of sync somewhere. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] On developing extensions and namespace registering
On 11-09-20 10:54 PM, Ashar Voultoiz wrote: On 21/09/11 05:39, K. Peachey wrote: Since no one seems to have sent this to the ML and to draw wider attention: http://www.mediawiki.org/wiki/Talk:Extension_namespace_registration#Social_tools.27_namespaces It would help to post a summary on wikitech. I am not sure lot of people will want to read the thirteen paragraphs at that URL, I personally skipped it :-D TL;DR version: - Random user comments that sites could use a defined place to safely declare custom namespaces and points out that as of writing nothing was inside the 500-599 range. - A few other users chime in that it's a good idea. - One user chimes in that it would be a good idea to notify the mailing lists, however no-one does this. - About a year later one of the users comes back and declares that since no-one objected 500-599 is reserved for site namespaces. - A few months later as part of porting some of ArmchairGM's/Wikia's extensions marks off on the page that the BlogPage extension has been using 500-501 for awhile. - The user that declared 500-599 for site-namespaces comes back and reverts Jack's edit. - Jack starts a discussion on the talkpage. Also comments on the sillyness of 500-599 being 'the' site-specific range. - User says the matter was open for discussion for 11 months, comments on that page being a 'reservation system' etc... - Jack comments on how practically no-one namely us developers even knew about that discussion, and how no matter what the page says the code in svn is still using those namespaces. - After a few other comments the user goes back to talking about 'rules', '[talking] to someone [of] authority', saying the range was 'duly registered by prior agreement'. - Another user comments on the ridiculousness of the assertion. The TL;DR-TL;DR version: Uhm... User gets a big head and starts wikilawyering and reverting people on a page that's supposed to list information rather than have some sort of authoritative registration process, claims that things were up for discussion when no-developer was ever really notified, no-one really discussed it, and the whole thing was based on a false premise in the first place. I've restored the info which IS valid information. Ripped out the registration of a site-specific range of namespaces. Added notes about current custom site namespace practices to the page to take note of when defining default namespaces for extensions. And renamed the page and removed all notion of a registration from the page which is nothing but a list of current practice to help extension developers avoid creating conflicts with other extensions when they write new code. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r95640]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r95640.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r95640.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95640#c22900
Commit summary:
As suggested to me by email: very active members of a wiki community can end up
receiving hundreds of emails via Special:EmailUser, the majority of which will
end up with the boilerplate {{SITENAME}} email subject, making them hard to
distinguish. Pass the name of the user sending the email to the message, so
that it can be at least a little bit more unique.
Comment:
Please amend/add message documentation for this message.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97705]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97705. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97705 Commit summary: Call Linker methods statically ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97698]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97698. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97698 Commit summary: Fix a conflict(?) in Special:Contributions in r97658. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97704]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97704. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r97704. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97704#c22901 Commit summary: Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them Comment: Causes missing space between histlinks and flags if no chardiff. I also don't see how this improves anything. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97704]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r97704. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97704 Commit summary: Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r75585]: New comment added
User Firefishy posted a comment on MediaWiki.r75585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/75585#c22902 Commit summary: Optional feature to login through HTTPS and come back to HTTP. Based on an idea by George Herbert george dot herbert at gmail dot com http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/050065.html Comment: Created: https://bugzilla.wikimedia.org/show_bug.cgi?id=31040 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] On developing extensions and namespace registering
On 21 September 2011 11:40, Daniel Friesen li...@nadir-seen-fire.com wrote: I've restored the info which IS valid information. Ripped out the registration of a site-specific range of namespaces. Added notes about current custom site namespace practices to the page to take note of when defining default namespaces for extensions. And renamed the page and removed all notion of a registration from the page which is nothing but a list of current practice to help extension developers avoid creating conflicts with other extensions when they write new code. I've added info few more extensions I have checked out. I don't however have all extensions checked out. A little task for someone would be to go through all extensions in svn and add missing items to the list to get an overview of the current state. -Niklas -- Niklas Laxström ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] [Foundation-l] Request: WMF commitment as a long term cultural archive?
Hi all; Just like the scripts to preserve wikis[1], I'm working in a new script to download all Wikimedia Commons images packed by day. But I have limited spare time. Sad that volunteers have to do this without any help from Wikimedia Foundation. I started too an effort in meta: (with low activity) to mirror XML dumps.[2] If you know about universities or research groups which works with Wiki[pm]edia XML dumps, they would be a possible successful target to mirror them. If you want to download the texts into your PC, you only need 100GB free and to run this Python script.[3] I heard that Internet Archive saves XML dumps quarterly or so, but no official announcement. Also, I heard about Library of Congress wanting to mirror the dumps, but not news since a long time. L'Encyclopédie has an uptime[4] of 260 years[5] and growing. Will Wiki[pm]edia projects reach that? Regards, emijrp [1] http://code.google.com/p/wikiteam/ [2] http://meta.wikimedia.org/wiki/Mirroring_Wikimedia_project_XML_dumps [3] http://code.google.com/p/wikiteam/source/browse/trunk/wikipediadownloader.py [4] http://en.wikipedia.org/wiki/Uptime [5] http://en.wikipedia.org/wiki/Encyclop%C3%A9die 2011/6/2 Fae fae...@gmail.com Hi, I'm taking part in an images discussion workshop with a number of academics tomorrow and could do with a statement about the WMF's long term commitment to supporting Wikimedia Commons (and other projects) in terms of the public availability of media. Is there an official published policy I can point to that includes, say, a 10 year or 100 commitment? If it exists, this would be a key factor for researchers choosing where to share their images with the public. Thanks, Fae -- http://enwp.org/user_talk:fae Guide to email tags: http://j.mp/faetags ___ foundation-l mailing list foundatio...@lists.wikimedia.org Unsubscribe: https://lists.wikimedia.org/mailman/listinfo/foundation-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r97710]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97710. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97710 Commit summary: Don't use isset() to check for null ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97704]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97704. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97704 Commit summary: Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97706]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97706. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r97706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97706#c22903 Commit summary: FU 97704: I was thinking the space was already added in this case Comment: Fine now. The change doesn't help much though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97708]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97708. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r97708. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97708#c22904 Commit summary: Wrap the copyright when its language is not the user's language; avoids problem when direction of the two languages is different Comment: Ugh raw html messages. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97711]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97711. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97711#c22905 Commit summary: * (bug 30245) Use the correct way to construct a log page title Comment: Forgot to mention in the commit message: Patch provided by Umherirrender. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97707]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97707. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97707#c22906 Commit summary: Added missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader() Comment: Can you tell what was the symptom of missing calls? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97703]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97703. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97703 Commit summary: Per Nikerabbit, follow-up r97658: change getAuthor() into getPerformer() for consistency ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96540]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r96540. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96540 Commit summary: Fix syntax error in r95476 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95827]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95827. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95827 Commit summary: Remove empty comments when dumping ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r96225]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r96225. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r96225. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96225#c22907 Commit summary: Do not use replaceafter, per r52735 CR Comment: But now the html links are mangled by the parser. What you need is wfMessage with selective replaceafter... called rawParams. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94903]: New comment added
User Nikerabbit posted a comment on MediaWiki.r94903. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94903#c22908 Commit summary: SocialProfile: make Special:UserStatus a listed special page, add standard checks (block+DB read-only mode) and move some hardcoded English texts into the i18n file Comment: Should use more escaping. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94906]: New comment added
User Nikerabbit posted a comment on MediaWiki.r94906. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94906#c22909 Commit summary: SocialProfile: in UserStatus, moved the public history button from JS to PHP, added some tr and td tags around the no status history message in wfGetHistory, made it so that the owner of a status update and anons can't like the status update, removed unused JS globals and renamed the method which outputs the new JS global and added some wfReadOnly() checks Comment: No i18n for that message? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r94932]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r94932. Old Status: new New Status: ok User Nikerabbit also posted a comment on MediaWiki.r94932. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94932#c22910 Commit summary: Moved wfGetIP() to WebRequest::getIP(): * Changed all calls in core to the latter * Also marked wfGetForwardedFor() as deprecated * Moved wfGetIP() tests to WebRequestTest Comment: Commit message does not mention wfGetAgent change, but that looks fine too. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95166]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95166.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95166
Commit summary:
Remove the * {{msg}} syntax introduced to MediaWiki:Sidebar in r66974. This
syntax is in the way of projects attempting to use a more flexible sidebar-like
message parser, or fixing the dependence on MediaWiki:Sidebar for sidebar
config. Eliminating it before people end up using it in production (from my
tests it never actually worked in 1.17).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93388]: New comment added
User Amire80 posted a comment on MediaWiki.r93388. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93388#c22911 Commit summary: Follow-up r93386: fix editsection when user language direction != content lang dir Comment: I'm not sure that i understand what is it for. I tried it in a mixed-directionality environment and it seems to work correctly with and without this line. If i work in a Hebrew wiki with English interface and add a period to the word edit, it appears on the wrong end even without this line. If i add direction: ltr, then it appears correctly, and it works even without unicode-bidi: embed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95200]: New comment added
User Nikerabbit posted a comment on MediaWiki.r95200. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95200#c22912 Commit summary: Followup r95185, replaced with , added hook for 'SignupForm' event which can be used to run hooks specifically for SpecialUserSignup Comment: pre+wfRunHooks( 'SignupForm' );/pre No parameters? What can they do? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95202]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95202. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95202 Commit summary: Followup r95185, changed name of class validateSignup to ValidateSignup, made necessary changes in other files as well ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95259]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95259. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95259 Commit summary: (bug 30480) Fixes AbuseFilter's tool page from having its own subtitle, it shoudl have the navigation bar instead ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95268]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95268. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95268 Commit summary: fix for bug 26797 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95319]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95319. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95319 Commit summary: (bug 30352) Add option to BlockList to filter out IP range blocks ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95457]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95457. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95457 Commit summary: Move the check for if a Maintenance script supports --batch-size away from addDefaultParams() and to setBatchSize(), since setBatchSize is usually called in a subclass constructor after parent:__construct() which is after addDefaultParams() is called. Upside of this is lots of scripts supporting --batch-size now list it in their help output. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95502]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95502. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95502 Commit summary: converts nbsp; to #160 per cr on r95043 Seems like the nbsp entities is not defined for some of our usage. So use the numerical entity which will always be correctly interpreted. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r95460]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r95460. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95460 Commit summary: Use getLinkURL instead of getLocalURL for titles from MediaWiki:Sidebar so that #Fragments are not discarded when the user uses them. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r93985]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r93985. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/93985 Commit summary: Use page content language for the WikimediaIncubator and Translate extension. This correctly sets writing direction, TOC, ... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97335]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97335. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97335 Commit summary: Forgot to press Ctrl-S: r97334 (was: Per initial commit r96356) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97578]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97578. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97578#c22914 Commit summary: follow up to r97566 - adding message documentation for new message texts (identical to two prefs- texts) Comment: FYI: http://translatewiki.net/wiki/Category:Identical_message_templates ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97619]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97619 Commit summary: Followup r97618: Make new message optional instead ignore for translatewiki.net (per r97566) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97619]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r97619. Old Status: ok New Status: new User Nikerabbit also posted a comment on MediaWiki.r97619. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97619#c22915 Commit summary: Followup r97618: Make new message optional instead ignore for translatewiki.net (per r97566) Comment: Why optional? There is no meaningful content in openid-urls-registration-date-time nor documentation what it should contain? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97618]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97618. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97618 Commit summary: Ignore new message key from r97566 for translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97566]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97566. Old Status: deferred New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97566 Commit summary: follow up to r97447 : show OpenID registration timestamps in OpenID preference tab, if these are present ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97712]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97712. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97712 Commit summary: small fix removing an obsolete paramter ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97714]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97714#c22916 Commit summary: Question type=text interpretation works. Implemented category-specific interpretation error messages parsing and display in addition to proposal-specific interpretation error messages. Comment: CSS validator complains about LightYellow color. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97714]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97714#c22917 Commit summary: Question type=text interpretation works. Implemented category-specific interpretation error messages parsing and display in addition to proposal-specific interpretation error messages. Comment: pre# $this-viewtokens-reset();/pre Commented code without comments? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97714]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97714#c22918 Commit summary: Question type=text interpretation works. Implemented category-specific interpretation error messages parsing and display in addition to proposal-specific interpretation error messages. Comment: I would break the very long line in setProposals to multiple shorter ones. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97715]: Revision status changed
User Catrope changed the status of MediaWiki.r97715. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97715 Commit summary: Cleanup Babel.i18n.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97715]: Revision status changed
User Catrope changed the status of MediaWiki.r97715. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97715 Commit summary: Cleanup Babel.i18n.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84020]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r84020. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84020 Commit summary: Add language tagging of inner Babel boxes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97716]: Revision status changed
User Catrope changed the status of MediaWiki.r97716. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97716 Commit summary: Partial revert of r84020 - we should not tag language unless we are pretty much certain it is correct. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84229]: New comment added, and revision status changed
User Siebrand changed the status of MediaWiki.r84229. Old Status: fixme New Status: resolved User Siebrand also posted a comment on MediaWiki.r84229. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84229#c22919 Commit summary: Wrap everything that is not a babel box into div 's as well, for consistenty and styling via CSS. Comment: Resolved after consultation with Niklas. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84248]: Revision status changed
User Siebrand changed the status of MediaWiki.r84248. Old Status: deferred New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84248 Commit summary: Minor enhancements and fixes following up r84229, r84078, 84027, 84015. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97717]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97717. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97717 Commit summary: Follow-up r84248: revert initialising an unused variable to initialising a used variable. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97576]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r97576. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r97576. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97576#c22920 Commit summary: MFT r97573 - hook to help with bug 31012 on MobileFrontend similar Comment: pre -die( Do not run update.php on the cluster. If you're seeing this you should -probably ask for some help in performing your schema changes.\n ); +#die( Do not run update.php on the cluster. If you're seeing this you should +#probably ask for some help in performing your schema changes.\n ); /pre WTF? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97374]: New comment added
User Nikerabbit posted a comment on MediaWiki.r97374. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97374#c22921 Commit summary: AdManager: version 0.2: *remove unused jquery-1.4.2.min.js file *define new globals $wgAdManagerService and $wgAdManagerCode in the setup file *some i18n tweaks *removed usage of $wgDBprefix from the code, Database class can automatically add it when needed *simplified ResourceLoader existence checks *added __METHOD__ to all Database calls *trimmed trailing whitespace for all files *coding style tweaks *removed ancient cruft (wfLoadExtensionMessages etc.) *added read-only/block checks to special pages Comment: Those i18n files get not so fun to work with when they are in multimegabyte size category. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97720]: Revision status changed
User SPQRobin changed the status of MediaWiki.r97720. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97720 Commit summary: Add Babel to make-wmf-branch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97718]: Revision status changed
User Siebrand changed the status of MediaWiki.r97718. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97718 Commit summary: 1.17wmf1: Copy Babel from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97719]: Revision status changed
User Siebrand changed the status of MediaWiki.r97719. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97719 Commit summary: 1.18wmf1: Copy Babel from trunk ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97646]: New comment added
User Siebrand posted a comment on MediaWiki.r97646. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97646#c22922 Commit summary: Syntax help for void blocks and comments Comment: Please add [[I18n#Message_documenation]] for the newly added messages. Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97619]: New comment added
User Raymond posted a comment on MediaWiki.r97619. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97619#c22923 Commit summary: Followup r97618: Make new message optional instead ignore for translatewiki.net (per r97566) Comment: I am in mail contact with Wikinaut about this. Hopefully he will document/fix this soon. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97726]: Revision status changed
User Catrope changed the status of MediaWiki.r97726. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97726 Commit summary: If babel-portal is empty, don't make a link. Made it empty by default. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97722]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97722.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97722
Commit summary:
1.18wmf1: Partial merge of r93758: add addModule{Scripts,Styles,Messages}() to
ParserOutput
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97723]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97723. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97723 Commit summary: 1.17wmf1: Merge r97722 (partial merge of r93758) from 1.18wmf1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97724]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r97724. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97724 Commit summary: Bump version. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97687]: New comment added, and revision status changed
User MarkAHershberger changed the status of MediaWiki.r97687.
Old Status: new
New Status: fixme
User MarkAHershberger also posted a comment on MediaWiki.r97687.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97687#c22924
Commit summary:
bug 31052 : live hack to support reading from old non-slave external store
servers
Comment:
+ if ( !in_array( DB://.$cluster, $wgDefaultExternalStore ) ) {
in_array() is slow, use isset() (see #5 here:
http://ilia.ws/archives/12-PHP-Optimization-Tricks.html)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r97731]: Revision status changed
User SPQRobin changed the status of MediaWiki.r97731. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97731 Commit summary: de-ignore an important message ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
